@faststore/api 1.9.6 → 1.9.7

package/CHANGELOG.md

@@ -3,6 +3,17 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [1.9.7](https://github.com/vtex/faststore/compare/v1.9.6...v1.9.7) (2022-06-13)
+
+
+### Features
+
+* Canonical PDP slugs ([#1338](https://github.com/vtex/faststore/issues/1338)) ([ec807bb](https://github.com/vtex/faststore/commit/ec807bb94dafaa72cdec82d53933ca0809bf01df))
+
+
+
+
+
 ## [1.9.6](https://github.com/vtex/faststore/compare/v1.9.5...v1.9.6) (2022-06-13)
 
 

package/dist/api.cjs.development.js

@@ -392,18 +392,7 @@ const isBadRequestError = error => {
 };
 
 const getSkuLoader = (_, clients) => {
-  const loader = async facetsList => {
-    const skuIds = facetsList.map(facets => {
-      const maybeFacet = facets.find(({
-        key
-      }) => key === 'id');
-
-      if (!maybeFacet) {
-        throw new BadRequestError('Error while loading SKU. Needs to pass an id to selected facets');
-      }
-
-      return maybeFacet.value;
-    });
+  const loader = async skuIds => {
     const {
       products
     } = await clients.search.products({
@@ -746,15 +735,12 @@ const equals = (storeOrder, orderForm) => {
   return isSameOrder && orderItemsAreSync;
 };
 
-const orderFormToCart = (form, skuLoader) => {
+const orderFormToCart = async (form, skuLoader) => {
   return {
     order: {
       orderNumber: form.orderFormId,
-      acceptedOffer: form.items.map(item => ({ ...item,
-        product: skuLoader.load([{
-          key: 'id',
-          value: item.id
-        }])
+      acceptedOffer: form.items.map(async item => ({ ...item,
+        product: await skuLoader.load(item.id)
       }))
     },
     messages: form.messages.map(({
@@ -1062,13 +1048,13 @@ const StoreOffer = {
 
     return null;
   },
-  itemOffered: async root => {
+  itemOffered: root => {
     if (isSearchItem(root)) {
       return root.product;
     }
 
     if (isOrderFormItem(root)) {
-      return { ...(await root.product),
+      return { ...root.product,
         attachmentsValues: root.attachments
       };
     }
@@ -1090,6 +1076,10 @@ const StoreOffer = {
   }
 };
 
+const canonicalFromProduct = ({
+  linkText
+}) => `/${linkText}/p`;
+
 const enhanceCommercialOffer = ({
   offer,
   seller,
@@ -1130,13 +1120,11 @@ const StoreProduct = {
     }
   }) => description,
   seo: ({
-    isVariantOf: {
-      description,
-      productName
-    }
+    isVariantOf
   }) => ({
-    title: productName,
-    description
+    title: isVariantOf.productName,
+    description: isVariantOf.description,
+    canonical: canonicalFromProduct(isVariantOf)
   }),
   brand: ({
     isVariantOf: {
@@ -1196,7 +1184,7 @@ const StoreProduct = {
   },
   review: () => [],
   aggregateRating: () => ({}),
-  offers: root => root.sellers.flatMap(seller => enhanceCommercialOffer({
+  offers: root => root.sellers.map(seller => enhanceCommercialOffer({
     offer: seller.commertialOffer,
     seller,
     product: root
@@ -1294,15 +1282,25 @@ const transformSelectedFacet = ({
       };
   }
 };
-const findLocale = facets => {
+const findSlug = facets => {
   var _facets$find$value, _facets$find;
 
-  return (_facets$find$value = facets == null ? void 0 : (_facets$find = facets.find(x => x.key === 'locale')) == null ? void 0 : _facets$find.value) != null ? _facets$find$value : null;
+  return (_facets$find$value = facets == null ? void 0 : (_facets$find = facets.find(x => x.key === 'slug')) == null ? void 0 : _facets$find.value) != null ? _facets$find$value : null;
 };
-const findChannel = facets => {
+const findSkuId = facets => {
   var _facets$find$value2, _facets$find2;
 
-  return (_facets$find$value2 = facets == null ? void 0 : (_facets$find2 = facets.find(facet => facet.key === 'channel')) == null ? void 0 : _facets$find2.value) != null ? _facets$find$value2 : null;
+  return (_facets$find$value2 = facets == null ? void 0 : (_facets$find2 = facets.find(x => x.key === 'id')) == null ? void 0 : _facets$find2.value) != null ? _facets$find$value2 : null;
+};
+const findLocale = facets => {
+  var _facets$find$value3, _facets$find3;
+
+  return (_facets$find$value3 = facets == null ? void 0 : (_facets$find3 = facets.find(x => x.key === 'locale')) == null ? void 0 : _facets$find3.value) != null ? _facets$find$value3 : null;
+};
+const findChannel = facets => {
+  var _facets$find$value4, _facets$find4;
+
+  return (_facets$find$value4 = facets == null ? void 0 : (_facets$find4 = facets.find(facet => facet.key === 'channel')) == null ? void 0 : _facets$find4.value) != null ? _facets$find$value4 : null;
 };
 
 const SORT_MAP = {
@@ -1316,6 +1314,42 @@ const SORT_MAP = {
   score_desc: ''
 };
 
+/**
+ * More info at: https://en.wikipedia.org/wiki/Order_statistic
+ */
+// O(n) search to find the max of an array
+const min = (array, cmp) => {
+  let best = 0;
+
+  for (let curr = 1; curr < array.length; curr++) {
+    if (cmp(array[best], array[curr]) > 0) {
+      best = curr;
+    }
+  }
+
+  return array[best];
+};
+
+/**
+ * This function implements Portal heuristics for returning the best sku for a product.
+ *
+ * The best sku is the one with the best (cheapest available) offer
+ * */
+
+const pickBestSku = skus => {
+  const offersBySku = skus.flatMap(sku => sku.sellers.map(seller => ({
+    offer: seller.commertialOffer,
+    sku
+  })));
+  const best = min(offersBySku, ({
+    offer: o1
+  }, {
+    offer: o2
+  }) => bestOfferFirst(o1, o2));
+  return best.sku;
+};
+const isValidSkuId = skuId => skuId !== '' && !Number.isNaN(Number(skuId));
+
 const Query = {
   product: async (_, {
     locator
@@ -1323,6 +1357,8 @@ const Query = {
     // Insert channel in context for later usage
     const channel = findChannel(locator);
     const locale = findLocale(locator);
+    const id = findSkuId(locator);
+    const slug = findSlug(locator);
 
     if (channel) {
       mutateChannelContext(ctx, channel);
@@ -1335,9 +1371,50 @@ const Query = {
     const {
       loaders: {
         skuLoader
+      },
+      clients: {
+        commerce,
+        search
       }
     } = ctx;
-    return skuLoader.load(locator);
+
+    try {
+      var _ref;
+
+      const skuId = (_ref = id != null ? id : slug == null ? void 0 : slug.split('-').pop()) != null ? _ref : '';
+
+      if (!isValidSkuId(skuId)) {
+        throw new Error('Invalid SkuId');
+      }
+
+      const sku = await skuLoader.load(skuId);
+      return sku;
+    } catch (err) {
+      if (slug == null) {
+        throw new BadRequestError('Missing slug or id');
+      }
+
+      const route = await commerce.catalog.portal.pagetype(`${slug}/p`);
+
+      if (route.pageType !== 'Product' || !route.id) {
+        throw new NotFoundError(`No product found for slug ${slug}`);
+      }
+
+      const {
+        products: [product]
+      } = await search.products({
+        page: 0,
+        count: 1,
+        query: `product:${route.id}`
+      });
+
+      if (!product) {
+        throw new NotFoundError(`No product found for id ${route.id}`);
+      }
+
+      const sku = pickBestSku(product.items);
+      return enhanceSku(sku, product);
+    }
   },
   collection: (_, {
     slug
@@ -1582,8 +1659,10 @@ const StoreSeo = {
   description: ({
     description
   }) => description != null ? description : '',
-  titleTemplate: () => '',
-  canonical: () => ''
+  canonical: ({
+    canonical
+  }) => canonical != null ? canonical : '',
+  titleTemplate: () => ''
 };
 
 const ObjectOrString = /*#__PURE__*/new graphql.GraphQLScalarType({