@fastify/reply-from 9.4.0 → 9.6.0

package/test/full-querystring-rewrite.test.js

@@ -3,7 +3,7 @@
 const t = require('tap')
 const Fastify = require('fastify')
 const From = require('..')
-const http = require('http')
+const http = require('node:http')
 const get = require('simple-get').concat
 
 const instance = Fastify()

package/test/full-querystring.test.js

@@ -3,7 +3,7 @@
 const t = require('tap')
 const Fastify = require('fastify')
 const From = require('..')
-const http = require('http')
+const http = require('node:http')
 const get = require('simple-get').concat
 
 const instance = Fastify()

package/test/full-rewrite-body-content-type.test.js

@@ -3,7 +3,7 @@
 const t = require('tap')
 const Fastify = require('fastify')
 const From = require('..')
-const http = require('http')
+const http = require('node:http')
 const get = require('simple-get').concat
 const msgpack = require('msgpack5')()
 

package/test/full-rewrite-body-http.test.js

@@ -3,7 +3,7 @@
 const t = require('tap')
 const Fastify = require('fastify')
 const From = require('..')
-const http = require('http')
+const http = require('node:http')
 const get = require('simple-get').concat
 
 const instance = Fastify()

package/test/full-rewrite-body-to-empty-string.test.js

@@ -3,7 +3,7 @@
 const t = require('tap')
 const Fastify = require('fastify')
 const From = require('..')
-const http = require('http')
+const http = require('node:http')
 const get = require('simple-get').concat
 
 const instance = Fastify()

package/test/full-rewrite-body-to-null.test.js

@@ -3,7 +3,7 @@
 const t = require('tap')
 const Fastify = require('fastify')
 const From = require('..')
-const http = require('http')
+const http = require('node:http')
 const get = require('simple-get').concat
 
 const instance = Fastify()

package/test/full-rewrite-body.test.js

@@ -3,7 +3,7 @@
 const t = require('tap')
 const Fastify = require('fastify')
 const From = require('..')
-const http = require('http')
+const http = require('node:http')
 const get = require('simple-get').concat
 
 const instance = Fastify()

package/test/get-upstream-http.test.js

@@ -3,7 +3,7 @@
 const t = require('tap')
 const Fastify = require('fastify')
 const From = require('..')
-const http = require('http')
+const http = require('node:http')
 const get = require('simple-get').concat
 
 const instance = Fastify()

package/test/get-upstream-type.test.js

@@ -3,7 +3,7 @@
 const t = require('tap')
 const Fastify = require('fastify')
 const From = require('..')
-const http = require('http')
+const http = require('node:http')
 const get = require('simple-get').concat
 
 const instance = Fastify()

package/test/get-upstream-undici.test.js

@@ -3,7 +3,7 @@
 const t = require('tap')
 const Fastify = require('fastify')
 const From = require('..')
-const http = require('http')
+const http = require('node:http')
 const get = require('simple-get').concat
 
 const instance = Fastify()

package/test/get-with-body.test.js

@@ -3,7 +3,7 @@
 const t = require('tap')
 const Fastify = require('fastify')
 const From = require('..')
-const http = require('http')
+const http = require('node:http')
 const get = require('simple-get').concat
 
 const instance = Fastify()

package/test/head-with-body.test.js

@@ -3,7 +3,7 @@
 const t = require('tap')
 const Fastify = require('fastify')
 const From = require('..')
-const http = require('http')
+const http = require('node:http')
 const get = require('simple-get').concat
 const semver = require('semver')
 

package/test/http-agents.test.js

@@ -3,8 +3,8 @@
 const t = require('tap')
 const Fastify = require('fastify')
 const From = require('..')
-const http = require('http')
-const https = require('https')
+const http = require('node:http')
+const https = require('node:https')
 const get = require('simple-get').concat
 
 const instance = Fastify()

package/test/http-global-agent.test.js

@@ -3,7 +3,7 @@
 const { test } = require('tap')
 const Fastify = require('fastify')
 const From = require('..')
-const http = require('http')
+const http = require('node:http')
 const get = require('simple-get').concat
 
 test('http global agent is used, but not destroyed', async (t) => {

package/test/http-retry.test.js

@@ -7,7 +7,7 @@ const { test } = require('tap')
 
 let retryNum = 1
 
-const target = require('http').createServer(function (req, res) {
+const target = require('node:http').createServer(function (req, res) {
   if (retryNum % 2 !== 0) {
     req.socket.destroy()
   } else {

package/test/http2-http2.test.js

@@ -4,8 +4,8 @@ const h2url = require('h2url')
 const t = require('tap')
 const Fastify = require('fastify')
 const From = require('..')
-const fs = require('fs')
-const path = require('path')
+const fs = require('node:fs')
+const path = require('node:path')
 const certs = {
   key: fs.readFileSync(path.join(__dirname, 'fixtures', 'fastify.key')),
   cert: fs.readFileSync(path.join(__dirname, 'fixtures', 'fastify.cert'))

package/test/http2-https.test.js

@@ -5,8 +5,8 @@ const t = require('tap')
 const Fastify = require('fastify')
 const From = require('..')
 const got = require('got')
-const fs = require('fs')
-const path = require('path')
+const fs = require('node:fs')
+const path = require('node:path')
 const certs = {
   allowHTTP1: true, // fallback support for HTTP1
   key: fs.readFileSync(path.join(__dirname, 'fixtures', 'fastify.key')),

package/test/https-agents.test.js

@@ -3,12 +3,12 @@
 const t = require('tap')
 const Fastify = require('fastify')
 const From = require('..')
-const http = require('http')
-const https = require('https')
+const http = require('node:http')
+const https = require('node:https')
 const get = require('simple-get').concat
 
-const fs = require('fs')
-const path = require('path')
+const fs = require('node:fs')
+const path = require('node:path')
 const certs = {
   key: fs.readFileSync(path.join(__dirname, 'fixtures', 'fastify.key')),
   cert: fs.readFileSync(path.join(__dirname, 'fixtures', 'fastify.cert'))

package/test/https-global-agent.test.js

@@ -3,11 +3,11 @@
 const { test } = require('tap')
 const Fastify = require('fastify')
 const From = require('..')
-const https = require('https')
+const https = require('node:https')
 const get = require('simple-get').concat
 
-const fs = require('fs')
-const path = require('path')
+const fs = require('node:fs')
+const path = require('node:path')
 const certs = {
   key: fs.readFileSync(path.join(__dirname, 'fixtures', 'fastify.key')),
   cert: fs.readFileSync(path.join(__dirname, 'fixtures', 'fastify.cert'))

package/test/method.test.js

@@ -3,7 +3,7 @@
 const t = require('tap')
 const Fastify = require('fastify')
 const From = require('..')
-const http = require('http')
+const http = require('node:http')
 const get = require('simple-get').concat
 
 const instance = Fastify()

package/test/modifyCoreObjects-false.test.js

@@ -3,7 +3,7 @@
 const t = require('tap')
 const Fastify = require('fastify')
 const From = require('..')
-const http = require('http')
+const http = require('node:http')
 const get = require('simple-get').concat
 
 const instance = Fastify({ modifyCoreObjects: false })

package/test/no-body-opts-with-get.test.js

@@ -3,7 +3,7 @@
 const t = require('tap')
 const Fastify = require('fastify')
 const From = require('..')
-const http = require('http')
+const http = require('node:http')
 const get = require('simple-get').concat
 
 const instance = Fastify()

package/test/no-body-opts-with-head.test.js

@@ -3,7 +3,7 @@
 const t = require('tap')
 const Fastify = require('fastify')
 const From = require('..')
-const http = require('http')
+const http = require('node:http')
 const get = require('simple-get').concat
 
 const instance = Fastify()

package/test/no-stream-body-option.test.js

@@ -3,9 +3,9 @@
 const t = require('tap')
 const Fastify = require('fastify')
 const From = require('..')
-const http = require('http')
+const http = require('node:http')
 const get = require('simple-get').concat
-const Readable = require('stream').Readable
+const Readable = require('node:stream').Readable
 
 const instance = Fastify()
 instance.register(From)

package/test/onResponse.test.js

@@ -3,7 +3,7 @@
 const t = require('tap')
 const Fastify = require('fastify')
 const From = require('..')
-const http = require('http')
+const http = require('node:http')
 const get = require('simple-get').concat
 
 const instance = Fastify()

package/test/padded-body.test.js

@@ -3,7 +3,7 @@
 const t = require('tap')
 const Fastify = require('fastify')
 const From = require('..')
-const http = require('http')
+const http = require('node:http')
 const get = require('simple-get').concat
 
 const instance = Fastify()

package/test/post-formbody.test.js

@@ -3,7 +3,7 @@
 const t = require('tap')
 const Fastify = require('fastify')
 const From = require('..')
-const http = require('http')
+const http = require('node:http')
 const get = require('simple-get').concat
 
 const instance = Fastify()

package/test/post-plain-text.test.js

@@ -3,7 +3,7 @@
 const t = require('tap')
 const Fastify = require('fastify')
 const From = require('..')
-const http = require('http')
+const http = require('node:http')
 const get = require('simple-get').concat
 
 const instance = Fastify()

package/test/post-with-custom-encoded-contenttype.test.js

@@ -3,9 +3,9 @@
 const t = require('tap')
 const Fastify = require('fastify')
 const From = require('..')
-const http = require('http')
+const http = require('node:http')
 const get = require('simple-get').concat
-const { parse } = require('querystring')
+const { parse } = require('node:querystring')
 
 const instance = Fastify()
 instance.register(From, {

package/test/post-with-octet-stream.test.js

@@ -3,9 +3,9 @@
 const test = require('tap').test
 const Fastify = require('fastify')
 const From = require('../index')
-const http = require('http')
+const http = require('node:http')
 const get = require('simple-get').concat
-const { parse } = require('querystring')
+const { parse } = require('node:querystring')
 
 test('with explicitly set content-type application/octet-stream', t => {
   const instance = Fastify()

package/test/retry-on-503.test.js

@@ -3,7 +3,7 @@
 const { test } = require('tap')
 const Fastify = require('fastify')
 const From = require('..')
-const http = require('http')
+const http = require('node:http')
 const got = require('got')
 
 function createTargetServer (withRetryAfterHeader, stopAfter = 1) {

package/test/retry-with-a-custom-handler.test.js

@@ -0,0 +1,162 @@
+'use strict'
+
+const { test } = require('tap')
+const Fastify = require('fastify')
+const From = require('..')
+const http = require('node:http')
+const got = require('got')
+
+function serverWithCustomError (stopAfter, statusCodeToFailOn, closeSocket) {
+  let requestCount = 0
+  return http.createServer((req, res) => {
+    if (requestCount++ < stopAfter) {
+      if (closeSocket) req.socket.end()
+      res.statusCode = statusCodeToFailOn
+      res.setHeader('Content-Type', 'text/plain')
+      return res.end('This Service is Unavailable')
+    } else {
+      res.statusCode = 205
+      res.setHeader('Content-Type', 'text/plain')
+      return res.end(`Hello World ${requestCount}!`)
+    }
+  })
+}
+
+async function setupServer (t, fromOptions = {}, statusCodeToFailOn = 500, stopAfter = 4, closeSocket = false) {
+  const target = serverWithCustomError(stopAfter, statusCodeToFailOn, closeSocket)
+
+  await target.listen({ port: 0 })
+  t.teardown(target.close.bind(target))
+
+  const instance = Fastify()
+  instance.register(From, {
+    base: `http://localhost:${target.address().port}`
+  })
+
+  instance.get('/', (request, reply) => {
+    reply.from(`http://localhost:${target.address().port}`, fromOptions)
+  })
+
+  t.teardown(instance.close.bind(instance))
+  await instance.listen({ port: 0 })
+
+  return {
+    instance
+  }
+}
+
+test('a 500 status code with no custom handler should fail', async (t) => {
+  const { instance } = await setupServer(t)
+
+  let errorMessage
+  try {
+    await got.get(`http://localhost:${instance.server.address().port}`, { retry: 3 })
+  } catch (error) {
+    errorMessage = error.message
+  }
+
+  t.equal(errorMessage, 'Response code 500 (Internal Server Error)')
+})
+
+test("a server 500's with a custom handler and should revive", async (t) => {
+  const customRetryLogic = ({ req, res, err, attempt, getDefaultDelay }) => {
+    const defaultDelay = getDefaultDelay()
+    if (defaultDelay) return defaultDelay
+
+    if (res && res.statusCode === 500 && req.method === 'GET') {
+      return 0.1
+    }
+    return null
+  }
+
+  const { instance } = await setupServer(t, { retryDelay: customRetryLogic })
+
+  const res = await got.get(`http://localhost:${instance.server.address().port}`, { retry: 5 })
+
+  t.equal(res.headers['content-type'], 'text/plain')
+  t.equal(res.statusCode, 205)
+  t.equal(res.body.toString(), 'Hello World 5!')
+})
+
+test('custom retry does not invoke the default delay causing a 501', async (t) => {
+  // the key here is our retryDelay doesn't register the deefault handler and as a result it doesn't work
+  const customRetryLogic = ({ req, res, err, attempt, getDefaultDelay }) => {
+    if (res && res.statusCode === 500 && req.method === 'GET') {
+      return 0
+    }
+    return null
+  }
+
+  const { instance } = await setupServer(t, { retryDelay: customRetryLogic }, 501)
+
+  let errorMessage
+  try {
+    await got.get(`http://localhost:${instance.server.address().port}`, { retry: 5 })
+  } catch (error) {
+    errorMessage = error.message
+  }
+
+  t.equal(errorMessage, 'Response code 501 (Not Implemented)')
+})
+
+test('custom retry delay functions can invoke the default delay', async (t) => {
+  const customRetryLogic = ({ req, res, err, attempt, getDefaultDelay }) => {
+    // registering the default retry logic for non 500 errors if it occurs
+    const defaultDelay = getDefaultDelay()
+    if (defaultDelay) return defaultDelay
+
+    if (res && res.statusCode === 500 && req.method === 'GET') {
+      return 0.1
+    }
+
+    return null
+  }
+
+  const { instance } = await setupServer(t, { retryDelay: customRetryLogic }, 500)
+
+  const res = await got.get(`http://localhost:${instance.server.address().port}`, { retry: 5 })
+
+  t.equal(res.headers['content-type'], 'text/plain')
+  t.equal(res.statusCode, 205)
+  t.equal(res.body.toString(), 'Hello World 5!')
+})
+
+test('custom retry delay function inspects the err paramater', async (t) => {
+  const customRetryLogic = ({ req, res, err, attempt, getDefaultDelay }) => {
+    if (err && (err.code === 'UND_ERR_SOCKET' || err.code === 'ECONNRESET')) {
+      return 0.1
+    }
+    return null
+  }
+
+  const { instance } = await setupServer(t, { retryDelay: customRetryLogic }, 500, 4, true)
+
+  const res = await got.get(`http://localhost:${instance.server.address().port}`, { retry: 5 })
+
+  t.equal(res.headers['content-type'], 'text/plain')
+  t.equal(res.statusCode, 205)
+  t.equal(res.body.toString(), 'Hello World 5!')
+})
+
+test('we can exceed our retryCount and introspect attempts independently', async (t) => {
+  const attemptCounter = []
+
+  const customRetryLogic = ({ req, res, err, attempt, getDefaultDelay }) => {
+    attemptCounter.push(attempt)
+
+    if (err && (err.code === 'UND_ERR_SOCKET' || err.code === 'ECONNRESET')) {
+      return 0.1
+    }
+
+    return null
+  }
+
+  const { instance } = await setupServer(t, { retryDelay: customRetryLogic }, 500, 4, true)
+
+  const res = await got.get(`http://localhost:${instance.server.address().port}`, { retry: 5 })
+
+  t.match(attemptCounter, [0, 1, 2, 3, 4])
+  t.equal(res.headers['content-type'], 'text/plain')
+  t.equal(res.statusCode, 205)
+  t.equal(res.body.toString(), 'Hello World 5!')
+})

package/test/rewrite-headers-type.test.js

@@ -3,7 +3,7 @@
 const t = require('tap')
 const Fastify = require('fastify')
 const From = require('..')
-const http = require('http')
+const http = require('node:http')
 const get = require('simple-get').concat
 
 const instance = Fastify()

package/test/rewrite-headers.test.js

@@ -3,7 +3,7 @@
 const t = require('tap')
 const Fastify = require('fastify')
 const From = require('..')
-const http = require('http')
+const http = require('node:http')
 const get = require('simple-get').concat
 
 const instance = Fastify()

package/test/rewrite-request-headers-type.test.js

@@ -3,7 +3,7 @@
 const t = require('tap')
 const Fastify = require('fastify')
 const From = require('..')
-const http = require('http')
+const http = require('node:http')
 const get = require('simple-get').concat
 
 const instance = Fastify()

package/test/rewrite-request-headers.test.js

@@ -3,7 +3,7 @@
 const t = require('tap')
 const Fastify = require('fastify')
 const From = require('..')
-const http = require('http')
+const http = require('node:http')
 const get = require('simple-get').concat
 
 const instance = Fastify()

package/test/transform-body.test.js

@@ -3,9 +3,9 @@
 const t = require('tap')
 const Fastify = require('fastify')
 const From = require('..')
-const http = require('http')
+const http = require('node:http')
 const get = require('simple-get').concat
-const Transform = require('stream').Transform
+const Transform = require('node:stream').Transform
 
 const instance = Fastify()
 instance.register(From)

package/test/undici-agent.test.js

@@ -3,7 +3,7 @@
 const t = require('tap')
 const Fastify = require('fastify')
 const proxyquire = require('proxyquire')
-const http = require('http')
+const http = require('node:http')
 const get = require('simple-get').concat
 const undici = require('undici')
 const { getUndiciOptions } = require('../lib/request')

package/test/undici-body.test.js

@@ -3,7 +3,7 @@
 const t = require('tap')
 const Fastify = require('fastify')
 const From = require('..')
-const http = require('http')
+const http = require('node:http')
 const get = require('simple-get').concat
 
 const instance = Fastify()

package/test/undici-connect-timeout.test.js

@@ -1,8 +1,8 @@
 'use strict'
 
 const t = require('tap')
-const http = require('http')
-const net = require('net')
+const http = require('node:http')
+const net = require('node:net')
 const Fastify = require('fastify')
 const From = require('..')
 const got = require('got')

package/test/undici-global-agent.test.js

@@ -2,7 +2,7 @@
 
 const { test } = require('tap')
 const Fastify = require('fastify')
-const http = require('http')
+const http = require('node:http')
 const get = require('simple-get').concat
 const undici = require('undici')
 const From = require('..')

package/test/undici-options.test.js

@@ -3,7 +3,7 @@
 const t = require('tap')
 const Fastify = require('fastify')
 const proxyquire = require('proxyquire')
-const http = require('http')
+const http = require('node:http')
 const get = require('simple-get').concat
 const undici = require('undici')
 const { getUndiciOptions } = require('../lib/request')

package/test/undici-retry.test.js

@@ -7,7 +7,7 @@ const { test } = require('tap')
 
 let retryNum = 1
 
-const target = require('http').createServer(function (req, res) {
+const target = require('node:http').createServer(function (req, res) {
   if (retryNum % 2 !== 0) {
     req.socket.destroy()
   } else {

package/test/undici-timeout-body-partial.test.js

@@ -1,7 +1,7 @@
 'use strict'
 
 const t = require('tap')
-const http = require('http')
+const http = require('node:http')
 const Fastify = require('fastify')
 const From = require('..')
 const got = require('got')

package/test/undici-timeout-body.test.js

@@ -1,7 +1,7 @@
 'use strict'
 
 const t = require('tap')
-const http = require('http')
+const http = require('node:http')
 const Fastify = require('fastify')
 const From = require('..')
 const got = require('got')

package/test/undici-with-path-in-base.test.js

@@ -3,7 +3,7 @@
 const t = require('tap')
 const Fastify = require('fastify')
 const From = require('..')
-const http = require('http')
+const http = require('node:http')
 const get = require('simple-get').concat
 
 const instance = Fastify()