@fastify/reply-from 11.0.2 → 12.0.1

package/test/full-post.test.js

@@ -29,7 +29,7 @@ const target = http.createServer((req, res) => {
   })
 })
 
-instance.post('/', (request, reply) => {
+instance.post('/', (_request, reply) => {
   reply.from(`http://localhost:${target.address().port}`)
 })
 
@@ -48,7 +48,7 @@ instance.listen({ port: 0 }, (err) => {
       body: {
         hello: 'world'
       }
-    }, (err, res, data) => {
+    }, (err, _res, data) => {
       t.error(err)
       t.same(data, { something: 'else' })
     })

package/test/full-querystring-rewrite-option-complex.test.js

@@ -21,7 +21,7 @@ const target = http.createServer((req, res) => {
   res.end('hello world')
 })
 
-instance.get('/hello', (request, reply) => {
+instance.get('/hello', (_request, reply) => {
   reply.from(`http://localhost:${target.address().port}/world?a=b`, {
     queryString: { b: 'c' }
   })

package/test/full-querystring-rewrite-option-function-request.test.js

@@ -9,7 +9,7 @@ const querystring = require('node:querystring')
 
 const instance = Fastify()
 
-instance.addHook('preHandler', (request, reply, done) => {
+instance.addHook('preHandler', (request, _reply, done) => {
   request.addedVal = 'test'
   done()
 })
@@ -27,9 +27,9 @@ const target = http.createServer((req, res) => {
   res.end('hello world')
 })
 
-instance.get('/hello', (request, reply) => {
+instance.get('/hello', (_request, reply) => {
   reply.from(`http://localhost:${target.address().port}/world?a=b`, {
-    queryString (search, reqUrl, request) {
+    queryString (_search, _reqUrl, request) {
       return querystring.stringify({ q: request.addedVal })
     }
   })

package/test/full-querystring-rewrite-option-function.test.js

@@ -22,7 +22,7 @@ const target = http.createServer((req, res) => {
   res.end('hello world')
 })
 
-instance.get('/hello', (request, reply) => {
+instance.get('/hello', (_request, reply) => {
   reply.from(`http://localhost:${target.address().port}/world?a=b`, {
     queryString () {
       return querystring.stringify({ b: 'c' })

package/test/full-querystring-rewrite-option.test.js

@@ -21,7 +21,7 @@ const target = http.createServer((req, res) => {
   res.end('hello world')
 })
 
-instance.get('/hello', (request, reply) => {
+instance.get('/hello', (_request, reply) => {
   reply.from(`http://localhost:${target.address().port}/world`, {
     queryString: { b: 'c' }
   })

package/test/full-querystring-rewrite-string.test.js

@@ -21,7 +21,7 @@ const target = http.createServer((req, res) => {
   res.end('hello world')
 })
 
-instance.get('/hello', (request, reply) => {
+instance.get('/hello', (_request, reply) => {
   reply.from(`http://localhost:${target.address().port}/world?b=c`)
 })
 

package/test/full-querystring-rewrite.test.js

@@ -21,7 +21,7 @@ const target = http.createServer((req, res) => {
   res.end('hello world')
 })
 
-instance.get('/hello', (request, reply) => {
+instance.get('/hello', (_request, reply) => {
   reply.from(`http://localhost:${target.address().port}/world`)
 })
 

package/test/full-querystring.test.js

@@ -21,7 +21,7 @@ const target = http.createServer((req, res) => {
   res.end('hello world')
 })
 
-instance.get('/hello', (request, reply) => {
+instance.get('/hello', (_request, reply) => {
   reply.from(`http://localhost:${target.address().port}/world`)
 })
 

package/test/full-rewrite-body-content-type.test.js

@@ -2,15 +2,17 @@
 
 const t = require('tap')
 const Fastify = require('fastify')
-const From = require('..')
+const fastifyReplyFrom = require('..')
 const http = require('node:http')
 const get = require('simple-get').concat
-const msgpack = require('msgpack5')()
 
 const instance = Fastify()
-instance.register(From)
+instance.register(fastifyReplyFrom)
 
-t.plan(8)
+const payload = { hello: 'world' }
+const msgPackPayload = Buffer.from([0x81, 0xa5, 0x68, 0x65, 0x6c, 0x6c, 0x6f, 0xa5, 0x77, 0x6f, 0x72, 0x6c, 0x64])
+
+t.plan(9)
 t.teardown(instance.close.bind(instance))
 
 const target = http.createServer((req, res) => {
@@ -22,7 +24,7 @@ const target = http.createServer((req, res) => {
     data.push(d)
   })
   req.on('end', () => {
-    t.same(msgpack.decode(Buffer.concat(data)), { hello: 'world' })
+    t.same(Buffer.concat(data), msgPackPayload)
     res.statusCode = 200
     res.setHeader('content-type', 'application/json')
     res.end(JSON.stringify({ something: 'else' }))
@@ -30,9 +32,10 @@ const target = http.createServer((req, res) => {
 })
 
 instance.post('/', (request, reply) => {
+  t.same(request.body, payload)
   reply.from(`http://localhost:${target.address().port}`, {
     contentType: 'application/msgpack',
-    body: msgpack.encode(request.body)
+    body: msgPackPayload
   })
 })
 
@@ -51,7 +54,7 @@ instance.listen({ port: 0 }, (err) => {
       body: {
         hello: 'world'
       }
-    }, (err, res, data) => {
+    }, (err, _res, data) => {
       t.error(err)
       t.same(data, { something: 'else' })
     })

package/test/full-rewrite-body-http.test.js

@@ -32,7 +32,7 @@ const target = http.createServer((req, res) => {
   })
 })
 
-instance.post('/', (request, reply) => {
+instance.post('/', (_request, reply) => {
   reply.from(`http://localhost:${target.address().port}`, {
     body: {
       something: 'else'
@@ -55,7 +55,7 @@ instance.listen({ port: 0 }, (err) => {
       body: {
         hello: 'world'
       }
-    }, (err, res, data) => {
+    }, (err, _res, data) => {
       t.error(err)
       t.same(data, { hello: 'fastify' })
     })

package/test/full-rewrite-body-to-empty-string.test.js

@@ -32,7 +32,7 @@ const target = http.createServer((req, res) => {
   })
 })
 
-instance.post('/', (request, reply) => {
+instance.post('/', (_request, reply) => {
   reply.from(`http://localhost:${target.address().port}`, {
     body: ''
   })
@@ -53,7 +53,7 @@ instance.listen({ port: 0 }, (err) => {
       body: {
         hello: 'world'
       }
-    }, (err, res, data) => {
+    }, (err, _res, data) => {
       t.error(err)
       t.same(data, { hello: 'fastify' })
     })

package/test/full-rewrite-body-to-null.test.js

@@ -32,7 +32,7 @@ const target = http.createServer((req, res) => {
   })
 })
 
-instance.post('/', (request, reply) => {
+instance.post('/', (_request, reply) => {
   reply.from(`http://localhost:${target.address().port}`, {
     body: null
   })
@@ -53,7 +53,7 @@ instance.listen({ port: 0 }, (err) => {
       body: {
         hello: 'world'
       }
-    }, (err, res, data) => {
+    }, (err, _res, data) => {
       t.error(err)
       t.same(data, { hello: 'fastify' })
     })

package/test/full-rewrite-body.test.js

@@ -30,7 +30,7 @@ const target = http.createServer((req, res) => {
   })
 })
 
-instance.post('/', (request, reply) => {
+instance.post('/', (_request, reply) => {
   reply.from(`http://localhost:${target.address().port}`, {
     body: {
       something: 'else'
@@ -53,7 +53,7 @@ instance.listen({ port: 0 }, (err) => {
       body: {
         hello: 'world'
       }
-    }, (err, res, data) => {
+    }, (err, _res, data) => {
       t.error(err)
       t.same(data, { hello: 'fastify' })
     })

package/test/get-upstream-http.test.js

@@ -29,16 +29,16 @@ const target = http.createServer((req, res) => {
   res.end(req.headers.host)
 })
 
-instance.get('/test', (request, reply) => {
+instance.get('/test', (_request, reply) => {
   reply.from('/test', {
-    getUpstream: (req, base) => {
+    getUpstream: (_req, base) => {
       t.pass('getUpstream called')
       return `${base}:${target.address().port}`
     }
   })
 })
 
-instanceWithoutBase.get('/test2', (request, reply) => {
+instanceWithoutBase.get('/test2', (_request, reply) => {
   reply.from('/test2', {
     getUpstream: () => {
       t.pass('getUpstream called')

package/test/get-upstream-undici.test.js

@@ -20,7 +20,7 @@ const target = http.createServer((req, res) => {
   res.end(req.headers.host)
 })
 
-instance.get('/test', (request, reply) => {
+instance.get('/test', (_request, reply) => {
   reply.from('/test', {
     getUpstream: () => {
       t.pass('getUpstream called')

package/test/get-with-body.test.js

@@ -22,7 +22,7 @@ const target = http.createServer((req, res) => {
   res.end('hello world')
 })
 
-instance.get('/', (request, reply) => {
+instance.get('/', (_request, reply) => {
   reply.from()
 })
 

package/test/head-with-body.test.js

@@ -5,12 +5,6 @@ const Fastify = require('fastify')
 const From = require('..')
 const http = require('node:http')
 const get = require('simple-get').concat
-const semver = require('semver')
-
-if (semver.gte(process.version, '20.2.0')) {
-  t.comment('skip this test on node >= 20.2.0 as it is current broken')
-  process.exit(0)
-}
 
 const instance = Fastify()
 
@@ -29,7 +23,7 @@ const target = http.createServer((req, res) => {
   res.end('hello world')
 })
 
-instance.head('/', (request, reply) => {
+instance.head('/', (_request, reply) => {
   t.pass('head received')
   reply.from()
 })

package/test/host-header.test.js

@@ -12,12 +12,12 @@ test('hostname', async (t) => {
 
   nock('http://httpbin.org')
     .get('/ip')
-    .reply(200, function (uri, requestBody) {
+    .reply(200, function () {
       t.equal(this.req.headers.host, 'httpbin.org')
       return { origin: '127.0.0.1' }
     })
 
-  instance.get('*', (request, reply) => {
+  instance.get('*', (_request, reply) => {
     reply.from(null, {
       rewriteRequestHeaders: (originalReq, headers) => {
         t.equal(headers.host, 'httpbin.org')
@@ -48,7 +48,7 @@ test('hostname and port', async (t) => {
 
   nock('http://httpbin.org:8080')
     .get('/ip')
-    .reply(200, function (uri, requestBody) {
+    .reply(200, function () {
       t.equal(this.req.headers.host, 'httpbin.org:8080')
       return { origin: '127.0.0.1' }
     })
@@ -58,7 +58,7 @@ test('hostname and port', async (t) => {
     http: true
   })
 
-  instance.get('*', (request, reply) => {
+  instance.get('*', (_request, reply) => {
     reply.from()
   })
 

package/test/http-agents.test.js

@@ -22,7 +22,7 @@ const target = http.createServer((req, res) => {
   res.end('hello world')
 })
 
-instance.get('/', (request, reply) => {
+instance.get('/', (_request, reply) => {
   reply.from()
 })
 

package/test/http-global-agent.test.js

@@ -12,7 +12,7 @@ test('http global agent is used, but not destroyed', async (t) => {
   }
   const instance = Fastify()
   t.teardown(instance.close.bind(instance))
-  instance.get('/', (request, reply) => {
+  instance.get('/', (_request, reply) => {
     reply.from()
   })
 

package/test/http-http2.test.js

@@ -14,14 +14,14 @@ test('http -> http2', async (t) => {
     http2: true
   })
 
-  target.get('/', (request, reply) => {
+  target.get('/', (_request, reply) => {
     t.pass('request proxied')
     reply.code(404).header('x-my-header', 'hello!').send({
       hello: 'world'
     })
   })
 
-  instance.get('/', (request, reply) => {
+  instance.get('/', (_request, reply) => {
     reply.from()
   })
 

package/test/http-invalid-target.test.js

@@ -10,7 +10,7 @@ test('http invalid target', async (t) => {
 
   t.teardown(instance.close.bind(instance))
 
-  instance.get('/', (request, reply) => {
+  instance.get('/', (_request, reply) => {
     reply.from()
   })
   instance.register(From, {

package/test/http-retry.test.js

@@ -29,7 +29,7 @@ test('Will retry', async function (t) {
 
   instance.register(From, { http: true })
 
-  instance.get('/', (request, reply) => {
+  instance.get('/', (_request, reply) => {
     reply.from(`http://localhost:${target.address().port}/`, {
       retriesCount: 1,
       onError: (reply, { error }) => {
@@ -56,7 +56,7 @@ test('will not retry', async function (t) {
 
   instance.register(From, { http: true })
 
-  instance.get('/', (request, reply) => {
+  instance.get('/', (_request, reply) => {
     reply.from(`http://localhost:${target.address().port}/`, {
       retriesCount: 0,
       onError: (reply, { error }) => {
@@ -87,7 +87,7 @@ test('will not retry unsupported method', async function (t) {
 
   instance.register(From, { http: true, retryMethods: ['DELETE'] })
 
-  instance.get('/', (request, reply) => {
+  instance.get('/', (_request, reply) => {
     reply.from(`http://localhost:${target.address().port}/`, {
       retriesCount: 1,
       onError: (reply, { error }) => {

package/test/http-timeout.test.js

@@ -12,7 +12,7 @@ test('http request timeout', async (t) => {
   const target = Fastify()
   t.teardown(target.close.bind(target))
 
-  target.get('/', (request, reply) => {
+  target.get('/', (_request, reply) => {
     t.pass('request arrives')
 
     clock.setTimeout(() => {
@@ -28,7 +28,7 @@ test('http request timeout', async (t) => {
 
   instance.register(From, { http: { requestOptions: { timeout: 100 } } })
 
-  instance.get('/', (request, reply) => {
+  instance.get('/', (_request, reply) => {
     reply.from(`http://localhost:${target.server.address().port}/`)
   })
 
@@ -56,7 +56,7 @@ test('http sse removes timeout test', async (t) => {
   const target = Fastify()
   t.teardown(target.close.bind(target))
 
-  target.get('/', (request, reply) => {
+  target.get('/', (_request, reply) => {
     t.pass('request arrives')
 
     reply.header('content-type', 'text/event-stream').status(200).send('hello world')
@@ -69,7 +69,7 @@ test('http sse removes timeout test', async (t) => {
 
   instance.register(From, { http: { requestOptions: { timeout: 100 } } })
 
-  instance.get('/', (request, reply) => {
+  instance.get('/', (_request, reply) => {
     reply.from(`http://localhost:${target.server.address().port}/`)
   })
 

package/test/http2-http2.test.js

@@ -23,14 +23,14 @@ t.test('http2 -> http2', async (t) => {
     http2: true
   })
 
-  target.get('/', (request, reply) => {
+  target.get('/', (_request, reply) => {
     t.pass('request proxied')
     reply.code(404).header('x-my-header', 'hello!').send({
       hello: 'world'
     })
   })
 
-  instance.get('/', (request, reply) => {
+  instance.get('/', (_request, reply) => {
     reply.from()
   })
 

package/test/http2-https.test.js

@@ -25,14 +25,14 @@ const target = Fastify({
   https: certs
 })
 
-target.get('/', (request, reply) => {
+target.get('/', (_request, reply) => {
   t.pass('request proxied')
   reply.code(404).header('x-my-header', 'hello!').send({
     hello: 'world'
   })
 })
 
-instance.get('/', (request, reply) => {
+instance.get('/', (_request, reply) => {
   reply.from()
 })
 

package/test/http2-invalid-target.test.js

@@ -10,7 +10,7 @@ test('http2 invalid target', async (t) => {
 
   t.teardown(instance.close.bind(instance))
 
-  instance.get('/', (request, reply) => {
+  instance.get('/', (_request, reply) => {
     reply.from()
   })
   instance.register(From, {

package/test/http2-target-crash.test.js

@@ -14,14 +14,14 @@ test('http -> http2 crash', async (t) => {
     http2: true
   })
 
-  target.get('/', (request, reply) => {
+  target.get('/', (_request, reply) => {
     t.pass('request proxied')
     reply.code(200).send({
       hello: 'world'
     })
   })
 
-  instance.get('/', (request, reply) => {
+  instance.get('/', (_request, reply) => {
     reply.from()
   })
 

package/test/http2-target-multi-crash.test.js

@@ -10,7 +10,7 @@ test('http -> http2 crash multiple times', async (t) => {
 
   t.teardown(instance.close.bind(instance))
 
-  instance.get('/', (request, reply) => {
+  instance.get('/', (_request, reply) => {
     reply.from()
   })
 

package/test/http2-timeout-disabled.test.js

@@ -23,7 +23,7 @@ test('http2 request timeout disabled', async (t) => {
     http2: { requestTimeout: 0, sessionTimeout: 16000 }
   })
 
-  instance.get('/', (request, reply) => {
+  instance.get('/', (_request, reply) => {
     reply.from(`http://localhost:${target.server.address().port}/`)
   })
 
@@ -59,7 +59,7 @@ test('http2 session timeout disabled', async (t) => {
     http2: { requestTimeout: 0, sessionTimeout: 0 }
   })
 
-  instance.get('/', (request, reply) => {
+  instance.get('/', (_request, reply) => {
     reply.from(`http://localhost:${target.server.address().port}/`)
   })
 

package/test/http2-timeout.test.js

@@ -23,7 +23,7 @@ test('http2 request timeout', async (t) => {
     http2: { requestTimeout: 100, sessionTimeout: 6000 }
   })
 
-  instance.get('/', (request, reply) => {
+  instance.get('/', (_request, reply) => {
     reply.from(`http://localhost:${target.server.address().port}/`)
   })
 
@@ -67,7 +67,7 @@ test('http2 session timeout', async (t) => {
     http2: { sessionTimeout: 100 }
   })
 
-  instance.get('/', (request, reply) => {
+  instance.get('/', (_request, reply) => {
     reply.from(`http://localhost:${target.server.address().port}/`)
   })
 
@@ -96,7 +96,7 @@ test('http2 session timeout', async (t) => {
 test('http2 sse removes request and session timeout test', async (t) => {
   const target = Fastify({ http2: true, sessionTimeout: 0 })
 
-  target.get('/', (request, reply) => {
+  target.get('/', (_request, reply) => {
     t.pass('request arrives')
 
     reply.status(200).header('content-type', 'text/event-stream').send('hello world')
@@ -111,7 +111,7 @@ test('http2 sse removes request and session timeout test', async (t) => {
     http2: { sessionTimeout: 100 }
   })
 
-  instance.get('/', (request, reply) => {
+  instance.get('/', (_request, reply) => {
     reply.from(`http://localhost:${target.server.address().port}/`)
   })
 

package/test/https-agents.test.js

@@ -31,7 +31,7 @@ const target = https.createServer(certs, (req, res) => {
   res.end('hello world')
 })
 
-instance.get('/', (request, reply) => {
+instance.get('/', (_request, reply) => {
   reply.from()
 })
 

package/test/https-global-agent.test.js

@@ -21,7 +21,7 @@ test('https global agent is used, but not destroyed', async (t) => {
     https: certs
   })
   t.teardown(instance.close.bind(instance))
-  instance.get('/', (request, reply) => {
+  instance.get('/', (_request, reply) => {
     reply.from()
   })
 

package/test/method.test.js

@@ -33,7 +33,7 @@ const target = http.createServer((req, res) => {
   })
 })
 
-instance.patch('/', (request, reply) => {
+instance.patch('/', (_request, reply) => {
   reply.from(`http://localhost:${target.address().port}`, { method: 'POST' })
 })
 
@@ -42,7 +42,7 @@ t.teardown(target.close.bind(target))
 target.listen({ port: 0 }, (err) => {
   t.error(err)
 
-  instance.addContentTypeParser('application/json', function (req, payload, done) {
+  instance.addContentTypeParser('application/json', function (_req, payload, done) {
     done(null, payload)
   })
 
@@ -61,7 +61,7 @@ target.listen({ port: 0 }, (err) => {
         'content-type': 'application/json'
       },
       body: bodyString
-    }, (err, res, data) => {
+    }, (err, _res, data) => {
       t.error(err)
       const parsed = JSON.parse(data)
       t.same(parsed, { something: 'else' })

package/test/modifyCoreObjects-false.test.js

@@ -21,7 +21,7 @@ const target = http.createServer((req, res) => {
   res.end('hello world')
 })
 
-instance.get('/', (request, reply) => {
+instance.get('/', (_request, reply) => {
   reply.from()
 })
 

package/test/no-body-opts-with-get.test.js

@@ -11,12 +11,12 @@ const instance = Fastify()
 t.plan(6)
 t.teardown(instance.close.bind(instance))
 
-const target = http.createServer((req, res) => {
+const target = http.createServer((_req, res) => {
   t.fail('this should never get called')
   res.end('hello world')
 })
 
-instance.get('/', (request, reply) => {
+instance.get('/', (_request, reply) => {
   try {
     reply.from(null, { body: 'this is the new body' })
   } catch (e) {

package/test/no-body-opts-with-head.test.js

@@ -11,12 +11,12 @@ const instance = Fastify()
 t.plan(7)
 t.teardown(instance.close.bind(instance))
 
-const target = http.createServer((req, res) => {
+const target = http.createServer((_req, res) => {
   t.fail('this should never get called')
   res.end('hello world')
 })
 
-instance.head('/', (request, reply) => {
+instance.head('/', (_request, reply) => {
   try {
     reply.from(null, { body: 'this is the new body' })
   } catch (e) {