@fastify/cookie 8.1.0 → 8.2.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@fastify/cookie",
-  "version": "8.1.0",
+  "version": "8.2.0",
   "description": "Plugin for fastify to add support for cookies",
   "main": "plugin.js",
   "types": "types/plugin.d.ts",
@@ -47,7 +47,7 @@
     "snazzy": "^9.0.0",
     "standard": "^17.0.0",
     "tap": "^16.0.0",
-    "tsd": "^0.22.0"
+    "tsd": "^0.24.1"
   },
   "dependencies": {
     "cookie": "^0.5.0",

package/plugin.js

@@ -42,7 +42,7 @@ function fastifyCookieSetCookie (reply, name, value, options, signer) {
 }
 
 function fastifyCookieClearCookie (reply, name, options) {
-  const opts = Object.assign({ path: '/' }, options || { }, {
+  const opts = Object.assign({ path: '/' }, options, {
     expires: new Date(1),
     signed: undefined,
     maxAge: undefined
@@ -135,8 +135,9 @@ function plugin (fastify, options, next) {
     return fastifyCookieSetCookie(this, name, value, opts, signer)
   }
 
-  function clearCookie (name, options) {
-    return fastifyCookieClearCookie(this, name, options)
+  function clearCookie (name, cookieOptions) {
+    const opts = Object.assign({}, options.parseOptions, cookieOptions)
+    return fastifyCookieClearCookie(this, name, opts)
   }
 }
 

package/test/cookie.test.js

@@ -942,3 +942,51 @@ test('if cookies are not set, then the handler creates an empty req.cookies obje
     t.equal(res.statusCode, 200)
   })
 })
+
+test('clearCookie should include parseOptions', (t) => {
+  t.plan(14)
+  const fastify = Fastify()
+  fastify.register(plugin, {
+    parseOptions: {
+      path: '/test',
+      domain: 'example.com'
+    }
+  })
+
+  const cookieOptions = {
+    path: '/test',
+    maxAge: 36000
+  }
+
+  fastify.get('/test1', (req, reply) => {
+    reply
+      .setCookie('foo', 'foo', cookieOptions)
+      .clearCookie('foo', cookieOptions)
+      .send({ hello: 'world' })
+  })
+
+  fastify.inject({
+    method: 'GET',
+    url: '/test1'
+  }, (err, res) => {
+    t.error(err)
+    t.equal(res.statusCode, 200)
+    t.same(JSON.parse(res.body), { hello: 'world' })
+
+    const cookies = res.cookies
+
+    t.equal(cookies.length, 2)
+    t.equal(cookies[0].name, 'foo')
+    t.equal(cookies[0].value, 'foo')
+    t.equal(cookies[0].maxAge, 36000)
+    t.equal(cookies[0].path, '/test')
+    t.equal(cookies[0].domain, 'example.com')
+
+    t.equal(cookies[1].name, 'foo')
+    t.equal(cookies[1].value, '')
+    t.equal(cookies[1].path, '/test')
+    t.equal(cookies[1].domain, 'example.com')
+
+    t.ok(new Date(cookies[1].expires) < new Date())
+  })
+})

package/types/plugin.test-d.ts

@@ -3,8 +3,7 @@ import { expectError, expectType } from 'tsd';
 import * as fastifyCookieStar from '..';
 import fastifyCookieCjsImport = require('..');
 import fastifyCookieDefault, { fastifyCookie as fastifyCookieNamed  } from '..';
-import fastify, { FastifyInstance,  FastifyPluginCallback,  FastifyReply, setCookieWrapper } from 'fastify';
-import { Server } from 'http';
+import fastify, { FastifyInstance, FastifyReply, setCookieWrapper } from 'fastify';
 
 const fastifyCookieCjs = require('..');