@fastify/compress 9.2.0 → 9.2.2

package/.c8rc

@@ -1,6 +1,6 @@
 {
   "all": true,
-  "exclude": ["test/", "coverage/", "types/", "eslint.config.js"],
+  "exclude": ["test/", "coverage/", "types/", "benchmark/", "eslint.config.js"],
   "clean": true,
   "check-coverage": true,
   "branches": 100,

package/.github/workflows/release.yml

@@ -0,0 +1,24 @@
+name: Release the package
+
+on:
+  workflow_dispatch:
+    inputs:
+      semver:
+        description: 'Release bump type'
+        required: true
+        type: choice
+        options:
+          - patch
+          - minor
+          - major
+
+permissions: {}
+
+jobs:
+  release:
+    permissions:
+      id-token: write # required for npm provenance via OIDC
+      contents: write # required to push the release commit and the tag
+    uses: fastify/workflows/.github/workflows/reusable-release.yml@b1a11bce713bc857e52b2231fec3c89071ad3135
+    with:
+      semver: ${{ inputs.semver }}

package/README.md

@@ -480,7 +480,7 @@ await fastify.register(
 
 ## Acknowledgments
 
-Past sp
+Past sponsors:
 - LetzDoIt
 
 ## License

package/index.js

@@ -2,13 +2,11 @@
 
 const zlib = require('node:zlib')
 const { inherits, format } = require('node:util')
-const { pipeline, compose } = require('node:stream')
+const { pipeline, compose, Readable, PassThrough } = require('node:stream')
 
 const fp = require('fastify-plugin')
 const encodingNegotiator = require('@fastify/accept-negotiator')
 const mimedb = require('mime-db')
-const { Minipass } = require('minipass')
-const { Readable } = require('readable-stream')
 
 const {
   computeSyncThreshold,
@@ -572,15 +570,30 @@ function compress (params) {
 }
 
 function setVaryHeader (reply) {
-  if (reply.hasHeader('Vary')) {
-    const rawHeaderValue = reply.getHeader('Vary')
-    const headerValueArray = Array.isArray(rawHeaderValue) ? rawHeaderValue : [rawHeaderValue]
-    if (!headerValueArray.some((h) => h.includes('accept-encoding'))) {
-      reply.header('Vary', headerValueArray.concat('accept-encoding').join(', '))
+  const current = reply.getHeader('vary')
+
+  if (current === undefined) {
+    reply.header('vary', 'accept-encoding')
+    return
+  }
+
+  const value = Array.isArray(current) ? current.join(', ') : String(current)
+
+  // Walk the comma-separated tokens without splitting the string.
+  const headerLength = value.length
+  let start = 0
+  for (let i = 0; i <= headerLength; i++) {
+    if (i === headerLength || value[i] === ',') {
+      const token = value.slice(start, i).trim().toLowerCase()
+      // A `Vary: *` already covers every request header.
+      if (token === 'accept-encoding' || token === '*') {
+        return
+      }
+      start = i + 1
     }
-  } else {
-    reply.header('Vary', 'accept-encoding')
   }
+
+  reply.header('vary', value + ', accept-encoding')
 }
 
 function onEnd (err) {
@@ -681,8 +694,8 @@ function maybeUnzip (payload, serialize) {
 function zipStream (deflate, encoding) {
   return createPeekTransform(function (data) {
     switch (isCompressed(data)) {
-      case 1: return new Minipass()
-      case 2: return new Minipass()
+      case 1: return new PassThrough()
+      case 2: return new PassThrough()
     }
     return deflate[encoding]()
   })
@@ -698,7 +711,7 @@ function unzipStream (inflate, maxRecursion) {
       case 1: return compose(inflate.gzip(), unzipStream(inflate, maxRecursion - 1))
       case 2: return compose(inflate.deflate(), unzipStream(inflate, maxRecursion - 1))
     }
-    return new Minipass()
+    return new PassThrough()
   })
 }
 

package/lib/utils.js

@@ -1,8 +1,7 @@
 'use strict'
 
-const { Readable: NodeReadable } = require('node:stream')
+const { Readable: NodeReadable, Transform } = require('node:stream')
 const { availableParallelism } = require('node:os')
-const { Transform } = require('readable-stream')
 
 // Bounds of the computed default synchronous compression threshold
 const MIN_SYNC_THRESHOLD = 4096

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@fastify/compress",
-  "version": "9.2.0",
+  "version": "9.2.2",
   "description": "Fastify compression utils",
   "main": "index.js",
   "type": "commonjs",
@@ -8,9 +8,7 @@
   "dependencies": {
     "@fastify/accept-negotiator": "^2.0.0",
     "fastify-plugin": "^6.0.0",
-    "mime-db": "^1.52.0",
-    "minipass": "^7.0.4",
-    "readable-stream": "^4.5.2"
+    "mime-db": "^1.52.0"
   },
   "devDependencies": {
     "@types/node": "^26.0.1",

package/test/global-compress.test.js

@@ -3167,6 +3167,55 @@ test('It should not add `accept-encoding` to `Vary` reply header if already pres
   })
 })
 
+test('It should handle case-insensitivity, substring safety, and wildcard in Vary header', async (t) => {
+  t.plan(3)
+
+  const fastify = Fastify()
+  await fastify.register(compressPlugin, { global: true })
+
+  fastify.get('/case', (_request, reply) => {
+    reply
+      .header('vary', 'Accept-Encoding')
+      .type('text/plain')
+      .compress(createReadStream('./package.json'))
+  })
+
+  fastify.get('/substring', (_request, reply) => {
+    reply
+      .header('vary', 'x-accept-encoding')
+      .type('text/plain')
+      .compress(createReadStream('./package.json'))
+  })
+
+  fastify.get('/wildcard', (_request, reply) => {
+    reply
+      .header('vary', '*')
+      .type('text/plain')
+      .compress(createReadStream('./package.json'))
+  })
+
+  const res1 = await fastify.inject({
+    url: '/case',
+    method: 'GET',
+    headers: { 'accept-encoding': 'deflate' }
+  })
+  t.assert.equal(res1.headers.vary, 'Accept-Encoding')
+
+  const res2 = await fastify.inject({
+    url: '/substring',
+    method: 'GET',
+    headers: { 'accept-encoding': 'deflate' }
+  })
+  t.assert.equal(res2.headers.vary, 'x-accept-encoding, accept-encoding')
+
+  const res3 = await fastify.inject({
+    url: '/wildcard',
+    method: 'GET',
+    headers: { 'accept-encoding': 'deflate' }
+  })
+  t.assert.equal(res3.headers.vary, '*')
+})
+
 test('It should follow the `Accept-Encoding` request header encoding order', async (t) => {
   t.plan(3)