@fastify/compress 8.0.0 → 8.0.2

package/test/global-decompress.test.js

@@ -251,7 +251,7 @@ describe('It should return the error returned by :', async () => {
 
     const fastify = Fastify()
     await fastify.register(compressPlugin, {
-      onUnsupportedRequestEncoding (encoding, request) {
+      onUnsupportedRequestEncoding (encoding) {
         return {
           statusCode: 400,
           code: 'INVALID',
@@ -288,7 +288,7 @@ describe('It should return the error returned by :', async () => {
 
     const fastify = Fastify()
     await fastify.register(compressPlugin, {
-      onInvalidRequestPayload (encoding, request, error) {
+      onInvalidRequestPayload (encoding, _request, error) {
         return {
           statusCode: 400,
           code: 'INVALID',
@@ -327,7 +327,7 @@ describe('It should return the default error :', async () => {
 
     const fastify = Fastify()
     await fastify.register(compressPlugin, {
-      onUnsupportedRequestEncoding (encoding, request) {
+      onUnsupportedRequestEncoding () {
         throw new Error('Kaboom!')
       }
     })
@@ -359,7 +359,7 @@ describe('It should return the default error :', async () => {
 
     const fastify = Fastify()
     await fastify.register(compressPlugin, {
-      onInvalidRequestPayload (encoding, request, error) {
+      onInvalidRequestPayload () {
         throw new Error('Kaboom!')
       }
     })

package/test/regression/issue-288.test.js

@@ -37,16 +37,16 @@ test('should not corrupt the file content', async (t) => {
   const fastify = new Fastify()
   t.after(() => fastify.close())
 
-  fastify.register(async (instance, opts) => {
+  fastify.register(async (instance) => {
     await fastify.register(fastifyCompress)
     // compression
-    instance.get('/compress', async (req, reply) => {
+    instance.get('/compress', async () => {
       return twoByteUnicodeContent
     })
   })
 
   // no compression
-  fastify.get('/no-compress', async (req, reply) => {
+  fastify.get('/no-compress', async () => {
     return twoByteUnicodeContent
   })
 

package/test/routes-compress.test.js

@@ -6,7 +6,7 @@ const zlib = require('node:zlib')
 const Fastify = require('fastify')
 const compressPlugin = require('../index')
 
-describe('When using routes `compress` settings :', async (t) => {
+describe('When using routes `compress` settings :', async () => {
   test('it should compress data using the route custom provided `createDeflate` method', async (t) => {
     t.plan(12)
     const equal = t.assert.equal
@@ -19,7 +19,7 @@ describe('When using routes `compress` settings :', async (t) => {
     const fastify = Fastify()
     await fastify.register(compressPlugin, { global: true, zlib: customZlibGlobal })
 
-    fastify.get('/', (request, reply) => {
+    fastify.get('/', (_request, reply) => {
       reply
         .type('text/plain')
         .compress(createReadStream('./package.json'))
@@ -27,7 +27,7 @@ describe('When using routes `compress` settings :', async (t) => {
 
     fastify.get('/custom', {
       compress: { zlib: customZlib }
-    }, (request, reply) => {
+    }, (_request, reply) => {
       reply
         .type('text/plain')
         .compress(createReadStream('./package.json'))
@@ -84,13 +84,13 @@ describe('When using routes `compress` settings :', async (t) => {
     const fastify = Fastify()
     await fastify.register(compressPlugin, { global: false, zlib: customZlibGlobal })
 
-    fastify.get('/', (request, reply) => {
+    fastify.get('/', (_request, reply) => {
       reply
         .type('text/plain')
         .compress(createReadStream('./package.json'))
     })
 
-    fastify.get('/custom', { compress: { zlib: customZlib } }, (request, reply) => {
+    fastify.get('/custom', { compress: { zlib: customZlib } }, (_request, reply) => {
       reply
         .type('text/plain')
         .compress(createReadStream('./package.json'))
@@ -143,7 +143,7 @@ describe('When using routes `compress` settings :', async (t) => {
     const fastify = Fastify()
     await fastify.register(compressPlugin, { global: false })
 
-    fastify.get('/', (request, reply) => {
+    fastify.get('/', (_request, reply) => {
       // compress function should still be available
       t.assert.ok(typeof reply.compress === 'function')
 
@@ -152,7 +152,7 @@ describe('When using routes `compress` settings :', async (t) => {
 
     fastify.get('/custom', {
       compress: { zlib: customZlib }
-    }, (request, reply) => {
+    }, (_request, reply) => {
       reply
         .type('text/plain')
         .compress(createReadStream('./package.json'))
@@ -160,7 +160,7 @@ describe('When using routes `compress` settings :', async (t) => {
 
     fastify.get('/standard', {
       compress: { threshold: 1 }
-    }, (request, reply) => {
+    }, (_request, reply) => {
       reply.send({ foo: 1 })
     })
 
@@ -218,7 +218,7 @@ describe('When using routes `compress` settings :', async (t) => {
 
     fastify.get('/', {
       compress: false
-    }, (request, reply) => {
+    }, (_request, reply) => {
       reply.send(content)
     })
 
@@ -245,7 +245,7 @@ describe('When using routes `compress` settings :', async (t) => {
     try {
       fastify.get('/', {
         compress: 'bad config'
-      }, (request, reply) => {
+      }, (_request, reply) => {
         reply.send('')
       })
     } catch (err) {
@@ -264,7 +264,7 @@ describe('When `compress.removeContentLengthHeader` is `false`, it should not re
 
     fastify.get('/', {
       compress: { removeContentLengthHeader: false }
-    }, (request, reply) => {
+    }, (_request, reply) => {
       readFile('./package.json', 'utf8', (err, data) => {
         if (err) {
           return reply.send(err)
@@ -301,7 +301,7 @@ describe('When `compress.removeContentLengthHeader` is `false`, it should not re
 
     fastify.get('/', {
       compress: { removeContentLengthHeader: false }
-    }, (request, reply) => {
+    }, (_request, reply) => {
       readFile('./package.json', 'utf8', (err, data) => {
         if (err) {
           return reply.send(err)
@@ -343,7 +343,7 @@ describe('When using the old routes `{ config: compress }` option :', async () =
     const fastify = Fastify()
     await fastify.register(compressPlugin, { global: false, zlib: customZlibGlobal })
 
-    fastify.get('/', (request, reply) => {
+    fastify.get('/', (_request, reply) => {
       reply
         .type('text/plain')
         .compress(createReadStream('./package.json'))
@@ -353,7 +353,7 @@ describe('When using the old routes `{ config: compress }` option :', async () =
       config: {
         compress: { zlib: customZlib }
       }
-    }, (request, reply) => {
+    }, (_request, reply) => {
       reply
         .type('text/plain')
         .compress(createReadStream('./package.json'))
@@ -410,7 +410,7 @@ describe('When using the old routes `{ config: compress }` option :', async () =
         config: {
           compress: 'bad config'
         }
-      }, (request, reply) => {
+      }, (_request, reply) => {
         reply.send('')
       })
     } catch (err) {
@@ -426,7 +426,7 @@ test('It should avoid to trigger `onSend` hook twice', async (t) => {
   await server.register(compressPlugin, { threshold: 0 })
 
   await server.register(async function (server) {
-    server.get('/', async (request, _) => {
+    server.get('/', async () => {
       return { hi: true }
     })
   }, { prefix: '/test' })

package/test/routes-decompress.test.js

@@ -18,7 +18,7 @@ function createPayload (compressor) {
   return payload
 }
 
-describe('When using routes `decompress` settings :', async (suite) => {
+describe('When using routes `decompress` settings :', async () => {
   test('it should decompress data using the route custom provided `createInflate` method', async (t) => {
     t.plan(8)
     const equal = t.assert.equal
@@ -182,6 +182,31 @@ describe('When using routes `decompress` settings :', async (suite) => {
     })
     equal(usedCustomGlobal, false)
 
+    equal(response.statusCode, 400)
+    t.assert.match(response.json().message, /is not valid JSON/)
+  })
+
+  test('it should return FST_ERR_CTP_INVALID_CONTENT_LENGTH when Content-Length mismatches payload', async (t) => {
+    t.plan(2)
+    const equal = t.assert.equal
+
+    const fastify = Fastify()
+    await fastify.register(compressPlugin)
+
+    fastify.post('/length', (request, reply) => {
+      reply.send({ ok: true })
+    })
+
+    const response = await fastify.inject({
+      url: '/length',
+      method: 'POST',
+      headers: {
+        'content-type': 'application/json',
+        'content-length': '100',
+      },
+      payload: JSON.stringify({ hello: 'world' })
+    })
+
     equal(response.statusCode, 400)
     t.assert.deepEqual(response.json(), {
       statusCode: 400,

package/types/index.d.ts

@@ -5,9 +5,9 @@ import {
   RouteOptions as FastifyRouteOptions,
   RawServerBase,
   RawServerDefault
-} from 'fastify';
-import { Stream } from 'stream';
-import { BrotliOptions, ZlibOptions } from 'zlib';
+} from 'fastify'
+import { Stream } from 'node:stream'
+import { BrotliOptions, ZlibOptions } from 'node:zlib'
 
 declare module 'fastify' {
   export interface FastifyContextConfig {
@@ -18,6 +18,7 @@ declare module 'fastify' {
   }
 
   export interface RouteShorthandOptions<
+    // eslint-disable-next-line @typescript-eslint/no-unused-vars
     RawServer extends RawServerBase = RawServerDefault
   > {
     compress?: RouteCompressOptions | false;
@@ -56,9 +57,9 @@ type RouteDecompressOptions = Pick<fastifyCompress.FastifyCompressOptions,
   | 'zlib'
 >
 
-type EncodingToken = 'br' | 'deflate' | 'gzip' | 'identity';
+type EncodingToken = 'br' | 'deflate' | 'gzip' | 'identity'
 
-type CompressibleContentTypeFunction = (contentType: string) => boolean;
+type CompressibleContentTypeFunction = (contentType: string) => boolean
 
 type Input =
   | Buffer
@@ -66,7 +67,7 @@ type Input =
   | ArrayBuffer
   | string
   | Iterable<Buffer | string>
-  | AsyncIterable<Buffer | string>;
+  | AsyncIterable<Buffer | string>
 
 declare namespace fastifyCompress {
 
@@ -105,5 +106,5 @@ declare namespace fastifyCompress {
   export { fastifyCompress as default }
 }
 
-declare function fastifyCompress(...params: Parameters<FastifyCompress>): ReturnType<FastifyCompress>
+declare function fastifyCompress (...params: Parameters<FastifyCompress>): ReturnType<FastifyCompress>
 export = fastifyCompress

package/types/index.test-d.ts

@@ -1,7 +1,7 @@
 import fastify, { FastifyInstance } from 'fastify'
-import { createReadStream } from 'fs'
+import { createReadStream } from 'node:fs'
 import { expectError, expectType } from 'tsd'
-import * as zlib from 'zlib'
+import * as zlib from 'node:zlib'
 import fastifyCompress, { FastifyCompressOptions } from '..'
 
 const stream = createReadStream('./package.json')
@@ -9,7 +9,7 @@ const stream = createReadStream('./package.json')
 const withGlobalOptions: FastifyCompressOptions = {
   global: true,
   threshold: 10,
-  zlib: zlib,
+  zlib,
   brotliOptions: {
     params: {
       [zlib.constants.BROTLI_PARAM_MODE]: zlib.constants.BROTLI_MODE_TEXT,
@@ -32,11 +32,11 @@ app.register(fastifyCompress, {
   customTypes: value => value === 'application/json'
 })
 
-app.get('/test-one', async (request, reply) => {
+app.get('/test-one', async (_request, reply) => {
   expectType<void>(reply.compress(stream))
 })
 
-app.get('/test-two', async (request, reply) => {
+app.get('/test-two', async (_request, reply) => {
   expectError(reply.compress())
 })
 
@@ -57,7 +57,7 @@ appWithoutGlobal.get('/one', {
       createGunzip: () => zlib.createGunzip()
     }
   }
-}, (request, reply) => {
+}, (_request, reply) => {
   expectType<void>(reply.type('text/plain').compress(stream))
 })
 
@@ -75,7 +75,7 @@ appWithoutGlobal.get('/two', {
       }
     }
   }
-}, (request, reply) => {
+}, (_request, reply) => {
   expectType<void>(reply.type('text/plain').compress(stream))
 })
 
@@ -83,7 +83,7 @@ expectError(
   appWithoutGlobal.get('/throw-a-ts-arg-error-on-shorthand-route', {
     compress: 'bad compress route option value',
     decompress: 'bad decompress route option value'
-  }, (request, reply) => {
+  }, (_request, reply) => {
     expectType<void>(reply.type('text/plain').compress(stream))
   })
 )
@@ -94,7 +94,7 @@ expectError(
     path: '/throw-a-ts-arg-error',
     compress: 'bad compress route option value',
     decompress: 'bad decompress route option value',
-    handler: (request, reply) => { expectType<void>(reply.type('text/plain').compress(stream)) }
+    handler: (_request, reply) => { expectType<void>(reply.type('text/plain').compress(stream)) }
   })
 )