@farmslot/review-dispatch 0.22.0 → 0.24.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +14 -0
- package/dist/checklist-progress.d.ts +10 -2
- package/dist/checklist-progress.d.ts.map +1 -1
- package/dist/checklist-progress.js +37 -7
- package/dist/checklist-progress.js.map +1 -1
- package/dist/index.d.ts +3 -0
- package/dist/index.d.ts.map +1 -1
- package/dist/index.js +3 -0
- package/dist/index.js.map +1 -1
- package/dist/native-launch.d.ts +26 -0
- package/dist/native-launch.d.ts.map +1 -0
- package/dist/native-launch.js +71 -0
- package/dist/native-launch.js.map +1 -0
- package/dist/publication-gate.d.ts.map +1 -1
- package/dist/publication-gate.js +12 -14
- package/dist/publication-gate.js.map +1 -1
- package/dist/review-attempt-receipt.d.ts +4 -0
- package/dist/review-attempt-receipt.d.ts.map +1 -0
- package/dist/review-attempt-receipt.js +22 -0
- package/dist/review-attempt-receipt.js.map +1 -0
- package/dist/review-history-content.d.ts +21 -0
- package/dist/review-history-content.d.ts.map +1 -0
- package/dist/review-history-content.js +168 -0
- package/dist/review-history-content.js.map +1 -0
- package/dist/review-history-timeline.d.ts +8 -0
- package/dist/review-history-timeline.d.ts.map +1 -1
- package/dist/review-history-timeline.js +36 -7
- package/dist/review-history-timeline.js.map +1 -1
- package/dist/review-history.d.ts +9 -2
- package/dist/review-history.d.ts.map +1 -1
- package/dist/review-history.js +65 -15
- package/dist/review-history.js.map +1 -1
- package/package.json +3 -3
|
@@ -0,0 +1,168 @@
|
|
|
1
|
+
import { Methods, reviewDiffHash, } from '@farmslot/protocol';
|
|
2
|
+
import { createSha256, resourceQuery, } from '@farmslot/protocol/client-cache';
|
|
3
|
+
import { loadReviewHistoryArtifacts, mergeReviewHistoryArtifacts, reviewHistoryArtifactPaths, reviewHistoryIdentity, reviewHistoryView, } from './review-history.js';
|
|
4
|
+
const encoder = new TextEncoder();
|
|
5
|
+
const decoder = new TextDecoder();
|
|
6
|
+
function digest(data) {
|
|
7
|
+
const hash = createSha256();
|
|
8
|
+
hash.update(data);
|
|
9
|
+
return hash.hex();
|
|
10
|
+
}
|
|
11
|
+
function alias(run) {
|
|
12
|
+
return `review-history:${digest(encoder.encode(reviewHistoryIdentity(run)))}`;
|
|
13
|
+
}
|
|
14
|
+
function isEntry(value) {
|
|
15
|
+
return Boolean(value &&
|
|
16
|
+
typeof value === 'object' &&
|
|
17
|
+
'path' in value &&
|
|
18
|
+
typeof value.path === 'string' &&
|
|
19
|
+
'kind' in value &&
|
|
20
|
+
['artifact', 'diff', 'absent'].includes(String(value.kind)) &&
|
|
21
|
+
(!('deferred' in value) || value.deferred === true));
|
|
22
|
+
}
|
|
23
|
+
function manifest(data) {
|
|
24
|
+
if (!data)
|
|
25
|
+
return undefined;
|
|
26
|
+
const value = JSON.parse(decoder.decode(data));
|
|
27
|
+
return Array.isArray(value) && value.every(isEntry) ? value : undefined;
|
|
28
|
+
}
|
|
29
|
+
function entryAlias(root, path) {
|
|
30
|
+
return `${root}:${digest(encoder.encode(path))}`;
|
|
31
|
+
}
|
|
32
|
+
/** First paint needs the round metadata; large diff bodies are read from the store on open. */
|
|
33
|
+
export function peekReviewHistoryContent(cache, run) {
|
|
34
|
+
const root = alias(run);
|
|
35
|
+
const entries = manifest(cache.peekContentByAlias?.(root));
|
|
36
|
+
if (!entries)
|
|
37
|
+
return undefined;
|
|
38
|
+
const result = {};
|
|
39
|
+
for (const entry of entries) {
|
|
40
|
+
if (entry.kind === 'absent') {
|
|
41
|
+
result[entry.path] = { notCaptured: true };
|
|
42
|
+
continue;
|
|
43
|
+
}
|
|
44
|
+
const data = cache.peekContentByAlias?.(entryAlias(root, entry.path));
|
|
45
|
+
if (data)
|
|
46
|
+
result[entry.path] = { content: decoder.decode(data) };
|
|
47
|
+
else if (entry.kind !== 'diff')
|
|
48
|
+
return undefined;
|
|
49
|
+
}
|
|
50
|
+
return result;
|
|
51
|
+
}
|
|
52
|
+
/** Hydrates the bounded working set during prefetch; opening protects these same store rows. */
|
|
53
|
+
export async function readReviewHistoryContent(cache, run, opened = false) {
|
|
54
|
+
const root = alias(run);
|
|
55
|
+
const read = (name) => opened ? cache.openContentByAlias(name) : cache.readContentByAlias(name);
|
|
56
|
+
const entries = manifest(await read(root));
|
|
57
|
+
if (!entries)
|
|
58
|
+
return undefined;
|
|
59
|
+
const result = {};
|
|
60
|
+
// Diff bodies are hydrated first so the bounded resident set keeps metadata for first paint.
|
|
61
|
+
for (const entry of [...entries].sort((a, b) => Number(b.kind === 'diff') - Number(a.kind === 'diff'))) {
|
|
62
|
+
if (entry.kind === 'absent') {
|
|
63
|
+
result[entry.path] = { notCaptured: true };
|
|
64
|
+
continue;
|
|
65
|
+
}
|
|
66
|
+
if (entry.deferred)
|
|
67
|
+
return undefined;
|
|
68
|
+
const data = await read(entryAlias(root, entry.path));
|
|
69
|
+
if (!data)
|
|
70
|
+
return undefined;
|
|
71
|
+
result[entry.path] = { content: decoder.decode(data) };
|
|
72
|
+
}
|
|
73
|
+
await read(root);
|
|
74
|
+
return result;
|
|
75
|
+
}
|
|
76
|
+
function hasHistory(run) {
|
|
77
|
+
return Boolean(reviewHistoryArtifactPaths(run).length ||
|
|
78
|
+
run.reviewResult ||
|
|
79
|
+
run.steps?.some((step) => step.name.includes('review')) ||
|
|
80
|
+
run.engineState?.publishGate?.reviews?.length ||
|
|
81
|
+
run.decisions.some((decision) => decision.payload?.kind === 'ready' && decision.payload.reviews?.length));
|
|
82
|
+
}
|
|
83
|
+
/** Both clients attach the same domain loader to the existing two-run prefetch queue. */
|
|
84
|
+
export function createReviewHistoryPrefetch(options) {
|
|
85
|
+
const { cache } = options;
|
|
86
|
+
return {
|
|
87
|
+
identity: (run) => (hasHistory(run) ? reviewHistoryIdentity(run) : ''),
|
|
88
|
+
async prefetch(run, write) {
|
|
89
|
+
if (!hasHistory(run))
|
|
90
|
+
return;
|
|
91
|
+
const held = await readReviewHistoryContent(cache, run);
|
|
92
|
+
let refusal;
|
|
93
|
+
const read = async (method, params) => {
|
|
94
|
+
try {
|
|
95
|
+
const since = Date.now();
|
|
96
|
+
const result = await cache.retry(resourceQuery(method, params), { origin: 'prefetch', cohort: write.cohort }, write.signal);
|
|
97
|
+
if (write.signal.aborted ||
|
|
98
|
+
result.data === undefined ||
|
|
99
|
+
result.error ||
|
|
100
|
+
(result.observedAt ?? -Infinity) < since)
|
|
101
|
+
throw Object.assign(new Error(result.error?.message ?? 'Review content read did not complete'), { code: result.error?.code });
|
|
102
|
+
return result.data;
|
|
103
|
+
}
|
|
104
|
+
catch (error) {
|
|
105
|
+
if (error &&
|
|
106
|
+
typeof error === 'object' &&
|
|
107
|
+
['AUTH_REQUIRED', 'AUTH_FORBIDDEN'].includes(String(Reflect.get(error, 'code'))))
|
|
108
|
+
refusal = error;
|
|
109
|
+
throw error;
|
|
110
|
+
}
|
|
111
|
+
};
|
|
112
|
+
const artifacts = held ??
|
|
113
|
+
(await loadReviewHistoryArtifacts(run, async (path) => {
|
|
114
|
+
try {
|
|
115
|
+
return decoder.decode(await options.readArtifact({ runId: run.id, path, bundleDigest: run.artifactBundle?.bundleDigest }, write.signal));
|
|
116
|
+
}
|
|
117
|
+
catch (error) {
|
|
118
|
+
const code = error && typeof error === 'object' ? Reflect.get(error, 'code') : undefined;
|
|
119
|
+
if (code === 'ARTIFACT_NOT_CAPTURED')
|
|
120
|
+
return null;
|
|
121
|
+
if (code === 'AUTH_REQUIRED' || code === 'AUTH_FORBIDDEN')
|
|
122
|
+
refusal = error;
|
|
123
|
+
throw error;
|
|
124
|
+
}
|
|
125
|
+
}, async (params) => (await read(Methods.FS_READ, params)).content, async (params) => (await read(Methods.GIT_DIFF, params)).diff));
|
|
126
|
+
if (refusal)
|
|
127
|
+
throw refusal;
|
|
128
|
+
if (write.signal.aborted)
|
|
129
|
+
return;
|
|
130
|
+
const root = alias(run);
|
|
131
|
+
const store = (name, data, kind) => cache.storeContent({
|
|
132
|
+
key: { kind, id: kind === 'diff' ? reviewDiffHash(decoder.decode(data)) : digest(data) },
|
|
133
|
+
data,
|
|
134
|
+
alias: name,
|
|
135
|
+
origin: 'prefetch',
|
|
136
|
+
cohort: write.cohort,
|
|
137
|
+
token: write.token,
|
|
138
|
+
});
|
|
139
|
+
const diffPaths = new Set(reviewHistoryView(run, artifacts).checks.flatMap((check) => check.rounds.flatMap((round) => [round.diffPath, round.fixDiffPath])));
|
|
140
|
+
const entries = [];
|
|
141
|
+
const ordered = Object.entries(artifacts).sort(([a], [b]) => Number(diffPaths.has(b)) - Number(diffPaths.has(a)));
|
|
142
|
+
for (const [path, value] of ordered) {
|
|
143
|
+
if (write.signal.aborted)
|
|
144
|
+
return;
|
|
145
|
+
if (value.error)
|
|
146
|
+
continue;
|
|
147
|
+
if (value.content === undefined) {
|
|
148
|
+
entries.push({ path, kind: 'absent' });
|
|
149
|
+
continue;
|
|
150
|
+
}
|
|
151
|
+
const kind = diffPaths.has(path) ? 'diff' : 'artifact';
|
|
152
|
+
const stored = await store(entryAlias(root, path), encoder.encode(value.content), kind);
|
|
153
|
+
entries.push({ path, kind, ...(stored ? {} : { deferred: true }) });
|
|
154
|
+
}
|
|
155
|
+
const failed = Object.values(artifacts).find((value) => value.error);
|
|
156
|
+
if (failed)
|
|
157
|
+
throw new Error(failed.error);
|
|
158
|
+
await store(root, encoder.encode(JSON.stringify(entries)), 'artifact');
|
|
159
|
+
},
|
|
160
|
+
};
|
|
161
|
+
}
|
|
162
|
+
/** Resident metadata is a preview until the complete same-identity read has hydrated. */
|
|
163
|
+
export function reviewHistoryDisplayArtifacts(identity, loaded, preview) {
|
|
164
|
+
return loaded?.identity === identity
|
|
165
|
+
? mergeReviewHistoryArtifacts(preview ?? {}, loaded.artifacts)
|
|
166
|
+
: (preview ?? loaded?.artifacts ?? {});
|
|
167
|
+
}
|
|
168
|
+
//# sourceMappingURL=review-history-content.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"review-history-content.js","sourceRoot":"","sources":["../src/review-history-content.ts"],"names":[],"mappings":"AAAA,OAAO,EAGL,OAAO,EACP,cAAc,GAEf,MAAM,oBAAoB,CAAC;AAC5B,OAAO,EAIL,YAAY,EAEZ,aAAa,GAEd,MAAM,iCAAiC,CAAC;AAEzC,OAAO,EACL,0BAA0B,EAC1B,2BAA2B,EAE3B,0BAA0B,EAE1B,qBAAqB,EACrB,iBAAiB,GAClB,MAAM,qBAAqB,CAAC;AAE7B,MAAM,OAAO,GAAG,IAAI,WAAW,EAAE,CAAC;AAClC,MAAM,OAAO,GAAG,IAAI,WAAW,EAAE,CAAC;AAClC,SAAS,MAAM,CAAC,IAAgB;IAC9B,MAAM,IAAI,GAAG,YAAY,EAAE,CAAC;IAC5B,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,CAAC;IAClB,OAAO,IAAI,CAAC,GAAG,EAAE,CAAC;AACpB,CAAC;AACD,SAAS,KAAK,CAAC,GAAQ;IACrB,OAAO,kBAAkB,MAAM,CAAC,OAAO,CAAC,MAAM,CAAC,qBAAqB,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC;AAChF,CAAC;AAUD,SAAS,OAAO,CAAC,KAAc;IAC7B,OAAO,OAAO,CACZ,KAAK;QACL,OAAO,KAAK,KAAK,QAAQ;QACzB,MAAM,IAAI,KAAK;QACf,OAAO,KAAK,CAAC,IAAI,KAAK,QAAQ;QAC9B,MAAM,IAAI,KAAK;QACf,CAAC,UAAU,EAAE,MAAM,EAAE,QAAQ,CAAC,CAAC,QAAQ,CAAC,MAAM,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;QAC3D,CAAC,CAAC,CAAC,UAAU,IAAI,KAAK,CAAC,IAAI,KAAK,CAAC,QAAQ,KAAK,IAAI,CAAC,CACpD,CAAC;AACJ,CAAC;AACD,SAAS,QAAQ,CAAC,IAA4B;IAC5C,IAAI,CAAC,IAAI;QAAE,OAAO,SAAS,CAAC;IAC5B,MAAM,KAAK,GAAY,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,MAAM,CAAC,IAAI,CAAC,CAAC,CAAC;IACxD,OAAO,KAAK,CAAC,OAAO,CAAC,KAAK,CAAC,IAAI,KAAK,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,SAAS,CAAC;AAC1E,CAAC;AACD,SAAS,UAAU,CAAC,IAAY,EAAE,IAAY;IAC5C,OAAO,GAAG,IAAI,IAAI,MAAM,CAAC,OAAO,CAAC,MAAM,CAAC,IAAI,CAAC,CAAC,EAAE,CAAC;AACnD,CAAC;AAED,+FAA+F;AAC/F,MAAM,UAAU,wBAAwB,CACtC,KAAoB,EACpB,GAAQ;IAER,MAAM,IAAI,GAAG,KAAK,CAAC,GAAG,CAAC,CAAC;IACxB,MAAM,OAAO,GAAG,QAAQ,CAAC,KAAK,CAAC,kBAAkB,EAAE,CAAC,IAAI,CAAC,CAAC,CAAC;IAC3D,IAAI,CAAC,OAAO;QAAE,OAAO,SAAS,CAAC;IAC/B,MAAM,MAAM,GAA0C,EAAE,CAAC;IACzD,KAAK,MAAM,KAAK,IAAI,OAAO,EAAE,CAAC;QAC5B,IAAI,KAAK,CAAC,IAAI,KAAK,QAAQ,EAAE,CAAC;YAC5B,MAAM,CAAC,KAAK,CAAC,IAAI,CAAC,GAAG,EAAE,WAAW,EAAE,IAAI,EAAE,CAAC;YAC3C,SAAS;QACX,CAAC;QACD,MAAM,IAAI,GAAG,KAAK,CAAC,kBAAkB,EAAE,CAAC,UAAU,CAAC,IAAI,EAAE,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC;QACtE,IAAI,IAAI;YAAE,MAAM,CAAC,KAAK,CAAC,IAAI,CAAC,GAAG,EAAE,OAAO,EAAE,OAAO,CAAC,MAAM,CAAC,IAAI,CAAC,EAAE,CAAC;aAC5D,IAAI,KAAK,CAAC,IAAI,KAAK,MAAM;YAAE,OAAO,SAAS,CAAC;IACnD,CAAC;IACD,OAAO,MAAM,CAAC;AAChB,CAAC;AAED,gGAAgG;AAChG,MAAM,CAAC,KAAK,UAAU,wBAAwB,CAC5C,KAAoB,EACpB,GAAQ,EACR,MAAM,GAAG,KAAK;IAEd,MAAM,IAAI,GAAG,KAAK,CAAC,GAAG,CAAC,CAAC;IACxB,MAAM,IAAI,GAAG,CAAC,IAAY,EAAE,EAAE,CAC5B,MAAM,CAAC,CAAC,CAAC,KAAK,CAAC,kBAAkB,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,kBAAkB,CAAC,IAAI,CAAC,CAAC;IAC3E,MAAM,OAAO,GAAG,QAAQ,CAAC,MAAM,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC;IAC3C,IAAI,CAAC,OAAO;QAAE,OAAO,SAAS,CAAC;IAC/B,MAAM,MAAM,GAA0C,EAAE,CAAC;IACzD,6FAA6F;IAC7F,KAAK,MAAM,KAAK,IAAI,CAAC,GAAG,OAAO,CAAC,CAAC,IAAI,CACnC,CAAC,CAAC,EAAE,CAAC,EAAE,EAAE,CAAC,MAAM,CAAC,CAAC,CAAC,IAAI,KAAK,MAAM,CAAC,GAAG,MAAM,CAAC,CAAC,CAAC,IAAI,KAAK,MAAM,CAAC,CAChE,EAAE,CAAC;QACF,IAAI,KAAK,CAAC,IAAI,KAAK,QAAQ,EAAE,CAAC;YAC5B,MAAM,CAAC,KAAK,CAAC,IAAI,CAAC,GAAG,EAAE,WAAW,EAAE,IAAI,EAAE,CAAC;YAC3C,SAAS;QACX,CAAC;QACD,IAAI,KAAK,CAAC,QAAQ;YAAE,OAAO,SAAS,CAAC;QACrC,MAAM,IAAI,GAAG,MAAM,IAAI,CAAC,UAAU,CAAC,IAAI,EAAE,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC;QACtD,IAAI,CAAC,IAAI;YAAE,OAAO,SAAS,CAAC;QAC5B,MAAM,CAAC,KAAK,CAAC,IAAI,CAAC,GAAG,EAAE,OAAO,EAAE,OAAO,CAAC,MAAM,CAAC,IAAI,CAAC,EAAE,CAAC;IACzD,CAAC;IACD,MAAM,IAAI,CAAC,IAAI,CAAC,CAAC;IACjB,OAAO,MAAM,CAAC;AAChB,CAAC;AAED,SAAS,UAAU,CAAC,GAAQ;IAC1B,OAAO,OAAO,CACZ,0BAA0B,CAAC,GAAG,CAAC,CAAC,MAAM;QACtC,GAAG,CAAC,YAAY;QAChB,GAAG,CAAC,KAAK,EAAE,IAAI,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,IAAI,CAAC,QAAQ,CAAC,QAAQ,CAAC,CAAC;QACvD,GAAG,CAAC,WAAW,EAAE,WAAW,EAAE,OAAO,EAAE,MAAM;QAC7C,GAAG,CAAC,SAAS,CAAC,IAAI,CAChB,CAAC,QAAQ,EAAE,EAAE,CAAC,QAAQ,CAAC,OAAO,EAAE,IAAI,KAAK,OAAO,IAAI,QAAQ,CAAC,OAAO,CAAC,OAAO,EAAE,MAAM,CACrF,CACF,CAAC;AACJ,CAAC;AAQD,yFAAyF;AACzF,MAAM,UAAU,2BAA2B,CACzC,OAA8B;IAE9B,MAAM,EAAE,KAAK,EAAE,GAAG,OAAO,CAAC;IAC1B,OAAO;QACL,QAAQ,EAAE,CAAC,GAAG,EAAE,EAAE,CAAC,CAAC,UAAU,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,qBAAqB,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC;QACtE,KAAK,CAAC,QAAQ,CAAC,GAAQ,EAAE,KAA2B;YAClD,IAAI,CAAC,UAAU,CAAC,GAAG,CAAC;gBAAE,OAAO;YAC7B,MAAM,IAAI,GAAG,MAAM,wBAAwB,CAAC,KAAK,EAAE,GAAG,CAAC,CAAC;YACxD,IAAI,OAAgB,CAAC;YACrB,MAAM,IAAI,GAAG,KAAK,EAAK,MAA0B,EAAE,MAAe,EAAc,EAAE;gBAChF,IAAI,CAAC;oBACH,MAAM,KAAK,GAAG,IAAI,CAAC,GAAG,EAAE,CAAC;oBACzB,MAAM,MAAM,GAAG,MAAM,KAAK,CAAC,KAAK,CAC9B,aAAa,CAAI,MAAM,EAAE,MAAM,CAAC,EAChC,EAAE,MAAM,EAAE,UAAU,EAAE,MAAM,EAAE,KAAK,CAAC,MAAM,EAAE,EAC5C,KAAK,CAAC,MAAM,CACb,CAAC;oBACF,IACE,KAAK,CAAC,MAAM,CAAC,OAAO;wBACpB,MAAM,CAAC,IAAI,KAAK,SAAS;wBACzB,MAAM,CAAC,KAAK;wBACZ,CAAC,MAAM,CAAC,UAAU,IAAI,CAAC,QAAQ,CAAC,GAAG,KAAK;wBAExC,MAAM,MAAM,CAAC,MAAM,CACjB,IAAI,KAAK,CAAC,MAAM,CAAC,KAAK,EAAE,OAAO,IAAI,sCAAsC,CAAC,EAC1E,EAAE,IAAI,EAAE,MAAM,CAAC,KAAK,EAAE,IAAI,EAAE,CAC7B,CAAC;oBACJ,OAAO,MAAM,CAAC,IAAI,CAAC;gBACrB,CAAC;gBAAC,OAAO,KAAK,EAAE,CAAC;oBACf,IACE,KAAK;wBACL,OAAO,KAAK,KAAK,QAAQ;wBACzB,CAAC,eAAe,EAAE,gBAAgB,CAAC,CAAC,QAAQ,CAAC,MAAM,CAAC,OAAO,CAAC,GAAG,CAAC,KAAK,EAAE,MAAM,CAAC,CAAC,CAAC;wBAEhF,OAAO,GAAG,KAAK,CAAC;oBAClB,MAAM,KAAK,CAAC;gBACd,CAAC;YACH,CAAC,CAAC;YACF,MAAM,SAAS,GACb,IAAI;gBACJ,CAAC,MAAM,0BAA0B,CAC/B,GAAG,EACH,KAAK,EAAE,IAAI,EAAE,EAAE;oBACb,IAAI,CAAC;wBACH,OAAO,OAAO,CAAC,MAAM,CACnB,MAAM,OAAO,CAAC,YAAY,CACxB,EAAE,KAAK,EAAE,GAAG,CAAC,EAAE,EAAE,IAAI,EAAE,YAAY,EAAE,GAAG,CAAC,cAAc,EAAE,YAAY,EAAE,EACvE,KAAK,CAAC,MAAM,CACb,CACF,CAAC;oBACJ,CAAC;oBAAC,OAAO,KAAK,EAAE,CAAC;wBACf,MAAM,IAAI,GACR,KAAK,IAAI,OAAO,KAAK,KAAK,QAAQ,CAAC,CAAC,CAAC,OAAO,CAAC,GAAG,CAAC,KAAK,EAAE,MAAM,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC;wBAC9E,IAAI,IAAI,KAAK,uBAAuB;4BAAE,OAAO,IAAI,CAAC;wBAClD,IAAI,IAAI,KAAK,eAAe,IAAI,IAAI,KAAK,gBAAgB;4BAAE,OAAO,GAAG,KAAK,CAAC;wBAC3E,MAAM,KAAK,CAAC;oBACd,CAAC;gBACH,CAAC,EACD,KAAK,EAAE,MAAM,EAAE,EAAE,CAAC,CAAC,MAAM,IAAI,CAAe,OAAO,CAAC,OAAO,EAAE,MAAM,CAAC,CAAC,CAAC,OAAO,EAC7E,KAAK,EAAE,MAAM,EAAE,EAAE,CAAC,CAAC,MAAM,IAAI,CAAgB,OAAO,CAAC,QAAQ,EAAE,MAAM,CAAC,CAAC,CAAC,IAAI,CAC7E,CAAC,CAAC;YACL,IAAI,OAAO;gBAAE,MAAM,OAAO,CAAC;YAC3B,IAAI,KAAK,CAAC,MAAM,CAAC,OAAO;gBAAE,OAAO;YACjC,MAAM,IAAI,GAAG,KAAK,CAAC,GAAG,CAAC,CAAC;YACxB,MAAM,KAAK,GAAG,CAAC,IAAY,EAAE,IAAgB,EAAE,IAAwB,EAAE,EAAE,CACzE,KAAK,CAAC,YAAY,CAAC;gBACjB,GAAG,EAAE,EAAE,IAAI,EAAE,EAAE,EAAE,IAAI,KAAK,MAAM,CAAC,CAAC,CAAC,cAAc,CAAC,OAAO,CAAC,MAAM,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,IAAI,CAAC,EAAE;gBACxF,IAAI;gBACJ,KAAK,EAAE,IAAI;gBACX,MAAM,EAAE,UAAU;gBAClB,MAAM,EAAE,KAAK,CAAC,MAAM;gBACpB,KAAK,EAAE,KAAK,CAAC,KAAK;aACnB,CAAC,CAAC;YACL,MAAM,SAAS,GAAG,IAAI,GAAG,CACvB,iBAAiB,CAAC,GAAG,EAAE,SAAS,CAAC,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,KAAK,EAAE,EAAE,CACzD,KAAK,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,CAAC,KAAK,CAAC,QAAQ,EAAE,KAAK,CAAC,WAAW,CAAC,CAAC,CACrE,CACF,CAAC;YACF,MAAM,OAAO,GAA0B,EAAE,CAAC;YAC1C,MAAM,OAAO,GAAG,MAAM,CAAC,OAAO,CAAC,SAAS,CAAC,CAAC,IAAI,CAC5C,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,MAAM,CAAC,SAAS,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,GAAG,MAAM,CAAC,SAAS,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,CAClE,CAAC;YACF,KAAK,MAAM,CAAC,IAAI,EAAE,KAAK,CAAC,IAAI,OAAO,EAAE,CAAC;gBACpC,IAAI,KAAK,CAAC,MAAM,CAAC,OAAO;oBAAE,OAAO;gBACjC,IAAI,KAAK,CAAC,KAAK;oBAAE,SAAS;gBAC1B,IAAI,KAAK,CAAC,OAAO,KAAK,SAAS,EAAE,CAAC;oBAChC,OAAO,CAAC,IAAI,CAAC,EAAE,IAAI,EAAE,IAAI,EAAE,QAAQ,EAAE,CAAC,CAAC;oBACvC,SAAS;gBACX,CAAC;gBACD,MAAM,IAAI,GAAG,SAAS,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,UAAU,CAAC;gBACvD,MAAM,MAAM,GAAG,MAAM,KAAK,CAAC,UAAU,CAAC,IAAI,EAAE,IAAI,CAAC,EAAE,OAAO,CAAC,MAAM,CAAC,KAAK,CAAC,OAAO,CAAC,EAAE,IAAI,CAAC,CAAC;gBACxF,OAAO,CAAC,IAAI,CAAC,EAAE,IAAI,EAAE,IAAI,EAAE,GAAG,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,EAAE,QAAQ,EAAE,IAAI,EAAE,CAAC,EAAE,CAAC,CAAC;YACtE,CAAC;YACD,MAAM,MAAM,GAAG,MAAM,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC,IAAI,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC;YACrE,IAAI,MAAM;gBAAE,MAAM,IAAI,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC;YAC1C,MAAM,KAAK,CAAC,IAAI,EAAE,OAAO,CAAC,MAAM,CAAC,IAAI,CAAC,SAAS,CAAC,OAAO,CAAC,CAAC,EAAE,UAAU,CAAC,CAAC;QACzE,CAAC;KACF,CAAC;AACJ,CAAC;AAMD,yFAAyF;AACzF,MAAM,UAAU,6BAA6B,CAC3C,QAAgB,EAChB,MAA8C,EAC9C,OAA2C;IAE3C,OAAO,MAAM,EAAE,QAAQ,KAAK,QAAQ;QAClC,CAAC,CAAC,2BAA2B,CAAC,OAAO,IAAI,EAAE,EAAE,MAAM,CAAC,SAAS,CAAC;QAC9D,CAAC,CAAC,CAAC,OAAO,IAAI,MAAM,EAAE,SAAS,IAAI,EAAE,CAAC,CAAC;AAC3C,CAAC"}
|
|
@@ -40,4 +40,12 @@ export declare function compareReviewHistoryRounds(a: ReviewHistoryRound, b: Rev
|
|
|
40
40
|
export declare function reviewHistoryTimeline(run: Run, rounds: ReviewHistoryRound[]): ReviewHistoryEvent[];
|
|
41
41
|
/** Both clients open source at the head owned by this round, never the current checkout. */
|
|
42
42
|
export declare function reviewHistorySourceRequest(run: Run, round: ReviewHistoryRound, finding: ReviewHistoryFinding): GitShowParams | null;
|
|
43
|
+
export interface ReviewHistoryRoundCard {
|
|
44
|
+
round: ReviewHistoryRound;
|
|
45
|
+
fixes: ReviewHistoryFix[];
|
|
46
|
+
totalDurationMs: number | null;
|
|
47
|
+
openFindings: ReviewHistoryFinding[];
|
|
48
|
+
}
|
|
49
|
+
/** Both clients keep the review and the fixes it triggered inside one stable card. */
|
|
50
|
+
export declare function reviewHistoryRoundCards(events: ReviewHistoryEvent[]): ReviewHistoryRoundCard[];
|
|
43
51
|
//# sourceMappingURL=review-history-timeline.d.ts.map
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"review-history-timeline.d.ts","sourceRoot":"","sources":["../src/review-history-timeline.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,KAAK,aAAa,EAAE,KAAK,GAAG,EAAE,MAAM,oBAAoB,CAAC;AAElE,OAAO,KAAK,EAAE,oBAAoB,EAAE,kBAAkB,EAAE,MAAM,qBAAqB,CAAC;AAEpF,MAAM,WAAW,gBAAgB;IAC/B,GAAG,EAAE,MAAM,CAAC;IACZ,KAAK,EAAE,MAAM,CAAC;IACd,SAAS,EAAE,MAAM,GAAG,IAAI,CAAC;IACzB,WAAW,EAAE,MAAM,GAAG,IAAI,CAAC;IAC3B,UAAU,EAAE,MAAM,GAAG,IAAI,CAAC;IAC1B,OAAO,EAAE,OAAO,CAAC;IACjB,KAAK,EAAE,MAAM,GAAG,IAAI,CAAC;IACrB,IAAI,EAAE,MAAM,GAAG,IAAI,CAAC;IACpB,KAAK,EAAE,MAAM,EAAE,CAAC;IAChB,QAAQ,EAAE,MAAM,GAAG,IAAI,CAAC;IACxB,QAAQ,EAAE,MAAM,GAAG,IAAI,CAAC;IACxB,QAAQ,EAAE,oBAAoB,EAAE,CAAC;IACjC,aAAa,EAAE,OAAO,CAAC;IACvB,SAAS,EAAE,MAAM,GAAG,IAAI,CAAC;IACzB,UAAU,EAAE,MAAM,GAAG,IAAI,CAAC;CAC3B;AAED,MAAM,MAAM,kBAAkB,GAC1B;IAAE,IAAI,EAAE,QAAQ,CAAC;IAAC,GAAG,EAAE,MAAM,CAAC;IAAC,EAAE,EAAE,MAAM,GAAG,IAAI,CAAC;IAAC,KAAK,EAAE,kBAAkB,CAAA;CAAE,GAC7E;IAAE,IAAI,EAAE,KAAK,CAAC;IAAC,GAAG,EAAE,MAAM,CAAC;IAAC,QAAQ,EAAE,MAAM,CAAC;IAAC,EAAE,EAAE,MAAM,GAAG,IAAI,CAAC;IAAC,GAAG,EAAE,gBAAgB,CAAA;CAAE,GACxF;IAAE,IAAI,EAAE,MAAM,CAAC;IAAC,GAAG,EAAE,MAAM,CAAC;IAAC,EAAE,EAAE,MAAM,GAAG,IAAI,CAAC;IAAC,KAAK,EAAE,MAAM,CAAA;CAAE,CAAC;AAEpE,kGAAkG;AAClG,wBAAgB,0BAA0B,CAAC,CAAC,EAAE,kBAAkB,EAAE,CAAC,EAAE,kBAAkB,GAAG,MAAM,CAI/F;AAED,uFAAuF;AACvF,wBAAgB,qBAAqB,CACnC,GAAG,EAAE,GAAG,EACR,MAAM,EAAE,kBAAkB,EAAE,GAC3B,kBAAkB,EAAE,
|
|
1
|
+
{"version":3,"file":"review-history-timeline.d.ts","sourceRoot":"","sources":["../src/review-history-timeline.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,KAAK,aAAa,EAAE,KAAK,GAAG,EAAE,MAAM,oBAAoB,CAAC;AAElE,OAAO,KAAK,EAAE,oBAAoB,EAAE,kBAAkB,EAAE,MAAM,qBAAqB,CAAC;AAEpF,MAAM,WAAW,gBAAgB;IAC/B,GAAG,EAAE,MAAM,CAAC;IACZ,KAAK,EAAE,MAAM,CAAC;IACd,SAAS,EAAE,MAAM,GAAG,IAAI,CAAC;IACzB,WAAW,EAAE,MAAM,GAAG,IAAI,CAAC;IAC3B,UAAU,EAAE,MAAM,GAAG,IAAI,CAAC;IAC1B,OAAO,EAAE,OAAO,CAAC;IACjB,KAAK,EAAE,MAAM,GAAG,IAAI,CAAC;IACrB,IAAI,EAAE,MAAM,GAAG,IAAI,CAAC;IACpB,KAAK,EAAE,MAAM,EAAE,CAAC;IAChB,QAAQ,EAAE,MAAM,GAAG,IAAI,CAAC;IACxB,QAAQ,EAAE,MAAM,GAAG,IAAI,CAAC;IACxB,QAAQ,EAAE,oBAAoB,EAAE,CAAC;IACjC,aAAa,EAAE,OAAO,CAAC;IACvB,SAAS,EAAE,MAAM,GAAG,IAAI,CAAC;IACzB,UAAU,EAAE,MAAM,GAAG,IAAI,CAAC;CAC3B;AAED,MAAM,MAAM,kBAAkB,GAC1B;IAAE,IAAI,EAAE,QAAQ,CAAC;IAAC,GAAG,EAAE,MAAM,CAAC;IAAC,EAAE,EAAE,MAAM,GAAG,IAAI,CAAC;IAAC,KAAK,EAAE,kBAAkB,CAAA;CAAE,GAC7E;IAAE,IAAI,EAAE,KAAK,CAAC;IAAC,GAAG,EAAE,MAAM,CAAC;IAAC,QAAQ,EAAE,MAAM,CAAC;IAAC,EAAE,EAAE,MAAM,GAAG,IAAI,CAAC;IAAC,GAAG,EAAE,gBAAgB,CAAA;CAAE,GACxF;IAAE,IAAI,EAAE,MAAM,CAAC;IAAC,GAAG,EAAE,MAAM,CAAC;IAAC,EAAE,EAAE,MAAM,GAAG,IAAI,CAAC;IAAC,KAAK,EAAE,MAAM,CAAA;CAAE,CAAC;AAEpE,kGAAkG;AAClG,wBAAgB,0BAA0B,CAAC,CAAC,EAAE,kBAAkB,EAAE,CAAC,EAAE,kBAAkB,GAAG,MAAM,CAI/F;AAED,uFAAuF;AACvF,wBAAgB,qBAAqB,CACnC,GAAG,EAAE,GAAG,EACR,MAAM,EAAE,kBAAkB,EAAE,GAC3B,kBAAkB,EAAE,CA2ItB;AAED,4FAA4F;AAC5F,wBAAgB,0BAA0B,CACxC,GAAG,EAAE,GAAG,EACR,KAAK,EAAE,kBAAkB,EACzB,OAAO,EAAE,oBAAoB,GAC5B,aAAa,GAAG,IAAI,CAStB;AAED,MAAM,WAAW,sBAAsB;IACrC,KAAK,EAAE,kBAAkB,CAAC;IAC1B,KAAK,EAAE,gBAAgB,EAAE,CAAC;IAC1B,eAAe,EAAE,MAAM,GAAG,IAAI,CAAC;IAC/B,YAAY,EAAE,oBAAoB,EAAE,CAAC;CACtC;AAED,sFAAsF;AACtF,wBAAgB,uBAAuB,CAAC,MAAM,EAAE,kBAAkB,EAAE,GAAG,sBAAsB,EAAE,CAuB9F"}
|
|
@@ -9,17 +9,27 @@ export function reviewHistoryTimeline(run, rounds) {
|
|
|
9
9
|
const ordered = [...rounds].sort(compareReviewHistoryRounds);
|
|
10
10
|
const events = [];
|
|
11
11
|
const fixes = [];
|
|
12
|
-
for (const round of ordered) {
|
|
12
|
+
for (const [roundIndex, round] of ordered.entries()) {
|
|
13
13
|
if (round.hasFix) {
|
|
14
14
|
// Artifact hydration may replace a pathname with a Git alias for the same code fix.
|
|
15
15
|
const key = round.fixBaseSha && round.fixHeadSha
|
|
16
16
|
? `${round.reviewId}:fix:${round.fixBaseSha}:${round.fixHeadSha}`
|
|
17
17
|
: (round.fixDiffPath ?? `${round.reviewId}:fix:${round.key}`);
|
|
18
|
+
const previous = ordered.slice(0, roundIndex);
|
|
19
|
+
const prior = previous.filter((entry) => entry.reviewId === round.reviewId);
|
|
20
|
+
const trigger = [...previous]
|
|
21
|
+
.reverse()
|
|
22
|
+
.find((entry) => entry.verdict === 'issues' && entry.headSha && entry.headSha === round.fixBaseSha) ??
|
|
23
|
+
[...prior].reverse().find((entry) => entry.verdict === 'issues') ??
|
|
24
|
+
prior.at(-1) ??
|
|
25
|
+
previous.at(-1);
|
|
18
26
|
let fix = fixes.find((entry) => entry.key === key);
|
|
19
27
|
if (!fix) {
|
|
20
28
|
fix = {
|
|
21
29
|
key,
|
|
22
|
-
label:
|
|
30
|
+
label: trigger
|
|
31
|
+
? `Fix after round ${trigger.roundNumber}`
|
|
32
|
+
: 'Fix before first recorded review',
|
|
23
33
|
startedAt: round.fixStartedAt,
|
|
24
34
|
completedAt: round.fixCompletedAt,
|
|
25
35
|
durationMs: round.fixDurationMs,
|
|
@@ -38,7 +48,7 @@ export function reviewHistoryTimeline(run, rounds) {
|
|
|
38
48
|
events.push({
|
|
39
49
|
kind: 'fix',
|
|
40
50
|
key,
|
|
41
|
-
roundKey: round.key,
|
|
51
|
+
roundKey: trigger?.key ?? round.key,
|
|
42
52
|
at: fix.startedAt ?? fix.completedAt ?? round.startedAt,
|
|
43
53
|
fix,
|
|
44
54
|
});
|
|
@@ -59,7 +69,7 @@ export function reviewHistoryTimeline(run, rounds) {
|
|
|
59
69
|
for (const finding of round.findings) {
|
|
60
70
|
if (prior.some((entry) => entry.findings.some((other) => other.id === finding.id))) {
|
|
61
71
|
finding.status = 'still-open';
|
|
62
|
-
finding.statusLabel = '
|
|
72
|
+
finding.statusLabel = 'Carried forward';
|
|
63
73
|
}
|
|
64
74
|
const later = ordered
|
|
65
75
|
.slice(index + 1)
|
|
@@ -79,9 +89,8 @@ export function reviewHistoryTimeline(run, rounds) {
|
|
|
79
89
|
.at(-1);
|
|
80
90
|
if (!fix)
|
|
81
91
|
continue;
|
|
82
|
-
finding.status = '
|
|
83
|
-
finding.
|
|
84
|
-
finding.statusLabel = `Resolved after ${fix.label.toLowerCase()} · not raised in round ${later.roundNumber}`;
|
|
92
|
+
finding.status = 'unconfirmed';
|
|
93
|
+
finding.statusLabel = `No explicit resolution recorded · round ${later.roundNumber}`;
|
|
85
94
|
if (!fix.resolved.some((entry) => entry.id === finding.id))
|
|
86
95
|
fix.resolved.push(finding);
|
|
87
96
|
}
|
|
@@ -136,4 +145,24 @@ export function reviewHistorySourceRequest(run, round, finding) {
|
|
|
136
145
|
path: finding.file,
|
|
137
146
|
};
|
|
138
147
|
}
|
|
148
|
+
/** Both clients keep the review and the fixes it triggered inside one stable card. */
|
|
149
|
+
export function reviewHistoryRoundCards(events) {
|
|
150
|
+
return events.flatMap((event) => {
|
|
151
|
+
if (event.kind !== 'review')
|
|
152
|
+
return [];
|
|
153
|
+
const fixes = events.flatMap((candidate) => candidate.kind === 'fix' && candidate.roundKey === event.key ? [candidate.fix] : []);
|
|
154
|
+
return [
|
|
155
|
+
{
|
|
156
|
+
round: event.round,
|
|
157
|
+
fixes,
|
|
158
|
+
totalDurationMs: event.round.durationMs === null || fixes.some((fix) => fix.durationMs === null)
|
|
159
|
+
? null
|
|
160
|
+
: event.round.durationMs + fixes.reduce((sum, fix) => sum + (fix.durationMs ?? 0), 0),
|
|
161
|
+
openFindings: event.round.unresolvedCount === 0
|
|
162
|
+
? []
|
|
163
|
+
: event.round.findings.filter((finding) => finding.status !== 'resolved' && finding.status !== 'accepted'),
|
|
164
|
+
},
|
|
165
|
+
];
|
|
166
|
+
});
|
|
167
|
+
}
|
|
139
168
|
//# sourceMappingURL=review-history-timeline.js.map
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"review-history-timeline.js","sourceRoot":"","sources":["../src/review-history-timeline.ts"],"names":[],"mappings":"AA2BA,kGAAkG;AAClG,MAAM,UAAU,0BAA0B,CAAC,CAAqB,EAAE,CAAqB;IACrF,MAAM,IAAI,GAAG,CAAC,KAAyB,EAAE,EAAE,CAAC,KAAK,CAAC,SAAS,IAAI,KAAK,CAAC,WAAW,IAAI,QAAQ,CAAC;IAC7F,sFAAsF;IACtF,OAAO,IAAI,CAAC,CAAC,CAAC,CAAC,aAAa,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,UAAU,GAAG,CAAC,CAAC,UAAU,CAAC;AACvE,CAAC;AAED,uFAAuF;AACvF,MAAM,UAAU,qBAAqB,CACnC,GAAQ,EACR,MAA4B;IAE5B,MAAM,OAAO,GAAG,CAAC,GAAG,MAAM,CAAC,CAAC,IAAI,CAAC,0BAA0B,CAAC,CAAC;IAC7D,MAAM,MAAM,GAAyB,EAAE,CAAC;IACxC,MAAM,KAAK,GAAuB,EAAE,CAAC;IACrC,KAAK,MAAM,KAAK,IAAI,OAAO,EAAE,CAAC;
|
|
1
|
+
{"version":3,"file":"review-history-timeline.js","sourceRoot":"","sources":["../src/review-history-timeline.ts"],"names":[],"mappings":"AA2BA,kGAAkG;AAClG,MAAM,UAAU,0BAA0B,CAAC,CAAqB,EAAE,CAAqB;IACrF,MAAM,IAAI,GAAG,CAAC,KAAyB,EAAE,EAAE,CAAC,KAAK,CAAC,SAAS,IAAI,KAAK,CAAC,WAAW,IAAI,QAAQ,CAAC;IAC7F,sFAAsF;IACtF,OAAO,IAAI,CAAC,CAAC,CAAC,CAAC,aAAa,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,UAAU,GAAG,CAAC,CAAC,UAAU,CAAC;AACvE,CAAC;AAED,uFAAuF;AACvF,MAAM,UAAU,qBAAqB,CACnC,GAAQ,EACR,MAA4B;IAE5B,MAAM,OAAO,GAAG,CAAC,GAAG,MAAM,CAAC,CAAC,IAAI,CAAC,0BAA0B,CAAC,CAAC;IAC7D,MAAM,MAAM,GAAyB,EAAE,CAAC;IACxC,MAAM,KAAK,GAAuB,EAAE,CAAC;IACrC,KAAK,MAAM,CAAC,UAAU,EAAE,KAAK,CAAC,IAAI,OAAO,CAAC,OAAO,EAAE,EAAE,CAAC;QACpD,IAAI,KAAK,CAAC,MAAM,EAAE,CAAC;YACjB,oFAAoF;YACpF,MAAM,GAAG,GACP,KAAK,CAAC,UAAU,IAAI,KAAK,CAAC,UAAU;gBAClC,CAAC,CAAC,GAAG,KAAK,CAAC,QAAQ,QAAQ,KAAK,CAAC,UAAU,IAAI,KAAK,CAAC,UAAU,EAAE;gBACjE,CAAC,CAAC,CAAC,KAAK,CAAC,WAAW,IAAI,GAAG,KAAK,CAAC,QAAQ,QAAQ,KAAK,CAAC,GAAG,EAAE,CAAC,CAAC;YAClE,MAAM,QAAQ,GAAG,OAAO,CAAC,KAAK,CAAC,CAAC,EAAE,UAAU,CAAC,CAAC;YAC9C,MAAM,KAAK,GAAG,QAAQ,CAAC,MAAM,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,QAAQ,KAAK,KAAK,CAAC,QAAQ,CAAC,CAAC;YAC5E,MAAM,OAAO,GACX,CAAC,GAAG,QAAQ,CAAC;iBACV,OAAO,EAAE;iBACT,IAAI,CACH,CAAC,KAAK,EAAE,EAAE,CACR,KAAK,CAAC,OAAO,KAAK,QAAQ,IAAI,KAAK,CAAC,OAAO,IAAI,KAAK,CAAC,OAAO,KAAK,KAAK,CAAC,UAAU,CACpF;gBACH,CAAC,GAAG,KAAK,CAAC,CAAC,OAAO,EAAE,CAAC,IAAI,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,OAAO,KAAK,QAAQ,CAAC;gBAChE,KAAK,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC;gBACZ,QAAQ,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,CAAC;YAClB,IAAI,GAAG,GAAG,KAAK,CAAC,IAAI,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,GAAG,KAAK,GAAG,CAAC,CAAC;YACnD,IAAI,CAAC,GAAG,EAAE,CAAC;gBACT,GAAG,GAAG;oBACJ,GAAG;oBACH,KAAK,EAAE,OAAO;wBACZ,CAAC,CAAC,mBAAmB,OAAO,CAAC,WAAW,EAAE;wBAC1C,CAAC,CAAC,kCAAkC;oBACtC,SAAS,EAAE,KAAK,CAAC,YAAY;oBAC7B,WAAW,EAAE,KAAK,CAAC,cAAc;oBACjC,UAAU,EAAE,KAAK,CAAC,aAAa;oBAC/B,OAAO,EAAE,KAAK;oBACd,KAAK,EAAE,KAAK,CAAC,QAAQ;oBACrB,IAAI,EAAE,KAAK,CAAC,OAAO;oBACnB,KAAK,EAAE,KAAK,CAAC,QAAQ;oBACrB,QAAQ,EAAE,KAAK,CAAC,WAAW;oBAC3B,QAAQ,EAAE,KAAK,CAAC,WAAW;oBAC3B,QAAQ,EAAE,EAAE;oBACZ,aAAa,EAAE,KAAK,CAAC,gBAAgB;oBACrC,SAAS,EAAE,KAAK,CAAC,YAAY;oBAC7B,UAAU,EAAE,KAAK,CAAC,gBAAgB,CAAC,CAAC,CAAC,KAAK,CAAC,SAAS,CAAC,CAAC,CAAC,IAAI;iBAC5D,CAAC;gBACF,KAAK,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;gBAChB,MAAM,CAAC,IAAI,CAAC;oBACV,IAAI,EAAE,KAAK;oBACX,GAAG;oBACH,QAAQ,EAAE,OAAO,EAAE,GAAG,IAAI,KAAK,CAAC,GAAG;oBACnC,EAAE,EAAE,GAAG,CAAC,SAAS,IAAI,GAAG,CAAC,WAAW,IAAI,KAAK,CAAC,SAAS;oBACvD,GAAG;iBACJ,CAAC,CAAC;YACL,CAAC;QACH,CAAC;QACD,MAAM,CAAC,IAAI,CAAC;YACV,IAAI,EAAE,QAAQ;YACd,GAAG,EAAE,KAAK,CAAC,GAAG;YACd,EAAE,EAAE,KAAK,CAAC,SAAS,IAAI,KAAK,CAAC,WAAW;YACxC,KAAK;SACN,CAAC,CAAC;IACL,CAAC;IACD,0FAA0F;IAC1F,yFAAyF;IACzF,KAAK,IAAI,KAAK,GAAG,CAAC,EAAE,KAAK,GAAG,OAAO,CAAC,MAAM,EAAE,KAAK,EAAE,EAAE,CAAC;QACpD,MAAM,KAAK,GAAG,OAAO,CAAC,KAAK,CAAC,CAAC;QAC7B,MAAM,KAAK,GAAG,OAAO,CAAC,KAAK,CAAC,CAAC,EAAE,KAAK,CAAC,CAAC;QACtC,KAAK,MAAM,OAAO,IAAI,KAAK,CAAC,QAAQ,EAAE,CAAC;YACrC,IAAI,KAAK,CAAC,IAAI,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,EAAE,KAAK,OAAO,CAAC,EAAE,CAAC,CAAC,EAAE,CAAC;gBACnF,OAAO,CAAC,MAAM,GAAG,YAAY,CAAC;gBAC9B,OAAO,CAAC,WAAW,GAAG,iBAAiB,CAAC;YAC1C,CAAC;YACD,MAAM,KAAK,GAAG,OAAO;iBAClB,KAAK,CAAC,KAAK,GAAG,CAAC,CAAC;iBAChB,IAAI,CACH,CAAC,KAAK,EAAE,EAAE,CACR,KAAK,CAAC,QAAQ,KAAK,KAAK,CAAC,QAAQ;gBACjC,KAAK,CAAC,MAAM,KAAK,KAAK,CAAC,MAAM;gBAC7B,KAAK,CAAC,KAAK,KAAK,KAAK,CAAC,KAAK;gBAC3B,KAAK,CAAC,cAAc;gBACpB,CAAC,MAAM,EAAE,QAAQ,CAAC,CAAC,QAAQ,CAAC,KAAK,CAAC,OAAO,CAAC,CAC7C,CAAC;YACJ,IAAI,CAAC,KAAK,IAAI,KAAK,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,EAAE,KAAK,OAAO,CAAC,EAAE,CAAC;gBAAE,SAAS;YAChF,MAAM,GAAG,GAAG,KAAK;iBACd,MAAM,CACL,CAAC,KAAK,EAAE,EAAE,CACR,CAAC,KAAK,CAAC,WAAW,IAAI,KAAK,CAAC,UAAU,CAAC;gBACvC,KAAK,CAAC,WAAW;gBACjB,KAAK,CAAC,SAAS;gBACf,CAAC,KAAK,CAAC,WAAW,IAAI,KAAK,CAAC,UAAU,IAAI,EAAE,CAAC,GAAG,KAAK,CAAC,WAAW;gBACjE,CAAC,KAAK,CAAC,WAAW,IAAI,KAAK,CAAC,UAAU,IAAI,EAAE,CAAC,IAAI,KAAK,CAAC,SAAS,CACnE;iBACA,EAAE,CAAC,CAAC,CAAC,CAAC,CAAC;YACV,IAAI,CAAC,GAAG;gBAAE,SAAS;YACnB,OAAO,CAAC,MAAM,GAAG,aAAa,CAAC;YAC/B,OAAO,CAAC,WAAW,GAAG,2CAA2C,KAAK,CAAC,WAAW,EAAE,CAAC;YACrF,IAAI,CAAC,GAAG,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,EAAE,KAAK,OAAO,CAAC,EAAE,CAAC;gBAAE,GAAG,CAAC,QAAQ,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;QACzF,CAAC;IACH,CAAC;IACD,KAAK,MAAM,KAAK,IAAI,OAAO,CAAC,MAAM,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,UAAU,CAAC,EAAE,CAAC;QAChE,MAAM,GAAG,GAAqB;YAC5B,GAAG,EAAE,GAAG,KAAK,CAAC,GAAG,aAAa;YAC9B,KAAK,EAAE,mBAAmB,KAAK,CAAC,WAAW,EAAE;YAC7C,SAAS,EAAE,KAAK,CAAC,kBAAkB;YACnC,WAAW,EAAE,IAAI;YACjB,UAAU,EAAE,IAAI;YAChB,OAAO,EAAE,IAAI;YACb,KAAK,EAAE,IAAI;YACX,IAAI,EAAE,IAAI;YACV,KAAK,EAAE,EAAE;YACT,QAAQ,EAAE,IAAI;YACd,QAAQ,EAAE,IAAI;YACd,QAAQ,EAAE,EAAE;YACZ,aAAa,EAAE,KAAK;YACpB,SAAS,EAAE,IAAI;YACf,UAAU,EAAE,IAAI;SACjB,CAAC;QACF,MAAM,KAAK,GAAG,MAAM,CAAC,SAAS,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,IAAI,KAAK,QAAQ,IAAI,KAAK,CAAC,GAAG,KAAK,KAAK,CAAC,GAAG,CAAC,CAAC;QAC9F,MAAM,CAAC,MAAM,CAAC,KAAK,GAAG,CAAC,EAAE,CAAC,EAAE;YAC1B,IAAI,EAAE,KAAK;YACX,GAAG,EAAE,GAAG,CAAC,GAAG;YACZ,QAAQ,EAAE,KAAK,CAAC,GAAG;YACnB,EAAE,EAAE,GAAG,CAAC,SAAS;YACjB,GAAG;SACJ,CAAC,CAAC;IACL,CAAC;IACD,MAAM,IAAI,GAAG,CAAC,GAAG,GAAG,CAAC,SAAS,CAAC;SAC5B,OAAO,EAAE;SACT,IAAI,CACH,CAAC,QAAQ,EAAE,EAAE,CACX,CAAC,QAAQ,CAAC,UAAU,IAAI,CAAC,OAAO,EAAE,QAAQ,CAAC,CAAC,QAAQ,CAAC,QAAQ,CAAC,OAAO,EAAE,IAAI,IAAI,EAAE,CAAC,CACrF,CAAC;IACJ,IAAI,IAAI;QACN,MAAM,CAAC,IAAI,CAAC;YACV,IAAI,EAAE,MAAM;YACZ,GAAG,EAAE,IAAI,CAAC,EAAE;YACZ,EAAE,EAAE,IAAI,CAAC,SAAS;YAClB,KAAK,EAAE,2BAA2B;SACnC,CAAC,CAAC;IACL,OAAO,MAAM,CAAC;AAChB,CAAC;AAED,4FAA4F;AAC5F,MAAM,UAAU,0BAA0B,CACxC,GAAQ,EACR,KAAyB,EACzB,OAA6B;IAE7B,IAAI,CAAC,KAAK,CAAC,OAAO,IAAI,CAAC,OAAO,CAAC,IAAI,IAAI,CAAC,OAAO,CAAC,IAAI,IAAI,CAAC,MAAM,CAAC,aAAa,CAAC,OAAO,CAAC,IAAI,CAAC;QACzF,OAAO,IAAI,CAAC;IACd,OAAO;QACL,MAAM,EAAE,GAAG,CAAC,MAAM,IAAI,EAAE;QACxB,GAAG,CAAC,GAAG,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,EAAE,KAAK,EAAE,GAAG,CAAC,EAAE,EAAE,CAAC;QACxC,GAAG,EAAE,KAAK,CAAC,OAAO;QAClB,IAAI,EAAE,OAAO,CAAC,IAAI;KACnB,CAAC;AACJ,CAAC;AASD,sFAAsF;AACtF,MAAM,UAAU,uBAAuB,CAAC,MAA4B;IAClE,OAAO,MAAM,CAAC,OAAO,CAAC,CAAC,KAAK,EAAE,EAAE;QAC9B,IAAI,KAAK,CAAC,IAAI,KAAK,QAAQ;YAAE,OAAO,EAAE,CAAC;QACvC,MAAM,KAAK,GAAG,MAAM,CAAC,OAAO,CAAC,CAAC,SAAS,EAAE,EAAE,CACzC,SAAS,CAAC,IAAI,KAAK,KAAK,IAAI,SAAS,CAAC,QAAQ,KAAK,KAAK,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,EAAE,CACpF,CAAC;QACF,OAAO;YACL;gBACE,KAAK,EAAE,KAAK,CAAC,KAAK;gBAClB,KAAK;gBACL,eAAe,EACb,KAAK,CAAC,KAAK,CAAC,UAAU,KAAK,IAAI,IAAI,KAAK,CAAC,IAAI,CAAC,CAAC,GAAG,EAAE,EAAE,CAAC,GAAG,CAAC,UAAU,KAAK,IAAI,CAAC;oBAC7E,CAAC,CAAC,IAAI;oBACN,CAAC,CAAC,KAAK,CAAC,KAAK,CAAC,UAAU,GAAG,KAAK,CAAC,MAAM,CAAC,CAAC,GAAG,EAAE,GAAG,EAAE,EAAE,CAAC,GAAG,GAAG,CAAC,GAAG,CAAC,UAAU,IAAI,CAAC,CAAC,EAAE,CAAC,CAAC;gBACzF,YAAY,EACV,KAAK,CAAC,KAAK,CAAC,eAAe,KAAK,CAAC;oBAC/B,CAAC,CAAC,EAAE;oBACJ,CAAC,CAAC,KAAK,CAAC,KAAK,CAAC,QAAQ,CAAC,MAAM,CACzB,CAAC,OAAO,EAAE,EAAE,CAAC,OAAO,CAAC,MAAM,KAAK,UAAU,IAAI,OAAO,CAAC,MAAM,KAAK,UAAU,CAC5E;aACR;SACF,CAAC;IACJ,CAAC,CAAC,CAAC;AACL,CAAC"}
|
package/dist/review-history.d.ts
CHANGED
|
@@ -1,16 +1,20 @@
|
|
|
1
|
-
import { deriveChecklistStepDurations, type FsReadParams, type GitDiffParams, type ReviewChainEntry, type ReviewMode, type Run } from '@farmslot/protocol';
|
|
1
|
+
import { deriveChecklistStepDurations, type FsReadParams, type GitDiffParams, type ReviewChainEntry, type ReviewMode, type Run, type RunnerSessionUsage } from '@farmslot/protocol';
|
|
2
2
|
export interface ReviewHistoryFinding {
|
|
3
3
|
id: string;
|
|
4
|
+
/** Keep the structured approval identity independent from its display formatting. */
|
|
5
|
+
recordedDescription?: string;
|
|
4
6
|
title: string;
|
|
5
7
|
details: string;
|
|
6
8
|
severity: string;
|
|
7
9
|
file: string;
|
|
8
10
|
line: number | null;
|
|
9
|
-
status: 'new' | 'still-open' | 'resolved';
|
|
11
|
+
status: 'new' | 'still-open' | 'resolved' | 'accepted' | 'unconfirmed';
|
|
10
12
|
statusLabel: string;
|
|
11
13
|
resolvedBy: string | null;
|
|
12
14
|
}
|
|
13
15
|
export interface ReviewHistoryArtifact {
|
|
16
|
+
/** The round is known, but this retained artifact has not been captured yet. */
|
|
17
|
+
notCaptured?: true;
|
|
14
18
|
content?: string;
|
|
15
19
|
error?: string;
|
|
16
20
|
}
|
|
@@ -40,6 +44,8 @@ export interface ReviewHistoryRound {
|
|
|
40
44
|
completedAt: string | null;
|
|
41
45
|
durationMs: number | null;
|
|
42
46
|
usageLabel: string | null;
|
|
47
|
+
/** The exact attempt receipt, retained for numeric accounting consumers. */
|
|
48
|
+
usage?: RunnerSessionUsage;
|
|
43
49
|
headSha: string | null;
|
|
44
50
|
reviewBaseSha: string | null;
|
|
45
51
|
resultRecorded: boolean;
|
|
@@ -93,6 +99,7 @@ export interface ReviewHistoryCheck {
|
|
|
93
99
|
export declare function reviewArtifactDir(loopNumber: number, artifactScope?: string | null): string;
|
|
94
100
|
export declare function reviewHistoryArtifactPaths(run: Run): string[];
|
|
95
101
|
export declare function reviewHistoryView(run: Run, artifacts?: ReviewHistoryArtifacts, chain?: ReviewChainEntry[]): {
|
|
102
|
+
cards: import("./review-history-timeline.js").ReviewHistoryRoundCard[];
|
|
96
103
|
checks: ReviewHistoryCheck[];
|
|
97
104
|
segments: Record<string, unknown>[];
|
|
98
105
|
roundCount: number;
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"review-history.d.ts","sourceRoot":"","sources":["../src/review-history.ts"],"names":[],"mappings":"AAAA,OAAO,EAEL,4BAA4B,
|
|
1
|
+
{"version":3,"file":"review-history.d.ts","sourceRoot":"","sources":["../src/review-history.ts"],"names":[],"mappings":"AAAA,OAAO,EAEL,4BAA4B,EAI5B,KAAK,YAAY,EACjB,KAAK,aAAa,EAKlB,KAAK,gBAAgB,EAGrB,KAAK,UAAU,EAGf,KAAK,GAAG,EACR,KAAK,kBAAkB,EACxB,MAAM,oBAAoB,CAAC;AAW5B,MAAM,WAAW,oBAAoB;IACnC,EAAE,EAAE,MAAM,CAAC;IACX,qFAAqF;IACrF,mBAAmB,CAAC,EAAE,MAAM,CAAC;IAC7B,KAAK,EAAE,MAAM,CAAC;IACd,OAAO,EAAE,MAAM,CAAC;IAChB,QAAQ,EAAE,MAAM,CAAC;IACjB,IAAI,EAAE,MAAM,CAAC;IACb,IAAI,EAAE,MAAM,GAAG,IAAI,CAAC;IACpB,MAAM,EAAE,KAAK,GAAG,YAAY,GAAG,UAAU,GAAG,UAAU,GAAG,aAAa,CAAC;IACvE,WAAW,EAAE,MAAM,CAAC;IACpB,UAAU,EAAE,MAAM,GAAG,IAAI,CAAC;CAC3B;AACD,MAAM,WAAW,qBAAqB;IACpC,gFAAgF;IAChF,WAAW,CAAC,EAAE,IAAI,CAAC;IACnB,OAAO,CAAC,EAAE,MAAM,CAAC;IACjB,KAAK,CAAC,EAAE,MAAM,CAAC;CAChB;AACD,MAAM,MAAM,sBAAsB,GAAG,QAAQ,CAAC,MAAM,CAAC,MAAM,EAAE,qBAAqB,CAAC,CAAC,CAAC;AAErF,MAAM,WAAW,2BAA2B;IAC1C,UAAU,EAAE,MAAM,CAAC;IACnB,SAAS,CAAC,EAAE,MAAM,GAAG,IAAI,CAAC;IAC1B,WAAW,EAAE,MAAM,GAAG,IAAI,CAAC;CAC5B;AAED,6FAA6F;AAC7F,wBAAgB,uBAAuB,CAAC,KAAK,EAAE,MAAM,EAAE,SAAS,EAAE,2BAA2B,UAO5F;AAaD,8FAA8F;AAC9F,wBAAgB,2BAA2B,CACzC,QAAQ,EAAE,sBAAsB,EAChC,IAAI,EAAE,sBAAsB,GAC3B,sBAAsB,CAYxB;AAED,MAAM,WAAW,kBAAkB;IACjC,GAAG,EAAE,MAAM,CAAC;IACZ,QAAQ,EAAE,MAAM,CAAC;IACjB,UAAU,EAAE,MAAM,CAAC;IACnB,WAAW,EAAE,MAAM,CAAC;IACpB,MAAM,EAAE,MAAM,CAAC;IACf,KAAK,EAAE,MAAM,CAAC;IACd,IAAI,EAAE,UAAU,GAAG,IAAI,CAAC;IACxB,SAAS,EAAE,MAAM,CAAC;IAClB,OAAO,EAAE,MAAM,CAAC;IAChB,WAAW,EAAE,IAAI,GAAG,MAAM,GAAG,MAAM,GAAG,SAAS,CAAC;IAChD,aAAa,CAAC,EAAE,MAAM,GAAG,IAAI,CAAC;IAC9B,SAAS,EAAE,MAAM,GAAG,IAAI,CAAC;IACzB,WAAW,EAAE,MAAM,GAAG,IAAI,CAAC;IAC3B,UAAU,EAAE,MAAM,GAAG,IAAI,CAAC;IAC1B,UAAU,EAAE,MAAM,GAAG,IAAI,CAAC;IAC1B,4EAA4E;IAC5E,KAAK,CAAC,EAAE,kBAAkB,CAAC;IAC3B,OAAO,EAAE,MAAM,GAAG,IAAI,CAAC;IACvB,aAAa,EAAE,MAAM,GAAG,IAAI,CAAC;IAC7B,cAAc,EAAE,OAAO,CAAC;IACxB,eAAe,EAAE,MAAM,GAAG,IAAI,CAAC;IAC/B,eAAe,EAAE,MAAM,CAAC;IACxB,aAAa,EAAE,MAAM,CAAC;IACtB,QAAQ,EAAE,oBAAoB,EAAE,CAAC;IACjC,eAAe,EAAE,KAAK,CAAC;QAAE,MAAM,EAAE,MAAM,CAAC;QAAC,SAAS,EAAE,MAAM,GAAG,IAAI,CAAC;QAAC,UAAU,EAAE,MAAM,GAAG,IAAI,CAAA;KAAE,CAAC,CAAC;IAChG,WAAW,EAAE,MAAM,CAAC;IACpB,QAAQ,EAAE,MAAM,GAAG,IAAI,CAAC;IACxB,OAAO,EAAE,MAAM,GAAG,IAAI,CAAC;IACvB,aAAa,EAAE,MAAM,GAAG,IAAI,CAAC;IAC7B,YAAY,EAAE,MAAM,GAAG,IAAI,CAAC;IAC5B,cAAc,EAAE,MAAM,GAAG,IAAI,CAAC;IAC9B,QAAQ,EAAE,MAAM,EAAE,CAAC;IACnB,UAAU,EAAE,OAAO,CAAC;IACpB,kBAAkB,EAAE,MAAM,GAAG,IAAI,CAAC;IAClC,MAAM,EAAE,OAAO,CAAC;IAChB,QAAQ,EAAE,MAAM,GAAG,IAAI,CAAC;IACxB,QAAQ,EAAE,MAAM,GAAG,IAAI,CAAC;IACxB,iBAAiB,EAAE,OAAO,CAAC;IAC3B,kBAAkB,EAAE,OAAO,CAAC;IAC5B,WAAW,EAAE,MAAM,GAAG,IAAI,CAAC;IAC3B,WAAW,EAAE,MAAM,GAAG,IAAI,CAAC;IAC3B,YAAY,EAAE,MAAM,GAAG,IAAI,CAAC;IAC5B,UAAU,EAAE,MAAM,GAAG,IAAI,CAAC;IAC1B,UAAU,EAAE,MAAM,GAAG,IAAI,CAAC;IAC1B,gBAAgB,EAAE,OAAO,CAAC;IAC1B,eAAe,EAAE,MAAM,CAAC;IACxB,MAAM,EAAE,UAAU,CAAC,OAAO,4BAA4B,CAAC,CAAC;IACxD,WAAW,EAAE,MAAM,EAAE,CAAC;CACvB;AAED,MAAM,WAAW,kBAAkB;IACjC,EAAE,EAAE,MAAM,CAAC;IACX,MAAM,EAAE,MAAM,CAAC;IACf,KAAK,EAAE,MAAM,CAAC;IACd,MAAM,EAAE,MAAM,CAAC;IACf,WAAW,EAAE,MAAM,CAAC;IACpB,YAAY,EAAE,MAAM,CAAC;IACrB,OAAO,EAAE,MAAM,CAAC;IAChB,eAAe,EAAE,MAAM,GAAG,IAAI,CAAC;IAC/B,KAAK,EAAE,OAAO,CAAC;IACf,YAAY,EAAE,MAAM,GAAG,IAAI,CAAC;IAC5B,MAAM,EAAE,kBAAkB,EAAE,CAAC;CAC9B;AA0ED,iGAAiG;AACjG,wBAAgB,iBAAiB,CAAC,UAAU,EAAE,MAAM,EAAE,aAAa,CAAC,EAAE,MAAM,GAAG,IAAI,GAAG,MAAM,CAK3F;AAED,wBAAgB,0BAA0B,CAAC,GAAG,EAAE,GAAG,GAAG,MAAM,EAAE,CAQ7D;AAcD,wBAAgB,iBAAiB,CAC/B,GAAG,EAAE,GAAG,EACR,SAAS,GAAE,sBAA2B,EACtC,KAAK,GAAE,gBAAgB,EAA2B;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;EA4hBnD;AA6BD,+FAA+F;AAC/F,wBAAgB,qBAAqB,CAAC,GAAG,EAAE,GAAG,GAAG,MAAM,CA+CtD;AAED,+FAA+F;AAC/F,wBAAsB,0BAA0B,CAC9C,GAAG,EAAE,GAAG,EACR,IAAI,EAAE,CAAC,IAAI,EAAE,MAAM,KAAK,OAAO,CAAC,MAAM,GAAG,IAAI,CAAC,EAC9C,QAAQ,CAAC,EAAE,CAAC,MAAM,EAAE,YAAY,KAAK,OAAO,CAAC,MAAM,CAAC,EACpD,QAAQ,CAAC,EAAE,CAAC,MAAM,EAAE,aAAa,KAAK,OAAO,CAAC,MAAM,CAAC,GACpD,OAAO,CAAC,MAAM,CAAC,MAAM,EAAE,qBAAqB,CAAC,CAAC,CAgJhD"}
|
package/dist/review-history.js
CHANGED
|
@@ -1,5 +1,6 @@
|
|
|
1
|
-
import { deriveChecklistStepDurations, digestRecipeDocument, extractRunArtifactManifest, isTerminalRunStatus, observedReviewSessionContinuity, reviewChainForRun, reviewResultForRun, } from '@farmslot/protocol';
|
|
2
|
-
import {
|
|
1
|
+
import { deriveChecklistStepDurations, digestRecipeDocument, extractRunArtifactManifest, FsErrorCodes, isTerminalRunStatus, observedReviewSessionContinuity, openReviewFindingCount, reviewChainForRun, reviewFindingId, reviewResultForRun, } from '@farmslot/protocol';
|
|
2
|
+
import { sameReviewAttemptReceipt } from './review-attempt-receipt.js';
|
|
3
|
+
import { compareReviewHistoryRounds, reviewHistoryRoundCards, reviewHistoryTimeline, } from './review-history-timeline.js';
|
|
3
4
|
import { runActivityView, runReviewActivityContext } from './run-activity.js';
|
|
4
5
|
import { reviewAttemptFailureReason } from './run-review-failures.js';
|
|
5
6
|
/** Transport generations invalidate requests, not facts already read from the same owner. */
|
|
@@ -95,6 +96,7 @@ function findings(value) {
|
|
|
95
96
|
return [
|
|
96
97
|
{
|
|
97
98
|
id: text(issue.id) ?? digestRecipeDocument({ file: issue.file ?? issue.path, title }),
|
|
99
|
+
recordedDescription: description,
|
|
98
100
|
title,
|
|
99
101
|
details: body.startsWith(title) ? body.slice(title.length).trim() : body,
|
|
100
102
|
severity: text(issue.severity) ?? priority?.[1] ?? 'Severity not recorded',
|
|
@@ -183,11 +185,13 @@ export function reviewHistoryView(run, artifacts = {}, chain = reviewChainForRun
|
|
|
183
185
|
const stepAttempts = Array.isArray(step?.outputs?.attempts)
|
|
184
186
|
? step.outputs.attempts.map(record).filter(isRecord)
|
|
185
187
|
: [];
|
|
186
|
-
const
|
|
188
|
+
const recordedAttempts = review
|
|
187
189
|
? review.attempts?.length
|
|
188
190
|
? review.attempts
|
|
189
191
|
: [review]
|
|
190
192
|
: [];
|
|
193
|
+
// A recovered receipt is audit history, not a second review of the same saved result.
|
|
194
|
+
const attempts = recordedAttempts.filter((attempt, index) => !recordedAttempts.slice(0, index).some((prior) => sameReviewAttemptReceipt(prior, attempt)));
|
|
191
195
|
const loops = [
|
|
192
196
|
...new Set([
|
|
193
197
|
...attempts.map((attempt) => attempt.loopNumber),
|
|
@@ -302,7 +306,9 @@ export function reviewHistoryView(run, artifacts = {}, chain = reviewChainForRun
|
|
|
302
306
|
.sort((left, right) => (left.completedAt ?? '').localeCompare(right.completedAt ?? ''))
|
|
303
307
|
.at(-1);
|
|
304
308
|
const previousHead = previousActor?.deliveryBaselineRef ?? previousActor?.pipelineVisualReviewInput?.headSha;
|
|
305
|
-
const headSha = text(snapshot?.headSha) ??
|
|
309
|
+
const headSha = text(snapshot?.headSha) ??
|
|
310
|
+
expectedHead ??
|
|
311
|
+
(attempt && attempt === attempts.at(-1) ? text(review?.reviewedHeadSha) : null);
|
|
306
312
|
const reconstructedFix = !fix && previousHead && headSha && previousHead !== headSha;
|
|
307
313
|
const fixBaseSha = text(fix?.fixBaseSha ?? fix?.baseSha) ?? (reconstructedFix ? previousHead : null);
|
|
308
314
|
const fixHeadSha = text(fix?.fixHeadSha ?? fix?.headSha) ?? (reconstructedFix ? headSha : null);
|
|
@@ -367,9 +373,15 @@ export function reviewHistoryView(run, artifacts = {}, chain = reviewChainForRun
|
|
|
367
373
|
text(raw?.reason) ??
|
|
368
374
|
(actor ? reviewAttemptFailureReason(run, actor) : null))
|
|
369
375
|
: null;
|
|
370
|
-
const unresolved = attempt?.unresolvedCount ??
|
|
376
|
+
const unresolved = (review && attempt ? openReviewFindingCount(review, attempt) : attempt?.unresolvedCount) ??
|
|
371
377
|
number(raw?.unresolvedCount) ??
|
|
378
|
+
number(saved?.unresolvedCount) ??
|
|
372
379
|
(recorded ? issueRows.length : null);
|
|
380
|
+
const usage = attempt?.usage ??
|
|
381
|
+
(review &&
|
|
382
|
+
ownsAttempt({ ...review, headSha: review.reviewSnapshot?.headSha ?? undefined }, review.loopNumber)
|
|
383
|
+
? review.usage
|
|
384
|
+
: undefined);
|
|
373
385
|
return {
|
|
374
386
|
key: actor?.id ?? `${id}:${loop}`,
|
|
375
387
|
reviewId: id,
|
|
@@ -391,11 +403,8 @@ export function reviewHistoryView(run, artifacts = {}, chain = reviewChainForRun
|
|
|
391
403
|
startedAt,
|
|
392
404
|
completedAt,
|
|
393
405
|
durationMs: duration(startedAt, completedAt),
|
|
394
|
-
|
|
395
|
-
|
|
396
|
-
ownsAttempt({ ...review, headSha: review.reviewSnapshot?.headSha ?? undefined }, review.loopNumber)
|
|
397
|
-
? review.usage
|
|
398
|
-
: undefined)),
|
|
406
|
+
usage,
|
|
407
|
+
usageLabel: reviewUsageLabel(usage),
|
|
399
408
|
headSha,
|
|
400
409
|
reviewBaseSha,
|
|
401
410
|
resultRecorded: recorded,
|
|
@@ -505,6 +514,26 @@ export function reviewHistoryView(run, artifacts = {}, chain = reviewChainForRun
|
|
|
505
514
|
orderedRounds.forEach((round, index) => {
|
|
506
515
|
round.roundNumber = index + 1;
|
|
507
516
|
});
|
|
517
|
+
const events = reviewHistoryTimeline(run, orderedRounds);
|
|
518
|
+
for (const round of orderedRounds) {
|
|
519
|
+
const head = round.headSha;
|
|
520
|
+
if (!head)
|
|
521
|
+
continue;
|
|
522
|
+
for (const finding of round.findings) {
|
|
523
|
+
const accepted = run.decisions.some((decision) => decision.publicationApproval?.headSha === head &&
|
|
524
|
+
decision.publicationApproval?.acceptedFindings?.findings.some((entry) => entry.reviewId === round.reviewId &&
|
|
525
|
+
reviewFindingId(entry.reviewId, head, entry) ===
|
|
526
|
+
reviewFindingId(round.reviewId, head, {
|
|
527
|
+
file: finding.file,
|
|
528
|
+
line: finding.line ?? undefined,
|
|
529
|
+
description: finding.recordedDescription ?? finding.title,
|
|
530
|
+
})));
|
|
531
|
+
if (accepted) {
|
|
532
|
+
finding.status = 'accepted';
|
|
533
|
+
finding.statusLabel = 'Accepted for publication';
|
|
534
|
+
}
|
|
535
|
+
}
|
|
536
|
+
}
|
|
508
537
|
const roundCount = orderedRounds.length;
|
|
509
538
|
const replayStep = run.steps.find((step) => step.name === 'review' && step.status === 'running');
|
|
510
539
|
const activeReplay = run.status === 'reviewing' &&
|
|
@@ -527,6 +556,7 @@ export function reviewHistoryView(run, artifacts = {}, chain = reviewChainForRun
|
|
|
527
556
|
.filter(Boolean)
|
|
528
557
|
.join(' · ');
|
|
529
558
|
return {
|
|
559
|
+
cards: reviewHistoryRoundCards(events),
|
|
530
560
|
checks,
|
|
531
561
|
segments,
|
|
532
562
|
roundCount,
|
|
@@ -538,7 +568,7 @@ export function reviewHistoryView(run, artifacts = {}, chain = reviewChainForRun
|
|
|
538
568
|
range: range(entry.baseSha, entry.headSha) ?? 'SHA unavailable',
|
|
539
569
|
diffPath: entry.artifactRefs.find((artifact) => artifact.path.endsWith('.diff'))?.path ?? null,
|
|
540
570
|
})),
|
|
541
|
-
events
|
|
571
|
+
events,
|
|
542
572
|
};
|
|
543
573
|
}
|
|
544
574
|
function reviewHistoryArtifactPathsForActor(actor) {
|
|
@@ -572,6 +602,8 @@ export function reviewHistoryIdentity(run) {
|
|
|
572
602
|
return JSON.stringify([
|
|
573
603
|
run.id,
|
|
574
604
|
run.reviewResult,
|
|
605
|
+
run.artifactBundle?.bundleDigest,
|
|
606
|
+
run.output?.artifactBundle?.bundleDigest,
|
|
575
607
|
run.reviewMode,
|
|
576
608
|
run.reviewRoundSettlements,
|
|
577
609
|
readyReviews(run).map((review) => [
|
|
@@ -616,6 +648,20 @@ export function reviewHistoryIdentity(run) {
|
|
|
616
648
|
}
|
|
617
649
|
/** One loader for both clients; the transport owns authentication and checks farm identity. */
|
|
618
650
|
export async function loadReviewHistoryArtifacts(run, read, readLive, readDiff) {
|
|
651
|
+
const readLiveFileIfPresent = async (params) => {
|
|
652
|
+
if (!readLive)
|
|
653
|
+
return null;
|
|
654
|
+
try {
|
|
655
|
+
return await readLive(params);
|
|
656
|
+
}
|
|
657
|
+
catch (error) {
|
|
658
|
+
if (error &&
|
|
659
|
+
typeof error === 'object' &&
|
|
660
|
+
Reflect.get(error, 'code') === FsErrorCodes.notFound)
|
|
661
|
+
return null;
|
|
662
|
+
throw error;
|
|
663
|
+
}
|
|
664
|
+
};
|
|
619
665
|
const readPaths = async (paths) => {
|
|
620
666
|
const settled = await Promise.allSettled(paths.map(async (path) => {
|
|
621
667
|
const retained = await read(path);
|
|
@@ -632,18 +678,20 @@ export async function loadReviewHistoryArtifacts(run, read, readLive, readDiff)
|
|
|
632
678
|
path.startsWith(`${reviewArtifactDir(context.reviewLoopNumber, context.artifactScope)}/`))))
|
|
633
679
|
: undefined;
|
|
634
680
|
if (!readLive || !actor?.slotId || !actor.taskFile)
|
|
635
|
-
|
|
681
|
+
return null;
|
|
636
682
|
const taskDir = actor.taskFile.slice(0, actor.taskFile.lastIndexOf('/'));
|
|
637
683
|
if (!taskDir || taskDir.split('/').includes('..') || path.split('/').includes('..'))
|
|
638
684
|
throw new Error('Recorded review task is unavailable');
|
|
639
|
-
return
|
|
685
|
+
return readLiveFileIfPresent({ slotId: actor.slotId, path: `${taskDir}/${path}` });
|
|
640
686
|
}));
|
|
641
687
|
return Object.fromEntries(paths.map((path, index) => {
|
|
642
688
|
const value = settled[index];
|
|
643
689
|
return [
|
|
644
690
|
path,
|
|
645
691
|
value.status === 'fulfilled'
|
|
646
|
-
?
|
|
692
|
+
? value.value === null
|
|
693
|
+
? { notCaptured: true }
|
|
694
|
+
: { content: value.value }
|
|
647
695
|
: {
|
|
648
696
|
error: `${path}: ${value.reason instanceof Error ? value.reason.message : String(value.reason)}`,
|
|
649
697
|
},
|
|
@@ -664,7 +712,9 @@ export async function loadReviewHistoryArtifacts(run, read, readLive, readDiff)
|
|
|
664
712
|
!['working', 'launching'].includes(context.status));
|
|
665
713
|
if (!actor?.slotId || !actor.taskFile)
|
|
666
714
|
return;
|
|
667
|
-
const task = await
|
|
715
|
+
const task = await readLiveFileIfPresent({ slotId: actor.slotId, path: actor.taskFile });
|
|
716
|
+
if (task === null)
|
|
717
|
+
return;
|
|
668
718
|
// These are engine-written frozen input headers, not reviewer transcript/output.
|
|
669
719
|
const match = /## COLD review range\s+Review the complete PR diff ([a-f0-9]{40})\.\.([a-f0-9]{40}) in /.exec(task) ?? /- Exact review range: `([a-f0-9]{40})\.\.([a-f0-9]{40})`/.exec(task);
|
|
670
720
|
if (!match || (round.headSha && match[2] !== round.headSha))
|