@farmslot/agent-runtime 0.5.1 → 0.6.0

package/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+## 0.6.0 - 2026-08-03
+
+- fix(mark): step enumeration now skips informational sections (Acceptance Criteria, pre-merge, `<details>`) exactly like the gateway parsers — checkbox-formatted ACs no longer shift `mark N` onto the wrong box. Also tightens checkbox matching to `- [ ]` (no `* [ ]`), matching gateway behavior.
+
 ## 0.5.1 - 2026-08-02
 
 - Align the published protocol dependency with 0.16.0 so downstream installs use one Recipe Protocol version.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@farmslot/agent-runtime",
-  "version": "0.5.1",
+  "version": "0.6.0",
   "type": "module",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
@@ -32,7 +32,7 @@
     "prepublishOnly": "node ../../scripts/quality/check-farmslot-package-readiness.mjs --publish --packages @farmslot/agent-runtime"
   },
   "dependencies": {
-    "@farmslot/protocol": "0.16.0"
+    "@farmslot/protocol": "0.17.0"
   },
   "devDependencies": {
     "@types/node": "^22.0.0",

package/scripts/checklist-target.cjs

@@ -12,6 +12,75 @@ const ROLE_SIGNAL_SUFFIX = '-SIGNAL.json';
 const SELF_REVIEW_CHECKLIST = 'SELF-REVIEW.md';
 const SELF_REVIEW_FIX_CHECKLIST = 'SELF-REVIEW-FIX.md';
 const CI_FIX_CHECKLIST = 'CI-FIX.md';
+// Sections whose checkboxes are informational (ACs, descriptions, upstream
+// PR-template fields) — not task steps. Canonical copy lives in
+// @farmslot/protocol/checklist-target CHECKLIST_SKIP_SECTIONS.
+const CHECKLIST_SKIP_SECTIONS =
+  /^\**\s*(acceptance criteria|description|task|affected area|screenshots|comments|root cause|rules|recipe acs|pre-merge)/i;
+
+// Behavioral mirror of @farmslot/protocol/checklist-target
+// enumerateChecklistCheckboxes — the single definition of which markdown
+// checkboxes are checklist steps. Any drift makes `mark N` check a different
+// box than the one gateway progress reporting counts as step N (see
+// test/checklist-target-sync.test.mjs for the parity fixture).
+function enumerateChecklistCheckboxes(markdown) {
+  const items = [];
+  const lines = markdown.split('\n');
+  let inCodeBlock = false;
+  let inDetails = 0;
+  let inSkippedSection = false;
+  let phase = null;
+  let phaseIndex = -1;
+  let stepNumber = 0;
+  for (let lineIndex = 0; lineIndex < lines.length; lineIndex += 1) {
+    const trimmed = lines[lineIndex].trim();
+    if (trimmed.startsWith('```')) {
+      inCodeBlock = !inCodeBlock;
+      continue;
+    }
+    if (inCodeBlock) continue;
+    // Only lines STARTING with a details tag are structural — prose that
+    // mentions `<details>` (e.g. PR-description instructions) must stay inert.
+    // On a structural line, net opens minus closes handles both the plain
+    // one-liner (`<details>…</details>` opens nothing) and nested same-line
+    // opens that leave a block dangling.
+    if (trimmed.startsWith('<details')) {
+      const opens = (trimmed.match(/<details\b/g) || []).length;
+      const closes = (trimmed.match(/<\/details/g) || []).length;
+      inDetails = Math.max(0, inDetails + opens - closes);
+      continue;
+    }
+    if (trimmed.startsWith('</details')) {
+      inDetails = Math.max(0, inDetails - 1);
+      continue;
+    }
+    if (inDetails > 0) continue;
+    if (/^#{2,}\s+[^#]/.test(trimmed)) {
+      const name = trimmed.replace(/^#{2,}\s+/, '').trim();
+      if (CHECKLIST_SKIP_SECTIONS.test(name)) {
+        inSkippedSection = true;
+        continue;
+      }
+      inSkippedSection = false;
+      phase = name;
+      phaseIndex += 1;
+      continue;
+    }
+    if (inSkippedSection) continue;
+    const match = trimmed.match(/^- \[( |x|X)\]\s*(.*)$/);
+    if (!match) continue;
+    stepNumber += 1;
+    items.push({
+      lineIndex,
+      stepNumber,
+      checked: match[1].toLowerCase() === 'x',
+      phase,
+      phaseIndex,
+      rawLabel: match[2],
+    });
+  }
+  return items;
+}
 const WORKER_TERMINAL_CONTRACT_INPUT = path.join('inputs', 'worker-terminal-contract.json');
 
 function signalFileForChecklist(checklistBasename) {
@@ -196,6 +265,8 @@ function resolveChecklistPaths(taskDir) {
 }
 
 module.exports = {
+  CHECKLIST_SKIP_SECTIONS,
+  enumerateChecklistCheckboxes,
   CHECKLIST_TARGET_MANIFEST,
   TASK_PROGRESS_MARKDOWN,
   INTERACTIVE_CHECKLIST_MARKDOWN,

package/scripts/mark-checklist-step.cjs

@@ -7,6 +7,7 @@ const {
   resolveWorkerTerminalContract,
 } = require('./worker-terminal-contract.cjs');
 const {
+  enumerateChecklistCheckboxes,
   parseTaskDirMarkArgs,
   terminalContractInputForChecklist,
 } = require('./checklist-target.cjs');
@@ -424,37 +425,26 @@ function stripLabel(raw) {
     .trim();
 }
 
+// Step enumeration is shared with the gateway parsers (generateTaskSchema in
+// tasks/writer.ts and parseCheckboxStates in methods/task.ts) via the
+// checklist-target enumerator: same skip sections, <details> handling, and
+// checkbox shape. Any divergence makes `mark N` check a different box than
+// the one progress reporting counts as step N (checkbox-formatted Acceptance
+// Criteria used to shift every step by the AC count).
 function parseChecklist(markdown) {
   const lines = markdown.split(/\n/);
-  const items = [];
-  let inFence = false;
-  let seen = 0;
-  for (let i = 0; i < lines.length; i += 1) {
-    if (/^\s*```/.test(lines[i])) {
-      inFence = !inFence;
-      continue;
-    }
-    if (inFence) continue;
-    const match = lines[i].match(/^(\s*[-*]\s+\[)( |x|X)(\]\s+)(.*)$/);
-    if (!match) continue;
-    seen += 1;
-    items.push({
-      lineIndex: i,
-      stepNumber: seen,
-      checked: match[2].toLowerCase() === 'x',
-      prefix: match[1],
-      suffix: match[3],
-      rawLabel: match[4],
-      label: stripLabel(match[4]),
-    });
-  }
+  const items = enumerateChecklistCheckboxes(markdown).map((item) => ({
+    ...item,
+    label: stripLabel(item.rawLabel),
+  }));
   return { lines, items };
 }
 
 function markStepInLines(lines, item) {
   if (item.checked) return false;
-  lines[item.lineIndex] = `${item.prefix}x${item.suffix}${item.rawLabel}`;
-  return true;
+  const before = lines[item.lineIndex];
+  lines[item.lineIndex] = before.replace(/^(\s*- \[)( |x|X)(\])/, '$1x$3');
+  return lines[item.lineIndex] !== before;
 }
 
 function resolveTarget(taskPath, stepNumber, markLast) {