@fantastic.dev/better-stripe 0.4.0 → 0.5.0

package/src/component/earnings-totals.test.ts

@@ -3,7 +3,7 @@
  * Tests for the earnings AGGREGATE queries (BTS-64). The row-list queries
  * (`listTransfersByAccount`, `listPayouts`) `.take(50)`, so a busy account's
  * earnings totals were silently truncated when summed client-side. These
- * aggregate queries paginate the account's ledger to completion and return
+ * aggregate queries iterate the account's ledger to completion and return
  * EXACT gross/reversed/paidOut regardless of row count, plus a bounded preview
  * of rows for drill-down UIs.
  */
@@ -12,6 +12,7 @@ import { describe, expect, it } from "vitest";
 
 import { api } from "./_generated/api.js";
 import schema from "./schema.js";
+import { getAccountEarnings, getAccountPayouts } from "./connect/queries.js";
 
 const modules = import.meta.glob("./**/*.*s");
 
@@ -194,3 +195,28 @@ describe("getAccountPayouts — exact paidOut past the 50-row cap (BTS-64)", ()
     expect(result.paidOut).toBe(210 * 100);
   });
 });
+
+// convex-test does not enforce production document/byte read limits. Simulate
+// a database iterator reaching that boundary after a row has been accumulated.
+// The aggregate must reject rather than exposing the partial financial total.
+describe("aggregate read-limit failures (BTS-116)", () => {
+  it.each([
+    ["earnings", getAccountEarnings, { destinationAccountId: "acct_limit" }],
+    ["payouts", getAccountPayouts, { accountId: "acct_limit" }],
+  ])("rejects incomplete %s totals", async (_name, query, args) => {
+    const readLimit = new Error(
+      "Too many documents read in a single function execution",
+    );
+    const rows = {
+      async *[Symbol.asyncIterator]() {
+        yield { amount: 100, reversedAmount: 10, status: "paid" };
+        throw readLimit;
+      },
+    };
+    const ctx = { db: { query: () => ({ withIndex: () => rows }) } };
+    const registered = query as unknown as {
+      _handler: (ctx: unknown, args: unknown) => Promise<unknown>;
+    };
+    await expect(registered._handler(ctx, args)).rejects.toBe(readLimit);
+  });
+});

package/src/component/lib/fees.ts

@@ -28,7 +28,7 @@ export type SplitRecipientRole = Infer<typeof splitRecipientRoleValidator>;
 
 /**
  * One destination in a multi-recipient split. The cut is expressed as either a
- * fixed `amount` (minor units) or a `percent` of the net; the resolver (BTS-14)
+ * fixed `amount` (minor units) or a `percent` of the gross charge; the resolver (BTS-14)
  * decides precedence. App-owned attribution (who the affiliate is) lives in app
  * tables — the component just records and executes the split.
  */

package/src/react/components/EmbeddedCheckout.render.test.tsx

@@ -0,0 +1,57 @@
+// @vitest-environment jsdom
+import { cleanup, render, waitFor } from "@testing-library/react";
+import { afterEach, expect, it, vi } from "vitest";
+
+import { EmbeddedCheckout } from "./EmbeddedCheckout.js";
+
+const { createEmbeddedCheckoutPage, mount, destroy } = vi.hoisted(() => ({
+  createEmbeddedCheckoutPage: vi.fn(),
+  mount: vi.fn(),
+  destroy: vi.fn(),
+}));
+vi.mock("@stripe/stripe-js", () => ({
+  loadStripe: () =>
+    Promise.resolve({
+      createEmbeddedCheckoutPage,
+      // React Stripe.js validates a Stripe instance with these methods.
+      elements: vi.fn(),
+      createToken: vi.fn(),
+      createPaymentMethod: vi.fn(),
+      confirmCardPayment: vi.fn(),
+    }),
+}));
+afterEach(() => {
+  cleanup();
+  vi.clearAllMocks();
+});
+
+it("mounts through the current Stripe.js API, forwards completion, and remounts a new session", async () => {
+  createEmbeddedCheckoutPage.mockResolvedValue({ mount, destroy });
+  const onComplete = vi.fn();
+  const view = render(
+    <EmbeddedCheckout
+      publishableKey="pk_test_local"
+      clientSecret="cs_first_secret"
+      onComplete={onComplete}
+    />,
+  );
+  await waitFor(() => expect(mount).toHaveBeenCalledTimes(1));
+  const firstOptions = createEmbeddedCheckoutPage.mock.calls[0][0];
+  expect(await firstOptions.fetchClientSecret()).toBe("cs_first_secret");
+  firstOptions.onComplete();
+  expect(onComplete).toHaveBeenCalledTimes(1);
+  view.rerender(
+    <EmbeddedCheckout
+      publishableKey="pk_test_local"
+      clientSecret="cs_second_secret"
+      onComplete={onComplete}
+    />,
+  );
+  await waitFor(() => expect(mount).toHaveBeenCalledTimes(2));
+  expect(destroy).toHaveBeenCalledTimes(1);
+  expect(
+    await createEmbeddedCheckoutPage.mock.calls[1][0].fetchClientSecret(),
+  ).toBe("cs_second_secret");
+  view.unmount();
+  expect(destroy).toHaveBeenCalledTimes(2);
+});

package/src/react/components/EmbeddedCheckout.tsx

@@ -44,6 +44,7 @@ export function EmbeddedCheckout({
   return (
     <div className={className}>
       <EmbeddedCheckoutProvider
+        key={`${publishableKey}:${clientSecret}`}
         stripe={stripePromise}
         options={{ fetchClientSecret, onComplete }}
       >