@fantastic.dev/better-stripe 0.23.2 → 0.24.0

package/src/component/summary-arithmetic.test.ts

@@ -103,15 +103,20 @@ it("rolls back subtract/reapply updates that would overflow", async () => {
   ).toMatchObject({ totals: [{ gross: max, transferCount: 2 }] });
 });
 
-it("rolls back a reversal whose cumulative summary would overflow", async () => {
+it("rolls back a reversal when a legacy cumulative summary would overflow", async () => {
   const t = convexTest(schema, modules);
   await t.mutation(api.connect.mutations.upsertTransfer, {
     ...transfer("tr_a", 1),
-    reversedAmount: max - 1,
+    reversedAmount: 0,
   });
   await t.mutation(api.connect.mutations.upsertTransfer, {
     ...transfer("tr_b", 1),
-    reversedAmount: 1,
+    reversedAmount: 0,
+  });
+  // Imported legacy totals can be inconsistent even when the new receipt is valid.
+  await t.run(async (ctx) => {
+    const totals = (await ctx.db.query("currencyTotals").first())!;
+    await ctx.db.patch("currencyTotals", totals._id, { reversed: max });
   });
   const before = await t.query(
     api.connect.queries.getAccountEarningsByCurrency,
@@ -120,7 +125,7 @@ it("rolls back a reversal whose cumulative summary would overflow", async () =>
   await expect(
     t.mutation(api.connect.mutations.recordTransferReversal, {
       stripeTransferId: "tr_b",
-      reversedAmount: 2,
+      reversedAmount: 1,
     }),
   ).rejects.toThrow(/safe integer/i);
   expect(

package/src/react/workflows/AffiliateRecovery.test.tsx

@@ -0,0 +1,106 @@
+// @vitest-environment jsdom
+import {
+  cleanup,
+  render,
+  screen,
+  fireEvent,
+  waitFor,
+} from "@testing-library/react";
+import { afterEach, expect, it, vi } from "vitest";
+import {
+  AffiliateRecovery,
+  AffiliateRecoveryHistory,
+} from "./AffiliateRecovery.js";
+import { affiliateRecoveryScenarios } from "../../testing/affiliate-recovery.js";
+import type { AffiliateRecoveryOperation } from "../../client/affiliateRecovery.js";
+afterEach(cleanup);
+it("shows exact recovered, debt and withheld amounts and labels simulated data separately", () => {
+  const fixture = affiliateRecoveryScenarios().find(
+    (r) => r.id === "paid-out",
+  )!;
+  expect(fixture.evidence).toBe("simulated");
+  render(<AffiliateRecovery snapshot={fixture.snapshot} currency="usd" />);
+  expect(screen.getAllByText("$10.01").length).toBeGreaterThan(1);
+  expect(screen.getByText("insufficient_balance")).toBeDefined();
+  expect(screen.getByText("Outstanding debt")).toBeDefined();
+  expect(screen.getByText("Withheld earnings")).toBeDefined();
+});
+it("exposes identical formatted metrics through the headless render API", () => {
+  const fixture = affiliateRecoveryScenarios().find((r) => r.id === "overlap")!;
+  let metrics: { key: string; formattedValue: string }[] = [];
+  render(
+    <AffiliateRecovery snapshot={fixture.snapshot} currency="usd">
+      {(state) => {
+        metrics = state.metrics;
+        return <p>{state.rows[0].sourceChargeId}</p>;
+      }}
+    </AffiliateRecovery>,
+  );
+  expect(metrics.find((r) => r.key === "recoveredAmount")!.formattedValue).toBe(
+    "$10.01",
+  );
+  expect(metrics.find((r) => r.key === "restoredAmount")!.formattedValue).toBe(
+    "$5.00",
+  );
+  expect(metrics.find((r) => r.key === "outstandingDebt")!.formattedValue).toBe(
+    "$0.00",
+  );
+});
+it("provides an operator reconcile action and visible provider errors without claiming success", async () => {
+  const fixture = affiliateRecoveryScenarios().find((r) => r.id === "unknown")!;
+  const retry = vi
+    .fn()
+    .mockRejectedValue(new Error("Provider outcome is unknown"));
+  render(
+    <AffiliateRecovery
+      snapshot={fixture.snapshot}
+      currency="usd"
+      onRetry={retry}
+    />,
+  );
+  fireEvent.click(screen.getByRole("button", { name: "Reconcile" }));
+  await waitFor(() =>
+    expect(screen.getByRole("alert").textContent).toBe(
+      "Provider outcome is unknown",
+    ),
+  );
+  expect(retry).toHaveBeenCalledWith(fixture.snapshot.obligations.page[0]._id);
+});
+it("shows authentication, pagination and unconfirmed receipt states", () => {
+  const { rerender } = render(
+    <AffiliateRecovery snapshot={null} currency="usd" />,
+  );
+  expect(
+    screen.getByText("Sign in to view your commission recovery."),
+  ).toBeDefined();
+  const fixture = affiliateRecoveryScenarios()[0];
+  rerender(
+    <AffiliateRecovery
+      snapshot={{
+        ...fixture.snapshot,
+        obligations: { ...fixture.snapshot.obligations, isDone: false },
+      }}
+      currency="usd"
+    />,
+  );
+  expect(screen.getByText(/More adjustments are available/)).toBeDefined();
+  rerender(
+    <AffiliateRecoveryHistory
+      currency="usd"
+      operations={[
+        {
+          _id: "fixture_op",
+          kind: "restoration",
+          amount: 501,
+          state: "unknown",
+          attempted: true,
+          createdAt: 0,
+          _creationTime: 0,
+          obligationId: "fixture_debt",
+        } as AffiliateRecoveryOperation,
+      ]}
+    />,
+  );
+  expect(screen.getByText("Unconfirmed")).toBeDefined();
+  expect(screen.getByText("unknown")).toBeDefined();
+});

package/src/react/workflows/AffiliateRecovery.tsx

@@ -0,0 +1,273 @@
+"use client";
+import type { ReactNode } from "react";
+import type {
+  AffiliateRecoverySnapshot,
+  AffiliateRecoveryObligation,
+  AffiliateRecoveryOperation,
+} from "../../client/affiliateRecovery.js";
+import { formatPrice } from "../lib/price-helpers.js";
+import { useWorkflowAction } from "./useWorkflowAction.js";
+export type RecoveryMetric = {
+  key: string;
+  label: string;
+  amount: number;
+  formattedValue: string;
+};
+export type RecoveryAdjustment = {
+  row: AffiliateRecoveryObligation;
+  source: string;
+  commission: string;
+  recovered: string;
+  debt: string;
+  status: string;
+};
+export type AffiliateRecoveryView = {
+  adjustments: RecoveryAdjustment[];
+  metrics: RecoveryMetric[];
+  rows: AffiliateRecoveryObligation[];
+  currency: string;
+  isLoading: boolean;
+  isComplete: boolean;
+  isPending: boolean;
+  error: string | null;
+  retry: (id: string) => Promise<unknown>;
+};
+export type AffiliateRecoveryProps = {
+  snapshot: AffiliateRecoverySnapshot | undefined | null;
+  currency: string;
+  showMetrics?: boolean;
+  locale?: string;
+  className?: string;
+  onRetry?: (obligationId: string) => Promise<unknown>;
+  onInspect?: (obligationId: string) => void;
+  sourceHref?: (row: AffiliateRecoveryObligation) => string | undefined;
+  children?: (state: AffiliateRecoveryView) => ReactNode;
+};
+/** Reusable, unstyled recovery state for earnings, referred sales and payouts. */
+export function AffiliateRecovery({
+  snapshot,
+  showMetrics = true,
+  currency,
+  locale,
+  className,
+  onRetry,
+  onInspect,
+  sourceHref,
+  children,
+}: AffiliateRecoveryProps) {
+  const action = useWorkflowAction(
+    async (id: string) => onRetry?.(id),
+    `affiliate-recovery:${currency}`,
+  );
+  const balance = snapshot?.balance;
+  if (
+    (balance && balance.currency !== currency) ||
+    snapshot?.obligations.page.some((row) => row.currency !== currency)
+  )
+    throw new Error("Affiliate recovery display cannot mix currencies.");
+  const definitions = [
+    ["originalCommission", "Original commission"],
+    ["recoveredAmount", "Reversed"],
+    ["outstandingDebt", "Outstanding debt"],
+    ["offsetAmount", "Recovered from future earnings"],
+    ["withheldAmount", "Withheld earnings"],
+    ["reservedRecovery", "Pending recovery"],
+    ["reservedRestoration", "Pending restoration"],
+    ["restoredAmount", "Restored"],
+    ["restorationDue", "Restoration owed"],
+    ["netPayable", "Net payable"],
+  ] as const;
+  const metrics = definitions.map(([key, label]) => {
+    const amount = balance?.[key] ?? 0;
+    return {
+      key,
+      label,
+      amount,
+      formattedValue: formatPrice(amount, currency, locale),
+    };
+  });
+  const adjustments = (snapshot?.obligations.page ?? []).map((row) => ({
+    row,
+    source: [
+      row.sourceChargeId,
+      row.storeAccountId,
+      row.sourceInvoiceId,
+      row.paymentId,
+      row.lastRefundId,
+      row.disputeId,
+    ]
+      .filter(Boolean)
+      .join(" · "),
+    commission: formatPrice(row.originalCommission, row.currency, locale),
+    recovered: formatPrice(
+      row.recoveredAmount + (row.offsetAmount ?? 0) - (row.restoredAmount ?? 0),
+      row.currency,
+      locale,
+    ),
+    debt: formatPrice(row.debtAmount ?? 0, row.currency, locale),
+    status: row.needsReconciliation
+      ? "Operator reconciliation required"
+      : (row.lastState ?? "Settled"),
+  }));
+  const state: AffiliateRecoveryView = {
+    adjustments,
+    metrics,
+    rows: snapshot?.obligations.page ?? [],
+    currency,
+    isLoading: snapshot === undefined,
+    isComplete: snapshot?.obligations.isDone ?? false,
+    isPending: action.isPending,
+    error: action.error,
+    retry: action.run,
+  };
+  if (children) return <>{children(state)}</>;
+  return (
+    <section className={className} data-better-stripe="affiliate-recovery">
+      <h2>Commission recovery ({currency.toUpperCase()})</h2>
+      {state.isLoading ? (
+        <p role="status">Loading commission recovery…</p>
+      ) : snapshot === null ? (
+        <p>Sign in to view your commission recovery.</p>
+      ) : (
+        <>
+          {showMetrics && (
+            <dl>
+              {metrics.map((metric) => (
+                <div key={metric.key}>
+                  <dt>{metric.label}</dt>
+                  <dd>{metric.formattedValue}</dd>
+                </div>
+              ))}
+            </dl>
+          )}
+          {state.error && <p role="alert">{state.error}</p>}
+          {!state.rows.length && <p>No commission adjustments yet.</p>}
+          <table>
+            <caption>Commission adjustments</caption>
+            <thead>
+              <tr>
+                <th scope="col">Original sale</th>
+                <th scope="col">Commission</th>
+                <th scope="col">Recovered</th>
+                <th scope="col">Debt</th>
+                <th scope="col">State</th>
+                {(onRetry || onInspect) && <th scope="col">Action</th>}
+              </tr>
+            </thead>
+            <tbody>
+              {state.rows.map((row) => (
+                <tr key={row._id}>
+                  <td>
+                    {sourceHref?.(row) ? (
+                      <a href={sourceHref(row)}>{row.sourceChargeId}</a>
+                    ) : (
+                      row.sourceChargeId
+                    )}
+                    <br />
+                    {[
+                      row.storeAccountId,
+                      row.sourceInvoiceId,
+                      row.paymentId,
+                      row.lastRefundId,
+                      row.disputeId,
+                    ]
+                      .filter(Boolean)
+                      .join(" · ")}
+                  </td>
+                  <td>
+                    {formatPrice(row.originalCommission, row.currency, locale)}
+                  </td>
+                  <td>
+                    {formatPrice(
+                      row.recoveredAmount +
+                        (row.offsetAmount ?? 0) -
+                        (row.restoredAmount ?? 0),
+                      row.currency,
+                      locale,
+                    )}
+                  </td>
+                  <td>
+                    {formatPrice(row.debtAmount ?? 0, row.currency, locale)}
+                  </td>
+                  <td>
+                    {row.needsReconciliation
+                      ? "Operator reconciliation required"
+                      : (row.lastState ?? "Settled")}
+                    {row.lastError && <p>{row.lastError}</p>}
+                  </td>
+                  {(onRetry || onInspect) && (
+                    <td>
+                      {onInspect && (
+                        <button
+                          type="button"
+                          onClick={() => onInspect(row._id)}
+                        >
+                          Inspect attempts
+                        </button>
+                      )}
+                      {onRetry && (
+                        <button
+                          type="button"
+                          disabled={state.isPending}
+                          onClick={() => {
+                            void state.retry(row._id);
+                          }}
+                        >
+                          Reconcile
+                        </button>
+                      )}
+                    </td>
+                  )}
+                </tr>
+              ))}
+            </tbody>
+          </table>
+          {!state.isComplete && (
+            <p>
+              More adjustments are available. Totals include the complete
+              account ledger.
+            </p>
+          )}
+        </>
+      )}
+    </section>
+  );
+}
+export function AffiliateRecoveryHistory({
+  operations,
+  currency,
+  locale,
+}: {
+  operations: AffiliateRecoveryOperation[];
+  currency: string;
+  locale?: string;
+}) {
+  return (
+    <table data-better-stripe="affiliate-recovery-history">
+      <caption>Recovery receipts and attempts</caption>
+      <thead>
+        <tr>
+          <th scope="col">Operation</th>
+          <th scope="col">Amount</th>
+          <th scope="col">Outcome</th>
+          <th scope="col">Receipt</th>
+        </tr>
+      </thead>
+      <tbody>
+        {operations.map((op) => (
+          <tr key={op._id}>
+            <td>
+              {op.kind} · {op.sourceEventId ?? op._id}
+            </td>
+            <td>{formatPrice(op.amount, currency, locale)}</td>
+            <td>
+              {op.state}
+              {op.error && <p>{op.error}</p>}
+            </td>
+            <td>{op.receiptId ?? "Unconfirmed"}</td>
+          </tr>
+        ))}
+      </tbody>
+    </table>
+  );
+}

package/src/react/workflows/index.ts

@@ -265,6 +265,15 @@ export type {
   AffiliatePayoutEditorState,
   AffiliatePayoutUpdate,
 } from "./AffiliatePayoutEditor.js";
+export {
+  AffiliateRecovery,
+  AffiliateRecoveryHistory,
+} from "./AffiliateRecovery.js";
+export type {
+  AffiliateRecoveryProps,
+  AffiliateRecoveryView,
+  RecoveryMetric,
+} from "./AffiliateRecovery.js";
 
 export { EvidenceUpload } from "./EvidenceUpload.js";
 export type { EvidenceUploadProps } from "./EvidenceUpload.js";

package/src/testing/affiliate-recovery.ts

@@ -0,0 +1,137 @@
+import type { AffiliateRecoverySnapshot } from "../client/affiliateRecovery.js";
+export type AffiliateRecoveryScenario = {
+  id: string;
+  label: string;
+  evidence: "simulated";
+  snapshot: AffiliateRecoverySnapshot;
+};
+/** Presentation fixtures only. These IDs are not Stripe or bank-payout receipts. */
+export function affiliateRecoveryScenarios(): AffiliateRecoveryScenario[] {
+  const cases = [
+    {
+      id: "one-time-refund",
+      label: "One-time full refund",
+      finalized: 1001,
+      recovered: 1001,
+    },
+    {
+      id: "invoice-refund",
+      label: "Recurring invoice refund",
+      finalized: 1001,
+      recovered: 1001,
+      invoice: "fixture_invoice_renewal",
+    },
+    {
+      id: "partial-refund",
+      label: "Partial refund and rounding",
+      finalized: 501,
+      recovered: 501,
+    },
+    {
+      id: "open-dispute",
+      label: "Open monetary dispute",
+      finalized: 0,
+      provisional: 1001,
+      recovered: 1001,
+    },
+    {
+      id: "lost-dispute",
+      label: "Lost dispute finalized",
+      finalized: 1001,
+      recovered: 1001,
+    },
+    {
+      id: "won-dispute",
+      label: "Won dispute restored",
+      finalized: 0,
+      recovered: 1001,
+      restored: 1001,
+    },
+    {
+      id: "overlap",
+      label: "Refund retained after dispute win",
+      finalized: 501,
+      recovered: 1001,
+      restored: 500,
+    },
+    {
+      id: "paid-out",
+      label: "Insufficient balance after external payout",
+      finalized: 1001,
+      recovered: 0,
+      state: "insufficient_balance",
+    },
+    {
+      id: "future-offset",
+      label: "Debt recovered from future commission",
+      finalized: 1001,
+      recovered: 0,
+      offset: 1001,
+    },
+    {
+      id: "unknown",
+      label: "Provider timeout awaiting receipt",
+      finalized: 1001,
+      recovered: 0,
+      reserved: 1001,
+      state: "unknown",
+    },
+  ];
+  return cases.map((c) => {
+    const recoveredAmount = c.recovered,
+      offsetAmount = c.offset ?? 0,
+      restoredAmount = c.restored ?? 0;
+    const debt = Math.max(
+      0,
+      c.finalized +
+        (c.provisional ?? 0) -
+        recoveredAmount -
+        offsetAmount +
+        restoredAmount,
+    );
+    const row = {
+      _id: `fixture_${c.id}`,
+      _creationTime: 0,
+      sourceChargeId: `fixture_charge_${c.id}`,
+      sourceInvoiceId: c.invoice,
+      paymentIntentId: "fixture_payment",
+      affiliateAccountId: "fixture_affiliate",
+      currency: "usd",
+      chargeAmount: 10000,
+      originalCommission: 1001,
+      refundedPrincipal: c.finalized ? 10000 : 0,
+      disputedPrincipal: c.provisional ? 10000 : 0,
+      lostPrincipal: 0,
+      finalizedAmount: c.finalized,
+      provisionalAmount: c.provisional ?? 0,
+      recoveredAmount,
+      offsetAmount,
+      restoredAmount,
+      reservedRecovery: c.reserved ?? 0,
+      debtAmount: debt,
+      creditAmount: 0,
+      needsReconciliation: false,
+      lastState: c.state ?? "succeeded",
+    } as AffiliateRecoverySnapshot["obligations"]["page"][number];
+    const snapshot = {
+      balance: {
+        _id: `fixture_balance_${c.id}`,
+        _creationTime: 0,
+        affiliateAccountId: "fixture_affiliate",
+        currency: "usd",
+        originalCommission: 1001,
+        recoveredAmount,
+        offsetAmount,
+        restoredAmount,
+        outstandingDebt: debt,
+        reservedRecovery: c.reserved ?? 0,
+        reservedRestoration: 0,
+        restorationDue: 0,
+        withheldAmount: offsetAmount,
+        netPayable: 0,
+      },
+      obligations: { page: [row], continueCursor: "", isDone: true },
+    } as AffiliateRecoverySnapshot;
+    return { id: c.id, label: c.label, evidence: "simulated", snapshot };
+  });
+}

package/src/testing/index.ts

@@ -11,3 +11,5 @@ export {
   mockAccountUpdated,
   mockInvoicePaid,
 } from "./mock-webhooks.js";
+export { affiliateRecoveryScenarios } from "./affiliate-recovery.js";
+export type { AffiliateRecoveryScenario } from "./affiliate-recovery.js";