@fairyhunter13/opentui-core 0.1.90 → 0.1.92

package/src/lib/KeyHandler.integration.test.ts

@@ -1,292 +0,0 @@
-import { test, expect } from "bun:test"
-import { InternalKeyHandler, KeyEvent } from "./KeyHandler.js"
-import { parseKeypress } from "./parse.keypress.js"
-
-/**
- * Integration tests demonstrating real-world scenarios with stopPropagation
- */
-
-function createKeyHandler(): InternalKeyHandler {
-  return new InternalKeyHandler()
-}
-
-function dispatchInput(handler: InternalKeyHandler, data: string): boolean {
-  const parsedKey = parseKeypress(data)
-  if (!parsedKey) {
-    return false
-  }
-
-  return handler.processParsedKey(parsedKey)
-}
-
-test("Integration - Modal ESC handler prevents subsequent handlers", () => {
-  const handler = createKeyHandler()
-
-  let modalOpen = true
-  let modalHandledEsc = false
-  let backgroundHandledEsc = false
-
-  // Modal ESC handler (registered first, so it runs first)
-  handler.on("keypress", (key: KeyEvent) => {
-    if (key.name === "escape" && modalOpen) {
-      modalHandledEsc = true
-      modalOpen = false
-      key.stopPropagation() // Stop other handlers from running
-    }
-  })
-
-  // Background/app-level ESC handler (registered second, should not run)
-  handler.on("keypress", (key: KeyEvent) => {
-    if (key.name === "escape") {
-      backgroundHandledEsc = true
-    }
-  })
-
-  // Simulate ESC key press while modal is open
-  dispatchInput(handler, "\x1b")
-
-  expect(modalOpen).toBe(false)
-  expect(modalHandledEsc).toBe(true)
-  expect(backgroundHandledEsc).toBe(false) // Modal stopped propagation
-})
-
-test("Integration - Focused input field handles key, stops parent handlers", () => {
-  const handler = createKeyHandler()
-
-  const inputValue: string[] = []
-  let parentHandledKey = false
-
-  // Parent container handler
-  handler.on("keypress", (key: KeyEvent) => {
-    if (!key.propagationStopped) {
-      parentHandledKey = true
-    }
-  })
-
-  // Focused input field handler (internal/renderable)
-  handler.onInternal("keypress", (key: KeyEvent) => {
-    if (key.name === "a" || key.name === "b" || key.name === "c") {
-      inputValue.push(key.name)
-      key.stopPropagation() // Input consumed the key
-    }
-  })
-
-  // Type some keys
-  dispatchInput(handler, "a")
-  dispatchInput(handler, "b")
-  dispatchInput(handler, "c")
-
-  expect(inputValue).toEqual(["a", "b", "c"])
-  expect(parentHandledKey).toBe(true) // Parent ran first (global priority)
-
-  // But internal handler got to consume the keys and stop propagation
-  // doesn't prevent parent from seeing them first (global runs before internal)
-})
-
-test("Integration - Dialog system with priority: innermost modal wins", () => {
-  const handler = createKeyHandler()
-
-  let outerModalClosed = false
-  let innerModalClosed = false
-  const closeLog: string[] = []
-
-  // Outer modal ESC handler
-  const outerHandler = (key: KeyEvent) => {
-    if (key.name === "escape" && !key.propagationStopped) {
-      closeLog.push("outer")
-      outerModalClosed = true
-      key.stopPropagation()
-    }
-  }
-
-  // Inner modal ESC handler (registered later, so it comes first in listener order)
-  const innerHandler = (key: KeyEvent) => {
-    if (key.name === "escape") {
-      closeLog.push("inner")
-      innerModalClosed = true
-      key.stopPropagation()
-    }
-  }
-
-  // Register outer first
-  handler.on("keypress", outerHandler)
-
-  // Then inner (but we want inner to handle first)
-  // In a real app, we'd use prependInputHandler or similar
-  // For now, let's simulate by removing outer and re-adding in correct order
-  handler.removeListener("keypress", outerHandler)
-  handler.on("keypress", innerHandler)
-  handler.on("keypress", outerHandler)
-
-  // Press ESC
-  dispatchInput(handler, "\x1b")
-
-  expect(closeLog).toEqual(["inner"])
-  expect(innerModalClosed).toBe(true)
-  expect(outerModalClosed).toBe(false) // Inner stopped propagation
-})
-
-test("Integration - Keyboard shortcut system with priorities", () => {
-  const handler = createKeyHandler()
-
-  const actions: string[] = []
-
-  // Global shortcuts (Ctrl+S = Save, Ctrl+O = Open)
-  handler.on("keypress", (key: KeyEvent) => {
-    if (key.ctrl && key.name === "s") {
-      actions.push("save")
-      // Don't stop propagation - allow other handlers to see it
-    }
-    if (key.ctrl && key.name === "o") {
-      actions.push("open")
-    }
-  })
-
-  // Text editor overrides Ctrl+S when focused
-  let editorFocused = true
-  handler.onInternal("keypress", (key: KeyEvent) => {
-    if (editorFocused && key.ctrl && key.name === "s") {
-      actions.push("save-document")
-      key.stopPropagation() // Override global save
-    }
-  })
-
-  // Ctrl+S with editor focused
-  dispatchInput(handler, "\x13") // Ctrl+S
-
-  expect(actions).toEqual(["save", "save-document"])
-  // Note: global runs first, then internal. To truly override,
-  // the editor would need to be a global handler registered first
-})
-
-test("Integration - preventDefault vs stopPropagation behavior", () => {
-  const handler = createKeyHandler()
-
-  const log: string[] = []
-
-  // Handler 1: preventDefault only
-  handler.on("keypress", (key: KeyEvent) => {
-    if (key.name === "a") {
-      log.push("handler1-saw-a")
-      key.preventDefault()
-    }
-  })
-
-  // Handler 2: Should still run (preventDefault doesn't stop global handlers)
-  handler.on("keypress", (key: KeyEvent) => {
-    if (key.name === "a") {
-      log.push("handler2-saw-a")
-      if (key.defaultPrevented) {
-        log.push("handler2-saw-prevented")
-      }
-    }
-  })
-
-  // Handler 3: Internal handler should not run (preventDefault stops internal)
-  handler.onInternal("keypress", (key: KeyEvent) => {
-    if (key.name === "a") {
-      log.push("handler3-internal-saw-a")
-    }
-  })
-
-  dispatchInput(handler, "a")
-
-  expect(log).toEqual([
-    "handler1-saw-a",
-    "handler2-saw-a",
-    "handler2-saw-prevented",
-    // handler3 doesn't run because preventDefault stops internal handlers
-  ])
-
-  // Now test with stopPropagation
-  log.length = 0
-
-  handler.removeAllListeners("keypress")
-
-  handler.on("keypress", (key: KeyEvent) => {
-    if (key.name === "b") {
-      log.push("handler1-saw-b")
-      key.stopPropagation()
-    }
-  })
-
-  handler.on("keypress", (key: KeyEvent) => {
-    if (key.name === "b") {
-      log.push("handler2-saw-b")
-    }
-  })
-
-  dispatchInput(handler, "b")
-
-  expect(log).toEqual([
-    "handler1-saw-b",
-    // handler2 doesn't run because stopPropagation stops all subsequent handlers
-  ])
-})
-
-test("Integration - Form submission with Enter key", () => {
-  const handler = createKeyHandler()
-
-  let formSubmitted = false
-  let inputValue = ""
-
-  // Form's Enter handler
-  handler.on("keypress", (key: KeyEvent) => {
-    if (key.name === "return" && !key.propagationStopped) {
-      formSubmitted = true
-    }
-  })
-
-  // Input field's Enter handler
-  handler.onInternal("keypress", (key: KeyEvent) => {
-    if (key.name === "return") {
-      // Multi-line input: add newline and stop propagation
-      inputValue += "\n"
-      key.stopPropagation()
-    }
-  })
-
-  // Press Enter
-  dispatchInput(handler, "\r")
-
-  expect(inputValue).toBe("\n")
-  expect(formSubmitted).toBe(true) // Global handler ran first
-
-  // In a real app, you'd check defaultPrevented in the form handler
-  // or the input would be registered as a global handler first
-})
-
-test("Integration - Event bubbling with multiple nested components", () => {
-  const handler = createKeyHandler()
-
-  const eventLog: Array<{ component: string; stopped: boolean }> = []
-
-  // Root component
-  handler.on("keypress", (key: KeyEvent) => {
-    eventLog.push({ component: "root", stopped: key.propagationStopped })
-  })
-
-  // Child component (registered as internal, represents focused element)
-  handler.onInternal("keypress", (key: KeyEvent) => {
-    eventLog.push({ component: "child", stopped: key.propagationStopped })
-
-    // Child handles space key and stops propagation
-    if (key.name === "space") {
-      key.stopPropagation()
-    }
-  })
-
-  // Another internal handler (sibling or parent)
-  handler.onInternal("keypress", (key: KeyEvent) => {
-    eventLog.push({ component: "sibling", stopped: key.propagationStopped })
-  })
-
-  dispatchInput(handler, " ") // Space key
-
-  expect(eventLog).toEqual([
-    { component: "root", stopped: false },
-    { component: "child", stopped: false },
-    // sibling doesn't run because child stopped propagation
-  ])
-  expect(eventLog).toHaveLength(2)
-})

package/src/lib/KeyHandler.stopPropagation.test.ts

@@ -1,289 +0,0 @@
-import { test, expect } from "bun:test"
-import { InternalKeyHandler, KeyEvent } from "./KeyHandler.js"
-import { parseKeypress } from "./parse.keypress.js"
-import { pasteBytes } from "../testing/mock-keys.js"
-
-function createKeyHandler(): InternalKeyHandler {
-  return new InternalKeyHandler()
-}
-
-function dispatchInput(handler: InternalKeyHandler, data: string): boolean {
-  const parsedKey = parseKeypress(data)
-  if (!parsedKey) {
-    return false
-  }
-
-  return handler.processParsedKey(parsedKey)
-}
-
-test("stopPropagation - stops subsequent global handlers", () => {
-  const handler = createKeyHandler()
-
-  const callOrder: string[] = []
-
-  handler.on("keypress", (key: KeyEvent) => {
-    callOrder.push("global1")
-    key.stopPropagation()
-  })
-
-  handler.on("keypress", (key: KeyEvent) => {
-    callOrder.push("global2")
-  })
-
-  dispatchInput(handler, "a")
-
-  expect(callOrder).toEqual(["global1"])
-})
-
-test("stopPropagation - stops internal handlers from running", () => {
-  const handler = createKeyHandler()
-
-  const callOrder: string[] = []
-
-  handler.on("keypress", (key: KeyEvent) => {
-    callOrder.push("global")
-    key.stopPropagation()
-  })
-
-  handler.onInternal("keypress", (key: KeyEvent) => {
-    callOrder.push("internal")
-  })
-
-  dispatchInput(handler, "a")
-
-  expect(callOrder).toEqual(["global"])
-})
-
-test("stopPropagation - internal handler can stop other internal handlers", () => {
-  const handler = createKeyHandler()
-
-  const callOrder: string[] = []
-
-  handler.onInternal("keypress", (key: KeyEvent) => {
-    callOrder.push("internal1")
-    key.stopPropagation()
-  })
-
-  handler.onInternal("keypress", (key: KeyEvent) => {
-    callOrder.push("internal2")
-  })
-
-  dispatchInput(handler, "a")
-
-  expect(callOrder).toEqual(["internal1"])
-})
-
-test("stopPropagation - does not affect preventDefault", () => {
-  const handler = createKeyHandler()
-
-  let stoppedPropagation = false
-  let preventedDefault = false
-
-  handler.on("keypress", (key: KeyEvent) => {
-    key.stopPropagation()
-    key.preventDefault()
-    stoppedPropagation = key.propagationStopped
-    preventedDefault = key.defaultPrevented
-  })
-
-  dispatchInput(handler, "a")
-
-  expect(stoppedPropagation).toBe(true)
-  expect(preventedDefault).toBe(true)
-})
-
-test("stopPropagation - without calling it, all handlers run", () => {
-  const handler = createKeyHandler()
-
-  const callOrder: string[] = []
-
-  handler.on("keypress", (key: KeyEvent) => {
-    callOrder.push("global1")
-  })
-
-  handler.on("keypress", (key: KeyEvent) => {
-    callOrder.push("global2")
-  })
-
-  handler.onInternal("keypress", (key: KeyEvent) => {
-    callOrder.push("internal1")
-  })
-
-  handler.onInternal("keypress", (key: KeyEvent) => {
-    callOrder.push("internal2")
-  })
-
-  dispatchInput(handler, "a")
-
-  expect(callOrder).toEqual(["global1", "global2", "internal1", "internal2"])
-})
-
-test("stopPropagation - paste events support stopPropagation", () => {
-  const handler = createKeyHandler()
-
-  const callOrder: string[] = []
-
-  handler.on("paste", (event) => {
-    callOrder.push("global")
-    event.stopPropagation()
-  })
-
-  handler.onInternal("paste", (event) => {
-    callOrder.push("internal")
-  })
-
-  handler.processPaste(pasteBytes("hello"))
-
-  expect(callOrder).toEqual(["global"])
-})
-
-test("stopPropagation - works with keyrelease events", () => {
-  const handler = createKeyHandler()
-
-  const callOrder: string[] = []
-
-  handler.on("keyrelease", (key: KeyEvent) => {
-    callOrder.push("global")
-    key.stopPropagation()
-  })
-
-  handler.onInternal("keyrelease", (key: KeyEvent) => {
-    callOrder.push("internal")
-  })
-
-  // Emit a release event directly since we need kitty protocol
-  handler.emit(
-    "keyrelease",
-    new KeyEvent({
-      name: "a",
-      ctrl: false,
-      meta: false,
-      shift: false,
-      option: false,
-      sequence: "a",
-      number: false,
-      raw: "a",
-      eventType: "release",
-      source: "kitty",
-    }),
-  )
-
-  expect(callOrder).toEqual(["global"])
-})
-
-test("stopPropagation - error in handler does not affect propagation stopped state", () => {
-  const handler = createKeyHandler()
-
-  const callOrder: string[] = []
-
-  handler.on("keypress", (key: KeyEvent) => {
-    callOrder.push("global1")
-    key.stopPropagation()
-    throw new Error("Test error")
-  })
-
-  handler.on("keypress", (key: KeyEvent) => {
-    callOrder.push("global2")
-  })
-
-  expect(() => dispatchInput(handler, "a")).not.toThrow()
-
-  expect(callOrder).toEqual(["global1"])
-})
-
-test("stopPropagation - modal scenario: ESC key handled by modal, stops at modal", () => {
-  const handler = createKeyHandler()
-
-  const callOrder: string[] = []
-  let modalClosed = false
-  let appHandledEsc = false
-
-  // Modal handler (internal, should be focused element) - runs BEFORE app handler
-  // In a real app, the focused modal element would use onInternal
-  handler.onInternal("keypress", (key: KeyEvent) => {
-    if (key.name === "escape") {
-      callOrder.push("modal")
-      modalClosed = true
-      key.stopPropagation()
-    }
-  })
-
-  // App-level global ESC handler (should NOT run if modal stops propagation)
-  handler.on("keypress", (key: KeyEvent) => {
-    if (key.name === "escape") {
-      callOrder.push("app")
-      appHandledEsc = true
-    }
-  })
-
-  dispatchInput(handler, "\x1b")
-
-  // Global handlers run before internal handlers
-  // So app handler runs first, but modal can still stop further internal handlers
-  expect(callOrder).toEqual(["app", "modal"])
-  expect(modalClosed).toBe(true)
-  expect(appHandledEsc).toBe(true)
-})
-
-test("stopPropagation - modal scenario: global modal handler prevents app handler", () => {
-  const handler = createKeyHandler()
-
-  const callOrder: string[] = []
-  let modalClosed = false
-  let appHandledEsc = false
-
-  // Modal as a global handler (registered first) - to stop before app handler
-  handler.on("keypress", (key: KeyEvent) => {
-    if (key.name === "escape") {
-      callOrder.push("modal")
-      modalClosed = true
-      key.stopPropagation()
-    }
-  })
-
-  // App-level ESC handler (should NOT run due to stopPropagation)
-  handler.on("keypress", (key: KeyEvent) => {
-    if (key.name === "escape") {
-      callOrder.push("app")
-      appHandledEsc = true
-    }
-  })
-
-  dispatchInput(handler, "\x1b")
-
-  // When modal is registered as a global handler first, it can stop the app handler
-  expect(callOrder).toEqual(["modal"])
-  expect(modalClosed).toBe(true)
-  expect(appHandledEsc).toBe(false)
-})
-
-test("stopPropagation - event flow without stopPropagation shows order", () => {
-  const handler = createKeyHandler()
-
-  const events: string[] = []
-
-  handler.on("keypress", (key: KeyEvent) => {
-    events.push("global1")
-    expect(key.propagationStopped).toBe(false)
-  })
-
-  handler.on("keypress", (key: KeyEvent) => {
-    events.push("global2")
-    expect(key.propagationStopped).toBe(false)
-  })
-
-  handler.onInternal("keypress", (key: KeyEvent) => {
-    events.push("internal1")
-    expect(key.propagationStopped).toBe(false)
-  })
-
-  handler.onInternal("keypress", (key: KeyEvent) => {
-    events.push("internal2")
-    expect(key.propagationStopped).toBe(false)
-  })
-
-  dispatchInput(handler, "a")
-
-  // Verify execution order: global handlers first, then internal handlers
-  expect(events).toEqual(["global1", "global2", "internal1", "internal2"])
-})