@fails-components/webtransport-transport-http3-quiche 1.6.2 → 1.6.3

package/CMakeLists.txt

@@ -378,6 +378,8 @@ third_party/quiche/quiche/quic/core/congestion_control/bbr2_sender.cc
 third_party/quiche/quiche/quic/core/congestion_control/bbr2_sender.h
 third_party/quiche/quiche/quic/core/congestion_control/bbr2_startup.cc
 third_party/quiche/quiche/quic/core/congestion_control/bbr2_startup.h
+third_party/quiche/quiche/quic/core/congestion_control/bbr3_sender.cc
+third_party/quiche/quiche/quic/core/congestion_control/bbr3_sender.h
 third_party/quiche/quiche/quic/core/congestion_control/bbr_sender.cc
 third_party/quiche/quiche/quic/core/congestion_control/bbr_sender.h
 third_party/quiche/quiche/quic/core/congestion_control/cubic_bytes.cc

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@fails-components/webtransport-transport-http3-quiche",
-  "version": "1.6.2",
+  "version": "1.6.3",
   "description": "A component to add webtransport support (server and client) to node.js, transport using libquiche",
   "exports": {
     ".": {

package/src/http3serversession.cc

@@ -79,15 +79,6 @@ namespace quic
     return stream;
   }
 
-  QuicSpdyStream *Http3ServerSession::CreateIncomingStream(
-      PendingStream *pending)
-  {
-    QuicSpdyStream *stream =
-        new Http3ServerStream(pending, this, http3_server_backend_);
-    ActivateStream(absl::WrapUnique(stream));
-    return stream;
-  }
-
   QuicSpdyStream *Http3ServerSession::CreateOutgoingBidirectionalStream()
   {
     if (!WillNegotiateWebTransport())

package/src/http3serversession.h

@@ -61,7 +61,6 @@ namespace quic
   protected:
     // QuicSession methods:
     QuicSpdyStream *CreateIncomingStream(QuicStreamId id) override;
-    QuicSpdyStream *CreateIncomingStream(PendingStream *pending) override;
     QuicSpdyStream *CreateOutgoingBidirectionalStream() override;
 
     // QuicServerSessionBaseMethod:

package/src/http3serverstream.cc

@@ -48,7 +48,7 @@ namespace quic
   Http3ServerStream::Http3ServerStream(
       PendingStream *pending, QuicSpdySession *session,
       Http3ServerBackend *http3_server_backend)
-      : QuicSpdyServerStreamBase(pending, session),
+      : QuicSpdyServerStreamBase(*pending, session),
         content_length_(-1),
         generate_bytes_length_(0),
         http3_server_backend_(http3_server_backend)
@@ -151,6 +151,7 @@ namespace quic
 
   void Http3ServerStream::SendResponse()
   {
+    if (fin_buffered()) return; // we already exited
     if (request_headers_.empty())
     {
       QUIC_DVLOG(1) << "Request headers empty.";
@@ -357,6 +358,7 @@ namespace quic
   void Http3ServerStream::SendNotFoundResponse()
   {
     QUIC_DVLOG(1) << "Stream " << id() << " sending not found response.";
+    if (fin_buffered()) return; // we already exited
     HttpHeaderBlock headers;
     headers[":status"] = "404";
     headers["content-length"] = absl::StrCat(strlen(kNotFoundResponseBody));
@@ -375,6 +377,7 @@ namespace quic
     {
       StopReading();
     }
+    if (fin_buffered()) return; // we already exited
     HttpHeaderBlock headers;
     if (resp_code <= 0)
     {
@@ -392,6 +395,7 @@ namespace quic
       HttpHeaderBlock response_headers,
       absl::string_view body)
   {
+    if (fin_buffered()) return; // we already exited
     QUIC_DLOG(INFO) << "Stream " << id() << " writing headers (fin = false) : "
                     << response_headers.DebugString();
     WriteHeaders(std::move(response_headers), /*fin=*/false, nullptr);
@@ -410,6 +414,7 @@ namespace quic
       HttpHeaderBlock response_headers,
       absl::string_view body)
   {
+    if (fin_buffered()) return; // we already exited
     SendHeadersAndBodyAndTrailers(std::move(response_headers), body,
                                   HttpHeaderBlock());
   }
@@ -419,6 +424,7 @@ namespace quic
       absl::string_view body,
       HttpHeaderBlock response_trailers)
   {
+    if (fin_buffered()) return; // we already exited
     // Send the headers, with a FIN if there's nothing else to send.
     bool send_fin = (body.empty() && response_trailers.empty());
     QUIC_DLOG(INFO) << "Stream " << id() << " writing headers (fin = " << send_fin