@fails-components/webtransport-transport-http3-quiche 1.4.0 → 1.4.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@fails-components/webtransport-transport-http3-quiche",
-  "version": "1.4.0",
+  "version": "1.4.1",
   "description": "A component to add webtransport support (server and client) to node.js, transport using libquiche",
   "exports": {
     ".": {

package/src/http3serversession.cc

@@ -109,20 +109,6 @@ namespace quic
     return stream;
   }
 
-  Http3ServerStream *
-  Http3ServerSession::CreateOutgoingUnidirectionalStream()
-  {
-    if (!ShouldCreateOutgoingUnidirectionalStream())
-    {
-      return nullptr;
-    }
-
-    Http3ServerStream *stream = new Http3ServerStream(
-        GetNextOutgoingUnidirectionalStreamId(), this, WRITE_UNIDIRECTIONAL,
-        http3_server_backend_);
-    ActivateStream(absl::WrapUnique(stream));
-    return stream;
-  }
 
   void Http3ServerSession::OnCanCreateNewOutgoingStream(bool unidirectional) {
     if (SupportsWebTransport()) {

package/src/http3serversession.h

@@ -63,7 +63,6 @@ namespace quic
     QuicSpdyStream *CreateIncomingStream(QuicStreamId id) override;
     QuicSpdyStream *CreateIncomingStream(PendingStream *pending) override;
     QuicSpdyStream *CreateOutgoingBidirectionalStream() override;
-    Http3ServerStream *CreateOutgoingUnidirectionalStream() override;
 
     // QuicServerSessionBaseMethod:
     std::unique_ptr<QuicCryptoServerStreamBase> CreateQuicCryptoServerStream(

package/src/http3wtstreamvisitor.cc

@@ -138,10 +138,11 @@ namespace quic
         while (chunks_.size() > 0)
         {
             auto cur = chunks_.front();
-            bool success = stream_->Write(absl::string_view(cur.buffer, cur.len));
+            absl::Status status = 
+                WriteIntoStream(*stream_, absl::string_view(cur.buffer, cur.len));
             QUIC_DVLOG(1) << "Attempted writing on WebTransport bidirectional stream "
-                          << ", success: " << (success ? "yes" : "no");
-            if (!success)
+                          << ", success: " << status;
+            if (!status.ok())
             {
                 return;
             }
@@ -153,8 +154,8 @@ namespace quic
 
         if (send_fin_)
         {
-            bool success = stream_->SendFin();
-            if (success) {
+            absl::Status status = SendFinOnStream(*stream_);
+            if (status.ok()) {
                 fin_was_sent_ = true;
                 getJS()->processStreamNetworkFinish(NetworkTask::streamFinal);
             }