@fails-components/webtransport-transport-http3-quiche 1.0.10 → 1.1.0

package/CMakeLists.txt

@@ -539,6 +539,8 @@ third_party/quiche/quiche/quic/core/http/quic_spdy_stream.cc
 third_party/quiche/quiche/quic/core/http/quic_spdy_stream.h
 third_party/quiche/quiche/quic/core/http/quic_spdy_stream_body_manager.cc
 third_party/quiche/quiche/quic/core/http/quic_spdy_stream_body_manager.h
+third_party/quiche/quiche/quic/core/http/metadata_decoder.cc
+third_party/quiche/quiche/quic/core/http/metadata_decoder.h
 third_party/quiche/quiche/quic/core/http/spdy_utils.cc
 third_party/quiche/quiche/quic/core/http/spdy_utils.h
 third_party/quiche/quiche/quic/core/http/web_transport_http3.cc

package/dist/lib/index.d.ts

@@ -1,11 +1,12 @@
 export const wtrouter: any;
 export const quicheInit: any;
 export function checkQuicheInit(args?: {
-    quicheLogVerbose?: number | undefined;
+    quicheLogVerbose?: import("./types.js").QUICHE_LOG | undefined;
     path?: string | undefined;
 } | undefined): void;
 export const Http3WebTransportClient: any;
 export const Http3WebTransportServer: any;
 export { Http3WebTransportClientSocket } from "./clientsocket.js";
 export { Http3WebTransportServerSocket } from "./serversocket.js";
+export type QUICHE_LOG = import('./types.js').QUICHE_LOG;
 //# sourceMappingURL=index.d.ts.map

package/dist/lib/index.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../lib/index.js"],"names":[],"mappings":"AA0BA,2BAAuC;AACvC,6BAA6C;AAOtC;;;qBAON;AAED,0CAAuE;AACvE,0CAAuE"}
+{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../lib/index.js"],"names":[],"mappings":"AA8BA,2BAAuC;AACvC,6BAA6C;AAOtC;;;qBAON;AAED,0CAAuE;AACvE,0CAAuE;;;yBAxC1D,OAAO,YAAY,EAAE,UAAU"}

package/dist/lib/socket.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"socket.d.ts","sourceRoot":"","sources":["../../lib/socket.js"],"names":[],"mappings":"AAqEA;IACE;;OAEG;IACH,kBAFW,OAAO,4BAA4B,EAAE,oBAAoB,GAAC,SAAS,EAa7E;IAVC,0CAA0C;IAE1C,WAFW,OAAO,YAAY,EAAE,MAAM,CAEZ;IAE1B,UAAqB;IACrB,oBAAuB;IAgCzB,qBAKC;IA9BD,+BAGC;IAPC,iBAAoB;IACpB,gBAAmB;IAQrB;;OAEG;IAEH,mDAHW,OAAO,SAAS,EAAE,mBAAmB,WAiB/C;CAQF"}
+{"version":3,"file":"socket.d.ts","sourceRoot":"","sources":["../../lib/socket.js"],"names":[],"mappings":"AAqEA;IACE;;OAEG;IACH,kBAFW,OAAO,4BAA4B,EAAE,oBAAoB,GAAC,SAAS,EAa7E;IAVC,0CAA0C;IAE1C,WAFW,OAAO,YAAY,EAAE,MAAM,CAEZ;IAE1B,UAAqB;IACrB,oBAAuB;IAgCzB,qBASC;IAlCD,+BAGC;IAPC,iBAAoB;IACpB,gBAAmB;IAQrB;;OAEG;IAEH,mDAHW,OAAO,SAAS,EAAE,mBAAmB,WAiB/C;CAYF"}

package/dist/lib/types.d.ts

@@ -11,10 +11,16 @@ export interface Logger {
     error: (formatter: any, ...args: any[]) => void;
     trace: (formatter: any, ...args: any[]) => void;
 }
+export type QUICHE_LOG_OFF = -1;
+export type QUICHE_LOG_INFO = 0;
+export type QUICHE_LOG_WARNING = 1;
+export type QUICHE_LOG_ERROR = 2;
+export type QUICHE_LOG_FATAL = 3;
+export type QUICHE_LOG = QUICHE_LOG_OFF | QUICHE_LOG_INFO | QUICHE_LOG_WARNING | QUICHE_LOG_ERROR | QUICHE_LOG_FATAL;
 export interface HttpWebTransportInit extends WebTransportOptions {
     host: string;
     port: string | number;
-    quicheLogVerbose?: number;
+    quicheLogVerbose?: QUICHE_LOG;
     forceIpv6?: boolean;
     localPort?: number;
 }

package/dist/lib/types.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"types.d.ts","sourceRoot":"","sources":["../../lib/types.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EACV,mBAAmB,EACpB,MAAM,uBAAuB,CAAA;AAE9B,MAAM,WAAW,mBAAmB;IAChC,GAAG,EAAG,UAAU,CAAA;IAChB,MAAM,EAAE,MAAM,CAAA;IACd,MAAM,EAAE,MAAM,CAAA;IACd,IAAI,EAAC,MAAM,CAAA;IACX,OAAO,EAAE,MAAM,CAAA;CAChB;AAED,MAAM,WAAW,MAAM;IACrB,CAAC,SAAS,EAAE,GAAG,EAAE,GAAG,IAAI,EAAE,GAAG,EAAE,GAAG,IAAI,CAAA;IACtC,KAAK,EAAE,CAAC,SAAS,EAAE,GAAG,EAAE,GAAG,IAAI,EAAE,GAAG,EAAE,KAAK,IAAI,CAAA;IAC/C,KAAK,EAAE,CAAC,SAAS,EAAE,GAAG,EAAE,GAAG,IAAI,EAAE,GAAG,EAAE,KAAK,IAAI,CAAA;CAChD;AAED,MAAM,WAAW,oBAAqB,SAAQ,mBAAmB;IAC/D,IAAI,EAAE,MAAM,CAAA;IACZ,IAAI,EAAE,MAAM,GAAG,MAAM,CAAA;IACrB,gBAAgB,CAAC,EAAE,MAAM,CAAA;IACzB,SAAS,CAAC,EAAE,OAAO,CAAA;IACnB,SAAS,CAAC,EAAE,MAAM,CAAA;CACnB"}
+{"version":3,"file":"types.d.ts","sourceRoot":"","sources":["../../lib/types.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EACV,mBAAmB,EACpB,MAAM,uBAAuB,CAAA;AAE9B,MAAM,WAAW,mBAAmB;IAChC,GAAG,EAAG,UAAU,CAAA;IAChB,MAAM,EAAE,MAAM,CAAA;IACd,MAAM,EAAE,MAAM,CAAA;IACd,IAAI,EAAC,MAAM,CAAA;IACX,OAAO,EAAE,MAAM,CAAA;CAChB;AAED,MAAM,WAAW,MAAM;IACrB,CAAC,SAAS,EAAE,GAAG,EAAE,GAAG,IAAI,EAAE,GAAG,EAAE,GAAG,IAAI,CAAA;IACtC,KAAK,EAAE,CAAC,SAAS,EAAE,GAAG,EAAE,GAAG,IAAI,EAAE,GAAG,EAAE,KAAK,IAAI,CAAA;IAC/C,KAAK,EAAE,CAAC,SAAS,EAAE,GAAG,EAAE,GAAG,IAAI,EAAE,GAAG,EAAE,KAAK,IAAI,CAAA;CAChD;AAEH,MAAM,MAAM,cAAc,GAAG,CAAC,CAAC,CAAA;AAC/B,MAAM,MAAM,eAAe,GAAG,CAAC,CAAA;AAC/B,MAAM,MAAM,kBAAkB,GAAG,CAAC,CAAA;AAClC,MAAM,MAAM,gBAAgB,GAAG,CAAC,CAAA;AAChC,MAAM,MAAM,gBAAgB,GAAG,CAAC,CAAA;AAChC,MAAM,MAAM,UAAU,GAAG,cAAc,GAAG,eAAe,GAAG,kBAAkB,GAAG,gBAAgB,GAAG,gBAAgB,CAAA;AAElH,MAAM,WAAW,oBAAqB,SAAQ,mBAAmB;IAC/D,IAAI,EAAE,MAAM,CAAA;IACZ,IAAI,EAAE,MAAM,GAAG,MAAM,CAAA;IACrB,gBAAgB,CAAC,EAAE,UAAU,CAAA;IAC7B,SAAS,CAAC,EAAE,OAAO,CAAA;IACnB,SAAS,CAAC,EAAE,MAAM,CAAA;CACnB"}

package/lib/index.js

@@ -5,6 +5,10 @@ import * as url from 'url'
 import { arch, platform } from 'node:process'
 import { logger } from './utils.js'
 
+/**
+ * @typedef {import('./types.js').QUICHE_LOG} QUICHE_LOG
+ */
+
 const log = logger(`webtransport:native(${process?.pid})`)
 
 const binplatform = platform + '_' + arch
@@ -30,7 +34,7 @@ export const quicheInit = wtrouter.quicheInit
 let quicheInited = false
 
 /**
- * @param {{quicheLogVerbose?: Number, path?: string}} [args]
+ * @param {{quicheLogVerbose?: QUICHE_LOG, path?: string}} [args]
  */
 export const checkQuicheInit = function (args) {
   if (!quicheInited) {

package/lib/socket.js

@@ -110,8 +110,12 @@ export class Http3WebTransportSocket {
   }
 
   packetSendCB() {
-    // @ts-ignore
-    if (this.socketInt.getSendQueueCount() === 0 && this.blocked) {
+    if (
+      !this.closed &&
+      // @ts-ignore
+      this.socketInt.getSendQueueCount() === 0 &&
+      this.blocked
+    ) {
       this.cobj.onCanWrite()
     }
   }

package/lib/types.ts

@@ -16,11 +16,17 @@ export interface UDPServerSocketSend {
     trace: (formatter: any, ...args: any[]) => void
   }
 
+export type QUICHE_LOG_OFF = -1
+export type QUICHE_LOG_INFO = 0
+export type QUICHE_LOG_WARNING = 1
+export type QUICHE_LOG_ERROR = 2
+export type QUICHE_LOG_FATAL = 3
+export type QUICHE_LOG = QUICHE_LOG_OFF | QUICHE_LOG_INFO | QUICHE_LOG_WARNING | QUICHE_LOG_ERROR | QUICHE_LOG_FATAL
+
   export interface HttpWebTransportInit extends WebTransportOptions {
     host: string
     port: string | number
-    quicheLogVerbose?: number
+    quicheLogVerbose?: QUICHE_LOG
     forceIpv6?: boolean
     localPort?: number
   }
-  

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@fails-components/webtransport-transport-http3-quiche",
-  "version": "1.0.10",
+  "version": "1.1.0",
   "description": "A component to add webtransport support (server and client) to node.js, transport using libquiche",
   "exports": {
     ".": {

package/src/http3client.cc

@@ -532,7 +532,7 @@ namespace quic
             if (wait_for_encryption_)
             {
                 if (EncryptionBeingEstablished())
-                    return false;
+                    return true;
                 wait_for_encryption_ = false;
                 ParsedQuicVersion version = UnsupportedQuicVersion();
                 if (session_ != nullptr && !CanReconnectWithDifferentVersion(&version) && !session_->connection()->connected())
@@ -569,11 +569,6 @@ namespace quic
                 recheck = true;
         }
 
-        if (checkSession())
-        {
-            recheck = true;
-        }
-
         return recheck;
     }
 
@@ -826,16 +821,18 @@ namespace quic
 
         if (client_->connectionrecheck_)
         {
-            client_->connectionrecheck_ = !client_->handleConnecting();
+            client_->connectionrecheck_ = client_->handleConnecting();
         }
+        if (client_->needsToCheckForSession()) client_->checkSession();
     }
 
     void Http3ClientJS::onCanWrite(const Napi::CallbackInfo &info)
     {
         if (client_->connectionrecheck_)
         {
-            client_->connectionrecheck_ = !client_->handleConnecting();
+            client_->connectionrecheck_ = client_->handleConnecting();
         }
+        if (client_->needsToCheckForSession()) client_->checkSession();
         client_->OnCanWrite();
     }
 

package/src/http3client.h

@@ -349,6 +349,10 @@ namespace quic
 
         bool checkSession();
 
+        bool needsToCheckForSession() {
+            return finish_stream_open_.size() > 0 && session_->CanOpenNextOutgoingBidirectionalStream();
+        }
+
         // Read oldest received response and remove it from closed_stream_states_.
         // void ReadNextResponse();
 

package/src/http3server.cc

@@ -91,8 +91,8 @@ namespace quic
   Http3ServerJS::Http3ServerJS(const Napi::CallbackInfo &info) : Napi::ObjectWrap<Http3ServerJS>(info)
   {
     std::string secret;
-    std::string cert;
-    std::string privkey;
+    std::vector<std::string> cert;
+    std::vector<std::string> privkey;
 
     QuicConfig sconfig;
     if (!info[0].IsUndefined())
@@ -113,7 +113,16 @@ namespace quic
         if (lobj.Has("cert") && !(lobj).Get("cert").IsEmpty())
         {
           Napi::Value certValue = (lobj).Get("cert");
-          cert = certValue.ToString().Utf8Value();
+          if (!certValue.IsArray()) {
+            cert.push_back(certValue.ToString().Utf8Value());
+          } else {
+            Napi::Array  certArray = certValue.As<Napi::Array>();
+            if (certArray.Length() < 1) Napi::Error::New(Env(), "No cert in array for Http3Server").ThrowAsJavaScriptException();
+            for (uint32_t i = 0; i < certArray.Length(); i++) {
+              Napi::Value curval = certArray.Get(i);
+              cert.push_back(curval.ToString().Utf8Value()); 
+            }
+          }
         }
         else
         {
@@ -123,13 +132,23 @@ namespace quic
         if (lobj.Has("privKey") && !(lobj).Get("privKey").IsEmpty())
         {
           Napi::Value keyValue = (lobj).Get("privKey");
-          privkey = keyValue.ToString().Utf8Value();
+          if (!keyValue.IsArray()) {
+            privkey.push_back(keyValue.ToString().Utf8Value());
+          } else {
+            Napi::Array  keyArray = keyValue.As<Napi::Array>();
+            if (keyArray.Length() < 1) Napi::Error::New(Env(), "No key in array for Http3Server").ThrowAsJavaScriptException();
+            for (uint32_t i = 0; i < keyArray.Length(); i++) {
+              Napi::Value curval = keyArray.Get(i);
+              privkey.push_back(curval.ToString().Utf8Value()); 
+            }
+          }
         }
         else
         {
           Napi::Error::New(Env(), "No privKey set for Http3Server").ThrowAsJavaScriptException();
           return;
         }
+        if (privkey.size() != cert.size()) Napi::Error::New(Env(), "Key and cert array length for Http3Server do not match").ThrowAsJavaScriptException();
         if (lobj.Has("maxConnections") && !(lobj).Get("maxConnections").IsEmpty())
         {
           Napi::Value maxconnValue = (lobj).Get("maxConnections");
@@ -176,10 +195,10 @@ namespace quic
       }
       // Callback *callback, int port, std::unique_ptr<ProofSource> proof_source,  const char *secret
 
-      std::stringstream certstream(cert, std::ios_base::in);
+      std::stringstream certstream(cert[0], std::ios_base::in);
       quiche::QuicheReferenceCountedPointer<ProofSource::Chain> chain(new ProofSource::Chain(CertificateView::LoadPemFromStream(&certstream)));
 
-      std::stringstream privkeystream(privkey, std::ios_base::in);
+      std::stringstream privkeystream(privkey[0], std::ios_base::in);
 
       auto certprivkey = CertificatePrivateKey::LoadPemFromStream(&privkeystream);
       if (certprivkey == nullptr)
@@ -194,6 +213,25 @@ namespace quic
         Napi::Error::New(Env(), "LoadPemFromStream cert failed for Http3Server").ThrowAsJavaScriptException();
         return;
       }
+      // add additional certs to proof source
+      for (size_t i = 1; i < cert.size(); i++)
+      {
+        std::stringstream addcertstream(cert[0], std::ios_base::in);
+        quiche::QuicheReferenceCountedPointer<ProofSource::Chain> addchain(new ProofSource::Chain(CertificateView::LoadPemFromStream(&addcertstream)));
+        std::stringstream addprivkeystream(privkey[0], std::ios_base::in);
+        auto addcertprivkey = CertificatePrivateKey::LoadPemFromStream(&privkeystream);
+        if (addcertprivkey == nullptr)
+        {
+          Napi::Error::New(Env(), "LoadPemFromStream addprivKey  failed for Http3Server").ThrowAsJavaScriptException();
+          return;
+        }
+
+        if (!proofsource->AddCertificateChain(addchain, std::move(*addcertprivkey)))
+        {
+          Napi::Error::New(Env(), "AddCertificateChain failed for Http3Server").ThrowAsJavaScriptException();
+          return;
+        }
+      }
 
       server_ = std::make_unique<Http3Server>(this, std::move(proofsource), secret.c_str(), sconfig);
 
@@ -207,7 +245,7 @@ namespace quic
   }
 
   Http3ServerJS::~Http3ServerJS()
-  {  
+  {
   }
 
   void Http3ServerJS::destroy(const Napi::CallbackInfo &info)
@@ -357,7 +395,7 @@ namespace quic
     }
   }*/
 
-  void Http3ServerJS::processNewSession(Http3WTSession *session, const std::string &path, Napi::Reference<Napi::Value> *header)
+  void Http3ServerJS::processNewSession(Http3WTSession *session, const std::string &path, Napi::Reference<Napi::Value> *header, Napi::Reference<Napi::Value> *userData)
   {
     Napi::HandleScope scope(Env());
 
@@ -378,12 +416,17 @@ namespace quic
       retObj.Set("header", header->Value());
       header->Unref();
     }
+    if (userData)
+    {
+      retObj.Set("userData", userData->Value());
+      userData->Unref();
+    }
     objVal.Get("onHttpWTSessionVisitor")
         .As<Napi::Function>()
         .Call(objVal, {retObj});
   }
 
-  void Http3ServerJS::processNewSessionRequest(WebTransportSession *session, const spdy::Http2HeaderBlock &reqhead, WebTransportRespPromisePtr *promise)
+  void Http3ServerJS::processNewSessionRequest(WebTransportSession *session, const spdy::Http2HeaderBlock &reqhead, WebTransportRespPromisePtr promise)
   {
     Napi::HandleScope scope(Env());
 
@@ -401,10 +444,11 @@ namespace quic
     }
     retObj.Set("header", headObj);
     // delete reqheadcopy; // we own it and must free it!
-
+    
+    WebTransportRespPromisePtr *prompointer = new WebTransportRespPromisePtr(promise);
     // promise
     Napi::External<WebTransportRespPromisePtr> promObj =
-        Napi::External<WebTransportRespPromisePtr>::New(Env(), promise,
+        Napi::External<WebTransportRespPromisePtr>::New(Env(), prompointer,
                                                         [](Napi::Env /*env*/, WebTransportRespPromisePtr *ref)
                                                         {
                                                           delete ref; // we own it and must delete it
@@ -419,6 +463,7 @@ namespace quic
                                                    // does it outlife everything?
                                                  });
     retObj.Set("session", wtsObj);
+    retObj.Set("protocol", "http3:libquiche");
 
     objVal.Get("onSessionRequest")
         .As<Napi::Function>()
@@ -465,7 +510,7 @@ namespace quic
           path = pathValue.ToString().Utf8Value();
         }
         else
-          return Napi::Error::New(Env(), "No status code passed for finishSessionRequest").ThrowAsJavaScriptException();
+          return Napi::Error::New(Env(), "No path passed for finishSessionRequest").ThrowAsJavaScriptException();
         WebTransportSession *session = nullptr;
         if (lobj.Has("session") && !(lobj).Get("session").IsEmpty())
         {
@@ -487,6 +532,7 @@ namespace quic
 
           Http3ServerBackend::WebTransportRespPromisePtr *prom = promise.Data();
           Napi::Reference<Napi::Value> *headerValue = nullptr;
+          Napi::Reference<Napi::Value> *userDataValue = nullptr;
           if (status == 200)
           {
 
@@ -498,7 +544,14 @@ namespace quic
               headerValue = new Napi::Reference<Napi::Value>(Env(), ref);
             }
             else
-              return Napi::Error::New(Env(), "No status code passed for finishSessionRequest").ThrowAsJavaScriptException();
+              return Napi::Error::New(Env(), "No header passed for finishSessionRequest").ThrowAsJavaScriptException();
+            if (lobj.Has("userData") && !(lobj).Get("userData").IsEmpty())
+            {
+              napi_ref ref;
+              napi_status status = napi_create_reference(Env(), lobj.Get("userData"), 1, &ref);
+              NAPI_THROW_IF_FAILED(Env(), status, Reference<Napi::Value>());
+              userDataValue = new Napi::Reference<Napi::Value>(Env(), ref);
+            }
           }
           if (status != 200)
           {
@@ -514,7 +567,7 @@ namespace quic
             wtsession->init(session);
             response->visitor =
                 std::make_unique<Http3WTSession::Visitor>(wtsession);
-            processNewSession(static_cast<Http3WTSession *>(wtsession), path, headerValue);
+            processNewSession(static_cast<Http3WTSession *>(wtsession), path, headerValue, userDataValue);
             (*prom)->resolve(std::move(response));
           }
         }

package/src/http3server.h

@@ -84,8 +84,8 @@ namespace quic
             exports.Set("Http3WebTransportServer", tplsrv);
         }
 
-        void processNewSession(Http3WTSession *session, const std::string &path, Napi::Reference<Napi::Value> *header);
-        void processNewSessionRequest(WebTransportSession *session, const spdy::Http2HeaderBlock &reqheadcopy, WebTransportRespPromisePtr *promise);
+        void processNewSession(Http3WTSession *session, const std::string &path, Napi::Reference<Napi::Value> *header, Napi::Reference<Napi::Value> *userData);
+        void processNewSessionRequest(WebTransportSession *session, const spdy::Http2HeaderBlock &reqheadcopy, WebTransportRespPromisePtr promise);
 
     protected:
         std::unique_ptr<Http3Server> server_;

package/src/http3serverbackend.cc

@@ -67,27 +67,28 @@ namespace quic
     }
     std::string path(path_it->second);
 
+    if (jshandlerequesthandler_)
+    {
+      // first step pass header block along, due to thread safety, we need to copy
+      // not necessary anymore
+
+      // second step inform the js side
+      server_->getJS()->processNewSessionRequest(session, request_headers, promise);
+      return promise;
+    } 
+    
     if (paths_.find(path) != paths_.end())
-    { // to do handle our web transport paths
+    { // to do handle our web transport paths, if no handler is present
       std::unique_ptr<WebTransportResponse> response = std::make_unique<WebTransportResponse>();
       Http3WTSession *wtsession = new Http3WTSession();
       wtsession->init(session);
       response->response_headers[":status"] = "200";
       response->visitor =
           std::make_unique<Http3WTSession::Visitor>(wtsession);
-      server_->getJS()->processNewSession(static_cast<Http3WTSession *>(wtsession), path, nullptr);
+      server_->getJS()->processNewSession(static_cast<Http3WTSession *>(wtsession), path, nullptr, nullptr);
       promise->resolve(std::move(response));
       return promise;
     }
-    else if (jshandlerequesthandler_)
-    {
-      // first step pass header block along, due to thread safety, we need to copy
-      // not necessary anymore
-
-      // second step inform the js side
-      server_->getJS()->processNewSessionRequest(session, request_headers, &promise);
-      return promise;
-    }
 
     std::unique_ptr<WebTransportResponse> response = std::make_unique<WebTransportResponse>();
     response->response_headers[":status"] = "404";

package/src/http3wtstreamvisitor.cc

@@ -83,34 +83,46 @@ namespace quic
     void Http3WTStream::doCanRead()
     {
         // if (pause_reading_) return ; // back pressure folks!
+        WebTransportStream::PeekResult pr;
+        pr = stream_->PeekNextReadableRegion();
+
+        if (pr.fin_next && pr.peeked_data.size() == 0) {
+            bool fin = stream_->SkipBytes(0);
+            if (fin) {
+                getJS()->signalFinOnly();
+                return;
+            }
+        }
 
         if (pause_reading_ && !drain_reads_)
         {
             can_read_pending_ = true;
             return; // back pressure folks!
         }
-        size_t readable = stream_->ReadableBytes();
         bool read = false;
-        while (readable > 0)
+        while (!pr.peeked_data.empty())
         {
             Http3WTStreamJS::StreamReadBuffer rbuf(js_);
-            rbuf.getBuffer(readable);
+            rbuf.getBuffer(stream_->ReadableBytes());
 
             size_t remainSize = rbuf.bufferSize();
             uint32_t writepos = 0;
 
-            while (readable > 0 && remainSize > 0) {
-                size_t len = remainSize;
-                WebTransportStream::ReadResult result =
-                    stream_->Read(absl::Span<char>(((char *)rbuf.bufferData()) + writepos, len));
+            while (!pr.peeked_data.empty() && remainSize > 0) {
+                size_t len = std::min(remainSize, pr.peeked_data.size());
+                if (len > 0) memcpy(((char *)rbuf.bufferData()) + writepos,pr.peeked_data.data(), len);
+                bool fin = stream_->SkipBytes(len);
                 QUIC_DVLOG(1) << "Attempted reading on WebTransport stream "
-                              << ", bytes read: " << result.bytes_read;
-                writepos += result.bytes_read;
-                remainSize -= result.bytes_read;
-                readable = stream_->ReadableBytes();
-                if (result.fin) rbuf.setFin();
+                              << ", bytes read: " << len;       
+                writepos += len;
+                remainSize -= len;
+                pr =  stream_->PeekNextReadableRegion();
+                if (fin) {
+                    rbuf.setFin();
+                    break;
+                }
             }
-            rbuf.commitBuffer(writepos, readable == 0);
+            rbuf.commitBuffer(writepos, pr.has_data());
         }
     }
 
@@ -142,8 +154,10 @@ namespace quic
         if (send_fin_)
         {
             bool success = stream_->SendFin();
-            if (success)
+            if (success) {
                 fin_was_sent_ = true;
+                getJS()->processStreamNetworkFinish(NetworkTask::streamFinal);
+            }
         }
     }
 
@@ -165,6 +179,17 @@ namespace quic
         }
     }
 
+    
+    void  Http3WTStreamJS::signalFinOnly() {
+        Napi::HandleScope scope(Env());
+        Napi::Object retObj = Napi::Object::New(Env());
+        Napi::Object objVal = Value().Get("jsobj").As<Napi::Object>();
+        retObj.Set("fin", true);
+        Napi::Value bufferVal = objVal.Get("commitReadBuffer").As<Napi::Function>().Call(objVal, {retObj});
+    }
+
+    
+
     void Http3WTStreamJS::processStreamNetworkFinish(NetworkTask task)
     {
         Napi::HandleScope scope(Env());

package/src/http3wtstreamvisitor.h

@@ -317,6 +317,7 @@ namespace quic
         void processStreamWrite(Napi::ObjectReference *bufferhandle, bool success);
         void processStreamNetworkFinish(NetworkTask task);
         void processStreamRecvSignal(WebTransportStreamError error_code, NetworkTask task);
+        void signalFinOnly();
     };
 }
 

package/src/librarymain.cc

@@ -38,7 +38,7 @@ namespace quic
       }
 
       quiche_cmd_line.push_back(std::string("-v"));
-      if (lobj.Has("quicheLogVerbose") && lobj.Get("quicheLogVerbose").IsFunction())
+      if (lobj.Has("quicheLogVerbose") && lobj.Get("quicheLogVerbose").IsNumber())
       {
         Napi::Value verboseValue = (lobj).Get("quicheLogVerbose");
         quiche_cmd_line.push_back(verboseValue.ToString().Utf8Value());

package/src/napialarmfactory.h

@@ -134,10 +134,17 @@ namespace quic
         alarmref_.Unref();
         timerset_ = false;
       }
+      auto val =  Napi::Value::From(alarmjs_->Env(), timedelay);
+      // Workaround for problem on windows plattform
+      if (val.ToNumber().DoubleValue() != timedelay) { 
+        // printf("val %lg %lg\n", val.ToNumber().DoubleValue(), timedelay);
+        val =  Napi::Value::From(alarmjs_->Env(), timedelay);
+        // printf("val2 %lg %lg\n", val.ToNumber().DoubleValue(), timedelay);
+      }
 
       Napi::Value timeoutobj = NapiAlarmJS::FAILSsetTimeoutAlarm_.Call({
           alarmjs_->Value().As<Napi::Object>(),
-          Napi::Value::From(alarmjs_->Env(), timedelay),
+          val,
       });
       alarmref_ = Napi::Reference<Napi::Object>::New(timeoutobj.As<Napi::Object>(), 1);
       timerset_ = true;