@fails-components/jupyter-interceptor 0.0.5 → 0.0.6

package/README.md

@@ -74,29 +74,3 @@ pip uninstall fails_components_jupyter_interceptor
 In development mode, you will also need to remove the symlink created by `jupyter labextension develop`
 command. To find its location, you can run `jupyter labextension list` to figure out where the `labextensions`
 folder is located. Then you can remove the symlink named `@fails-components/jupyter-applet-view` within that folder.
-
-### Testing the extension
-
-#### Frontend tests
-
-This extension is using [Jest](https://jestjs.io/) for JavaScript code testing.
-
-To execute them, execute:
-
-```sh
-jlpm
-jlpm test
-```
-
-<!--
-#### Integration tests
-
-This extension uses [Playwright](https://playwright.dev/docs/intro) for the integration tests (aka user level tests).
-More precisely, the JupyterLab helper [Galata](https://github.com/jupyterlab/jupyterlab/tree/master/galata) is used to handle testing the extension in JupyterLab.
-
-More information are provided within the [ui-tests](./ui-tests/README.md) README.
-
-### Packaging the extension
-
-See [RELEASE](RELEASE.md)
--->

package/lib/index.d.ts

@@ -1,6 +1,7 @@
-import { JupyterFrontEndPlugin } from '@jupyterlab/application';
-import { WidgetModel } from '@jupyter-widgets/base';
-import { IFailsInterceptorUpdateMessage, IAppletWidgetRegistry, IFailsLauncherInfo } from '@fails-components/jupyter-launcher';
+import type { JupyterFrontEndPlugin } from '@jupyterlab/application';
+import type { WidgetModel } from '@jupyter-widgets/base';
+import type { IFailsInterceptorUpdateMessage, IAppletWidgetRegistry } from '@fails-components/jupyter-launcher';
+import { IFailsLauncherInfo } from '@fails-components/jupyter-launcher';
 export * from './tokens';
 export declare class AppletWidgetRegistry implements IAppletWidgetRegistry {
     constructor(launcher: IFailsLauncherInfo);

package/lib/index.js

@@ -138,19 +138,19 @@ function activateWidgetInterceptor(app, notebookTracker, rendermimeRegistry, lau
         mimetypes.forEach(mime => {
             const factory = rmRegistry.getFactory(mime);
             if (!factory) {
-                console.log('Plotly seems to be not installed! So I can not add an interceptor');
+                console.warn('Plotly seems to be not installed! So I can not add an interceptor');
                 return;
             }
             // ok, lets add an interceptor
             const createRendererOld = factory.createRenderer;
             factory.createRenderer = function (options) {
                 const renderer = createRendererOld(options);
-                console.log('intercepted renderer', mime, renderer, renderer.node);
+                // console.log('intercepted renderer', mime, renderer, renderer.node);
                 // we have also the replace renderModel
                 const renderModelOld = renderer.renderModel.bind(renderer);
                 renderer.renderModel = async (model) => {
                     let result = await renderModelOld(model);
-                    console.log('intercepted renderer model', model);
+                    // console.log('intercepted renderer model', model);
                     if (!renderer.hasGraphElement()) {
                         result = await renderer.createGraph(renderer === null || renderer === void 0 ? void 0 : renderer._model);
                     }
@@ -165,7 +165,7 @@ function activateWidgetInterceptor(app, notebookTracker, rendermimeRegistry, lau
                         ];
                         messages.forEach(mess => {
                             renderer.node.on('plotly_' + mess, (data) => {
-                                var _a, _b;
+                                var _a;
                                 const path = (_a = model.metadata) === null || _a === void 0 ? void 0 : _a.appPath;
                                 if (path) {
                                     wRegistry.dispatchMessage({
@@ -174,22 +174,20 @@ function activateWidgetInterceptor(app, notebookTracker, rendermimeRegistry, lau
                                         state: data
                                     });
                                 }
-                                console.log('plotly', mess, data, (_b = model.metadata) === null || _b === void 0 ? void 0 : _b.appPath, path);
+                                /*
+                                console.log(
+                                  'plotly',
+                                  mess,
+                                  data,
+                                  model.metadata?.appPath,
+                                  path
+                                ); */
                             });
                         });
                     }
-                    console.log('renderer layout rM', 
-                    // @ts-expect-error plotly
-                    renderer.node.layout, 
-                    // @ts-expect-error plotly
-                    !!renderer.node.on, renderer);
-                    //@ts-expect-error result is different from void
-                    console.log('renderer result', result, !!(result === null || result === void 0 ? void 0 : result.on));
                     return result;
                 };
                 // special code for plotly
-                // @ts-expect-error plotly
-                console.log('renderer layout', renderer.node.layout);
                 /* if (!(renderer as any).hasGraphElement()) {
                     (renderer as any).createGraph((renderer as any)['_model]']);
                   } */
@@ -332,9 +330,6 @@ function activateWidgetInterceptor(app, notebookTracker, rendermimeRegistry, lau
                                                 // eslint-disable-next-line no-constant-condition
                                                 mimebundle['application/vnd.plotly.v1+json'] &&
                                                     false) {
-                                                    const bundle = mimebundle['application/vnd.plotly.v1+json'];
-                                                    console.log('Plotly bundle', bundle);
-                                                    console.log('plotly cell', cell);
                                                     if (result.metadata.appPath !== appPath) {
                                                         result.metadata.appPath = appPath;
                                                         addPath = true;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@fails-components/jupyter-interceptor",
-    "version": "0.0.5",
+    "version": "0.0.6",
     "description": "A collections of plugins intercepting kernel messages and other message, to steer outputs remotely",
     "keywords": [
         "jupyter",
@@ -34,8 +34,8 @@
     "scripts": {
         "build": "jlpm build:lib && jlpm build:labextension:dev",
         "build:prod": "jlpm clean && jlpm build:lib:prod && jlpm build:labextension",
-        "build:labextension": "jupyter labextension build .",
-        "build:labextension:dev": "jupyter labextension build --development True .",
+        "build:labextension": "jupyter-builder build .",
+        "build:labextension:dev": "jupyter-builder build --development True .",
         "build:lib": "tsc --sourceMap",
         "build:lib:prod": "tsc",
         "clean": "jlpm clean:lib",
@@ -60,33 +60,34 @@
         "watch:labextension": "jupyter labextension watch ."
     },
     "dependencies": {
-        "@fails-components/jupyter-launcher": "^0.0.5",
+        "@fails-components/jupyter-launcher": "^0.0.6",
         "@jupyter-widgets/base": "^6.0.11",
         "@jupyter-widgets/jupyterlab-manager": "^5.0.15",
-        "@jupyter/ydoc": "^3.1.0",
-        "@jupyterlab/application": "^4.5.1",
-        "@jupyterlab/cells": "^4.5.1",
-        "@jupyterlab/nbformat": "^4.5.1",
-        "@jupyterlab/notebook": "^4.5.1",
-        "@jupyterlab/rendermime": "^4.5.1",
-        "@jupyterlab/services": "^7.5.1",
-        "@jupyterlite/application-extension": "^0.7.1",
+        "@jupyter/ydoc": "^4.0.0",
+        "@jupyterlab/application": "~4.6.0",
+        "@jupyterlab/cells": "~4.6.0",
+        "@jupyterlab/nbformat": "~4.6.0",
+        "@jupyterlab/notebook": "~4.6.0",
+        "@jupyterlab/rendermime": "~4.6.0",
+        "@jupyterlab/services": "^7.6.0",
+        "@jupyterlite/application-extension": "^0.8.1",
         "@lumino/coreutils": "^2.2.2",
         "@lumino/signaling": "^2.1.5"
     },
     "devDependencies": {
-        "@jupyterlab/builder": "^4.5.1",
-        "@jupyterlab/testutils": "^4.5.1",
+        "@jupyter/builder": "~1.0.0",
+        "@jupyter/eslint-plugin": "0.0.5",
+        "@jupyterlab/testutils": "~4.6.0",
+        "@stylistic/eslint-plugin": "^5.10.0",
         "@types/jest": "^29.2.0",
         "@types/json-schema": "^7.0.11",
         "@types/react": "^18.0.26",
         "@types/react-addons-linked-state-mixin": "^0.14.22",
-        "@typescript-eslint/eslint-plugin": "^6.1.0",
-        "@typescript-eslint/parser": "^6.1.0",
         "css-loader": "^6.7.1",
-        "eslint": "^8.36.0",
-        "eslint-config-prettier": "^8.8.0",
-        "eslint-plugin-prettier": "^5.0.0",
+        "eslint": "^9.39.2",
+        "eslint-config-prettier": "^9.1.0",
+        "eslint-plugin-prettier": "^5.1.3",
+        "eslint-plugin-react": "^7.37.0",
         "jest": "^29.2.0",
         "npm-run-all": "^4.1.5",
         "prettier": "^3.0.0",
@@ -98,7 +99,8 @@
         "stylelint-config-standard": "^34.0.0",
         "stylelint-csstree-validator": "^3.0.0",
         "stylelint-prettier": "^4.0.0",
-        "typescript": "~5.0.2",
+        "typescript": "~5.9.3",
+        "typescript-eslint": "^8.0.0",
         "yjs": "^13.5.0"
     },
     "sideEffects": [
@@ -127,8 +129,7 @@
         "coverage",
         "**/*.d.ts",
         "tests",
-        "**/__tests__",
-        "ui-tests"
+        "**/__tests__"
     ],
     "eslintConfig": {
         "extends": [

package/src/index.ts

@@ -1,32 +1,26 @@
-import {
-  INotebookTracker,
-  NotebookPanel,
-  INotebookModel
-} from '@jupyterlab/notebook';
-import {
+import type { NotebookPanel, INotebookModel } from '@jupyterlab/notebook';
+import { INotebookTracker } from '@jupyterlab/notebook';
+import type {
   JupyterFrontEnd,
   JupyterFrontEndPlugin
 } from '@jupyterlab/application';
-import { IWidgetManager, WidgetModel } from '@jupyter-widgets/base';
-import {
+import type { IWidgetManager, WidgetModel } from '@jupyter-widgets/base';
+import type {
   IExecuteResult,
   IDisplayData,
   IDisplayUpdate
 } from '@jupyterlab/nbformat';
-import {
-  IRenderMime,
-  IRenderMimeRegistry,
-  RenderMimeRegistry
-} from '@jupyterlab/rendermime';
-import { ICellModel } from '@jupyterlab/cells';
-import { ISharedCodeCell } from '@jupyter/ydoc';
-import { JSONObject, PromiseDelegate } from '@lumino/coreutils';
-import { Kernel /*, KernelMessage */ } from '@jupyterlab/services';
-import {
+import type { IRenderMime, RenderMimeRegistry } from '@jupyterlab/rendermime';
+import { IRenderMimeRegistry } from '@jupyterlab/rendermime';
+import type { ICellModel } from '@jupyterlab/cells';
+import type { ISharedCodeCell } from '@jupyter/ydoc';
+import type { JSONObject, PromiseDelegate } from '@lumino/coreutils';
+import type { Kernel /*, KernelMessage */ } from '@jupyterlab/services';
+import type {
   IFailsInterceptorUpdateMessage,
-  IAppletWidgetRegistry,
-  IFailsLauncherInfo
+  IAppletWidgetRegistry
 } from '@fails-components/jupyter-launcher';
+import { IFailsLauncherInfo } from '@fails-components/jupyter-launcher';
 import { Signal } from '@lumino/signaling';
 import { IFailsInterceptor } from './tokens';
 
@@ -200,7 +194,7 @@ function activateWidgetInterceptor(
         mime
       ) as IRenderMime.IRendererFactory;
       if (!factory) {
-        console.log(
+        console.warn(
           'Plotly seems to be not installed! So I can not add an interceptor'
         );
         return;
@@ -211,12 +205,12 @@ function activateWidgetInterceptor(
         options: IRenderMime.IRendererOptions
       ) {
         const renderer = createRendererOld(options);
-        console.log('intercepted renderer', mime, renderer, renderer.node);
+        // console.log('intercepted renderer', mime, renderer, renderer.node);
         // we have also the replace renderModel
         const renderModelOld = renderer.renderModel.bind(renderer);
         renderer.renderModel = async (model: IRenderMime.IMimeModel) => {
           let result = await renderModelOld(model);
-          console.log('intercepted renderer model', model);
+          // console.log('intercepted renderer model', model);
           if (!(<any>renderer).hasGraphElement()) {
             result = await (renderer as any).createGraph(
               (renderer as any)?._model
@@ -241,32 +235,21 @@ function activateWidgetInterceptor(
                     state: data
                   });
                 }
+                /*
                 console.log(
                   'plotly',
                   mess,
                   data,
                   model.metadata?.appPath,
                   path
-                );
+                ); */
               });
             });
           }
-          console.log(
-            'renderer layout rM',
-            // @ts-expect-error plotly
-            renderer.node.layout,
-            // @ts-expect-error plotly
-            !!renderer.node.on,
-            renderer
-          );
-          //@ts-expect-error result is different from void
-          console.log('renderer result', result, !!result?.on);
 
           return result;
         };
         // special code for plotly
-        // @ts-expect-error plotly
-        console.log('renderer layout', renderer.node.layout);
         /* if (!(renderer as any).hasGraphElement()) {
             (renderer as any).createGraph((renderer as any)['_model]']);
           } */
@@ -412,9 +395,7 @@ function activateWidgetInterceptor(
                       case 'execute_result':
                         {
                           const result = output as
-                            | IExecuteResult
-                            | IDisplayUpdate
-                            | IDisplayData;
+                            IExecuteResult | IDisplayUpdate | IDisplayData;
 
                           // console.log('Mimebundle', result.data); // to do parse this also
                           // console.log('Metadata', result.metadata);
@@ -433,10 +414,6 @@ function activateWidgetInterceptor(
                             mimebundle['application/vnd.plotly.v1+json'] &&
                             false
                           ) {
-                            const bundle =
-                              mimebundle['application/vnd.plotly.v1+json'];
-                            console.log('Plotly bundle', bundle);
-                            console.log('plotly cell', cell);
                             if ((<any>result.metadata).appPath !== appPath) {
                               (<any>result.metadata).appPath = appPath;
                               addPath = true;