@factorypure/client-helpers 1.1.13 → 1.1.14

package/dist/index.js

@@ -538,7 +538,9 @@ export class FilterEngine {
             result.hide_reasons = allFilterResults
                 .filter((fr) => fr.severity === FilterSeverity.BLOCK || fr.severity === FilterSeverity.WARNING)
                 .map((fr) => fr.message);
-            result.hide_override_reasons = allFilterResults.filter((fr) => fr.metadata?.isOverride).map((fr) => fr.message);
+            result.hide_override_reasons = allFilterResults
+                .filter((fr) => fr.metadata?.isOverride)
+                .map((fr) => fr.message);
             result.ignore_result = visibilityState === VisibilityState.HIDDEN;
             return result;
         });
@@ -583,8 +585,20 @@ export class FilterEngine {
         if (overridableBlocks.length > 0) {
             return VisibilityState.HIDDEN;
         }
-        // If we have warnings, show with warnings
-        if (warningResults.length > 0) {
+        // Check for warnings that haven't been overridden
+        const nonOverriddenWarnings = warningResults.filter((wr) => {
+            const rule = this.registry.getRule(wr.ruleId);
+            if (!rule || !rule.canBeOverridden)
+                return true;
+            // Check if any override can override this warning
+            const canBeOverridden = overrideResults.some((or) => {
+                const overrideRule = this.registry.getRule(or.ruleId);
+                return overrideRule && rule.overridableBy.includes(overrideRule.id);
+            });
+            return !canBeOverridden; // Still a warning if no override present
+        });
+        // If we have non-overridden warnings, show with warnings
+        if (nonOverriddenWarnings.length > 0) {
             return VisibilityState.VISIBLE_WITH_WARNINGS;
         }
         return VisibilityState.VISIBLE;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@factorypure/client-helpers",
-    "version": "1.1.13",
+    "version": "1.1.14",
     "description": "",
     "main": "./dist/index.js",
     "types": "./dist/index.d.ts",