@fabriktor/fx 0.0.123 → 0.0.124

package/dist/src/payrolls/workspace.js

@@ -1,6 +1,6 @@
 import { isHTTPClientErr } from "@fabriktor/client";
 import { ColPayrollsPayrolls, ColPayrollsHourBanks, ColPayrollsPayables, ColPayrollsAdjustments, ColPayrollsAdjustmentFolders, ColPayrollsPayConfigs, ColPayrollsEmployeePayConfigs, ColPayrollsAdjustmentRecords, ColPayrollsAdjustmentAggregates, ColPayrollsPayrollPrograms, UserTypeEmployer, UserTypeEmployee, AdjustmentTypeRate, AdjustmentTypePerHour, AdjustmentTypePerPeriod, PayTypeFixed, PayTypePerHour, RecurrenceTypeDaily, RecurrenceTypeWeekly, RecurrenceTypeMonthly, RecurrenceTypeYearly, } from "@fabriktor/schema";
-import { employmentCanRead, employmentCatalogOwnerIDs, } from "../contacts/scope.js";
+import { employmentCanRead, employmentCatalogOwnerIDs, employmentOwnsRecord, } from "../contacts/scope.js";
 import { normalizeIDs, requiredOperationID } from "../core/id.js";
 import { runOwnerScopeQuery } from "../core/query.js";
 import { runOwnerScopeSearch, emptySearchPage, } from "../core/search.js";
@@ -137,6 +137,9 @@ export const payrollRecurrenceTypes = [
 ];
 // record/config.go pctMoney uses basis.X100000. A displayed percentage is 100 times the fraction.
 export const payrollPercentageScale = 1000;
+// Validation and access denials reject these transactional generation requests.
+// A 409 can also come from idempotency middleware, so it cannot release a request.
+const payrollGenerationRejectionStatuses = [400, 403];
 export class PayrollWorkflowError extends Error {
     reason;
     constructor(reason) {
@@ -152,7 +155,7 @@ function requirePayroll(value, reason) {
 export function payrollCanManage(actor, record) {
     return (employmentCanRead(actor) &&
         actor.active_mode === UserTypeEmployer &&
-        (!record || record.owner_id === actor.owner_id));
+        (!record || employmentOwnsRecord(actor, record)));
 }
 export function payrollCanRead(actor, resource) {
     return (employmentCanRead(actor) &&
@@ -341,12 +344,13 @@ export class PayrollsWorkspace {
                     return p.insertOnePayrollProgram({ in: command.input, ...request });
             }
         })().catch((error) => {
-            // These three handlers roll back their transaction on validation failure.
-            // Other responses remain uncertain and retain request/source checkpoints.
-            const transactional = command.resource === PayrollResource.Payrolls ||
-                command.resource === PayrollResource.HourBanks ||
-                command.resource === PayrollResource.Payables;
-            if (transactional && isHTTPClientErr(error) && error.status === 400) {
+            // Generation from configurations, hour banks and payables returns a payroll.
+            // A rejection on retry does not settle an earlier ambiguous submission.
+            if (!previous &&
+                resource === PayrollResource.Payrolls &&
+                isHTTPClientErr(error) &&
+                error.status !== undefined &&
+                payrollGenerationRejectionStatuses.includes(error.status)) {
                 this.submitted.delete(attempt.idempotency_key);
                 for (const key of sourceKeys)
                     this.sourceRequests.delete(key);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@fabriktor/fx",
-  "version": "0.0.123",
+  "version": "0.0.124",
   "description": "![Fabriktor Logo](./img/fabriktor-character.gif)",
   "type": "module",
   "exports": {