@fabrika/provider-zerops 0.2.0 → 0.3.1

package/src/provider.ts

@@ -4,12 +4,20 @@
 // driver's whole side-effect surface is one REST client plus the portable schema reconciler
 // (`./collaborators.ts`). It never spawns a process and has no `runCommand` to be handed.
 //
-// The interesting step is `await-deploy`: fabrika does not RUN the build, it WATCHES one the platform
-// runs. That is the case the run's `AbortSignal` was added for (ADR-0009), and it is honoured three ways —
-// the poll loop rechecks it, the sleep between polls is interruptible, and a cancelled run asks Zerops to
-// cancel the build it started rather than leaving it running.
+// The interesting step is `await-version`: fabrika does not RUN the build, it WATCHES one the platform
+// runs. Recovery never resumes a deploy (ADR-0044): a version reserved but never triggered is deleted, and
+// one whose build may have been requested is settled only by polling it.
 
-import { createProvider, type JsonValue, type ProviderDeploySession, type ProviderModule, type TypedProviderRun } from '@fabrika/provider-contract'
+import {
+	type DeployStepResult,
+	followLeaseLoss,
+	isLeaseLoss,
+	type JsonValue,
+	ProviderInvocationAbort,
+	type ProviderManagedEnvironment,
+	type ProviderRunEvents,
+	runSteps,
+} from '@fabrika/provider-contract'
 import {
 	waitForProcess,
 	ZEROPS_ACTIVE,
@@ -21,51 +29,60 @@ import {
 	type ZeropsLogAccess,
 	type ZeropsProcess,
 } from './api'
-import { zeropsTargetCodec } from './codec'
-import { defaultSleep, defaultZeropsCollaborators, type ZeropsCollaboratorFactory, type ZeropsCollaborators } from './collaborators'
+import { defaultZeropsCollaborators, type ZeropsCollaboratorFactory, type ZeropsCollaborators } from './collaborators'
 import { assertZeropsInvariants, renderYaml } from './compile'
 import {
-	type FabrikaImportDocument,
-	type FabrikaManifest,
-	manifestServiceHostnames,
-	verifyZeropsArtifactSourceDescriptor,
-	zeropsArtifactCodec,
-} from './manifest'
-import { buildZeropsPlan, resolveDeployHostname, type ZeropsJobSpec, type ZeropsPlan } from './plan'
+	assertAuthoredManagedDocument,
+	assertAuthoredManagedInputs,
+	type ManagedValues,
+	overlayRelease,
+	parseManagedValues,
+	SERVICE_MANAGED_KEYS,
+} from './managed-env'
+import { type FabrikaImportDocument, type FabrikaManifest, manifestServiceHostnames, verifyZeropsArtifactSourceDescriptor } from './manifest'
+import { buildZeropsPlan, resolveDeployHostname, type ZeropsStep } from './plan'
 import { allowedReferenceHosts, foreignReferenceHost } from './service-references'
-import type { ZeropsSourceUploadInputV2, ZeropsSourceUploadResult } from './source'
+import { isZeropsUploadDestination } from './source'
 import type { ZeropsRunState, ZeropsRuntimeSource, ZeropsRuntimeTarget } from './types'
+import { deleteVersion } from './version-attempt'
 
 export const CANCELLED = 'deploy cancelled'
 
-type ZeropsRun = TypedProviderRun<ZeropsRuntimeTarget, FabrikaManifest>
-
-export interface ZeropsSourceTransportBinding {
-	readonly connectionId: string
-	readonly installationId: number
-	readonly transportKind: 'keyed-v2'
+export interface ZeropsDeployRun {
+	readonly appId: string
+	readonly env: string
+	/** Every origin IAM may hand this app a session at; app-wide, because IAM's registry is keyed by app id. */
+	readonly returnOrigins?: readonly string[]
+	readonly secrets: Readonly<Record<string, string>>
+	readonly vars: Readonly<Record<string, string>>
+	/** Platform-owned runtime configuration, separate from operator-managed application vars. */
+	readonly managedEnvironment: ProviderManagedEnvironment
+	readonly target: ZeropsRuntimeTarget
+	readonly artifact: FabrikaManifest
+	readonly dryRun: boolean
+	readonly signal: AbortSignal
+	readonly events: ProviderRunEvents
 }
 
-export interface ZeropsSourceTransportRouting {
-	bindingForRun(runId: string): ZeropsSourceTransportBinding | undefined
-	uploadV2(input: ZeropsSourceUploadInputV2): Promise<ZeropsSourceUploadResult>
+export interface ZeropsDeployResult {
+	readonly appId: string
+	readonly env: string
+	readonly status: 'succeeded' | 'failed'
+	readonly steps: readonly DeployStepResult[]
 }
 
-/** How often `await-deploy` asks Zerops for the version's status. */
+/** How often `await-version` asks Zerops for the version's status. */
 const POLL_INTERVAL_MS = 3000
 
-/** Give up after this long. Zerops' own pipeline limit is 1 hour; we allow a little slack past it. */
-const POLL_TIMEOUT_MS = 70 * 60 * 1000
-
-/** Delay before deciding whether an ambiguous build trigger remained pre-trigger. */
-const BUILD_TRIGGER_CONSISTENCY_MS = 10_000
+/** A run stops waiting for its version this long after it started. Zerops' own pipeline limit is 1 hour. */
+export const ZEROPS_VERSION_DEADLINE_MS = 75 * 60 * 1000
 
-/** Source cancellation cannot hold Zerops cleanup hostage. */
-const SOURCE_CANCEL_TIMEOUT_MS = 5000
+const RELEASE_KEY = 'FABRIKA_RELEASE'
 
 /** Abandon the step if the run was cancelled. Checked before every real mutation and each poll iteration. */
 const assertRunning = (signal: AbortSignal): void => {
 	if (signal.aborted) {
+		if (signal.reason instanceof ProviderInvocationAbort) throw signal.reason
 		throw new Error(CANCELLED)
 	}
 }
@@ -173,6 +190,8 @@ export function interpolateManifest(
 	values: Record<string, string>,
 	ownHostnames: readonly string[],
 ): FabrikaImportDocument {
+	assertAuthoredManagedDocument(document.services)
+	assertAuthoredManagedInputs({ variableNames: [...declared, ...Object.keys(values)], secretNames: [] })
 	const allowed = new Set(declared)
 	const hosts = allowedReferenceHosts(ownHostnames)
 	const resolve = (text: string): string => {
@@ -204,6 +223,7 @@ export function interpolateManifest(
 	assertZeropsInvariants(substituted)
 	assertStructureUnchanged(document, substituted)
 	assertNoPlaceholderLeft(substituted)
+	assertAuthoredManagedDocument(substituted.services)
 	return substituted
 }
 
@@ -218,36 +238,32 @@ const terminalFailure = (version: ZeropsAppVersion): string => {
 	return `Zerops pipeline failed: app-version ${version.id} is ${version.status ?? 'in an unknown state'}`
 }
 
+/**
+ * The attempt this invocation is making. `appVersionId` is set once a version is reserved and `triggered`
+ * just before the build request is sent; together they decide whether a failure may delete the version.
+ */
+interface Attempt {
+	appVersionId?: string
+	uploadUrl?: string
+	processId?: string
+	triggered: boolean
+}
+
 /** Everything one step's executor needs, bundled so the per-kind handlers stay small. */
 interface StepEnv {
-	run: ZeropsRun
+	run: ZeropsDeployRun
 	zerops: ZeropsCollaborators
 	/** The compiled import document + its YAML text, materialized once in `open()`. */
 	compiled: { yaml: string; hostnames: string[] }
-	/** Hostname of the service the app's code deploys to. */
-	deployHostname: string
 	log: (line: string) => void
 	signal: AbortSignal
 	dryRun: boolean
-	sourceTransport?: ZeropsSourceTransportRouting
-	/** Set by `trigger-deploy`, read by `await-deploy` — the only state that crosses a step boundary. */
-	state: { appVersionId?: string; processId?: string }
+	attempt: Attempt
+	managedValues: ManagedValues
+	/** `await-version` gives up at this instant. */
+	deadlineMs: number
 }
 
-const runState = (
-	appVersionId: string,
-	phase: Exclude<ZeropsRunState['phase'], 'build_triggered'>,
-): Exclude<ZeropsRunState, { phase: 'build_triggered' }> => ({ appVersionId, phase })
-
-const buildTriggeredState = (
-	appVersionId: string,
-	processId?: string,
-): Extract<ZeropsRunState, { phase: 'build_triggered' }> => ({
-	appVersionId,
-	phase: 'build_triggered',
-	...(processId === undefined ? {} : { processId }),
-})
-
 const requireSource = (env: StepEnv): { runtime: ZeropsRuntimeSource; client: NonNullable<ZeropsCollaborators['source']> } => {
 	const runtime = env.run.target.source
 	const client = env.zerops.source
@@ -257,38 +273,15 @@ const requireSource = (env: StepEnv): { runtime: ZeropsRuntimeSource; client: No
 	return { runtime, client }
 }
 
-const cancelSourceBestEffort = async (env: StepEnv, source: ZeropsRuntimeSource, appVersionId: string): Promise<void> => {
-	const client = env.zerops.source
-	if (client === undefined) return
-	const sourceController = new AbortController()
-	const timeoutController = new AbortController()
-	const cancel = Promise.resolve()
-		.then(() => client.cancel({ runId: source.runId, appVersionId, signal: sourceController.signal }))
-		.catch(() => {})
-	const timeout = Promise.resolve()
-		.then(() => (env.zerops.sourceCancelSleep ?? defaultSleep)(SOURCE_CANCEL_TIMEOUT_MS, timeoutController.signal))
-		.then(() => sourceController.abort())
-		.catch(() => {})
-	await Promise.race([cancel, timeout])
-	timeoutController.abort()
-	sourceController.abort()
+const requireVersion = (env: StepEnv, step: string): string => {
+	const appVersionId = env.attempt.appVersionId
+	if (appVersionId === undefined) throw new Error(`zerops: ${step} has no reserved app-version (reserve-version did not run)`)
+	return appVersionId
 }
 
-/**
- * Drop a version that was created and never handed to the platform.
- *
- * BEST EFFORT ON PURPOSE. Every caller runs this while already failing, so a cleanup that throws would
- * replace the reason the deploy failed with the reason the cleanup did — which is what happened live,
- * where a real `trigger-deploy` failure surfaced as `delete app-version failed (400)` and the cause was
- * gone. The leftover version is visible on the platform; the lost diagnosis was not.
- */
-const cleanupPreTriggerVersion = async (env: StepEnv, source: ZeropsRuntimeSource, appVersionId: string): Promise<void> => {
-	await cancelSourceBestEffort(env, source, appVersionId)
-	try {
-		await env.zerops.api.deleteAppVersion({ appVersionId, signal: AbortSignal.timeout(5000) })
-	} catch (error) {
-		env.log(`  [warn] app-version ${appVersionId} was left behind: ${error instanceof Error ? error.message : 'unknown error'}`)
-	}
+/** Best-effort: the caller is already giving up, so a failed cancellation must not replace the reason. */
+const cancelBuildQuietly = async (env: StepEnv, appVersionId: string): Promise<void> => {
+	await env.zerops.api.cancelBuild({ appVersionId, signal: AbortSignal.timeout(5000) }).catch(() => {})
 }
 
 /**
@@ -354,22 +347,28 @@ const openLog = async (env: StepEnv): Promise<ZeropsLogAccess | null> => {
  * Poll the trigger process and `/app-version` until the version reaches a terminal state, relaying the
  * build log as it goes. The process is optional because the trigger response may omit its id.
  *
- * A run cancelled here asks Zerops to cancel the BUILD too. That is not tidiness: the platform is running
- * the work, so abandoning the poll loop without telling it leaves a build container burning through the
- * pipeline's hour.
+ * A cancelled run asks Zerops to cancel the BUILD too: the platform is running the work, so abandoning the
+ * poll loop without telling it leaves a build container burning through the pipeline's hour. A lost lease
+ * gives no such permission (ADR-0044), so it stops without touching the build.
  */
 const awaitVersion = async (env: StepEnv, appVersionId: string, processId: string | undefined): Promise<void> => {
 	const { zerops, signal, log } = env
 	const access = await openLog(env)
 	const seen = new Set<string>()
-	const deadline = Date.now() + POLL_TIMEOUT_MS
 	let previous: string | undefined
+	const timedOut = async (): Promise<never> => {
+		await cancelBuildQuietly(env, appVersionId)
+		throw new Error(`zerops: gave up waiting for app-version ${appVersionId} at the run deadline`)
+	}
 
 	for (;;) {
+		// Only a boundary that still holds the lease may cancel the build; a lost lease rejects it as lease_lost.
+		const crossed: unknown = await env.run.events.boundary().then(() => null, (error: unknown) => error)
+		if (isLeaseLoss(crossed)) throw crossed
 		if (signal.aborted) {
-			// Best-effort: the run is already abandoned, so a failure to cancel must not mask the reason.
-			await zerops.api.cancelBuild({ appVersionId, signal: AbortSignal.timeout(5000) }).catch(() => {})
-			throw new Error(CANCELLED)
+			if (isLeaseLoss(signal.reason)) throw signal.reason
+			await cancelBuildQuietly(env, appVersionId)
+			throw new ProviderInvocationAbort('cancel_requested')
 		}
 		let process: ZeropsProcess | undefined
 		let version: ZeropsAppVersion
@@ -378,12 +377,18 @@ const awaitVersion = async (env: StepEnv, appVersionId: string, processId: strin
 			version = await zerops.api.getAppVersion({ appVersionId, signal })
 		} catch {
 			log(`  ${appVersionId}: status observation unavailable; retrying`)
-			if (Date.now() > deadline) {
-				throw new Error(`zerops: timed out after ${Math.round(POLL_TIMEOUT_MS / 60000)}m waiting for app-version ${appVersionId}`)
-			}
+			if (Date.now() > env.deadlineMs) await timedOut()
 			await zerops.sleep(POLL_INTERVAL_MS, signal)
 			continue
 		}
+		if (signal.aborted) continue
+		if (
+			version.id !== appVersionId || (version.serviceStackId !== undefined && version.serviceStackId !== env.run.target.serviceId)
+			|| (processId !== undefined && process?.id !== processId)
+			|| (process?.appVersionId !== undefined && process.appVersionId !== appVersionId)
+		) {
+			throw new Error('zerops: status observation has different coordinates')
+		}
 		if (version.status !== previous) {
 			log(`  ${appVersionId}: ${version.status ?? 'unknown'}`)
 			previous = version.status
@@ -401,17 +406,52 @@ const awaitVersion = async (env: StepEnv, appVersionId: string, processId: strin
 			}
 			throw new Error(terminalFailure(version))
 		}
-		if (Date.now() > deadline) {
-			throw new Error(`zerops: timed out after ${Math.round(POLL_TIMEOUT_MS / 60000)}m waiting for app-version ${appVersionId}`)
-		}
+		if (Date.now() > env.deadlineMs) await timedOut()
 		await zerops.sleep(POLL_INTERVAL_MS, signal)
 	}
 }
 
-/** Run one step's effect. Resolves on success, throws on failure (caught + recorded by the engine). */
-const runStep = async (spec: ZeropsJobSpec, env: StepEnv): Promise<void> => {
-	const { run, zerops, compiled, log, signal, dryRun, state } = env
+/** Write the five service-level managed keys; `FABRIKA_RELEASE` is never a service variable (ADR-0044). */
+const writeServiceEnv = async (env: StepEnv): Promise<void> => {
+	const { zerops, log, signal, managedValues } = env
+	const serviceId = env.run.target.serviceId
+	if (env.dryRun) {
+		const written = SERVICE_MANAGED_KEYS.filter((key) => managedValues[key] !== null)
+		const removed = SERVICE_MANAGED_KEYS.filter((key) => managedValues[key] === null)
+		log(`  [dry-run] would write service variables on ${serviceId}: ${written.join(', ') || '(none)'}`)
+		log(`  [dry-run] would remove service variables on ${serviceId} if present: ${[...removed, RELEASE_KEY].join(', ')}`)
+		return
+	}
+	assertRunning(signal)
+	// One read: every write below waits for its own user-data sync, so the build request never meets `userDataSyncRunning`.
+	const records = await zerops.api.listServiceEnv({ serviceId, signal })
+	for (const key of SERVICE_MANAGED_KEYS) {
+		const value = managedValues[key]
+		const existing = records.find((record) => record.key === key)
+		assertRunning(signal)
+		if (value !== null && existing?.content !== value) {
+			await zerops.api.putServiceEnv({ serviceId, key, value, signal })
+			log(`  ${key}: updated`)
+		} else if (value === null && existing !== undefined) {
+			await zerops.api.deleteServiceEnv({ envId: existing.id, signal })
+			log(`  ${key}: removed`)
+		} else {
+			log(`  ${key}: unchanged`)
+		}
+	}
+	const strayRelease = records.find((record) => record.key === RELEASE_KEY)
+	if (strayRelease !== undefined) {
+		assertRunning(signal)
+		await zerops.api.deleteServiceEnv({ envId: strayRelease.id, signal })
+		log(`  ${RELEASE_KEY}: removed`)
+	}
+}
+
+/** Run one step's effect. Resolves on success, throws on failure (caught + recorded by `runSteps`). */
+const runStep = async (spec: ZeropsStep, env: StepEnv): Promise<void> => {
+	const { run, zerops, compiled, log, signal, dryRun, attempt } = env
 	const { target, artifact } = run
+	await run.events.boundary()
 
 	switch (spec.kind) {
 		case 'apply-import': {
@@ -440,117 +480,109 @@ const runStep = async (spec: ZeropsJobSpec, env: StepEnv): Promise<void> => {
 			return
 		}
 
-		case 'trigger-deploy': {
+		case 'write-service-env': {
+			await writeServiceEnv(env)
+			return
+		}
+
+		case 'reserve-version': {
 			if (dryRun) {
-				log(`  [dry-run] would create an app version, upload the resolved repository snapshot, and trigger build+deploy for service ${target.serviceId}`)
+				log(`  [dry-run] would reserve an app version on service ${target.serviceId}`)
 				return
 			}
-			assertRunning(signal)
 			const source = requireSource(env)
 			await verifyZeropsArtifactSourceDescriptor(artifact.target.sourceDescriptor)
+			assertRunning(signal)
 			const version = await zerops.api.createAppVersion({ serviceId: target.serviceId, name: source.runtime.runId, signal })
-			state.appVersionId = version.id
-			let buildTriggerRequested = false
+			attempt.appVersionId = version.id
+			attempt.uploadUrl = version.uploadUrl
+			const checkpoint: ZeropsRunState = { appVersionId: version.id, triggered: false }
+			await run.events.externalId(version.id, { ...checkpoint })
+			log(`  reserved app-version ${version.id}`)
+			return
+		}
+
+		case 'upload-source': {
+			if (dryRun) {
+				log('  [dry-run] would upload the resolved repository snapshot to the reserved app version')
+				return
+			}
+			const source = requireSource(env)
+			const appVersionId = requireVersion(env, 'upload-source')
+			const uploadUrl = attempt.uploadUrl
+			if (uploadUrl === undefined) throw new Error('zerops: upload-source has no upload URL')
+			// The upload URL carries its own credential; it is checked here and never put in an error.
+			if (!isZeropsUploadDestination(uploadUrl)) throw new Error('zerops: the reserved app version has an unexpected upload destination')
+			assertRunning(signal)
+			const binding = source.runtime.privateBinding
+			const uploaded = await source.client.upload({
+				repository: source.runtime.repository,
+				commitSha: source.runtime.commitSha,
+				descriptorSha256: artifact.target.sourceDescriptor.sha256,
+				archive: {
+					kind: 'application',
+					...(binding === undefined ? {} : { privateBinding: { connectionId: binding.connectionId, installationId: binding.installationId } }),
+				},
+				uploadUrl,
+				signal,
+			})
+			if (
+				uploaded.commitSha !== source.runtime.commitSha
+				|| uploaded.descriptorSha256 !== artifact.target.sourceDescriptor.sha256
+			) {
+				throw new Error('zerops: source upload returned different coordinates')
+			}
+			log(`  uploaded ${source.runtime.commitSha} to ${appVersionId}`)
+			return
+		}
+
+		case 'trigger-build': {
+			if (dryRun) {
+				log('  [dry-run] would trigger build+deploy with FABRIKA_RELEASE written into the execution descriptor')
+				return
+			}
+			const appVersionId = requireVersion(env, 'trigger-build')
+			await verifyZeropsArtifactSourceDescriptor(artifact.target.sourceDescriptor)
+			const descriptor = overlayRelease(artifact.target.sourceDescriptor.contents, artifact.target.zeropsSetup, env.managedValues.FABRIKA_RELEASE)
+			assertRunning(signal)
+			// Recorded BEFORE the request: from here on the version is settled only by polling it (ADR-0044).
+			const checkpoint: ZeropsRunState = { appVersionId, triggered: true }
+			await run.events.checkpoint({ ...checkpoint })
+			attempt.triggered = true
+			// A cancel from here on still sends the build, so `cancel()` cancels a real build instead of
+			// polling a version that would sit in UPLOADING until the deadline. Only a lost lease stops it.
+			const buildSignal = followLeaseLoss(signal)
+			buildSignal.throwIfAborted()
+			let process: ZeropsProcess
 			try {
-				await run.events.externalId(version.id, runState(version.id, 'version_created'))
-				const uploadInput = {
-					runId: source.runtime.runId,
-					appVersionId: version.id,
-					repository: source.runtime.repository,
-					commitSha: source.runtime.commitSha,
-					...(source.runtime.githubInstallationId === undefined
-						? {}
-						: { githubInstallationId: source.runtime.githubInstallationId }),
-					uploadUrl: version.uploadUrl,
-					descriptor: {
-						path: artifact.target.sourceDescriptor.path,
-						sha256: artifact.target.sourceDescriptor.sha256,
-					},
-					signal,
-				}
-				const sourceTransport = env.sourceTransport
-				const binding = sourceTransport?.bindingForRun(source.runtime.runId)
-				if (binding !== undefined && source.runtime.githubInstallationId !== binding.installationId) {
-					throw new Error('zerops: source transport binding has different installation coordinates')
-				}
-				let uploaded: ZeropsSourceUploadResult
-				if (binding === undefined) {
-					uploaded = await source.client.upload(uploadInput)
-				} else {
-					if (sourceTransport === undefined) throw new Error('zerops: keyed source transport is unavailable')
-					uploaded = await sourceTransport.uploadV2({
-						...uploadInput,
-						privateBinding: { connectionId: binding.connectionId, installationId: binding.installationId },
-					})
-				}
-				if (
-					uploaded.runId !== source.runtime.runId
-					|| uploaded.appVersionId !== version.id
-					|| uploaded.commitSha !== source.runtime.commitSha
-					|| uploaded.descriptorSha256 !== artifact.target.sourceDescriptor.sha256
-				) {
-					throw new Error('zerops: source upload returned different coordinates')
-				}
-				await run.events.checkpoint(runState(version.id, 'source_uploaded'))
-				await verifyZeropsArtifactSourceDescriptor(artifact.target.sourceDescriptor)
-				await run.events.checkpoint(runState(version.id, 'build_trigger_requested'))
-				buildTriggerRequested = true
-				let process: ZeropsProcess
-				try {
-					process = await zerops.api.buildAndDeployAppVersion({
-						appVersionId: version.id,
-						zeropsYaml: artifact.target.sourceDescriptor.contents,
-						...(artifact.target.zeropsSetup === undefined ? {} : { zeropsYamlSetup: artifact.target.zeropsSetup }),
-						signal,
-					})
-				} catch (error) {
-					if (error instanceof ZeropsApiError && error.status >= 400 && error.status < 500) {
-						await cleanupPreTriggerVersion(env, source.runtime, version.id)
-						throw error
-					}
-					let observed: ZeropsAppVersion | undefined
-					try {
-						await zerops.sleep(BUILD_TRIGGER_CONSISTENCY_MS, signal)
-						observed = await zerops.api.getAppVersion({ appVersionId: version.id, signal })
-					} catch {
-						log(`  ${version.id}: build-trigger observation unavailable; continuing to poll`)
-						return
-					}
-					if (observed.id === version.id && observed.status === 'UPLOADING') {
-						await cleanupPreTriggerVersion(env, source.runtime, version.id)
-						throw error
-					}
-					if (observed.id === version.id && observed.status !== undefined) {
-						await run.events.checkpoint(buildTriggeredState(version.id)).catch(() => {})
-						log(`  recovered accepted build trigger for app-version ${version.id}`)
-					} else {
-						log(`  ${version.id}: build-trigger state is not known yet; continuing to poll`)
-					}
-					return
-				}
-				state.processId = process.id
-				await run.events.checkpoint(buildTriggeredState(version.id, process.id)).catch(() => {})
-				log(`  triggered: app-version ${version.id} (build+deploy is ONE platform-side operation)`)
+				process = await zerops.api.buildAndDeployAppVersion({
+					appVersionId,
+					zeropsYaml: descriptor.contents,
+					zeropsYamlSetup: descriptor.setup,
+					signal: buildSignal,
+				})
 			} catch (error) {
-				if (!buildTriggerRequested) {
-					await cleanupPreTriggerVersion(env, source.runtime, version.id)
+				buildSignal.throwIfAborted()
+				// A 408 says the request timed out, not that the platform refused it.
+				if (error instanceof ZeropsApiError && error.status >= 400 && error.status < 500 && error.status !== 408) {
+					throw new Error(`zerops: build refused (${error.code === '' ? error.status : error.code})`)
 				}
-				throw error
+				log('  build request outcome unknown; polling the version')
+				return
 			}
+			attempt.processId = process.id
+			log(`  triggered app-version ${appVersionId}`)
 			return
 		}
 
-		case 'await-deploy': {
+		case 'await-version': {
 			if (dryRun) {
 				log('  [dry-run] would poll the pipeline process when available and /app-version until it is ACTIVE, relaying the build log')
 				return
 			}
-			const appVersionId = state.appVersionId
-			if (appVersionId === undefined) {
-				throw new Error('zerops: await-deploy has no app-version to watch (trigger-deploy did not run)')
-			}
+			const appVersionId = requireVersion(env, 'await-version')
 			assertRunning(signal)
-			await awaitVersion(env, appVersionId, state.processId)
+			await awaitVersion(env, appVersionId, attempt.processId)
 			return
 		}
 
@@ -585,59 +617,52 @@ const runStep = async (spec: ZeropsJobSpec, env: StepEnv): Promise<void> => {
 }
 
 /**
- * Build a Zerops driver over a specific collaborator FACTORY. Production passes the real one; tests pass
+ * Build a Zerops deployer over a specific collaborator FACTORY. Production passes the real one; tests pass
  * `() => fakes`, which is the whole testability property — one seam, all of this driver's effects.
  *
  * A factory rather than a bundle because the Zerops client is authenticated with a token that lives on the
  * run's target, so it cannot be constructed once at module load the way Cloudflare's bundle is.
  */
-export type ZeropsProvider = ProviderModule<'zerops', ZeropsRuntimeTarget, FabrikaManifest>
-
-/** Construct an independently testable Zerops provider against one collaborator factory. */
-export const createZeropsProvider = (
+export const createZeropsDeployer = (
 	collaborators: ZeropsCollaboratorFactory = defaultZeropsCollaborators,
-	sourceTransport?: ZeropsSourceTransportRouting,
-): ZeropsProvider =>
-	createProvider({
-		id: 'zerops',
-		target: zeropsTargetCodec,
-		artifact: zeropsArtifactCodec,
-		open: (run): Promise<ProviderDeploySession> => {
-			if (run.artifact.app.id !== run.appId) {
-				throw new Error(`zerops: artifact app drift: expected \`${run.appId}\`, got \`${run.artifact.app.id}\``)
-			}
-			if (run.artifact.app.env !== run.env) {
-				throw new Error(`zerops: artifact environment drift: expected \`${run.env}\`, got \`${run.artifact.app.env}\``)
-			}
-			const hostnames = manifestServiceHostnames(run.artifact)
-			const document = interpolateManifest(run.artifact.target.importDocument, run.artifact.app.pipeline.vars, run.vars, hostnames)
-			const compiled = { yaml: renderYaml(document), hostnames }
-			const deployHostname = resolveDeployHostname(run.artifact)
-			const plan: ZeropsPlan = buildZeropsPlan(run.artifact, run.target, run.env)
-			const env: StepEnv = {
-				run,
-				zerops: collaborators(run.target),
-				compiled,
-				deployHostname,
-				log: run.events.log,
-				signal: run.signal,
-				dryRun: run.dryRun,
-				...(sourceTransport === undefined ? {} : { sourceTransport }),
-				state: {},
-			}
-			const byId = new Map(plan.steps.map((step): [string, ZeropsJobSpec] => [step.id, step]))
-
-			return Promise.resolve({
-				plan,
-				execute: async (stepId: string): Promise<void> => {
-					const spec = byId.get(stepId)
-					if (spec === undefined) {
-						throw new Error(`zerops: no step \`${stepId}\` in this plan`)
-					}
-					await runStep(spec, env)
-				},
-			})
-		},
-	})
-
-export const zeropsProvider: ZeropsProvider = createZeropsProvider()
+) =>
+async (run: ZeropsDeployRun): Promise<ZeropsDeployResult> => {
+	if (run.artifact.app.id !== run.appId) {
+		throw new Error(`zerops: artifact app drift: expected \`${run.appId}\`, got \`${run.artifact.app.id}\``)
+	}
+	if (run.artifact.app.env !== run.env) {
+		throw new Error(`zerops: artifact environment drift: expected \`${run.env}\`, got \`${run.artifact.app.env}\``)
+	}
+	assertAuthoredManagedInputs({ variableNames: Object.keys(run.vars), secretNames: Object.keys(run.secrets) })
+	const managedValues = parseManagedValues(run.managedEnvironment)
+	const hostnames = manifestServiceHostnames(run.artifact)
+	const document = interpolateManifest(run.artifact.target.importDocument, run.artifact.app.pipeline.vars, run.vars, hostnames)
+	const compiled = { yaml: renderYaml(document), hostnames }
+	resolveDeployHostname(run.artifact)
+	const zerops = collaborators(run.target)
+	const env: StepEnv = {
+		run,
+		zerops,
+		compiled,
+		log: run.events.log,
+		signal: run.signal,
+		dryRun: run.dryRun,
+		attempt: { triggered: false },
+		managedValues,
+		deadlineMs: Date.now() + ZEROPS_VERSION_DEADLINE_MS,
+	}
+	const steps = buildZeropsPlan(run.artifact, run.target)
+	const options = { appId: run.appId, env: run.env, dryRun: run.dryRun, signal: run.signal, log: run.events.log }
+	const result = await runSteps(steps, options, (step) => runStep(step, env))
+	const { appVersionId, triggered } = env.attempt
+	// A cancelled run leaves the version to `cancel()`; a lost lease leaves it to the next owner.
+	if (result.status === 'failed' && appVersionId !== undefined && !triggered && !run.signal.aborted) {
+		try {
+			await deleteVersion(zerops.api, appVersionId, run.signal)
+			run.events.log(`  deleted app-version ${appVersionId}`)
+		} catch {
+			run.events.log(`  [warn] app-version ${appVersionId} could not be deleted; it was never built`)
+		}
+	}
+	return { appId: run.appId, env: run.env, ...result }
+}

package/src/source/constants.ts

@@ -0,0 +1,11 @@
+export const MAX_ID_LENGTH = 128
+
+export const SHA256_PATTERN = /^[a-f0-9]{64}$/
+
+export const COMMIT_SHA_PATTERN = /^(?:[a-f0-9]{40}|[a-f0-9]{64})$/
+
+export const ID_PATTERN = /^[A-Za-z0-9._:-]+$/
+
+export const GITHUB_OWNER_PATTERN = /^[a-z0-9](?:[a-z0-9-]{0,37}[a-z0-9])?$/
+
+export const GITHUB_REPOSITORY_PATTERN = /^[a-z0-9._-]{1,100}$/