@fable-org/fable-library-ts 1.4.1 → 1.4.3

package/BigInt.ts

@@ -148,10 +148,11 @@ export function toFloat32(x: bigint): float32 { return Number(x); }
 export function toFloat64(x: bigint): float64 { return Number(x); }
 
 export function toDecimal(x: bigint): decimal {
-    const low = Number(BigInt.asUintN(32, x))
-    const mid = Number(BigInt.asUintN(32, x >> 32n))
-    const high = Number(BigInt.asUintN(32, x >> 64n))
     const isNegative = x < zero;
+    const bits = abs(x);
+    const low = Number(BigInt.asUintN(32, bits));
+    const mid = Number(BigInt.asUintN(32, bits >> 32n));
+    const high = Number(BigInt.asUintN(32, bits >> 64n));
     const scale = 0;
     return fromParts(low, mid, high, isNegative, scale)
 }

package/CHANGELOG.md

@@ -7,6 +7,16 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## Unreleased
 
+## 1.4.3 - 2024-09-04
+
+* [JS/TS] Fixed Decimal comparisons (#3884) (by @ncave)
+
+## 1.4.2 - 2024-06-13
+
+### Fixed
+
+* [JS/TS] Fixed BigInt.ToDecimal with negative values (#3500) (by @ncave)
+
 ## 1.4.1 - 2024-06-13
 
 ### Fixed

package/Date.ts

@@ -524,7 +524,6 @@ export function parseRaw(input: string): [Date, Offset] {
 
   if (isNaN(date.getTime())) {
     // Try to check strings JS Date cannot parse (see #1045, #1422)
-    // tslint:disable-next-line:max-line-length
     const m = /^\s*(\d+[^\w\s:]\d+[^\w\s:]\d+)?\s*(\d+:\d+(?::\d+(?:\.\d+)?)?)?\s*([AaPp][Mm])?\s*(Z|[+-]([01]?\d):?([0-5]?\d)?)?\s*$/.exec(input);
     if (m != null) {
       let baseDate: Date;

package/Decimal.ts

@@ -44,16 +44,16 @@ export function equals(x: Decimal, y: Decimal) {
 }
 
 export function abs(x: Decimal) { return x.abs(); }
-export function sign(x: Decimal): number { return x < get_Zero ? -1 : x > get_Zero ? 1 : 0; }
+export function sign(x: Decimal): number { return x.lt(get_Zero) ? -1 : x.gt(get_Zero) ? 1 : 0; }
 
-export function max(x: Decimal, y: Decimal): Decimal { return x > y ? x : y; }
-export function min(x: Decimal, y: Decimal): Decimal { return x < y ? x : y; }
+export function max(x: Decimal, y: Decimal): Decimal { return x.gt(y) ? x : y; }
+export function min(x: Decimal, y: Decimal): Decimal { return x.lt(y) ? x : y; }
 
-export function maxMagnitude(x: Decimal, y: Decimal): Decimal { return abs(x) > abs(y) ? x : y; }
-export function minMagnitude(x: Decimal, y: Decimal): Decimal { return abs(x) < abs(y) ? x : y; }
+export function maxMagnitude(x: Decimal, y: Decimal): Decimal { return abs(x).gt(abs(y)) ? x : y; }
+export function minMagnitude(x: Decimal, y: Decimal): Decimal { return abs(x).lt(abs(y)) ? x : y; }
 
 export function clamp(x: Decimal, min: Decimal, max: Decimal): Decimal {
-  return x < min ? min : x > max ? max : x;
+  return x.lt(min) ? min : x.gt(max) ? max : x;
 }
 
 export function round(x: Decimal, digits: number = 0) {

package/RegExp.ts

@@ -48,7 +48,6 @@ export function matches(reg: RegExp, input: string, startAt = 0) {
   const matches: RegExpExecArray[] = [];
   let m: RegExpExecArray | null;
   let lastMatchIndex = -1;
-  // tslint:disable-next-line:no-conditional-assignment
   while ((m = reg.exec(input)) != null) {
     // It can happen even global regex get stuck, see #2845
     if (m.index === lastMatchIndex) {

package/TimeSpan.ts

@@ -1,4 +1,3 @@
-// tslint:disable:max-line-length
 import { FSharpRef } from "./Types.js";
 import { comparePrimitives, padLeftAndRightWithZeros, padWithZeros } from "./Util.js";
 import { toInt64, fromFloat64 } from "./BigInt.js";

package/Types.ts

@@ -199,7 +199,7 @@ export function isPromise(x: any) {
   return x instanceof Promise;
 }
 
-export function ensureErrorOrException(e: any) {
+export function ensureErrorOrException(e: any): any {
   // Exceptionally admitting promises as errors for compatibility with React.suspense (see #3298)
   return (isException(e) || isPromise(e)) ? e : new Error(String(e));
 }

package/Uri.ts

@@ -26,7 +26,6 @@ export class Uri {
 
   private static isAbsoluteUri(uri: string): boolean {
     try {
-      // tslint:disable-next-line no-unused-expression
       new URL(uri);
       return true;
     } catch {

package/Util.ts

@@ -1,5 +1,3 @@
-// tslint:disable:ban-types
-
 // Don't change, this corresponds to DateTime.Kind enum values in .NET
 export const enum DateKind {
   Unspecified = 0,

package/lib/big.js

@@ -1,5 +1,4 @@
 // Adapted from https://github.com/MikeMcl/big.js/blob/0f94dc9110d55c4f324a47ba6a2e832ce23ac589/big.mjs
-/* tslint:disable */
 
 var P = {};
 

package/package.json

@@ -3,7 +3,7 @@
   "private": false,
   "type": "module",
   "name": "@fable-org/fable-library-ts",
-  "version": "1.4.1",
+  "version": "1.4.3",
   "description": "Core library used by F# projects compiled with fable.io",
   "author": "Fable Contributors",
   "license": "MIT",