@faable/faable 1.15.2 → 1.15.3

package/dist/commands/deploy/index.js

@@ -8,7 +8,7 @@ import { check_environment } from './check_environment.js';
 import { git_context } from './git_context.js';
 import { resolve_app_id } from './resolve_app_id.js';
 import { secrets } from './secrets/index.js';
-import { start_log_sync, mark_build_failure, upload_logs } from './upload_logs.js';
+import { mark_build_failure, start_log_sync, upload_logs } from './upload_logs.js';
 import { upload_tag } from './upload_tag.js';
 
 const deploy = {
@@ -41,20 +41,43 @@ const deploy = {
         const workdir = args.workdir || process.cwd();
         const ctx = await requireApi();
         const { api } = ctx;
-        // Resolve the buildpack plan (detection or forced override). All the
-        // build thinking happens here; build() below just executes the plan.
         const config = Configuration.instance().deployConfig();
-        const plan = await detect_buildpack({ workdir, config }, args.buildpack || config.buildpack);
         const app_id = await resolve_app_id(args.app_id, ctx.appId, api, workdir);
         const app = await api.getApp(app_id);
         // Capture the commit/ref/actor so the deployment records which commit
         // it came from and who pushed it (env in CI, git fallback locally).
         const git = await git_context({ workdir });
+        // Resolve the buildpack plan (detection or forced override). All the build
+        // thinking happens here; build() below just executes the plan. Detection can
+        // fail (e.g. an app whose start command can't be inferred) — and it runs
+        // before the create-first deployment exists, so without this a detection
+        // failure would leave NO deployment row: no deploy-failed email, nothing in
+        // the dashboard, just a red X in the CI logs the user may never see. Record
+        // it as a failed deployment instead.
+        let plan;
+        try {
+            plan = await detect_buildpack({ workdir, config }, args.buildpack || config.buildpack);
+        }
+        catch (error) {
+            // Log the reason into the build buffer first (so it rides along in the
+            // attached logs), then record a typeless BUILD_ERROR row — typeless so it
+            // can't rewrite the app's runtime_strategy. Best-effort: a create that
+            // itself fails (e.g. the free-plan quota gate) must not mask the original
+            // detection error.
+            log.error(error.message);
+            const failed = await api
+                .createDeployment({ app_id: app.id, ...git })
+                .catch(() => null);
+            if (failed) {
+                await mark_build_failure(api, { deployment_id: failed.id, app });
+            }
+            throw error;
+        }
         // Create-first: register the deployment BEFORE building. Gate rejections
         // (free-plan quota 429, disabled app 409) surface here, at second 0 —
         // before any build minutes are spent. The row is born QUEUED; the CLI
         // owns it until the built image lands (or the build fails). `type` rides
-        // on the create as before — the buildpack plan is already resolved.
+        // on the create — the buildpack plan is already resolved.
         const deployment = await api.createDeployment({
             app_id: app.id,
             type: plan.type,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@faable/faable",
-  "version": "1.15.2",
+  "version": "1.15.3",
   "main": "dist/index.js",
   "license": "MIT",
   "author": "Marc Pomar <marc@faable.com>",