@f5-sales-demo/xcsh 22.7.2 → 22.8.0

package/src/utils/title-generator.ts

@@ -1,8 +1,9 @@
 /**
  * Generate session titles using a smol, fast model.
  */
+
 import * as path from "node:path";
-import type { ThinkingLevel } from "@f5-sales-demo/pi-agent-core";
+import type { AgentMessage, ThinkingLevel } from "@f5-sales-demo/pi-agent-core";
 import type { Api, Model } from "@f5-sales-demo/pi-ai";
 import { completeSimple } from "@f5-sales-demo/pi-ai";
 import { logger, prompt } from "@f5-sales-demo/pi-utils";
@@ -11,6 +12,7 @@ import type { ModelRegistry } from "../config/model-registry";
 import { resolveRoleSelection } from "../config/model-resolver";
 import type { Settings } from "../config/settings";
 import titleSystemPrompt from "../prompts/system/title-system.md" with { type: "text" };
+import type { AutomaticTitleState, SessionEntry } from "../session/session-manager";
 import { toReasoningEffort } from "../thinking";
 
 const TITLE_SYSTEM_PROMPT = prompt.render(titleSystemPrompt);
@@ -42,7 +44,9 @@ export function sanitizeGeneratedSessionTitle(value: string): string | null {
 	}
 	if (!parsed || typeof parsed !== "object" || Array.isArray(parsed)) return null;
 	const record = parsed as Record<string, unknown>;
-	if (Object.keys(record).length !== 1 || typeof record.title !== "string") return null;
+	if (Object.keys(record).some(key => key !== "title" && key !== "provisional") || typeof record.title !== "string")
+		return null;
+	if ("provisional" in record && typeof record.provisional !== "boolean") return null;
 	const sanitized = record.title.replace(TERMINAL_TITLE_CONTROL_CHARS, "").replace(/\s+/gu, " ").trim();
 	if (!sanitized) return null;
 	return [...sanitized].slice(0, MAX_TITLE_CHARACTERS).join("").trim() || null;
@@ -73,26 +77,26 @@ const TITLE_TOOL = {
 	description: "Return the generated session title as strict JSON.",
 	strict: true,
 	parameters: Type.Object(
-		{ title: Type.String({ maxLength: MAX_TITLE_CHARACTERS }) },
+		{ title: Type.String({ maxLength: MAX_TITLE_CHARACTERS }), provisional: Type.Boolean() },
 		{ additionalProperties: false },
 	),
 } as const;
 
 /**
- * Generate a title for a session based on the first user message.
+ * Generate a session name and model-judged provisional status from completed conversation data.
  *
- * @param firstMessage The first user message
+ * @param firstMessage Serialized completed exchanges
  * @param registry Model registry
  * @param settings Settings used to resolve the smol role, including per-role thinking
  * @param sessionId Optional session id for sticky API key selection
  */
-export async function generateSessionTitle(
+async function generateSessionName(
 	firstMessage: string,
 	registry: ModelRegistry,
 	settings: Settings,
 	sessionId?: string,
 	currentModel?: Model<Api>,
-): Promise<string | null> {
+): Promise<GeneratedSessionName | null> {
 	const candidates = getTitleModels(registry, settings, currentModel);
 	if (candidates.length === 0) {
 		logger.debug("title-generator: no title model found");
@@ -137,7 +141,7 @@ ${truncatedMessage}
 				},
 			);
 
-			if (response.stopReason === "error") {
+			if (response.stopReason === "error" || response.stopReason === "aborted") {
 				logger.debug("title-generator: response error", {
 					model,
 					attempt: attempt + 1,
@@ -147,16 +151,18 @@ ${truncatedMessage}
 			}
 
 			const toolCalls = response.content.filter(content => content.type === "toolCall");
-			const title =
+			const payload =
 				toolCalls.length === 1 && toolCalls[0]!.name === TITLE_TOOL_NAME
-					? sanitizeGeneratedSessionTitle(JSON.stringify(toolCalls[0]!.arguments) ?? "")
-					: sanitizeGeneratedSessionTitle(
-							response.content
+					? (JSON.stringify(toolCalls[0]!.arguments) ?? "")
+					: toolCalls.length === 0
+						? response.content
 								.filter(content => content.type === "text")
 								.map(content => content.text)
 								.join("")
-								.trim(),
-						);
+								.trim()
+						: "";
+			const title = sanitizeGeneratedSessionTitle(payload);
+			const provisional = title ? (JSON.parse(payload) as { provisional?: boolean }).provisional : undefined;
 
 			logger.debug("title-generator: response", {
 				model,
@@ -166,7 +172,7 @@ ${truncatedMessage}
 				titleCharacters: title ? [...title].length : 0,
 				stopReason: response.stopReason,
 			});
-			if (title) return title;
+			if (title && typeof provisional === "boolean") return { title, provisional };
 		} catch (err) {
 			logger.debug("title-generator: error", {
 				model,
@@ -178,31 +184,126 @@ ${truncatedMessage}
 	return null;
 }
 
+export interface GeneratedSessionName {
+	title: string;
+	provisional: boolean;
+}
+
+/** Compatibility helper for consumers needing only the generated string. */
+export async function generateSessionTitle(...args: Parameters<typeof generateSessionName>): Promise<string | null> {
+	return (await generateSessionName(...args))?.title ?? null;
+}
+
 interface SessionTitleManager {
 	getSessionName?(): string | undefined;
+	getBranch?(): SessionEntry[];
+	getAutomaticTitleState?(): AutomaticTitleState | undefined;
+	readonly titleSource?: "auto" | "user";
+	readonly titleRevision?: number;
+	setAutomaticSessionName?(
+		name: string,
+		state: AutomaticTitleState,
+		sessionId: string,
+		revision: number,
+	): Promise<boolean>;
 }
-
 interface SessionTitleTarget {
 	sessionId: string;
 	sessionName?: string;
+	messages?: AgentMessage[];
 	model?: Model<Api>;
 	modelRegistry: ModelRegistry;
 	settings: Settings;
 	sessionManager: SessionTitleManager;
 	setSessionName(name: string, source: "auto" | "user"): Promise<boolean>;
 }
+export interface CompletedTitleExchange {
+	id: string;
+	user: string;
+	assistant: string;
+}
+
+function messageText(message: { content?: unknown }): string {
+	if (typeof message.content === "string") return message.content;
+	if (!Array.isArray(message.content)) return "";
+	return message.content
+		.filter(part => part?.type === "text")
+		.map(part => part.text)
+		.join("\n");
+}
 
-type TitleGenerator = typeof generateSessionTitle;
+/** Read finalized conversation records, never transport deltas, closure tails, or delegation wrappers. */
+export function completedTitleExchanges(entries: SessionEntry[]): CompletedTitleExchange[] {
+	const exchanges: CompletedTitleExchange[] = [];
+	let user: { id: string; text: string } | undefined;
+	let delegated = false;
+	for (const entry of entries) {
+		let role: string | undefined;
+		let text = "";
+		if (entry.type === "message") {
+			const message = entry.message;
+			role = message.role;
+			if (message.role !== "user" && message.role !== "assistant") continue;
+			if (message.role === "user" && message.attribution === "agent") continue;
+			text = messageText(message);
+			if (role === "user") delegated = text.trim().startsWith("<realtime_delegation>");
+			if (delegated) continue;
+			if (
+				message.role === "assistant" &&
+				(message.stopReason === "error" ||
+					message.stopReason === "aborted" ||
+					message.content.some(part => part.type === "toolCall"))
+			) {
+				if (
+					(message.stopReason === "error" || message.stopReason === "aborted") &&
+					exchanges.at(-1)?.id === user?.id
+				)
+					exchanges.pop();
+				continue;
+			}
+		} else if (entry.type === "custom" && entry.customType === "remote-realtime") {
+			const record = entry.data as Record<string, unknown> | undefined;
+			if (record?.kind !== "transcript" || typeof record.text !== "string") continue;
+			delegated = false;
+			role = String(record.role);
+			text = record.text;
+		}
+		if (!text.trim()) continue;
+		if (role === "user") user = { id: entry.id, text };
+		else if (role === "assistant" && user) {
+			const exchange = { id: user.id, user: user.text, assistant: text };
+			if (exchanges.at(-1)?.id === user.id) exchanges[exchanges.length - 1] = exchange;
+			else exchanges.push(exchange);
+		}
+	}
+	return exchanges;
+}
+
+function titleSource(exchanges: CompletedTitleExchange[], currentName?: string): string {
+	// Bound the serialized payload, including escapes, while retaining both sides of the latest exchange.
+	const recent = exchanges.slice(-3);
+	for (let budget = 120; budget >= 0; budget -= 10) {
+		const source = JSON.stringify({
+			currentTitle: currentName,
+			exchanges: recent.map(exchange => ({
+				user: truncateTitleSource(exchange.user, budget),
+				assistant: truncateTitleSource(exchange.assistant, budget),
+			})),
+		});
+		if (Buffer.byteLength(source) <= MAX_TITLE_INPUT_BYTES) return source;
+	}
+	return JSON.stringify({ currentTitle: currentName });
+}
+
+type TitleGenerator = typeof generateSessionName;
 interface TitleFlight {
 	promise: Promise<string | null>;
-	callbacks: Set<(title: string) => void>;
 }
 interface TitleCoordinator {
 	flights: Map<string, TitleFlight>;
 	listeners: Set<(title: string) => void>;
 }
 const titleCoordinators = new WeakMap<object, TitleCoordinator>();
-
 function titleCoordinator(manager: object): TitleCoordinator {
 	let state = titleCoordinators.get(manager);
 	if (!state) {
@@ -211,7 +312,6 @@ function titleCoordinator(manager: object): TitleCoordinator {
 	}
 	return state;
 }
-
 export function subscribeSessionTitle(manager: object, listener: (title: string) => void): () => void {
 	const state = titleCoordinator(manager);
 	state.listeners.add(listener);
@@ -220,37 +320,79 @@ export function subscribeSessionTitle(manager: object, listener: (title: string)
 
 export function coordinateSessionTitle(
 	target: SessionTitleTarget,
-	firstMessage: string,
-	onApplied?: (title: string) => void,
-	generate: TitleGenerator = generateSessionTitle,
+	generate: TitleGenerator = generateSessionName,
 ): Promise<string | null> {
 	const manager = target.sessionManager;
 	const state = titleCoordinator(manager as object);
-	const existing = state.flights.get(target.sessionId);
-	if (existing) {
-		if (onApplied) existing.callbacks.add(onApplied);
-		return existing.promise;
-	}
+	const sessionId = target.sessionId;
+	const existing = state.flights.get(sessionId);
+	if (existing) return existing.promise;
 	const currentName = manager.getSessionName?.() ?? target.sessionName;
-	if (process.env.PI_NO_TITLE || currentName) return Promise.resolve(null);
-	const callbacks = new Set<(title: string) => void>();
-	if (onApplied) callbacks.add(onApplied);
-	const pending = generate(firstMessage, target.modelRegistry, target.settings, target.sessionId, target.model)
-		.then(async title => {
-			if (!title || !(await target.setSessionName(title, "auto"))) return null;
-			for (const callback of [...callbacks, ...state.listeners])
+	const automatic = manager.getAutomaticTitleState?.();
+	if (
+		process.env.PI_NO_TITLE ||
+		manager.titleSource === "user" ||
+		(currentName && automatic?.status !== "provisional")
+	)
+		return Promise.resolve(null);
+	const history = () =>
+		manager.getBranch?.() ??
+		(target.messages ?? []).map((message, index) => ({
+			type: "message" as const,
+			id: `${index}:${message.timestamp}`,
+			parentId: null,
+			timestamp: new Date(message.timestamp).toISOString(),
+			message,
+		}));
+	const exchanges = completedTitleExchanges(history());
+	const latest = exchanges.at(-1);
+	if (!latest || automatic?.exchangeId === latest.id || !manager.setAutomaticSessionName) return Promise.resolve(null);
+	const revision = manager.titleRevision ?? 0;
+	const source = titleSource(exchanges, currentName);
+	const pending = generate(source, target.modelRegistry, target.settings, sessionId, target.model)
+		.then(async result => {
+			if (!result || target.sessionId !== sessionId || manager.titleRevision !== revision) return null;
+			// A still-generic refinement candidate must not replace the opening name or consume its one refinement.
+			if (currentName && result.provisional) {
+				await manager.setAutomaticSessionName!(
+					currentName,
+					{ status: "provisional", exchangeId: latest.id },
+					sessionId,
+					revision,
+				);
+				return null;
+			}
+			const title = sanitizeGeneratedSessionTitle(JSON.stringify({ title: result.title }));
+			if (
+				!title ||
+				!(await manager.setAutomaticSessionName!(
+					title,
+					{
+						status: result.provisional ? "provisional" : "refined",
+						exchangeId: latest.id,
+					},
+					sessionId,
+					revision,
+				))
+			)
+				return null;
+			if (target.sessionId !== sessionId || manager.titleRevision !== revision + 1) return null;
+			for (const listener of state.listeners)
 				try {
-					callback(title);
+					listener(title);
 				} catch {
-					// Title generation is presentation-only and must not fail the user's turn.
+					/* Presentation-only. */
 				}
 			return title;
 		})
 		.catch(() => null)
 		.finally(() => {
-			if (state.flights.get(target.sessionId)?.promise === pending) state.flights.delete(target.sessionId);
+			if (state.flights.get(sessionId)?.promise === pending) state.flights.delete(sessionId);
+			// Another exchange may finish during inference. Retry only for new history, never for a failed request.
+			if (target.sessionId === sessionId && completedTitleExchanges(history()).at(-1)?.id !== latest.id)
+				void coordinateSessionTitle(target, generate);
 		});
-	state.flights.set(target.sessionId, { promise: pending, callbacks });
+	state.flights.set(sessionId, { promise: pending });
 	return pending;
 }
 

package/src/prompts/system/eager-todo.md

@@ -1,13 +0,0 @@
-<system-reminder>
-Before doing substantive work on the upcoming user request, create a comprehensive phased todo first.
-
-You **MUST** call `todo_write` first in this turn.
-You **MUST** initialize the todo list with a single `replace` op.
-You **MUST** cover the entire request from investigation through implementation and verification — not just the next immediate step.
-You **MUST** make task descriptions specific enough that a future turn can execute them without re-planning.
-You **MUST** keep task `content` to a short label (5-10 words). Put file paths, implementation steps, and specifics in `details`.
-You **MUST** keep exactly one task `in_progress` and all later tasks `pending`.
-
-After the initial `todo_write` call succeeds, continue with the user's request in the same turn.
-Do not emit another `todo_write` call unless task state materially changed.
-</system-reminder>