@f5-sales-demo/xcsh 19.92.1 → 19.93.0

package/package.json

@@ -1,7 +1,7 @@
 {
 	"type": "module",
 	"name": "@f5-sales-demo/xcsh",
-	"version": "19.92.1",
+	"version": "19.93.0",
 	"description": "Coding agent CLI with read, bash, edit, write tools and session management",
 	"homepage": "https://github.com/f5-sales-demo/xcsh",
 	"author": "Can Boluk",
@@ -56,13 +56,13 @@
 	"dependencies": {
 		"@agentclientprotocol/sdk": "1.3.0",
 		"@mozilla/readability": "^0.6",
-		"@f5-sales-demo/xcsh-stats": "19.92.1",
-		"@f5-sales-demo/pi-agent-core": "19.92.1",
-		"@f5-sales-demo/pi-ai": "19.92.1",
-		"@f5-sales-demo/pi-natives": "19.92.1",
-		"@f5-sales-demo/pi-resource-management": "19.92.1",
-		"@f5-sales-demo/pi-tui": "19.92.1",
-		"@f5-sales-demo/pi-utils": "19.92.1",
+		"@f5-sales-demo/xcsh-stats": "19.93.0",
+		"@f5-sales-demo/pi-agent-core": "19.93.0",
+		"@f5-sales-demo/pi-ai": "19.93.0",
+		"@f5-sales-demo/pi-natives": "19.93.0",
+		"@f5-sales-demo/pi-resource-management": "19.93.0",
+		"@f5-sales-demo/pi-tui": "19.93.0",
+		"@f5-sales-demo/pi-utils": "19.93.0",
 		"@sinclair/typebox": "^0.34",
 		"@xterm/headless": "^6.0",
 		"ajv": "^8.20",

package/src/browser/chat-handler.ts

@@ -10,6 +10,7 @@ import {
 	normalizeHostToolDefinitions,
 	RpcHostToolBridge,
 } from "../host-tools";
+import { extractReferences } from "../references";
 import type { AgentSession, AgentSessionEvent } from "../session/agent-session";
 import {
 	type ChatDelta,
@@ -17,7 +18,6 @@ import {
 	type ChatError,
 	type ChatErrorReason,
 	type ChatKeepalive,
-	type ChatReference,
 	type ChatRequest,
 	type Configure,
 	type ConfigureAck,
@@ -680,39 +680,6 @@ function composeBrowserPageContext(parts: string[], context: PageContextSnapshot
 	parts.push("---");
 }
 
-export function classifyReferenceKind(url: string): "doc" | "console" {
-	try {
-		const parsed = new URL(url);
-		if (/\.console\.ves\.volterra\.io$/.test(parsed.hostname)) return "console";
-		if (parsed.hostname === "docs.cloud.f5.com" || parsed.pathname.startsWith("/docs")) return "doc";
-	} catch {
-		/* malformed URL — default to doc */
-	}
-	return "doc";
-}
-
-function titleFromUrl(url: string): string {
-	try {
-		const parsed = new URL(url);
-		const segments = parsed.pathname.split("/").filter(Boolean);
-		return segments.length > 0 ? segments[segments.length - 1] : parsed.hostname;
-	} catch {
-		return url;
-	}
-}
-
-/**
- * Trailing characters a bare-URL match may greedily swallow at a markdown/prose
- * boundary — markdown emphasis + code (`*_~` and backtick) and sentence/wrap
- * punctuation. A real URL effectively never ends in these, so trimming them yields
- * the intended link (e.g. `**https://…/llms.txt**` or a code-wrapped
- * `` `https://…/llms.txt` `` → `https://…/llms.txt`). The markdown-link branch is
- * bounded by its closing `)` and needs no trimming.
- */
-function trimTrailingMarkup(url: string): string {
-	return url.replace(/[*_~`,.;:!?'")\]}>]+$/, "");
-}
-
 /** Panel-facing labels for provider-side tools, used for the activity rows (#2340). */
 function serverToolLabels(toolName: string): { running: string; done: string } {
 	switch (toolName) {
@@ -724,47 +691,3 @@ function serverToolLabels(toolName: string): { running: string; done: string } {
 			return { running: `${toolName}: running`, done: toolName };
 	}
 }
-
-export function extractReferences(msg: AssistantMessage): ChatReference[] {
-	const refs: ChatReference[] = [];
-	const seen = new Set<string>();
-
-	// STRUCTURED CITATIONS FIRST (#2340): a provider-side search reports the real page title, so
-	// it beats the regex scrape below — which can only guess a title from the URL path, and finds
-	// nothing at all when the model cites a source without printing its URL in the prose. Done as
-	// its own pass so a citation in a later block still wins over a scrape in an earlier one.
-	for (const block of msg.content) {
-		if (block.type !== "text" || !block.citations) continue;
-		for (const citation of block.citations) {
-			const url = citation.url;
-			if (!url || seen.has(url)) continue;
-			seen.add(url);
-			refs.push({
-				kind: classifyReferenceKind(url),
-				title: citation.title?.trim() || titleFromUrl(url),
-				url,
-			});
-		}
-	}
-
-	for (const block of msg.content) {
-		if (block.type !== "text") continue;
-
-		const mdLinkRegex = /\[([^\]]+)\]\((https?:\/\/[^\s)]+)\)/g;
-		for (let match = mdLinkRegex.exec(block.text); match !== null; match = mdLinkRegex.exec(block.text)) {
-			const [, title, url] = match;
-			if (seen.has(url)) continue;
-			seen.add(url);
-			refs.push({ kind: classifyReferenceKind(url), title, url });
-		}
-
-		const bareUrlRegex = /(?<!\()(https?:\/\/[^\s)>\]]+)/g;
-		for (let match = bareUrlRegex.exec(block.text); match !== null; match = bareUrlRegex.exec(block.text)) {
-			const url = trimTrailingMarkup(match[1]);
-			if (seen.has(url)) continue;
-			seen.add(url);
-			refs.push({ kind: classifyReferenceKind(url), title: titleFromUrl(url), url });
-		}
-	}
-	return refs;
-}

package/src/internal-urls/build-info.generated.ts

@@ -17,17 +17,17 @@ export interface BuildInfo {
 }
 
 export const BUILD_INFO: BuildInfo = {
-	"version": "19.92.1",
-	"commit": "f3e12dd43623f1171d4dff7c837532e64ab8bb4b",
-	"shortCommit": "f3e12dd",
+	"version": "19.93.0",
+	"commit": "212247c75cbe621350eda99e20ca752b44cd730f",
+	"shortCommit": "212247c",
 	"branch": "main",
-	"tag": "v19.92.1",
-	"commitDate": "2026-07-26T01:09:53Z",
-	"buildDate": "2026-07-26T01:30:47.762Z",
+	"tag": "v19.93.0",
+	"commitDate": "2026-07-26T05:23:45Z",
+	"buildDate": "2026-07-26T05:48:10.440Z",
 	"dirty": true,
 	"prNumber": "",
 	"repoUrl": "https://github.com/f5-sales-demo/xcsh",
 	"repoSlug": "f5-sales-demo/xcsh",
-	"commitUrl": "https://github.com/f5-sales-demo/xcsh/commit/f3e12dd43623f1171d4dff7c837532e64ab8bb4b",
-	"releaseUrl": "https://github.com/f5-sales-demo/xcsh/releases/tag/v19.92.1"
+	"commitUrl": "https://github.com/f5-sales-demo/xcsh/commit/212247c75cbe621350eda99e20ca752b44cd730f",
+	"releaseUrl": "https://github.com/f5-sales-demo/xcsh/releases/tag/v19.93.0"
 };

package/src/internal-urls/terraform-index.generated.ts

@@ -148,6 +148,22 @@ export const TERRAFORM_INDEX: TerraformIndex = {
 				"workload_flavor",
 			],
 		},
+		{
+			name: "Uncategorized",
+			slug: "uncategorized",
+			description: "Resources pending categorization",
+			resource_count: 8,
+			resources: [
+				"application_profiles",
+				"authorization_server",
+				"bot_infrastructure",
+				"domain",
+				"mitigated_domain",
+				"protected_application",
+				"protected_domain",
+				"registration_approval",
+			],
+		},
 		{
 			name: "DNS",
 			slug: "dns",
@@ -163,21 +179,6 @@ export const TERRAFORM_INDEX: TerraformIndex = {
 				"dns_zone",
 			],
 		},
-		{
-			name: "Uncategorized",
-			slug: "uncategorized",
-			description: "Resources pending categorization",
-			resource_count: 7,
-			resources: [
-				"application_profiles",
-				"authorization_server",
-				"bot_infrastructure",
-				"mitigated_domain",
-				"protected_application",
-				"protected_domain",
-				"registration_approval",
-			],
-		},
 		{
 			name: "API Security",
 			slug: "api-security",
@@ -185,13 +186,6 @@ export const TERRAFORM_INDEX: TerraformIndex = {
 			resource_count: 5,
 			resources: ["api_crawler", "api_definition", "api_discovery", "api_testing", "app_api_group"],
 		},
-		{
-			name: "Monitoring",
-			slug: "monitoring",
-			description: "Log receivers, alert policies, APM, and global logging configuration",
-			resource_count: 5,
-			resources: ["alert_receiver", "alert_template", "apm", "global_log_receiver", "log_receiver"],
-		},
 		{
 			name: "Applications",
 			slug: "applications",
@@ -213,6 +207,13 @@ export const TERRAFORM_INDEX: TerraformIndex = {
 			resource_count: 4,
 			resources: ["certificate", "certificate_chain", "crl", "trusted_ca_list"],
 		},
+		{
+			name: "Monitoring",
+			slug: "monitoring",
+			description: "Log receivers, alert policies, APM, and global logging configuration",
+			resource_count: 4,
+			resources: ["alert_receiver", "alert_template", "global_log_receiver", "log_receiver"],
+		},
 		{
 			name: "VPN",
 			slug: "vpn",
@@ -386,16 +387,6 @@ export const TERRAFORM_INDEX: TerraformIndex = {
 			},
 			import_syntax: "terraform import xcsh_api_testing.example namespace/name",
 		},
-		apm: {
-			category: "monitoring",
-			description: "New APM as a service with configured parameters",
-			required: ["name", "namespace"],
-			minimal_config: 'resource "xcsh_apm" "example" {\n  name      = "example-apm"\n  namespace = "staging"\n}',
-			dependencies: {
-				requires: [],
-			},
-			import_syntax: "terraform import xcsh_apm.example namespace/name",
-		},
 		app_api_group: {
 			category: "api-security",
 			description: "App_api_group creates a new object in the storage backend for metadata.namespace",
@@ -531,7 +522,7 @@ export const TERRAFORM_INDEX: TerraformIndex = {
 		bgp_routing_policy: {
 			category: "security",
 			description:
-				"Bgp routing policy is a list of rules containing match criteria and action to be applied. these rules help contol routes which are imported or exported to bgp peers. configuration",
+				"Bgp routing policy is a list of rules containing match criteria and action to be applied. these rules help control routes which are imported or exported to bgp peers. configuration",
 			required: ["name", "namespace"],
 			minimal_config:
 				'resource "xcsh_bgp_routing_policy" "example" {\n  name      = "example-bgp-routing-policy"\n  namespace = "staging"\n}',
@@ -857,6 +848,17 @@ export const TERRAFORM_INDEX: TerraformIndex = {
 			},
 			import_syntax: "terraform import xcsh_dns_zone.example namespace/name",
 		},
+		domain: {
+			category: "uncategorized",
+			description: "Allowed domain",
+			required: ["name", "namespace", "allowed_domain"],
+			minimal_config:
+				'resource "xcsh_domain" "example" {\n  name      = "example-domain"\n  namespace = "staging"\n\n  allowed_domain = "example-value"\n}',
+			dependencies: {
+				requires: [],
+			},
+			import_syntax: "terraform import xcsh_domain.example namespace/name",
+		},
 		endpoint: {
 			category: "load-balancing",
 			description: "Endpoint will create the object in the storage backend for namespace metadata.namespace",
@@ -1636,9 +1638,9 @@ export const TERRAFORM_INDEX: TerraformIndex = {
 		udp_loadbalancer: {
 			category: "load-balancing",
 			description: "Load balancing UDP traffic across origin pools",
-			required: ["name", "namespace", "dns_volterra_managed", "enable_per_packet_load_balancing", "idle_timeout"],
+			required: ["name", "namespace", "dns_volterra_managed", "idle_timeout"],
 			minimal_config:
-				'resource "xcsh_udp_loadbalancer" "example" {\n  name      = "example-udp-loadbalancer"\n  namespace = "staging"\n\n  domains                          = ["example-value"]\n  dns_volterra_managed             = true\n  enable_per_packet_load_balancing = true\n  idle_timeout                     = 1\n}',
+				'resource "xcsh_udp_loadbalancer" "example" {\n  name      = "example-udp-loadbalancer"\n  namespace = "staging"\n\n  domains              = ["example-value"]\n  dns_volterra_managed = true\n  idle_timeout         = 1\n}',
 			dependencies: {
 				requires: ["namespace", "origin_pool"],
 			},

package/src/modes/rpc/rpc-mode.ts

@@ -24,6 +24,7 @@ import {
 	RpcHostToolBridge,
 } from "../../host-tools";
 import { type Theme, theme } from "../../modes/theme/theme";
+import { referencesEventFor } from "../../references";
 import type { AgentSession } from "../../session/agent-session";
 import { mapContextStatus, runWelcomeChecks } from "../components/welcome-checks";
 import type {
@@ -497,6 +498,11 @@ export async function runRpcMode(session: AgentSession): Promise<never> {
 	// Output all agent events as JSON
 	session.subscribe(event => {
 		output(event);
+		// Citations for the host's Sources chips, mirroring `chat_done.references` on
+		// the WS bridge. The turn-boundary rule (an intermediate tool-use step also
+		// emits message_end) lives in the shared, tested `referencesEventFor` (#2420).
+		const refs = referencesEventFor(event);
+		if (refs) output(refs);
 	});
 
 	// Handle a single command

package/src/references.ts

@@ -0,0 +1,116 @@
+/**
+ * Citation extraction — the "Sources" chips a surface shows under an answer.
+ *
+ * Neutral module ON PURPOSE. This used to live in `browser/chat-handler.ts`, whose
+ * 14 imports would have dragged the whole browser chat stack into the RPC path when
+ * `rpc-mode` needed the same extraction (#2420). One extractor, and one rule for
+ * "which assistant message ends a turn", shared by every transport — a client
+ * reimplementing either would drift (see the #2249 trailing-markup regression).
+ */
+import type { AssistantMessage } from "@f5-sales-demo/pi-ai";
+import type { ChatReference } from "./browser/chat-protocol";
+
+export function classifyReferenceKind(url: string): "doc" | "console" {
+	try {
+		const parsed = new URL(url);
+		if (/\.console\.ves\.volterra\.io$/.test(parsed.hostname)) return "console";
+		if (parsed.hostname === "docs.cloud.f5.com" || parsed.pathname.startsWith("/docs")) return "doc";
+	} catch {
+		/* malformed URL — default to doc */
+	}
+	return "doc";
+}
+function titleFromUrl(url: string): string {
+	try {
+		const parsed = new URL(url);
+		const segments = parsed.pathname.split("/").filter(Boolean);
+		return segments.length > 0 ? segments[segments.length - 1] : parsed.hostname;
+	} catch {
+		return url;
+	}
+}
+/**
+ * Trailing characters a bare-URL match may greedily swallow at a markdown/prose
+ * boundary — markdown emphasis + code (`*_~` and backtick) and sentence/wrap
+ * punctuation. A real URL effectively never ends in these, so trimming them yields
+ * the intended link (e.g. `**https://…/llms.txt**` or a code-wrapped
+ * `` `https://…/llms.txt` `` → `https://…/llms.txt`). The markdown-link branch is
+ * bounded by its closing `)` and needs no trimming.
+ */
+function trimTrailingMarkup(url: string): string {
+	return url.replace(/[*_~`,.;:!?'")\]}>]+$/, "");
+}
+export function extractReferences(msg: AssistantMessage): ChatReference[] {
+	const refs: ChatReference[] = [];
+	const seen = new Set<string>();
+
+	// STRUCTURED CITATIONS FIRST (#2340): a provider-side search reports the real page title, so
+	// it beats the regex scrape below — which can only guess a title from the URL path, and finds
+	// nothing at all when the model cites a source without printing its URL in the prose. Done as
+	// its own pass so a citation in a later block still wins over a scrape in an earlier one.
+	for (const block of msg.content) {
+		if (block.type !== "text" || !block.citations) continue;
+		for (const citation of block.citations) {
+			const url = citation.url;
+			if (!url || seen.has(url)) continue;
+			seen.add(url);
+			refs.push({
+				kind: classifyReferenceKind(url),
+				title: citation.title?.trim() || titleFromUrl(url),
+				url,
+			});
+		}
+	}
+
+	for (const block of msg.content) {
+		if (block.type !== "text") continue;
+
+		const mdLinkRegex = /\[([^\]]+)\]\((https?:\/\/[^\s)]+)\)/g;
+		for (let match = mdLinkRegex.exec(block.text); match !== null; match = mdLinkRegex.exec(block.text)) {
+			const [, title, url] = match;
+			if (seen.has(url)) continue;
+			seen.add(url);
+			refs.push({ kind: classifyReferenceKind(url), title, url });
+		}
+
+		const bareUrlRegex = /(?<!\()(https?:\/\/[^\s)>\]]+)/g;
+		for (let match = bareUrlRegex.exec(block.text); match !== null; match = bareUrlRegex.exec(block.text)) {
+			const url = trimTrailingMarkup(match[1]);
+			if (seen.has(url)) continue;
+			seen.add(url);
+			refs.push({ kind: classifyReferenceKind(url), title: titleFromUrl(url), url });
+		}
+	}
+	return refs;
+}
+
+/** The RPC stream's citation event, mirroring `chat_done.references` on the bridge. */
+export interface RpcReferencesEvent {
+	type: "references";
+	references: ChatReference[];
+}
+
+/**
+ * Decide whether an agent event should produce a citation event, and build it.
+ *
+ * Pure so the TURN-BOUNDARY rule is testable: an intermediate tool-use step also
+ * emits `message_end`, and treating that as terminal is the trap
+ * `chat-handler.ts` documents at length — it would publish the citations of a
+ * half-finished answer (and, on the bridge, end the turn early). Returns null for
+ * anything that is not a settled assistant message, and for a turn that cited
+ * nothing, so callers emit only real content.
+ *
+ * Typed by what it CONSUMES (a tagged event that may carry a message) rather than by
+ * one event union: the bridge and the RPC session stream different unions
+ * (`AgentEvent` vs `AgentSessionEvent`) and both must be able to call this.
+ */
+export function referencesEventFor(event: { type: string; message?: unknown }): RpcReferencesEvent | null {
+	if (event.type !== "message_end") return null;
+	const message = (event as { message?: { role?: string } }).message;
+	if (message?.role !== "assistant") return null;
+	const assistant = message as AssistantMessage;
+	// Intermediate tool-use step — the turn continues after the tool round-trip.
+	if (assistant.stopReason === "toolUse" || assistant.content.some(part => part.type === "toolCall")) return null;
+	const references = extractReferences(assistant);
+	return references.length > 0 ? { type: "references", references } : null;
+}