@f5-sales-demo/xcsh 19.62.0 → 19.62.1

package/package.json

@@ -1,7 +1,7 @@
 {
 	"type": "module",
 	"name": "@f5-sales-demo/xcsh",
-	"version": "19.62.0",
+	"version": "19.62.1",
 	"description": "Coding agent CLI with read, bash, edit, write tools and session management",
 	"homepage": "https://github.com/f5-sales-demo/xcsh",
 	"author": "Can Boluk",
@@ -56,13 +56,13 @@
 	"dependencies": {
 		"@agentclientprotocol/sdk": "0.16.1",
 		"@mozilla/readability": "^0.6",
-		"@f5-sales-demo/xcsh-stats": "19.62.0",
-		"@f5-sales-demo/pi-agent-core": "19.62.0",
-		"@f5-sales-demo/pi-ai": "19.62.0",
-		"@f5-sales-demo/pi-natives": "19.62.0",
-		"@f5-sales-demo/pi-resource-management": "19.62.0",
-		"@f5-sales-demo/pi-tui": "19.62.0",
-		"@f5-sales-demo/pi-utils": "19.62.0",
+		"@f5-sales-demo/xcsh-stats": "19.62.1",
+		"@f5-sales-demo/pi-agent-core": "19.62.1",
+		"@f5-sales-demo/pi-ai": "19.62.1",
+		"@f5-sales-demo/pi-natives": "19.62.1",
+		"@f5-sales-demo/pi-resource-management": "19.62.1",
+		"@f5-sales-demo/pi-tui": "19.62.1",
+		"@f5-sales-demo/pi-utils": "19.62.1",
 		"@sinclair/typebox": "^0.34",
 		"@xterm/headless": "^6.0",
 		"ajv": "^8.20",

package/src/commands/manager-core.ts

@@ -131,6 +131,25 @@ export function touchLastSeen(reg: Registry, sessionId: string | undefined, now:
 	return true;
 }
 
+/** True iff this manager should self-recycle because it is running a STALE on-disk
+ * binary. Only for a COMPILED install: after `brew upgrade` + `brew cleanup`, the old
+ * versioned binary the manager was launched from is DELETED, yet the process lingers
+ * on the freed inode — and can no longer spawn workers/spares (spawn ENOENT), which
+ * surfaces as the extension's "xcsh didn't start". Detecting the deleted binary lets
+ * the manager step down so a fresh one (launched from the version-stable PATH wrapper)
+ * takes over. Dev (`bun src/cli.ts`) has a live interpreter execPath → never stale.
+ * Fail-closed: any error from `exists` → NOT stale, so uncertainty never triggers a
+ * recycle loop. Only the unambiguous deleted-binary signal is used (a version/realpath
+ * drift signal was deliberately NOT added — false positives would flap-recycle). */
+export function binaryIsStale(opts: { compiled: boolean; execPath: string; exists: (p: string) => boolean }): boolean {
+	if (!opts.compiled) return false;
+	try {
+		return !opts.exists(opts.execPath);
+	} catch {
+		return false;
+	}
+}
+
 /** The NDJSON keepalive an actively-chatting worker writes to the manager control
  * socket to refresh its `lastSeen` (consumed by `touchLastSeen`). Null for the
  * unbound `spare` sentinel or an empty id — a spare has no session to keep alive. */

package/src/commands/manager.ts

@@ -26,8 +26,11 @@ import { Command } from "@f5-sales-demo/pi-utils/cli";
 // slows the manager's cold start — keep the daemon's module graph minimal).
 import { VERSION } from "@f5-sales-demo/pi-utils/dirs";
 import { portCandidates } from "../browser/extension-bridge";
+// Lean standalone fn (compiled-runtime detection) — no heavy graph, safe for the daemon.
+import { detectCompiledRuntime } from "../internal-urls/build-info-runtime";
 import { removeManagerState, writeManagerState } from "../services/manager-state";
 import {
+	binaryIsStale,
 	needsProvision,
 	parseControlMsg,
 	pickPort,
@@ -209,6 +212,17 @@ export default class Manager extends Command {
 		// (production always reports the real binary VERSION).
 		const selfVersion = process.env.XCSH_MANAGER_VERSION || VERSION;
 
+		// Durable-upgrade self-recycle (#upgrade-recycle): a compiled manager whose
+		// on-disk binary was removed by `brew upgrade`+`brew cleanup` lingers on the
+		// freed inode but can no longer spawn workers (ENOENT) → it must step down so a
+		// fresh manager (from the version-stable PATH wrapper) takes over. Dev is never
+		// compiled → never stale. `XCSH_FORCE_STALE=1` lets the dev-mode integration test
+		// exercise the recycle path (same env-override convention as XCSH_MANAGER_VERSION).
+		const compiled = detectCompiledRuntime(import.meta.url, Bun.env);
+		const isSelfStale = (): boolean =>
+			process.env.XCSH_FORCE_STALE === "1" ||
+			binaryIsStale({ compiled, execPath: process.execPath, exists: fs.existsSync });
+
 		// Lifecycle gate (#1874): once we begin graceful shutdown we stop accepting
 		// provisions (the host retries the successor manager) and never double-run
 		// the teardown.
@@ -430,13 +444,22 @@ export default class Manager extends Command {
 			const msg = parseControlMsg(raw);
 			if (!msg) return; // fail closed on unknown/invalid frames
 			if (msg.type === "provision") {
-				// Draining: refuse new work so the host retries the successor manager.
-				if (!accepting) {
+				// Draining, OR self-stale (our binary was removed by an upgrade): refuse
+				// this provision so the host retries the successor manager — spawning now
+				// would ENOENT on the deleted binary. If stale-but-still-accepting, step
+				// down immediately so the fresh manager takes over in seconds (not on the
+				// ≤60s sweep). Reuses the existing draining reply/contract.
+				const stale = accepting && isSelfStale();
+				if (!accepting || stale) {
 					try {
 						socket.write(`${JSON.stringify({ type: "draining" })}\n`);
 					} catch {
 						/* client hung up */
 					}
+					if (stale) {
+						console.error("[xcsh manager] binary is stale (upgraded/removed) — recycling on provision");
+						gracefulShutdown("updated");
+					}
 					return;
 				}
 				const provisionReceivedAt = Date.now(); // TTFT Phase 2: start of manager_provision
@@ -537,8 +560,15 @@ export default class Manager extends Command {
 		// Pre-warm the spare pool so provisions can adopt instead of cold-spawn.
 		if (poolTarget > 0) maintainPool();
 
-		// Idle sweep: reap workers untouched for longer than the TTL.
+		// Idle sweep: reap workers untouched for longer than the TTL. Also self-recycle
+		// if our own binary went stale (upgrade removed it) — a lingering deleted-binary
+		// manager can't spawn workers, so step down for a fresh one (#upgrade-recycle).
 		setInterval(() => {
+			if (isSelfStale()) {
+				console.error("[xcsh manager] binary is stale (upgraded/removed) — recycling on sweep");
+				gracefulShutdown("updated");
+				return;
+			}
 			for (const key of staleKeys(reg, Date.now(), IDLE_MS)) reap(key);
 		}, SWEEP_MS);
 

package/src/internal-urls/build-info.generated.ts

@@ -17,17 +17,17 @@ export interface BuildInfo {
 }
 
 export const BUILD_INFO: BuildInfo = {
-	"version": "19.62.0",
-	"commit": "002bc2b7d7e14a95e282f940730cbdc347197635",
-	"shortCommit": "002bc2b",
+	"version": "19.62.1",
+	"commit": "914880a26dc07e8cbfe5f79dcaef4012e559779d",
+	"shortCommit": "914880a",
 	"branch": "main",
-	"tag": "v19.62.0",
-	"commitDate": "2026-07-08T02:22:10Z",
-	"buildDate": "2026-07-08T02:45:44.169Z",
+	"tag": "v19.62.1",
+	"commitDate": "2026-07-08T16:48:22Z",
+	"buildDate": "2026-07-08T17:15:30.572Z",
 	"dirty": true,
 	"prNumber": "",
 	"repoUrl": "https://github.com/f5-sales-demo/xcsh",
 	"repoSlug": "f5-sales-demo/xcsh",
-	"commitUrl": "https://github.com/f5-sales-demo/xcsh/commit/002bc2b7d7e14a95e282f940730cbdc347197635",
-	"releaseUrl": "https://github.com/f5-sales-demo/xcsh/releases/tag/v19.62.0"
+	"commitUrl": "https://github.com/f5-sales-demo/xcsh/commit/914880a26dc07e8cbfe5f79dcaef4012e559779d",
+	"releaseUrl": "https://github.com/f5-sales-demo/xcsh/releases/tag/v19.62.1"
 };