@f5-sales-demo/xcsh 19.61.3 → 19.61.4

package/package.json

@@ -1,7 +1,7 @@
 {
 	"type": "module",
 	"name": "@f5-sales-demo/xcsh",
-	"version": "19.61.3",
+	"version": "19.61.4",
 	"description": "Coding agent CLI with read, bash, edit, write tools and session management",
 	"homepage": "https://github.com/f5-sales-demo/xcsh",
 	"author": "Can Boluk",
@@ -56,13 +56,13 @@
 	"dependencies": {
 		"@agentclientprotocol/sdk": "0.16.1",
 		"@mozilla/readability": "^0.6",
-		"@f5-sales-demo/xcsh-stats": "19.61.3",
-		"@f5-sales-demo/pi-agent-core": "19.61.3",
-		"@f5-sales-demo/pi-ai": "19.61.3",
-		"@f5-sales-demo/pi-natives": "19.61.3",
-		"@f5-sales-demo/pi-resource-management": "19.61.3",
-		"@f5-sales-demo/pi-tui": "19.61.3",
-		"@f5-sales-demo/pi-utils": "19.61.3",
+		"@f5-sales-demo/xcsh-stats": "19.61.4",
+		"@f5-sales-demo/pi-agent-core": "19.61.4",
+		"@f5-sales-demo/pi-ai": "19.61.4",
+		"@f5-sales-demo/pi-natives": "19.61.4",
+		"@f5-sales-demo/pi-resource-management": "19.61.4",
+		"@f5-sales-demo/pi-tui": "19.61.4",
+		"@f5-sales-demo/pi-utils": "19.61.4",
 		"@sinclair/typebox": "^0.34",
 		"@xterm/headless": "^6.0",
 		"ajv": "^8.20",

package/src/browser/ttft-spans.ts

@@ -28,6 +28,17 @@ export function chatSpans(id: string, entryAt: number, promptAt: number, firstDe
 	];
 }
 
+/**
+ * Build the session-build span: the heavy `createAgentSession` step (model
+ * registry load, discovery, extension/plugin loading, context bootstrap) that
+ * runs between `worker_boot` (ends at bridge-listen) and `chat_handler`. Without
+ * this stage the cost is silently absorbed into total ttft_ms, hiding plugin/
+ * discovery regressions from the bench and the diagnostics panel.
+ */
+export function sessionBuildSpan(sid: string, cold: boolean, ms: number): SpanFrame {
+	return { type: "span", stage: "session_build", ms: clamp(ms), sid, cold };
+}
+
 /** Build the per-session cold-start spans, tagged with the session id + authoritative cold. */
 export function coldStartSpans(
 	sid: string,

package/src/commands/worker.ts

@@ -19,7 +19,7 @@ import { ChatHandler } from "../browser/chat-handler";
 import { startBridgeServer } from "../browser/extension-bridge";
 import { createExtensionBridgeTools, EXTENSION_AGENT_TOOL_NAMES } from "../browser/extension-bridge-tools";
 import { setSharedBridgeServer } from "../browser/provider";
-import { coldStartSpans, type SpanFrame } from "../browser/ttft-spans";
+import { coldStartSpans, type SpanFrame, sessionBuildSpan } from "../browser/ttft-spans";
 import { initializeWithSettings } from "../discovery";
 import { createAgentSession } from "../sdk";
 import { activateTenantContext } from "../services/session-context-binding";
@@ -162,11 +162,22 @@ export default class Worker extends Command {
 			for (const s of coldStartBuffer) bridge.send(s);
 			coldStartSent = true;
 		};
+		// TTFT: the session_build span (createAgentSession seam) is computed after the
+		// bridge is listening but possibly before the extension connects — buffer it and
+		// flush on connect, same as the cold-start spans.
+		let sessionBuildFrame: SpanFrame | null = null;
+		let sessionBuildSent = false;
+		const flushSessionBuild = (): void => {
+			if (sessionBuildSent || !clientConnected || !sessionBuildFrame) return;
+			bridge.send(sessionBuildFrame);
+			sessionBuildSent = true;
+		};
 		// onConnected (raw WS open) is the deliberate flush trigger: no hello hook is exposed
 		// today, and the bridge's origin check already gates opens to the extension.
 		bridge.onConnected(() => {
 			clientConnected = true;
 			flushColdStart();
+			flushSessionBuild();
 		});
 
 		if (coldSpawn && process.env.XCSH_SESSION_ID && Number.isFinite(spawnAtEnv)) {
@@ -218,6 +229,7 @@ export default class Worker extends Command {
 		// session:createAgentSession — the heavy step between bridge-ready and
 		// session-ready (model registry, tools, context bootstrap). Wrapped as a span
 		// (parity with main.ts:892) so PI_TIMING reveals the per-tab session-load split.
+		const sessionBuildStart = Date.now();
 		const { session } = await logger.time("session:createAgentSession", createAgentSession, {
 			cwd,
 			hasUI: false,
@@ -232,6 +244,15 @@ export default class Worker extends Command {
 			// sets XCSH_BENCH_EXTENSION (absolute path). Inert for normal workers.
 			...(process.env.XCSH_BENCH_EXTENSION ? { additionalExtensionPaths: [process.env.XCSH_BENCH_EXTENSION] } : {}),
 		});
+		// TTFT: emit the session_build stage (createAgentSession seam) as a WS span so the
+		// bench and diagnostics panel stop hiding plugin/discovery/registry-load cost inside
+		// total ttft_ms. Buffered + flushed on connect (parity with cold-start spans).
+		sessionBuildFrame = sessionBuildSpan(
+			process.env.XCSH_SESSION_ID ?? "",
+			coldSpawn,
+			Date.now() - sessionBuildStart,
+		);
+		flushSessionBuild();
 
 		// TTFT Phase 3 hermeticity: the bench-instant stand-in provider is registered while
 		// createAgentSession loads the bench extension (additionalExtensionPaths), which is

package/src/config/auto-config.ts

@@ -16,6 +16,7 @@
 import * as fs from "node:fs";
 import * as path from "node:path";
 import { $env, logger, readProviderFromModelsYml } from "@f5-sales-demo/pi-utils";
+import { DEFAULT_MODEL_ROLE } from "./settings-schema";
 
 /** Current config schema version. Bump when the generated format changes. */
 export const CURRENT_CONFIG_VERSION = 2;
@@ -118,47 +119,68 @@ export function readLiteLLMConfig(modelsPath: string): LiteLLMConfig | undefined
 	return { baseUrl: resolvedBaseUrl, apiKey: resolvedApiKey };
 }
 
-/** Generate config.yml with sensible defaults for LiteLLM. */
+/**
+ * The default model role is baked into the binary (settings-schema `modelRoles`
+ * default) so a fresh install needs NO config.yml. Re-exported here for the
+ * healer and tests; there is a single source of truth in settings-schema.
+ */
+export const DEFAULT_MODEL_ROLE_VALUE = DEFAULT_MODEL_ROLE;
+
+/**
+ * Generate config.yml for the LiteLLM proxy.
+ *
+ * The default model role is NOT written here — it ships in the binary
+ * (settings-schema), so we never persist a model id that can go stale (the
+ * failure mode behind the invalid-model / catalog-walk bugs). This only carries
+ * settings that differ from the built-in schema defaults.
+ */
 export function generateConfigYml(): string {
 	return [
 		"# Auto-generated by xcsh for LiteLLM proxy",
-		"modelRoles:",
-		"  default: anthropic/claude-opus-4-6",
-		"",
+		"# The default model role ships in the binary — none is written here.",
 		"providers:",
 		"  image: openai",
 		"  webSearch: anthropic",
 		"",
-		"generate_image:",
-		"  enabled: true",
-		"",
-		"inspect_image:",
-		"  enabled: true",
-		"",
-		"images:",
-		"  blockImages: false",
-		"  autoResize: true",
-		"",
-		"terminal:",
-		"  showImages: true",
-		"",
 	].join("\n");
 }
 
 /**
- * Ensure config.yml has a modelRoles.default entry.
- * Existing configs from earlier versions may be missing this, causing xcsh
- * to fall through to the "first available model" fallback which picks stale
- * cached models that the proxy can't serve.
+ * Provider prefixes that are never valid as a persisted runtime default.
+ * `bench-instant` is the TTFT benchmark stand-in provider — it only registers
+ * when XCSH_BENCH_EXTENSION is set, so a `bench-instant/*` default in a normal
+ * worker is unresolvable and drops xcsh into the "first available model"
+ * fallback (which can pick a model the F5 proxy can't serve).
+ */
+const UNRESOLVABLE_DEFAULT_PROVIDER_PREFIXES = ["bench-instant/"];
+
+/**
+ * Repair a config.yml whose `modelRoles.default` can never resolve at runtime
+ * (e.g. `bench-instant/bench-instant` leaked from a benchmark run) by rewriting
+ * it to the binary default. Left unhealed, such a default triggers the
+ * catalog-wide fallback that surfaced as the AWS-SSO / invalid-model errors.
+ *
+ * A config.yml with NO `modelRoles:` needs no healing — the binary provides the
+ * default. We deliberately do not add one, to avoid persisting a stale id.
  */
 export function healConfigYmlModelRoles(configPath: string): void {
 	try {
 		const content = fs.readFileSync(configPath, "utf-8");
-		if (content.includes("modelRoles:")) return; // Already has modelRoles
-		// Prepend modelRoles section
-		const healed = `modelRoles:\n  default: anthropic/claude-opus-4-6\n\n${content}`;
-		fs.writeFileSync(configPath, healed);
-		logger.debug("Healed config.yml: added default modelRoles", { configPath });
+		if (!content.includes("modelRoles:")) return; // binary default applies
+		const defaultLine = /^(\s*)default:\s*(\S+)\s*$/m;
+		const match = content.match(defaultLine);
+		if (match) {
+			const [, indent, value] = match;
+			if (UNRESOLVABLE_DEFAULT_PROVIDER_PREFIXES.some(prefix => value.startsWith(prefix))) {
+				const healed = content.replace(defaultLine, `${indent}default: ${DEFAULT_MODEL_ROLE_VALUE}`);
+				fs.writeFileSync(configPath, healed);
+				logger.debug("Healed config.yml: replaced unresolvable default modelRole", {
+					configPath,
+					previous: value,
+					replacement: DEFAULT_MODEL_ROLE_VALUE,
+				});
+			}
+		}
 	} catch {
 		// Best-effort — don't block startup
 	}

package/src/config/model-registry.ts

@@ -774,6 +774,8 @@ export class ModelRegistry {
 	#customProviderApiKeys: Map<string, string> = new Map();
 	#keylessProviders: Set<string> = new Set();
 	#discoverableProviders: DiscoveryProviderConfig[] = [];
+	/** Provider ids explicitly configured in models.yml (empty until a config is loaded). */
+	#configuredProviderIds: Set<string> = new Set();
 	#customModelOverlays: CustomModelOverlay[] = [];
 	#providerOverrides: Map<string, ProviderOverride> = new Map();
 	#modelOverrides: Map<string, Map<string, ModelOverride>> = new Map();
@@ -923,6 +925,7 @@ export class ModelRegistry {
 		this.#configError = configError;
 		this.#keylessProviders = keylessProviders;
 		this.#discoverableProviders = discoverableProviders;
+		this.#configuredProviderIds = configuredProviders;
 		this.#customModelOverlays = customModels;
 		this.#providerOverrides = overrides;
 		this.#modelOverrides = modelOverrides;
@@ -1993,6 +1996,16 @@ export class ModelRegistry {
 		return this.#models.filter(model => this.#isModelAvailable(model));
 	}
 
+	/**
+	 * Provider ids explicitly configured in models.yml.
+	 * Empty when no config has been loaded (e.g. a fresh install before `/login`).
+	 * Used to keep automatic model selection scoped to providers the user has
+	 * actually set up, rather than probing the entire bundled catalog.
+	 */
+	getConfiguredProviderIds(): Set<string> {
+		return new Set(this.#configuredProviderIds);
+	}
+
 	getDiscoverableProviders(): string[] {
 		const disabledProviders = getDisabledProviderIdsFromSettings();
 		return this.#discoverableProviders

package/src/config/settings-schema.ts

@@ -152,6 +152,14 @@ export interface ModelTagsSettings {
 const EMPTY_STRING_ARRAY: string[] = [];
 const EMPTY_STRING_RECORD: Record<string, string> = {};
 const DEFAULT_CYCLE_ORDER: string[] = ["smol", "default", "slow"];
+/**
+ * Binary-baked default model role. Ships in the binary so a fresh install needs
+ * NO `~/.xcsh/agent/config.yml` — `/login` only supplies the (PII) proxy URL + key.
+ * The gateway serves the id `claude-opus-4-8`; its catalog entry carries the
+ * `context-1m-2025-08-07` beta for 1M context.
+ */
+export const DEFAULT_MODEL_ROLE = "anthropic/claude-opus-4-8";
+const DEFAULT_MODEL_ROLES: Record<string, string> = { default: DEFAULT_MODEL_ROLE };
 const EMPTY_MODEL_TAGS_RECORD: ModelTagsSettings = {};
 export const DEFAULT_BASH_INTERCEPTOR_RULES: BashInterceptorRule[] = [
 	{
@@ -245,7 +253,7 @@ export const SETTINGS_SCHEMA = {
 
 	disabledExtensions: { type: "array", default: EMPTY_STRING_ARRAY },
 
-	modelRoles: { type: "record", default: EMPTY_STRING_RECORD },
+	modelRoles: { type: "record", default: DEFAULT_MODEL_ROLES },
 
 	modelTags: { type: "record", default: EMPTY_MODEL_TAGS_RECORD },
 

package/src/internal-urls/build-info.generated.ts

@@ -17,17 +17,17 @@ export interface BuildInfo {
 }
 
 export const BUILD_INFO: BuildInfo = {
-	"version": "19.61.3",
-	"commit": "1546a875f07608812967e1169ea86c2bd3f837ac",
-	"shortCommit": "1546a87",
+	"version": "19.61.4",
+	"commit": "8697bc5fee06350b861c8c8bf7bbac1f00f85408",
+	"shortCommit": "8697bc5",
 	"branch": "main",
-	"tag": "v19.61.3",
-	"commitDate": "2026-07-07T11:57:08Z",
-	"buildDate": "2026-07-07T12:21:42.145Z",
+	"tag": "v19.61.4",
+	"commitDate": "2026-07-07T16:14:37Z",
+	"buildDate": "2026-07-07T16:40:48.327Z",
 	"dirty": true,
 	"prNumber": "",
 	"repoUrl": "https://github.com/f5-sales-demo/xcsh",
 	"repoSlug": "f5-sales-demo/xcsh",
-	"commitUrl": "https://github.com/f5-sales-demo/xcsh/commit/1546a875f07608812967e1169ea86c2bd3f837ac",
-	"releaseUrl": "https://github.com/f5-sales-demo/xcsh/releases/tag/v19.61.3"
+	"commitUrl": "https://github.com/f5-sales-demo/xcsh/commit/8697bc5fee06350b861c8c8bf7bbac1f00f85408",
+	"releaseUrl": "https://github.com/f5-sales-demo/xcsh/releases/tag/v19.61.4"
 };

package/src/sdk.ts

@@ -31,7 +31,13 @@ import { loadCapability } from "./capability";
 import { type Rule, ruleCapability } from "./capability/rule";
 import { hasLiteLLMEnv } from "./config/auto-config";
 import { ModelRegistry } from "./config/model-registry";
-import { formatModelString, parseModelPattern, parseModelString, resolveModelRoleValue } from "./config/model-resolver";
+import {
+	defaultModelPerProvider,
+	formatModelString,
+	parseModelPattern,
+	parseModelString,
+	resolveModelRoleValue,
+} from "./config/model-resolver";
 import { loadPromptTemplates as loadPromptTemplatesInternal, type PromptTemplate } from "./config/prompt-templates";
 import { Settings, type SkillsSettings } from "./config/settings";
 import { CursorExecHandlers } from "./cursor";
@@ -1296,8 +1302,26 @@ export async function createAgentSession(options: CreateAgentSessionOptions = {}
 		// Fall back to first available model with a valid API key.
 		// Skip fallback if the user explicitly requested a model via --model that wasn't found.
 		if (!model && !options.modelPattern) {
-			const allModels = modelRegistry.getAll();
-			for (const candidate of allModels) {
+			// Scope automatic selection to providers the user has actually configured
+			// in models.yml. This keeps a stray credential for an unconfigured provider
+			// (e.g. an expired AWS_PROFILE that makes Bedrock look "authenticated") from
+			// ever being selected, and stops us probing the entire bundled catalog. A
+			// fresh install (nothing configured) falls straight through to /login guidance
+			// instead of walking legacy catalog entries the proxy can't serve.
+			const configuredProviders = modelRegistry.getConfiguredProviderIds();
+			const candidates =
+				configuredProviders.size > 0
+					? modelRegistry.getAll().filter(candidate => configuredProviders.has(candidate.provider))
+					: [];
+			// Within a configured provider, prefer its designated default model over raw
+			// catalog order (which begins at legacy ids like claude-3-5-sonnet-20240620).
+			const isProviderDefault = (candidate: Model): boolean =>
+				defaultModelPerProvider[candidate.provider as keyof typeof defaultModelPerProvider] === candidate.id;
+			const orderedCandidates = [
+				...candidates.filter(isProviderDefault),
+				...candidates.filter(candidate => !isProviderDefault(candidate)),
+			];
+			for (const candidate of orderedCandidates) {
 				if (await hasModelApiKey(candidate)) {
 					model = candidate;
 					break;