@f5-sales-demo/pi-tui 21.13.2 → 21.14.0

package/CHANGELOG.md

@@ -2,6 +2,12 @@
 
 # Changelog
 
+## Unreleased
+
+### Fixed
+
+- Kept `@` directory completion open after Tab or Enter without inserting a trailing space ([#3724](https://github.com/f5-sales-demo/xcsh/issues/3724)).
+
 ## [20.3.0] - 2026-08-04
 
 <!-- textlint-disable terminology -->
@@ -274,7 +280,7 @@
 
 ### Fixed
 
-- Fixed terminal scrolling when displaying overlays after rendering large content, preventing hundreds of blank lines from being output
+- Fixed terminal scrolling when displaying overlays after rendering large content, preventing hundreds of empty lines from being output
 
 ## [11.3.0] - 2026-02-06
 
@@ -307,7 +313,7 @@
 
 ### Fixed
 
-- Fixed rendering of extra blank lines when content shrinks by improving cursor positioning logic during line deletion
+- Fixed rendering of extra empty lines when content shrinks by improving cursor positioning logic during line deletion
 - Fixed cursor display position in Input component when scrolling horizontally through long text
 - Fixed Kitty keyboard protocol disable sequence to use safe write method, preventing potential output buffering issues
 - Fixed unnecessary full-screen redraws when changes occur in out-of-view components (e.g., spinners), reducing terminal scroll events and improving performance on slower connections
@@ -430,7 +436,7 @@
 - Improved blockquote rendering with text wrapping in Markdown component
 - Restructured terminal capabilities from interface-based to class-based model
 - Improved table column width calculation with word-aware wrapping
-- Refactored text utilities to use native WASM implementations for strings >256 chars with JS fast path
+- Refactored text utilities to use native Wasm implementations for strings >256 chars with JS fast path
 
 ### Fixed
 

package/package.json

@@ -1,7 +1,7 @@
 {
 	"type": "module",
 	"name": "@f5-sales-demo/pi-tui",
-	"version": "21.13.2",
+	"version": "21.14.0",
 	"description": "Terminal User Interface library with differential rendering for efficient text-based applications",
 	"homepage": "https://github.com/f5-sales-demo/xcsh",
 	"author": "Can Boluk",
@@ -37,8 +37,8 @@
 		"fmt": "biome format --write ."
 	},
 	"dependencies": {
-		"@f5-sales-demo/pi-natives": "21.13.2",
-		"@f5-sales-demo/pi-utils": "21.13.2",
+		"@f5-sales-demo/pi-natives": "21.14.0",
+		"@f5-sales-demo/pi-utils": "21.14.0",
 		"marked": "^18.0"
 	},
 	"devDependencies": {

package/src/autocomplete.ts

@@ -89,6 +89,11 @@ function parsePathPrefix(prefix: string): { rawPrefix: string; isAtPrefix: boole
 	return { rawPrefix: prefix, isAtPrefix: false, isQuotedPrefix: false };
 }
 
+/** Whether a completion value represents a directory, including quoted and Windows paths. */
+export function isDirectoryCompletionValue(value: string): boolean {
+	return /[\\/]["']?$/.test(value);
+}
+
 function buildCompletionValue(
 	path: string,
 	options: { isDirectory: boolean; isAtPrefix: boolean; isQuotedPrefix: boolean },
@@ -363,15 +368,16 @@ export class CombinedAutocompleteProvider implements AutocompleteProvider {
 
 		// Check if we're completing a file attachment (prefix starts with "@")
 		if (prefix.startsWith("@")) {
-			// This is a file attachment completion
-			const newLine = `${beforePrefix + item.value} ${afterCursor}`;
+			// This is a file attachment completion. Keep directory paths open for traversal.
+			const suffix = isDirectoryCompletionValue(item.value) ? "" : " ";
+			const newLine = `${beforePrefix + item.value}${suffix}${afterCursor}`;
 			const newLines = [...lines];
 			newLines[cursorLine] = newLine;
 
 			return {
 				lines: newLines,
 				cursorLine,
-				cursorCol: beforePrefix.length + item.value.length + 1, // +1 for space
+				cursorCol: beforePrefix.length + item.value.length + suffix.length,
 			};
 		}
 

package/src/components/editor.ts

@@ -1,5 +1,9 @@
 import { $flag, getProjectDir, logger } from "@f5-sales-demo/pi-utils";
-import type { AutocompleteProvider, CombinedAutocompleteProvider } from "../autocomplete";
+import {
+	type AutocompleteProvider,
+	type CombinedAutocompleteProvider,
+	isDirectoryCompletionValue,
+} from "../autocomplete";
 import { BracketedPasteHandler } from "../bracketed-paste";
 import { getKeybindings, type KeybindingsManager } from "../keybindings";
 import { extractPrintableText, matchesKey } from "../keys";
@@ -1020,7 +1024,8 @@ export class Editor implements Component, Focusable {
 				if (kb.matches(data, "tui.input.tab")) {
 					const selected = this.#autocompleteList.getSelectedItem();
 					if (selected && this.#autocompleteProvider) {
-						const shouldChainSlashCommandAutocomplete = this.#isSlashCommandNameAutocompleteSelection();
+						const shouldChainAutocomplete =
+							this.#isSlashCommandNameAutocompleteSelection() || isDirectoryCompletionValue(selected.value);
 						const result = this.#autocompleteProvider.applyCompletion(
 							this.#state.lines,
 							this.#state.cursorLine,
@@ -1041,8 +1046,8 @@ export class Editor implements Component, Focusable {
 
 						result.onApplied?.();
 
-						if (shouldChainSlashCommandAutocomplete && this.#isCompletedSlashCommandAtCursor()) {
-							void this.#tryTriggerAutocomplete();
+						if (shouldChainAutocomplete) {
+							queueMicrotask(() => void this.#tryTriggerAutocomplete());
 						}
 					}
 					return;
@@ -1080,6 +1085,7 @@ export class Editor implements Component, Focusable {
 				else if (kb.matches(data, "tui.input.submit") || data === "\n") {
 					const selected = this.#autocompleteList.getSelectedItem();
 					if (selected && this.#autocompleteProvider) {
+						const shouldChainDirectoryCompletion = isDirectoryCompletionValue(selected.value);
 						const result = this.#autocompleteProvider.applyCompletion(
 							this.#state.lines,
 							this.#state.cursorLine,
@@ -1099,6 +1105,10 @@ export class Editor implements Component, Focusable {
 						}
 
 						result.onApplied?.();
+
+						if (shouldChainDirectoryCompletion) {
+							queueMicrotask(() => void this.#tryTriggerAutocomplete());
+						}
 					}
 					return;
 				}
@@ -2395,16 +2405,6 @@ export class Editor implements Component, Focusable {
 		return textBeforeCursor.startsWith("/") && !textBeforeCursor.includes(" ");
 	}
 
-	#isCompletedSlashCommandAtCursor(): boolean {
-		const currentLine = this.#state.lines[this.#state.cursorLine] || "";
-		if (this.#state.cursorCol !== currentLine.length) {
-			return false;
-		}
-
-		const textBeforeCursor = currentLine.slice(0, this.#state.cursorCol).trimStart();
-		return /^\/\S+ $/.test(textBeforeCursor);
-	}
-
 	// Autocomplete methods
 	async #tryTriggerAutocomplete(explicitTab: boolean = false): Promise<void> {
 		if (!this.#autocompleteProvider) return;
@@ -2493,6 +2493,7 @@ https://github.com/EsotericSoftware/spine-runtimes/actions/runs/19536643416/job/
 			// If there's exactly one suggestion and this was an explicit Tab press, apply it immediately
 			if (explicitTab && suggestions.items.length === 1) {
 				const item = suggestions.items[0]!;
+				const shouldChainDirectoryCompletion = isDirectoryCompletionValue(item.value);
 				const result = this.#autocompleteProvider.applyCompletion(
 					this.#state.lines,
 					this.#state.cursorLine,
@@ -2508,6 +2509,9 @@ https://github.com/EsotericSoftware/spine-runtimes/actions/runs/19536643416/job/
 				if (this.onChange) {
 					this.onChange(this.getText());
 				}
+				if (shouldChainDirectoryCompletion) {
+					queueMicrotask(() => void this.#tryTriggerAutocomplete());
+				}
 				return;
 			}