@eyeo/get-browser-binary 0.23.0 → 0.23.2

package/RELEASE_NOTES.md

@@ -1,5 +1,14 @@
 # Unreleased
 
+# 0.23.2
+
+- Limit Edge downloads to those seen on the linux fileserver, to solve an issue
+  where the binaries of the latest version were removed. (!151)
+
+# 0.23.1
+
+- Re-enables local network access checks on Chromium v.139 (!149)
+
 # 0.23.0
 
 - Adds beta and dev channels to Edge on Windows and MacOS (#29)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@eyeo/get-browser-binary",
-  "version": "0.23.0",
+  "version": "0.23.2",
   "description": "Install browser binaries and matching webdrivers",
   "repository": {
     "type": "git",

package/src/chromium.js

@@ -248,8 +248,6 @@ export class Chromium extends Browser {
       await checkExtensionPaths(extensionPaths);
       options.addArguments(`load-extension=${extensionPaths.join(",")}`);
     }
-    if (majorVersion >= 139)
-      options.addArguments("--disable-features=LocalNetworkAccessChecks");
     if (headless) {
       // https://www.selenium.dev/blog/2023/headless-is-going-away/
       if (majorVersion >= 109)

package/src/edge.js

@@ -156,9 +156,14 @@ export class Edge extends Browser {
 
     let {versionNumber, channel} = await Edge.#getVersionForChannel(version);
     let binary = Edge.#getBinaryPath(channel);
+
+    // Patch versions differ between Debian repo and Enterprise API.
+    // We treat same-major versions as installed to avoid re-downloads.
+    // Applies to both channel builds and numeric Linux versions.
     try {
-      if (await Edge.getInstalledVersion(binary) == versionNumber)
-        return {binary, versionNumber};
+      const installedVersion = await Edge.getInstalledVersion(binary);
+      if (getMajorVersion(installedVersion) == getMajorVersion(versionNumber))
+        return {binary, versionNumber: installedVersion};
     }
     catch (e) {}
 
@@ -183,8 +188,14 @@ export class Edge extends Browser {
         if (product.Product != downloadChannels[version])
           continue;
 
-        let release = product.Releases.find(
-          r => r.Platform == plat && r.Architecture == arch);
+        // Ideally this would only check platform and architecture, not
+        // version. However, we've run into a case where Microsoft has removed a
+        // latest stable version of Edge from the download servers without
+        // updating this index, so it helps to have some way of checking if a
+        // version is probably available.
+        let release = product.Releases.find(r => r.Platform == plat &&
+                                            r.Architecture == arch &&
+                                            r.ProductVersion == versionNumber);
         if (!release)
           continue;
 

package/test/browsers.js

@@ -333,6 +333,10 @@ for (let browser of Object.keys(BROWSERS)) {
           if (browser == "firefox" && version == "68.0")
             this.skip();
 
+          // Skipping flaky test until solution is found, see issue #89
+          if (process.platform === "win32")
+            this.skip();
+
           let {extensionPaths, manifest} = getExtension(browser, version);
           driver = await BROWSERS[browser].getDriver(
             version, {headless: false, extensionPaths, incognito: true});