@eyeo/get-browser-binary 0.20.1 → 0.20.2

package/RELEASE_NOTES.md

@@ -1,8 +1,12 @@
 # Unreleased
 
+# 0.20.2
+
+- Fixes getting majorVersion on Edge (!133)
+
 # 0.20.1
 
-- test: Fixes enabling developer mode (!131)
+- Fixes enabling developer mode (!131)
 
 # 0.20.0
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@eyeo/get-browser-binary",
-  "version": "0.20.1",
+  "version": "0.20.2",
   "description": "Install browser binaries and matching webdrivers",
   "repository": {
     "type": "git",

package/src/chromium.js

@@ -42,6 +42,17 @@ async function enableDeveloperMode(driver) {
       devModeToggle.click();
   });
 
+  await driver.wait(async() => {
+    const checked = await driver.executeScript(() => {
+      const devModeToggle = document
+      .querySelector("extensions-manager").shadowRoot
+      .getElementById("toolbar").shadowRoot
+      .querySelector("#toolbar #devMode");
+      return devModeToggle.checked;
+    });
+    return checked;
+  }, 500);
+
   await driver.close();
   await driver.switchTo().window(currentHandle);
 }

package/src/edge.js

@@ -42,6 +42,14 @@ async function enableDeveloperMode(driver) {
       devModeToggle.click();
   });
 
+  await driver.wait(async() => {
+    const checked = await driver.executeScript(() => {
+      const devModeToggle = document.getElementById("developer-mode");
+      return devModeToggle.checked;
+    });
+    return checked;
+  }, 500);
+
   await driver.close();
   await driver.switchTo().window(currentHandle);
 }
@@ -215,6 +223,7 @@ export class Edge extends Browser {
     }
 
     let options = new edge.Options().addArguments("no-sandbox", ...extraArgs);
+    let majorVersion = getMajorVersion(versionNumber);
     if (headless) {
       if (versionNumber && getMajorVersion(versionNumber) >= 114)
         options.addArguments("headless=new");
@@ -253,7 +262,7 @@ export class Edge extends Browser {
 
     // From Edge 134 on, developer mode needs to be enabled
     // for custom extensions to work properly
-    if (versionNumber >= 134)
+    if (majorVersion >= 134)
       await enableDeveloperMode(driver);
 
     return driver;