@expressive/mvc 1.0.0-beta.37 → 1.0.0-beta.38

package/lib/index.js

@@ -121,13 +121,15 @@ class Controller {
             Pending.delete(entry);
             delete subject[key];
             const desc = instruction.call(this, key, this);
-            if (!desc)
+            if (desc === false)
                 return;
-            if ("value" in desc)
-                state[key] = desc.value;
-            onSet = desc.set;
-            onGet = desc.get;
-            enumerable = desc.enumerable;
+            if (typeof desc == "object") {
+                if ("value" in desc)
+                    state[key] = desc.value;
+                onSet = desc.set;
+                onGet = desc.get;
+                enumerable = desc.enumerable;
+            }
         }
         else
             state[key] = entry;
@@ -252,16 +254,15 @@ function control(subject, cb) {
 }
 
 class Subscriber {
-    constructor(parent, onUpdate) {
+    constructor(target, onUpdate) {
         this.onUpdate = onUpdate;
         this.active = false;
         this.dependant = new Set();
         this.watch = {};
-        if (!(parent instanceof Controller))
-            parent = control(parent);
-        let reset;
+        const parent = target instanceof Controller
+            ? target : control(target);
         const proxy = create(parent.proxy);
-        const controller = parent;
+        let reset;
         define(proxy, LOCAL, this);
         defineProperty(this, "proxy", {
             configurable: true,
@@ -271,29 +272,29 @@ class Subscriber {
                 return proxy;
             }
         });
-        const onEvent = (key) => {
+        const release = parent.addListener(key => {
             const handler = this.watch[key];
-            if (!handler)
+            if (!handler || !this.active)
                 return;
             if (typeof handler == "function")
                 handler();
-            const notify = this.onUpdate(key, controller);
+            const notify = this.onUpdate(key, parent);
             const getWhy = (keys) => {
                 reset = applyUpdate(proxy, keys.filter(k => k in this.watch));
             };
             if (notify) {
-                controller.requestUpdate(getWhy);
-                controller.requestUpdate(notify);
+                parent.requestUpdate(getWhy);
+                parent.requestUpdate(notify);
             }
-        };
+        });
         this.commit = () => {
-            const release = controller.addListener(onEvent);
             this.active = true;
             this.dependant.forEach(x => x.commit());
-            return this.release = () => {
-                this.dependant.forEach(x => x.release());
-                release();
-            };
+            return this.release;
+        };
+        this.release = () => {
+            this.dependant.forEach(x => x.release());
+            release();
         };
     }
 }
@@ -384,9 +385,8 @@ function prepare(parent, key, source, setter, getter) {
         configurable: true,
         enumerable: true
     });
-    return getter
-        ? () => getter(parent, key)
-        : {};
+    if (getter)
+        return () => getter(parent, key);
 }
 function ensure(on, keys) {
     for (const key of keys) {
@@ -560,18 +560,17 @@ function apply(fn, label) {
     const placeholder = Symbol(`${name} instruction`);
     function setup(key) {
         let output = fn.call(this, key, this);
-        if (!output)
-            return;
-        if ("explicit" in output) {
+        if (typeof output == "function")
+            return { get: output };
+        if (typeof output !== "object")
+            return output || undefined;
+        if ("explicit" in output && output.explicit) {
             defineProperty(this.subject, key, output);
-            return;
+            return false;
         }
         if ("recursive" in output)
             output = Object.assign(Object.assign({}, output), { get: recursive(this, key) });
-        if (typeof output == "function")
-            return { get: output };
-        else
-            return output;
+        return output;
     }
     Pending.set(placeholder, setup);
     return placeholder;
@@ -991,9 +990,9 @@ function use(init) {
     return state[0];
 }
 
-function useModel(source, arg, callback) {
+function useModel(source, arg, arg2) {
     const instance = React__default["default"].useMemo(() => {
-        const cb = callback || arg;
+        const cb = arg2 || arg;
         const instance = typeof source == "function" ?
             source.prototype instanceof Model ?
                 new source() :
@@ -1017,9 +1016,18 @@ function useModel(source, arg, callback) {
         return instance;
     }
     else {
-        const local = use(refresh => {
-            return new Subscriber(instance, () => refresh);
-        });
+        const local = use(refresh => (new Subscriber(instance, () => refresh)));
+        if (typeof arg == "object") {
+            local.active = false;
+            if (typeof arg2 !== "object")
+                arg2 = getOwnPropertyNames(instance);
+            for (const key of arg2)
+                if (key in arg)
+                    instance[key] = arg[key];
+            React__default["default"].useLayoutEffect(() => {
+                local.active = true;
+            });
+        }
         React__default["default"].useLayoutEffect(() => {
             local.commit();
             return () => {
@@ -1102,10 +1110,11 @@ function useTap(source, path, expect) {
         }
         return sub;
     });
-    React__default["default"].useLayoutEffect(() => local.commit(), []);
+    React__default["default"].useLayoutEffect(local.commit, []);
     return local.proxy;
 }
 
+/* istanbul ignore file */
 class MVC extends Model {
     tap(path, expect) {
         return useTap(this, path, expect);
@@ -1210,7 +1219,7 @@ function RenderFunction(props) {
         return {};
     });
     if (hook.commit)
-        React__default["default"].useLayoutEffect(() => hook.commit(), []);
+        React__default["default"].useLayoutEffect(hook.commit, []);
     return props.render(hook.proxy);
 }