@expressive/mvc 0.6.3 → 0.7.0

package/lib/index.js

@@ -204,22 +204,6 @@ class Model {
         defineProperty(this, "is", {
             value: this
         });
-        defineProperty(this, "set", {
-            configurable: true,
-            get: () => {
-                const controller = ensure(this);
-                const value = (key, value) => {
-                    controller.state.set(key, value);
-                    controller.update(key);
-                };
-                for (const key of controller.state.keys())
-                    defineProperty(value, key, {
-                        value: controller.ref(key)
-                    });
-                defineProperty(this, "set", { value });
-                return value;
-            }
-        });
     }
     get [STATE]() {
         return this.export();
@@ -482,8 +466,11 @@ class Controller {
             return;
         if (typeof value == "symbol") {
             const instruction = PENDING.get(value);
-            if (instruction)
+            if (instruction) {
+                delete subject[key];
+                PENDING.delete(value);
                 instruction.call(this, key, this);
+            }
             return;
         }
         state.set(key, value);
@@ -587,9 +574,6 @@ function apply(fn, label) {
     const placeholder = Symbol(`${name} instruction`);
     function setup(key) {
         const { subject, state } = this;
-        const control = this;
-        PENDING.delete(placeholder);
-        delete subject[key];
         let output = fn.call(this, key, this);
         if (typeof output == "function")
             output = { get: output };
@@ -612,6 +596,7 @@ function apply(fn, label) {
                         destroy();
                 });
         }
+        const control = this;
         defineProperty(subject, key, {
             enumerable: output.enumerable,
             set: onSet !== false
@@ -805,7 +790,7 @@ function get(arg0, arg1, arg2) {
                 throw new Error(`Factory argument cannot be ${arg1}`);
             getter = computeMode(this, source, setter, key, computeRequired);
         };
-        if (typeof arg0 == "function" && factoryRequired)
+        if (typeof arg0 == "function" && computeRequired)
             try {
                 init();
             }
@@ -821,18 +806,28 @@ function get(arg0, arg1, arg2) {
     });
 }
 
-function ref(callback) {
+function ref(arg) {
     return apply(function ref(key) {
-        const value = this.ref(key, callback && createValueEffect(callback));
-        defineProperty(value, "current", {
-            set: value,
-            get: () => this.state.get(key)
-        });
-        return {
-            value,
-            explicit: true
-        };
+        let value = {};
+        if (typeof arg == "object") {
+            const source = ensure(arg);
+            for (const key of source.state.keys())
+                defineProperty(value, key, {
+                    value: createRef(this, key)
+                });
+        }
+        else
+            value = createRef(this, key, arg);
+        return { value, explicit: true };
+    });
+}
+function createRef(src, key, cb) {
+    const refObjectFunction = src.ref(key, cb && createValueEffect(cb));
+    defineProperty(refObjectFunction, "current", {
+        set: refObjectFunction,
+        get: () => src.state.get(key)
     });
+    return refObjectFunction;
 }
 
 function set(value, argument) {
@@ -1480,11 +1475,11 @@ const Oops = issues({
 const Active = new WeakMap();
 class Global extends MVC {
     static create(...args) {
-        const Type = this;
-        if (Active.has(Type))
+        if (Active.has(this))
             throw Oops.AlreadyExists(this.name);
-        const instance = super.create(...args);
-        Active.set(Type, instance);
+        const instance = new this(...args);
+        ensure(instance);
+        Active.set(this, instance);
         return instance;
     }
     /**