@expo/eas-json 0.33.0 → 0.36.0

package/src/__tests__/migrate-test.ts

@@ -1,297 +0,0 @@
-import { EasJson as DeprecatedEasJson } from '../DeprecatedEasJsonReader';
-import { migrateProfile } from '../migrate';
-
-test('migration for default manged eas.json', async () => {
-  const easJson = {
-    builds: {
-      android: {
-        release: {
-          buildType: 'app-bundle',
-        },
-        development: {
-          buildType: 'development-client',
-          distribution: 'internal',
-        },
-      },
-      ios: {
-        release: {
-          buildType: 'release',
-        },
-        development: {
-          buildType: 'development-client',
-          distribution: 'internal',
-        },
-      },
-    },
-  } as DeprecatedEasJson;
-  expect(migrateProfile(easJson, 'release')).toEqual({
-    android: {
-      buildType: 'app-bundle',
-    },
-  });
-  expect(migrateProfile(easJson, 'development')).toEqual({
-    developmentClient: true,
-    distribution: 'internal',
-  });
-});
-
-test('migration for default bare workflow eas.json', async () => {
-  const easJson = {
-    builds: {
-      android: {
-        release: {
-          gradleCommand: ':app:bundleRelease',
-        },
-        development: {
-          gradleCommand: ':app:assembleDebug',
-          distribution: 'internal',
-        },
-      },
-      ios: {
-        release: {
-          schemeBuildConfiguration: 'Release',
-        },
-        development: {
-          schemeBuildConfiguration: 'Debug',
-          distribution: 'internal',
-        },
-      },
-    },
-  } as DeprecatedEasJson;
-  expect(migrateProfile(easJson, 'release')).toEqual({
-    android: {
-      gradleCommand: ':app:bundleRelease',
-    },
-    ios: {
-      buildConfiguration: 'Release',
-    },
-  });
-  expect(migrateProfile(easJson, 'development')).toEqual({
-    distribution: 'internal',
-    android: {
-      gradleCommand: ':app:assembleDebug',
-    },
-    ios: {
-      buildConfiguration: 'Debug',
-    },
-  });
-});
-
-test('migration for example manged eas.json', async () => {
-  const easJson = {
-    builds: {
-      android: {
-        base: {
-          image: 'default',
-          env: {
-            EXAMPLE_ENV: 'example value',
-          },
-        },
-        release: {
-          extends: 'base',
-          env: {
-            ENVIRONMENT: 'production',
-          },
-          buildType: 'app-bundle',
-        },
-        staging: {
-          extends: 'base',
-          env: {
-            ENVIRONMENT: 'staging',
-          },
-          distribution: 'internal',
-          buildType: 'apk',
-        },
-        debug: {
-          extends: 'base',
-          withoutCredentials: true,
-          env: {
-            ENVIRONMENT: 'staging',
-          },
-          distribution: 'internal',
-          buildType: 'development-client',
-        },
-      },
-      ios: {
-        base: {
-          image: 'latest',
-          node: '12.13.0',
-          yarn: '1.22.5',
-        },
-        release: {
-          extends: 'base',
-          buildType: 'release',
-          env: {
-            ENVIRONMENT: 'production',
-          },
-        },
-        inhouse: {
-          extends: 'base',
-          distribution: 'internal',
-          enterpriseProvisioning: 'universal',
-          env: {
-            ENVIRONMENT: 'staging',
-          },
-        },
-        adhoc: {
-          extends: 'base',
-          distribution: 'internal',
-          env: {
-            ENVIRONMENT: 'staging',
-          },
-        },
-        client: {
-          extends: 'adhoc',
-          buildType: 'development-client',
-        },
-      },
-    },
-  } as DeprecatedEasJson;
-  expect(migrateProfile(easJson, 'base')).toEqual({
-    android: {
-      env: {
-        EXAMPLE_ENV: 'example value',
-      },
-      image: 'default',
-    },
-    ios: {
-      image: 'latest',
-      node: '12.13.0',
-      yarn: '1.22.5',
-    },
-  });
-  expect(migrateProfile(easJson, 'release')).toEqual({
-    extends: 'base',
-    android: {
-      buildType: 'app-bundle',
-      env: {
-        ENVIRONMENT: 'production',
-      },
-    },
-    ios: {
-      env: {
-        ENVIRONMENT: 'production',
-      },
-    },
-  });
-  expect(migrateProfile(easJson, 'staging')).toEqual({
-    android: {
-      buildType: 'apk',
-      distribution: 'internal',
-      env: {
-        ENVIRONMENT: 'staging',
-      },
-    },
-  });
-  expect(migrateProfile(easJson, 'inhouse')).toEqual({
-    ios: {
-      distribution: 'internal',
-      enterpriseProvisioning: 'universal',
-      env: {
-        ENVIRONMENT: 'staging',
-      },
-    },
-  });
-});
-
-test('migration for example bare workflow eas.json', async () => {
-  const easJson = {
-    builds: {
-      android: {
-        base: {
-          image: 'ubuntu-18.04-android-30-ndk-r19c',
-          ndk: '21.4.7075529',
-          env: {
-            EXAMPLE_ENV: 'example value',
-          },
-        },
-        release: {
-          extends: 'base',
-          env: {
-            ENVIRONMENT: 'production',
-          },
-          gradleCommand: ':app:bundleRelease',
-        },
-        staging: {
-          extends: 'base',
-          env: {
-            ENVIRONMENT: 'staging',
-          },
-          distribution: 'internal',
-          gradleCommand: ':app:assembleRelease',
-        },
-        debug: {
-          extends: 'base',
-          withoutCredentials: true,
-          env: {
-            ENVIRONMENT: 'staging',
-          },
-          distribution: 'internal',
-          gradleCommand: ':app:assembleDebug',
-        },
-      },
-      ios: {
-        base: {
-          image: 'latest',
-          node: '12.13.0',
-          yarn: '1.22.5',
-        },
-        release: {
-          extends: 'base',
-          schemeBuildConfiguration: 'Release',
-          scheme: 'testapp',
-          env: {
-            ENVIRONMENT: 'production',
-          },
-        },
-        inhouse: {
-          extends: 'base',
-          distribution: 'internal',
-          enterpriseProvisioning: 'universal',
-          scheme: 'testapp-enterprise',
-          env: {
-            ENVIRONMENT: 'staging',
-          },
-        },
-        adhoc: {
-          extends: 'base',
-          distribution: 'internal',
-          scheme: 'testapp',
-          env: {
-            ENVIRONMENT: 'staging',
-          },
-        },
-      },
-    },
-  } as DeprecatedEasJson;
-  expect(migrateProfile(easJson, 'base')).toEqual({
-    android: {
-      env: {
-        EXAMPLE_ENV: 'example value',
-      },
-      image: 'ubuntu-18.04-android-30-ndk-r19c',
-      ndk: '21.4.7075529',
-    },
-    ios: {
-      image: 'latest',
-      node: '12.13.0',
-      yarn: '1.22.5',
-    },
-  });
-  expect(migrateProfile(easJson, 'release')).toEqual({
-    extends: 'base',
-    android: {
-      env: {
-        ENVIRONMENT: 'production',
-      },
-      gradleCommand: ':app:bundleRelease',
-    },
-    ios: {
-      buildConfiguration: 'Release',
-      env: {
-        ENVIRONMENT: 'production',
-      },
-      scheme: 'testapp',
-    },
-  });
-});

package/src/migrate.ts

@@ -1,182 +0,0 @@
-import { Android, Ios } from '@expo/eas-build-job';
-import JsonFile, { JSONObject } from '@expo/json-file';
-import fs from 'fs-extra';
-import path from 'path';
-
-import { AndroidBuildProfile, IosBuildProfile } from './DeprecatedConfig.types';
-import { EasJson as DeprecatedEasJson, EasJsonReader } from './DeprecatedEasJsonReader';
-import { EasJson, RawBuildProfile } from './EasJson.types';
-
-export async function isUsingDeprecatedFormatAsync(projectDir: string): Promise<boolean> {
-  const easJsonPath = path.join(projectDir, 'eas.json');
-  if (!(await fs.pathExists(easJsonPath))) {
-    return false;
-  }
-  const json = await readEasJsonAsync(projectDir);
-  return !!json?.builds;
-}
-
-export async function hasMismatchedExtendsAsync(projectDir: string): Promise<boolean> {
-  const rawEasJson = (await readEasJsonAsync(projectDir)) as unknown as DeprecatedEasJson;
-  const profiles = new Set<string>();
-  Object.keys(rawEasJson.builds.android ?? {}).forEach(profile => profiles.add(profile));
-  Object.keys(rawEasJson.builds.ios ?? {}).forEach(profile => profiles.add(profile));
-
-  let hasMismatchedExtendsKeys = false;
-  profiles.forEach(profileName => {
-    if (
-      rawEasJson?.builds?.ios?.[profileName]?.extends !==
-      rawEasJson?.builds?.android?.[profileName]?.extends
-    ) {
-      hasMismatchedExtendsKeys = true;
-    }
-  });
-  return hasMismatchedExtendsKeys;
-}
-
-export async function migrateAsync(projectDir: string): Promise<void> {
-  const reader = new EasJsonReader(projectDir, 'all');
-  try {
-    await reader.validateAsync();
-  } catch (err: any) {
-    throw new Error(`Valid eas.json is required to migrate to the new format\n${err.message}`);
-  }
-  const rawEasJson = (await readEasJsonAsync(projectDir)) as unknown as DeprecatedEasJson;
-  const profiles = new Set<string>();
-  Object.keys(rawEasJson.builds.android ?? {}).forEach(profile => profiles.add(profile));
-  Object.keys(rawEasJson.builds.ios ?? {}).forEach(profile => profiles.add(profile));
-
-  const result: EasJson = {
-    build: {},
-  };
-  profiles.forEach(profileName => {
-    result.build[profileName] = migrateProfile(rawEasJson, profileName);
-  });
-  await fs.writeFile(path.join(projectDir, 'eas.json'), `${JSON.stringify(result, null, 2)}\n`);
-}
-
-async function readEasJsonAsync(projectDir: string): Promise<JSONObject> {
-  try {
-    const easJsonPath = path.join(projectDir, 'eas.json');
-    return JsonFile.read(easJsonPath);
-  } catch (err: any) {
-    if (err.code === 'EJSONPARSE') {
-      err.message = `Found invalid JSON in eas.json. ${err.message}`;
-    }
-    throw err;
-  }
-}
-
-interface MigrateContext {
-  androidProfile?: Partial<AndroidBuildProfile>;
-  iosProfile?: Partial<IosBuildProfile>;
-}
-
-export function migrateProfile(
-  rawEasJson: DeprecatedEasJson,
-  profileName: string
-): RawBuildProfile {
-  const androidProfile = (rawEasJson?.builds?.android?.[profileName] ??
-    {}) as AndroidBuildProfile & { extends?: string };
-  const iosProfile = (rawEasJson?.builds?.ios?.[profileName] ?? {}) as IosBuildProfile & {
-    extends?: string;
-  };
-  let profile: RawBuildProfile = {
-    android: {},
-    ios: {},
-  };
-  const ctx = { androidProfile, iosProfile };
-  const androidCtx = { androidProfile };
-  const iosCtx = { iosProfile };
-
-  // simple common values
-  profile = migrateProperty('credentialsSource', profile, ctx);
-  profile = migrateProperty('releaseChannel', profile, ctx);
-  profile = migrateProperty('channel', profile, ctx);
-  profile = migrateProperty('node', profile, ctx);
-  profile = migrateProperty('yarn', profile, ctx);
-  profile = migrateProperty('expoCli', profile, ctx);
-  if (androidProfile.extends && androidProfile.extends === iosProfile.extends) {
-    profile = migrateProperty('extends', profile, ctx);
-  }
-
-  // android
-  profile = migrateProperty('image', profile, androidCtx);
-  profile = migrateProperty('ndk', profile, androidCtx);
-  profile = migrateProperty('gradleCommand', profile, androidCtx);
-  profile = migrateProperty('artifactPath', profile, androidCtx);
-  profile = migrateProperty('env', profile, androidCtx);
-  profile = migrateProperty('cache', profile, androidCtx);
-  profile = migrateProperty('withoutCredentials', profile, androidCtx);
-
-  // ios
-  profile = migrateProperty('enterpriseProvisioning', profile, iosCtx);
-  profile = migrateProperty('autoIncrement', profile, iosCtx);
-  profile = migrateProperty('image', profile, iosCtx);
-  profile = migrateProperty('bundler', profile, iosCtx);
-  profile = migrateProperty('fastlane', profile, iosCtx);
-  profile = migrateProperty('cocoapods', profile, iosCtx);
-  profile = migrateProperty('artifactPath', profile, iosCtx);
-  profile = migrateProperty('scheme', profile, iosCtx);
-  profile = migrateProperty('env', profile, iosCtx);
-  profile = migrateProperty('cache', profile, iosCtx);
-
-  profile = migrateProperty('developmentClient', profile, {
-    androidProfile: {
-      ...androidProfile,
-      developmentClient:
-        androidProfile.buildType === Android.BuildType.DEVELOPMENT_CLIENT || undefined,
-    } as any,
-    iosProfile: {
-      ...iosProfile,
-      developmentClient: iosProfile.buildType === Ios.BuildType.DEVELOPMENT_CLIENT || undefined,
-    } as any,
-  });
-  if (
-    androidProfile.buildType &&
-    androidProfile.buildType !== Android.BuildType.DEVELOPMENT_CLIENT
-  ) {
-    profile.android!.buildType = androidProfile.buildType;
-  }
-  if (iosProfile.distribution === 'simulator') {
-    profile.ios!.simulator = true;
-    delete (iosProfile as any).distribution;
-  }
-  profile = migrateProperty('distribution', profile, ctx);
-
-  if (iosProfile.schemeBuildConfiguration) {
-    profile.ios!.buildConfiguration = iosProfile.schemeBuildConfiguration;
-  }
-  if (Object.keys(profile.android ?? {}).length === 0) {
-    delete profile.android;
-  }
-  if (Object.keys(profile.ios ?? {}).length === 0) {
-    delete profile.ios;
-  }
-  return profile;
-}
-
-function migrateProperty(
-  key: string,
-  profile: RawBuildProfile,
-  ctx: MigrateContext
-): RawBuildProfile {
-  const androidProperty = (ctx.androidProfile as any)?.[key];
-  const iosProperty = (ctx.iosProfile as any)?.[key];
-
-  if (androidProperty && iosProperty && androidProperty === iosProperty) {
-    return { ...profile, [key]: androidProperty };
-  } else {
-    return {
-      ...profile,
-      android: {
-        ...profile.android,
-        ...(androidProperty ? { [key]: androidProperty } : {}),
-      },
-      ios: {
-        ...profile.ios,
-        ...(iosProperty ? { [key]: iosProperty } : {}),
-      },
-    };
-  }
-}