@expo/eas-json 0.32.0 → 0.33.0

package/build/EasJsonReader.d.ts

@@ -19,7 +19,7 @@ export declare class EasJsonReader {
         throwIfEasJsonDoesNotExist?: boolean | undefined;
     }): Promise<string[]>;
     readBuildProfileAsync<T extends Platform>(platform: T, profileName: string): Promise<BuildProfile<T>>;
-    readSubmitProfileAsync<T extends Platform>(platform: T, profileName?: string): Promise<SubmitProfile<T>>;
+    readSubmitProfileAsync<T extends Platform>(platform: T, profileNameArg?: string): Promise<SubmitProfile<T>>;
     readAndValidateAsync(): Promise<EasJson>;
     readRawAsync(): Promise<EasJsonPreValidation>;
     private resolveBuildProfile;

package/build/EasJsonReader.js

@@ -56,14 +56,18 @@ class EasJsonReader {
             throw new Error(`Unknown platform ${platform}`);
         }
     }
-    async readSubmitProfileAsync(platform, profileName) {
+    async readSubmitProfileAsync(platform, profileNameArg) {
         var _a;
+        let profileName = profileNameArg;
         if (!profileName) {
             const profileNames = await this.getSubmitProfileNamesAsync({
                 throwIfEasJsonDoesNotExist: false,
             });
-            if (profileNames.includes('release')) {
-                return await this.readSubmitProfileAsync(platform, 'release');
+            if (profileNames.includes('production')) {
+                profileName = 'production';
+            }
+            else if (profileNames.includes('release')) {
+                profileName = 'release';
             }
             else {
                 return getDefaultSubmitProfile(platform);

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@expo/eas-json",
   "description": "A library for interacting with the eas.json",
-  "version": "0.32.0",
+  "version": "0.33.0",
   "author": "Expo <support@expo.dev>",
   "bugs": "https://github.com/expo/eas-cli/issues",
   "dependencies": {
@@ -33,5 +33,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "cf7848e3c5171473ccdf1cbdde377bf73c5f6458"
+  "gitHead": "48130dcbdc3192a495a8094707408f2f6925075c"
 }

package/src/EasJsonReader.ts

@@ -81,18 +81,24 @@ export class EasJsonReader {
 
   public async readSubmitProfileAsync<T extends Platform>(
     platform: T,
-    profileName?: string
+    profileNameArg?: string
   ): Promise<SubmitProfile<T>> {
+    let profileName = profileNameArg;
+
     if (!profileName) {
       const profileNames = await this.getSubmitProfileNamesAsync({
         throwIfEasJsonDoesNotExist: false,
       });
-      if (profileNames.includes('release')) {
-        return await this.readSubmitProfileAsync(platform, 'release');
+
+      if (profileNames.includes('production')) {
+        profileName = 'production';
+      } else if (profileNames.includes('release')) {
+        profileName = 'release';
       } else {
         return getDefaultSubmitProfile(platform);
       }
     }
+
     const easJson = await this.readAndValidateAsync();
     const profile = easJson?.submit?.[profileName];
     if (!profile) {

package/src/__tests__/EasJsonReader-build-test.ts

@@ -14,13 +14,13 @@ beforeEach(async () => {
 test('minimal valid eas.json for both platforms', async () => {
   await fs.writeJson('/project/eas.json', {
     build: {
-      release: {},
+      production: {},
     },
   });
 
   const reader = new EasJsonReader('/project');
-  const iosProfile = await reader.readBuildProfileAsync(Platform.IOS, 'release');
-  const androidProfile = await reader.readBuildProfileAsync(Platform.ANDROID, 'release');
+  const iosProfile = await reader.readBuildProfileAsync(Platform.IOS, 'production');
+  const androidProfile = await reader.readBuildProfileAsync(Platform.ANDROID, 'production');
 
   expect({
     distribution: 'store',
@@ -36,7 +36,7 @@ test('minimal valid eas.json for both platforms', async () => {
 test('valid eas.json for development client builds', async () => {
   await fs.writeJson('/project/eas.json', {
     build: {
-      release: {},
+      production: {},
       debug: {
         developmentClient: true,
         android: {
@@ -219,7 +219,7 @@ test('valid profile extending other profile with platform specific caching', asy
 test('valid eas.json with missing profile', async () => {
   await fs.writeJson('/project/eas.json', {
     build: {
-      release: {},
+      production: {},
     },
   });
 
@@ -231,14 +231,14 @@ test('valid eas.json with missing profile', async () => {
 test('invalid eas.json when using wrong buildType', async () => {
   await fs.writeJson('/project/eas.json', {
     build: {
-      release: { android: { buildType: 'archive' } },
+      production: { android: { buildType: 'archive' } },
     },
   });
 
   const reader = new EasJsonReader('/project');
-  const promise = reader.readBuildProfileAsync(Platform.ANDROID, 'release');
+  const promise = reader.readBuildProfileAsync(Platform.ANDROID, 'production');
   await expect(promise).rejects.toThrowError(
-    'eas.json is not valid [ValidationError: "build.release.android.buildType" must be one of [apk, app-bundle]]'
+    'eas.json is not valid [ValidationError: "build.production.android.buildType" must be one of [apk, app-bundle]]'
   );
 });
 
@@ -246,33 +246,33 @@ test('empty json', async () => {
   await fs.writeJson('/project/eas.json', {});
 
   const reader = new EasJsonReader('/project');
-  const promise = reader.readBuildProfileAsync(Platform.ANDROID, 'release');
-  await expect(promise).rejects.toThrowError('There is no profile named release in eas.json');
+  const promise = reader.readBuildProfileAsync(Platform.ANDROID, 'production');
+  await expect(promise).rejects.toThrowError('There is no profile named production in eas.json');
 });
 
 test('invalid semver value', async () => {
   await fs.writeJson('/project/eas.json', {
     build: {
-      release: { node: '12.0.0-alpha' },
+      production: { node: '12.0.0-alpha' },
     },
   });
 
   const reader = new EasJsonReader('/project');
-  const promise = reader.readBuildProfileAsync(Platform.ANDROID, 'release');
+  const promise = reader.readBuildProfileAsync(Platform.ANDROID, 'production');
   await expect(promise).rejects.toThrowError(
-    'eas.json is not valid [ValidationError: "build.release.node" failed custom validation because 12.0.0-alpha is not a valid version]'
+    'eas.json is not valid [ValidationError: "build.production.node" failed custom validation because 12.0.0-alpha is not a valid version]'
   );
 });
 
 test('get profile names', async () => {
   await fs.writeJson('/project/eas.json', {
     build: {
-      release: { node: '12.0.0-alpha' },
+      production: { node: '12.0.0-alpha' },
       blah: { node: '12.0.0-alpha' },
     },
   });
 
   const reader = new EasJsonReader('/project');
   const allProfileNames = await reader.getBuildProfileNamesAsync();
-  expect(allProfileNames.sort()).toEqual(['blah', 'release'].sort());
+  expect(allProfileNames.sort()).toEqual(['blah', 'production'].sort());
 });

package/src/__tests__/EasJsonReader-submit-test.ts

@@ -14,13 +14,13 @@ beforeEach(async () => {
 test('minimal allowed eas.json for both platforms', async () => {
   await fs.writeJson('/project/eas.json', {
     submit: {
-      release: {},
+      production: {},
     },
   });
 
   const reader = new EasJsonReader('/project');
-  const iosProfile = await reader.readSubmitProfileAsync(Platform.IOS, 'release');
-  const androidProfile = await reader.readSubmitProfileAsync(Platform.ANDROID, 'release');
+  const iosProfile = await reader.readSubmitProfileAsync(Platform.IOS, 'production');
+  const androidProfile = await reader.readSubmitProfileAsync(Platform.ANDROID, 'production');
 
   expect(androidProfile).toEqual({
     changesNotSentForReview: false,
@@ -35,7 +35,7 @@ test('minimal allowed eas.json for both platforms', async () => {
 test('android config with all required values', async () => {
   await fs.writeJson('/project/eas.json', {
     submit: {
-      release: {
+      production: {
         android: {
           serviceAccountKeyPath: './path.json',
           track: 'beta',
@@ -46,7 +46,7 @@ test('android config with all required values', async () => {
   });
 
   const reader = new EasJsonReader('/project');
-  const androidProfile = await reader.readSubmitProfileAsync(Platform.ANDROID, 'release');
+  const androidProfile = await reader.readSubmitProfileAsync(Platform.ANDROID, 'production');
 
   expect(androidProfile).toEqual({
     serviceAccountKeyPath: './path.json',
@@ -59,7 +59,7 @@ test('android config with all required values', async () => {
 test('android config with serviceAccountKeyPath set to env var', async () => {
   await fs.writeJson('/project/eas.json', {
     submit: {
-      release: {
+      production: {
         android: {
           serviceAccountKeyPath: '$GOOGLE_SERVICE_ACCOUNT',
           track: 'beta',
@@ -72,7 +72,7 @@ test('android config with serviceAccountKeyPath set to env var', async () => {
   try {
     process.env.GOOGLE_SERVICE_ACCOUNT = './path.json';
     const reader = new EasJsonReader('/project');
-    const androidProfile = await reader.readSubmitProfileAsync(Platform.ANDROID, 'release');
+    const androidProfile = await reader.readSubmitProfileAsync(Platform.ANDROID, 'production');
 
     expect(androidProfile).toEqual({
       serviceAccountKeyPath: './path.json',
@@ -88,7 +88,7 @@ test('android config with serviceAccountKeyPath set to env var', async () => {
 test('ios config with all required values', async () => {
   await fs.writeJson('/project/eas.json', {
     submit: {
-      release: {
+      production: {
         ios: {
           appleId: 'some@email.com',
           ascAppId: '1223423523',
@@ -102,7 +102,7 @@ test('ios config with all required values', async () => {
   });
 
   const reader = new EasJsonReader('/project');
-  const iosProfile = await reader.readSubmitProfileAsync(Platform.IOS, 'release');
+  const iosProfile = await reader.readSubmitProfileAsync(Platform.IOS, 'production');
 
   expect(iosProfile).toEqual({
     appleId: 'some@email.com',

package/src/__tests__/migrate-test.ts

@@ -35,7 +35,7 @@ test('migration for default manged eas.json', async () => {
   });
 });
 
-test('migration for default generic eas.json', async () => {
+test('migration for default bare workflow eas.json', async () => {
   const easJson = {
     builds: {
       android: {
@@ -194,7 +194,7 @@ test('migration for example manged eas.json', async () => {
   });
 });
 
-test('migration for example generic eas.json', async () => {
+test('migration for example bare workflow eas.json', async () => {
   const easJson = {
     builds: {
       android: {