@expo/code-review-cli 0.7.0 → 0.9.0

package/README.md

@@ -70,9 +70,9 @@ excludes) — see [the mixed setup](#other-providers) below. Prefer
 # Review working-tree changes; prints here, posts nothing
 ecr review
 # Review a GitHub PR by number (preview only)
-ecr review --pr 4057
+ecr review --pr 123
 # …and post it as the PR comment
-ecr review --pr 4057 --post
+ecr review --pr 123 --post
 ```
 
 Options (most to least common):
@@ -115,15 +115,61 @@ is a ready example to adapt.
 | `ecr review --scope <name>` | Review only one routing scope over just that scope's changed files. |
 | `ecr ci` | Review the current GitHub PR and post/update a comment. For GitHub Actions. |
 | `ecr doctor [--list-scopes]` | Check environment, config, credentials, and (with a manifest) scopes. |
+| `ecr feedback [--repo <owner/repo>]` | Report which findings PR authors pushed back on, across history. See below. |
+| `ecr ref-check [--json]` | Fail when the review setup cites code that moved or vanished. See below. |
 
 Extra flags for monorepos: `review`/`ci` `--config-dir <dir>` (load config from an
 alternate dir; also `ECR_CONFIG_DIR`), `ci --scopes a,b` (limit the fan-out to
-named scopes), `ci --comment single|per-scope` (override the manifest).
+named scopes), `ci --comment single|per-scope` (override the manifest). Both
+`review` and `ci` also take `--context-file <path>` (inject a file's text as
+untrusted external context; see below).
 
 (When developing this repo itself, use `bun run src/cli.ts <command>`.)
 
 ---
 
+## Keeping prompts true (`ecr ref-check`)
+
+Good reviewer prompts cite real code: "the only session entry point is
+`server/src/session.ts`", "every webhook router must call `sanitizeSecrets`". Then the
+code moves and the prompt keeps citing a path that no longer exists — the reviewer
+reasons from a fiction, on every PR, with nothing to warn you.
+
+`ecr ref-check` makes those citations checkable. Pin each one with a ref, in a comment
+of its own (`<!-- … -->` in Markdown, `//` in JSONC):
+
+```md
+<!-- @ref server/src/session.ts#createSession — the only place a session is minted -->
+<!-- @ref server/src/entities/oauth/ — every provider lives here -->
+<!-- @ref glob:**/*WebhookRouter.ts — the routers this rule is about -->
+```
+
+A target is a file, a `dir/`, `glob:<pattern>`, `file#symbol`, or `doc.md#heading` —
+never a line number, since a line number rots without any signal. Symbol anchors are
+checked by whole-word match, so code moving inside its file is fine and a rename is not.
+
+The check is strict on purpose: a backticked token in `.expo-code-review/` that looks
+like a repo path **must** be a ref, because the stale citations are exactly the ones
+nobody thought to annotate. A token with no extension (`eas-build-worker/terraform`,
+`general-central/{module,production}`, `finops`) counts when it names something that
+exists — so those get pinned too, while `anthropic/claude-opus-5`, shaped the same way,
+stays prose. For a token that only looks like a path, say so once:
+`<!-- @ref-ignore knex.raw() -->`. It also checks what your config already declares —
+`enforceAgents` ids, scope `config` directories, scope path globs.
+
+Refs are repo-root-relative, including in a scope's own setup dir. A scope prompt that
+cites `general-central/module` for `infrastructure/general-central/module` gets told the
+root-relative form to use.
+
+Two run points:
+
+- `ecr ref-check` exits 1 on any problem. Run it in CI or a pre-commit hook.
+- `ecr review` / `ecr ci` run it too, and never fail a PR's checks with it. The comment
+  carries a **Review setup** note instead: refs that no longer resolve, plus cited code
+  *this PR* changes, where the ref still resolves but the guidance may not.
+
+---
+
 ## Monorepos (routing manifest)
 
 A monorepo can route different subtrees to different reviewer rosters from a single
@@ -138,9 +184,9 @@ your-monorepo/
     routing.jsonc          # the manifest — infra-owned, ordered scope list + locked defaults
     config.jsonc           # the default/root scope; the ONLY place auth/tokenEnv lives
     shared.md coordinator.md agents/
-  server/
-    www/.expo-code-review/{config.jsonc(NO auth),coordinator.md,agents/}       # www team
-    website/.expo-code-review/{config.jsonc(NO auth),coordinator.md,agents/}   # website team
+  apps/
+    api/.expo-code-review/{config.jsonc(NO auth),coordinator.md,agents/}   # api team
+    web/.expo-code-review/{config.jsonc(NO auth),coordinator.md,agents/}   # web team
   .github/workflows/expo-code-review.yml   # unchanged shape: one workflow, one `ecr ci`
 ```
 
@@ -157,21 +203,21 @@ your-monorepo/
   "comment": "single",   // "single" = one aggregated comment (default) | "per-scope"
   // Ordered; the LAST matching scope wins per changed file (CODEOWNERS discipline).
   "scopes": [
-    { "name": "default",        "paths": ["**/*"],              "config": "." },
-    { "name": "server-www",     "paths": ["server/www/**"],     "config": "server/www" },
-    { "name": "server-website", "paths": ["server/website/**"], "config": "server/website" }
+    { "name": "default",  "paths": ["**/*"],        "config": "." },
+    { "name": "apps-api", "paths": ["apps/api/**"], "config": "apps/api" },
+    { "name": "apps-web", "paths": ["apps/web/**"], "config": "apps/web" }
   ]
 }
 ```
 
 ```jsonc
-// server/www/.expo-code-review/config.jsonc  (the www team owns this)
+// apps/api/.expo-code-review/config.jsonc  (the api team owns this)
 {
   // NO "auth" block — locked centrally; a tokenEnv here is rejected by loader + CI guard.
   "model": "openai/gpt-5.5",
   "policy": { "includeSuggestions": false },
-  "noise":  { "additionalIgnores": ["server/www/**/__generated__/**"] }
-  // shared.md, coordinator.md, agents/*.md live beside this file — the www team's roster.
+  "noise":  { "additionalIgnores": ["apps/api/**/__generated__/**"] }
+  // shared.md, coordinator.md, agents/*.md live beside this file — the api team's roster.
 }
 ```
 
@@ -245,7 +291,7 @@ your-monorepo/
   security warning and will be removed on a minor boundary.
 
 Ownership is enforced with CODEOWNERS: `/.expo-code-review/routing.jsonc @your-infra`
-(the single authoritative router) and `/server/www/.expo-code-review/ @your-www-team`
+(the single authoritative router) and `/apps/api/.expo-code-review/ @your-api-team`
 (each team owns only its own scope dir). Rerouting globs is gated behind infra review.
 
 ---
@@ -486,6 +532,108 @@ as the published package via `npx`, so no PR-controlled code is built.
 
 </details>
 
+<details>
+<summary><b>Author feedback (replies to findings)</b></summary>
+
+A PR author's reply to a finding is matched to it deterministically — by quoting
+the finding's title back, or by citing its short `` `id:…` `` token (only the id can
+clear a finding, see below) — and recorded
+in the comment's embedded state, no model involved in the matching itself. A
+matched finding shows `💬 @login replied` (linked to the comment) and a visible
+count above the fold; the reply's own text is never stored or rendered, only the
+login, the comment link, and (optionally) an enum-valued verdict. Controlled by
+the root-only `feedback` block in `config.jsonc`:
+
+```jsonc
+"feedback": {
+  "mode": "annotate",       // "off" | "annotate" | "adjudicate"
+  "match": "both",          // "quote" | "id" | "both"
+  "dismiss": "never",       // "never" | "maintainers" | "adjudicated"
+  "protectedCategories": ["secrets", "security"],
+  "maxAdjudications": 10    // cap on model calls per run, when mode is "adjudicate"
+}
+```
+
+- **`annotate`** (the default) matches and shows "author replied" with zero effect
+  on the decision — safe and useful even if you never touch this block.
+- **Clearing a finding always needs the `` `id:…` `` token**, in the replier's own words
+  (an id inside a `>` quote does not count). Quoting the title is enough to *annotate*,
+  never to clear: GitHub's "Quote reply" copies the PR author's text verbatim, so a
+  maintainer clicking it would otherwise dismiss a finding on words the author wrote —
+  by accident, or because they were led to.
+- **`adjudicate`** additionally has a model re-check the reply against the actual
+  source (distrust-by-default, like the finding verifier) and record a verdict.
+  Whether that verdict can actually clear a finding is a separate, still-off-by-
+  default choice — `mode` and `dismiss` are independent axes: `dismiss:
+  "maintainers"` lets a maintainer's own reply dismiss with no model involved
+  (it works under plain `annotate` too); `dismiss: "adjudicated"` additionally
+  accepts an author reply the model confirmed (which does need `mode:
+  "adjudicate"` for verdicts to exist). Either way the reply has to cite the finding's
+  `` `id:…` ``. A `critical` finding, or one categorized `secrets`/
+  `security`, can never be cleared this way, whatever the config — that floor is
+  enforced in code, not the prompt.
+- **`/undismiss <id>` wins over a reply.** Running it on a finding a reply cleared
+  puts the finding back in the active list and keeps it there: another reply from
+  the PR author can't clear it again. The restore is recorded against the FINDING
+  in the comment state, not against the reply, so editing or deleting the reply
+  doesn't drop it either. Only a maintainer lifts that — either `/dismiss <id>` on
+  the same finding, or a maintainer's own reply to it.
+
+`ecr feedback` mines this substrate retroactively, with no model call and no
+re-review: it crawls a repo's PRs, reads each one's existing reviewer comment
+(which already embeds its findings), matches non-bot replies against it, and
+reports totals, a reply-rate, breakdowns by category/severity/agent, and — the
+highest-value part — "repeat offenders": findings whose title recurred across 2+
+PRs and drew a reply every single time.
+
+```bash
+ecr feedback --repo your-org/your-repo --limit 100 --since 2026-06-01
+ecr feedback --as my-review-bot   # if CI posts under a PAT/app identity
+ecr feedback --json               # for scripting
+```
+
+The crawl matches the reviewer's comments by author. CI posts them as
+`github-actions[bot]` (the default), so a locally-run crawl uses that identity —
+pass `--as <login>` when your workflow posts under something else.
+
+`ecr feedback` always reads `.expo-code-review/config.jsonc` from the LOCAL
+checkout, even with `--repo`. If `--repo` points at a different repo, it warns
+that `commentTag` may not match, so a zero-findings result there is not read as
+zero pushback. It also warns when every scanned PR had no bot comment at all,
+instead of leaving that as an easy-to-miss "0 with a bot comment" in the totals.
+
+See [LLP 0011](./llp/0011-author-feedback.explainer.md) for why matching is
+deterministic, why reply text is never echoed into the comment, and why the
+defaults are asymmetric.
+
+</details>
+
+<details>
+<summary><b>External context (--context-file)</b></summary>
+
+`ecr review --context-file <path>` and `ecr ci --context-file <path>` inject the
+file's UTF-8 text into the reviewer prompts as an explicitly UNTRUSTED external
+block (the reviewer is told to use it but never follow instructions in it). The
+main use is a CI-provided terraform plan. The text is sanitized like any untrusted
+prose and capped at 24k chars (head 16k + tail 8k, so a big plan keeps both its
+resource list and its `Plan: N to add…` summary); the read itself is bounded at
+1 MiB.
+
+Read errors differ by command on purpose. `ecr review` fails loud (exits 2) on a
+missing or oversized file, since you typed the path. `ecr ci` warns and continues
+with no context, because a CI run must never fail the PR's checks.
+
+### Atlantis terraform plans
+
+`templates/atlantis.yml` is an opt-in workflow (not scaffolded by `ecr init`) that
+runs the reviewer when Atlantis posts a `terraform plan` comment on a PR and feeds
+the plan into the review as `--context-file`. The plan comment body is treated as
+untrusted data throughout. Copy it into `.github/workflows/` and set two repo
+variables: `ATLANTIS_BOT_LOGIN` (the Atlantis bot's comment login, e.g.
+`atlantis-app[bot]`) and optionally `ATLANTIS_PLAN_MARKER`.
+
+</details>
+
 <details>
 <summary><b>Run logs</b></summary>
 

package/build/cli.js

@@ -1,8 +1,11 @@
 #!/usr/bin/env node
+// @ref LLP 0007#command-dispatch-and-conventions — argv dispatch only; no execution logic lives here
 import { ciCommand } from "./commands/ci.js";
 import { dismissCommand } from "./commands/dismiss.js";
 import { doctorCommand } from "./commands/doctor.js";
+import { feedbackCommand } from "./commands/feedback.js";
 import { initCommand } from "./commands/init.js";
+import { refCheckCommand } from "./commands/ref-check.js";
 import { reviewCommand } from "./commands/review.js";
 import { setupAuthCommand } from "./commands/setup-auth.js";
 import { verifyConfigCommand } from "./commands/verify-config.js";
@@ -13,10 +16,12 @@ Usage:
   ecr ci                 Review the current PR and post a comment (GitHub Actions).
   ecr dismiss --pr <n> <id...>     Hide a finding on a PR (see \`ecr dismiss --help\`).
   ecr undismiss --pr <n> <id...>   Restore a dismissed finding.
+  ecr feedback [--repo <owner/repo>] [--limit <n>]   Report what humans pushed back on (see \`ecr feedback --help\`).
   ecr init [--monorepo] [--scope <dir>]   Scaffold .expo-code-review/ in this repo.
   ecr setup-auth [--yes]   Walk through getting model credentials for local runs.
   ecr doctor [--list-scopes]   Check environment, config, credentials, and scopes.
   ecr verify-config [--expected <env>] [--json]   Refuse to run if a config could redirect the credential (CI guard).
+  ecr ref-check [--root <dir>] [--json]   Fail if the review setup cites code that moved or vanished.
 
 Agents live in each repo under .expo-code-review/. This CLI is the engine.
 
@@ -28,6 +33,7 @@ async function main() {
         process.stdout.write(USAGE);
         return;
     }
+    // @ref LLP 0007#command-dispatch-and-conventions [implements] — default-to-review also swallows leading-flag typos; new global flags must not collide with review flags
     // No subcommand (or a leading flag) defaults to `review`.
     if (!sub || sub.startsWith("-")) {
         await reviewCommand(process.argv.slice(2));
@@ -46,6 +52,9 @@ async function main() {
         case "undismiss":
             await dismissCommand(rest, "remove");
             break;
+        case "feedback":
+            await feedbackCommand(rest);
+            break;
         case "init":
             await initCommand(rest);
             break;
@@ -58,6 +67,9 @@ async function main() {
         case "verify-config":
             await verifyConfigCommand(rest);
             break;
+        case "ref-check":
+            await refCheckCommand(rest);
+            break;
         default:
             process.stderr.write(`Unknown command: ${sub}\n\n${USAGE}`);
             process.exitCode = 2;