@expo/build-tools 22.0.0 → 22.2.0

package/dist/utils/AndroidEmulatorUtils.js

@@ -11,9 +11,11 @@ const assert_1 = __importDefault(require("assert"));
 const fast_glob_1 = __importDefault(require("fast-glob"));
 const node_crypto_1 = require("node:crypto");
 const node_fs_1 = __importDefault(require("node:fs"));
+const node_net_1 = require("node:net");
 const node_os_1 = __importDefault(require("node:os"));
 const node_path_1 = __importDefault(require("node:path"));
 const promises_1 = require("node:timers/promises");
+const sentry_1 = require("../sentry");
 const retry_1 = require("./retry");
 var AndroidEmulatorUtils;
 (function (AndroidEmulatorUtils) {
@@ -216,17 +218,21 @@ var AndroidEmulatorUtils;
     AndroidEmulatorUtils.cloneAsync = cloneAsync;
     async function startAsync({ deviceName, env, logcatDirectory, }) {
         let logcatOutputPath;
+        let emulatorOutputPath;
         try {
             await node_fs_1.default.promises.mkdir(logcatDirectory, { recursive: true });
             const safeDeviceName = deviceName.replace(/[^a-zA-Z0-9_.-]/g, '_');
             const timestamp = Math.floor(Date.now() / 1000)
                 .toString(16)
                 .padStart(8, '0');
-            logcatOutputPath = node_path_1.default.join(logcatDirectory, `${safeDeviceName}-${timestamp}-${(0, node_crypto_1.randomBytes)(2).toString('hex')}.log`);
+            const outputName = `${safeDeviceName}-${timestamp}-${(0, node_crypto_1.randomBytes)(2).toString('hex')}`;
+            logcatOutputPath = node_path_1.default.join(logcatDirectory, `${outputName}-logcat.log`);
+            emulatorOutputPath = node_path_1.default.join(logcatDirectory, `${outputName}-emulator.log`);
             await node_fs_1.default.promises.writeFile(logcatOutputPath, '');
+            await node_fs_1.default.promises.writeFile(emulatorOutputPath, '');
         }
         catch (err) {
-            throw new eas_build_job_1.SystemError(`Failed to prepare Android emulator logcat output for ${deviceName}.`, {
+            throw new eas_build_job_1.SystemError(`Failed to prepare Android emulator output for ${deviceName}.`, {
                 cause: err,
             });
         }
@@ -249,13 +255,49 @@ var AndroidEmulatorUtils;
                 : []),
         ], {
             detached: true,
-            stdio: 'inherit',
+            stdio: ['ignore', 'pipe', 'pipe'],
+            ignoreStdio: true,
             env: {
                 ...env,
                 // We don't need to wait for emulator to exit gracefully.
                 ANDROID_EMULATOR_WAIT_TIME_BEFORE_KILL: '1',
             },
         });
+        const emulatorOutputStream = node_fs_1.default.createWriteStream(emulatorOutputPath, { flags: 'a' });
+        let reportedEmulatorOutputError = false;
+        emulatorOutputStream.on('error', err => {
+            process.stderr.write(`Failed to write Android emulator output to ${emulatorOutputPath}: ${err}\n`);
+            if (!reportedEmulatorOutputError) {
+                reportedEmulatorOutputError = true;
+                sentry_1.Sentry.capture('Failed to write Android emulator process output', err, {
+                    level: 'warning',
+                    tags: {
+                        errorCode: err.code ?? 'unknown',
+                    },
+                    extras: {
+                        deviceName,
+                        emulatorOutputPath,
+                    },
+                });
+            }
+        });
+        // Only into the log file -- this process' stdout/stderr is not watched or uploaded.
+        emulatorPromise.child.stdout?.pipe(emulatorOutputStream, { end: false });
+        emulatorPromise.child.stderr?.pipe(emulatorOutputStream, { end: false });
+        emulatorPromise.child.once('close', () => {
+            emulatorOutputStream.end();
+        });
+        // Piped stdio creates socket handles in this process which, unlike inherited
+        // file descriptors, keep the event loop alive for as long as the emulator runs.
+        // We never stop the emulator explicitly, so without unref-ing these the process
+        // would never exit on its own -- defeating the `detached` + `unref()` below.
+        // Output is still captured for as long as this process lives.
+        if (emulatorPromise.child.stdout instanceof node_net_1.Socket) {
+            emulatorPromise.child.stdout.unref();
+        }
+        if (emulatorPromise.child.stderr instanceof node_net_1.Socket) {
+            emulatorPromise.child.stderr.unref();
+        }
         // If emulator fails to start, throw its error.
         if (!emulatorPromise.child.pid) {
             await emulatorPromise;
@@ -276,7 +318,7 @@ var AndroidEmulatorUtils;
         });
         // We don't want to await the SpawnPromise here.
         // eslint-disable-next-line @typescript-eslint/return-await
-        return { emulatorPromise, serialId, logcatOutputPath };
+        return { emulatorPromise, serialId, logcatOutputPath, emulatorOutputPath };
     }
     AndroidEmulatorUtils.startAsync = startAsync;
     async function waitForReadyAsync({ serialId, env, timeoutMs = 3 * 60 * 1_000, logger, }) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@expo/build-tools",
-  "version": "22.0.0",
+  "version": "22.2.0",
   "bugs": "https://github.com/expo/eas-cli/issues",
   "license": "BUSL-1.1",
   "author": "Expo <support@expo.io>",
@@ -46,7 +46,7 @@
     "@expo/plist": "^0.3.5",
     "@expo/results": "^1.0.0",
     "@expo/spawn-async": "1.7.2",
-    "@expo/steps": "22.0.0",
+    "@expo/steps": "22.1.0",
     "@expo/template-file": "22.0.0",
     "@expo/turtle-spawn": "22.0.0",
     "@expo/xcpretty": "^4.3.1",
@@ -100,5 +100,5 @@
     "typescript": "^5.5.4",
     "uuid": "^9.0.1"
   },
-  "gitHead": "b92a9cc5a718f133966e27b9fedcedb569f9cd17"
+  "gitHead": "5484dd607468c7711d915a2521df10531f8b9908"
 }