@expensify/react-native-live-markdown 0.1.99 → 0.1.101

package/ios/MarkdownCommitHook.mm

@@ -141,30 +141,31 @@ RootShadowNode::Unshared MarkdownCommitHook::shadowTreeWillCommit(
                     stateData.attributedStringBox);
 
             // Handles the first render, where the text stored in props is
-            // different than the one stored in state The one in state is empty,
-            // while the one in props is passed from JS If we don't update the
-            // state here, we'll end up with a one-default-line-sized text
-            // input. A better condition to do that can be probably chosen, but
-            // this seems to work
-            auto plainString =
-                std::string([[nsAttributedString string] UTF8String]);
-            if (plainString != textInputProps.text) {
-              // creates new AttributedString from props, adapted from
-              // TextInputShadowNode (ios one, text inputs are
-              // platform-specific)
-              auto attributedString = AttributedString{};
-              attributedString.appendFragment(AttributedString::Fragment{
-                  textInputProps.text, defaultTextAttributes});
-
-              auto attachments = BaseTextShadowNode::Attachments{};
-              BaseTextShadowNode::buildAttributedString(
-                  defaultTextAttributes, *nodes.textInput, attributedString,
-                  attachments);
-
-              // convert the newly created attributed string to
-              // NSAttributedString
-              nsAttributedString = RCTNSAttributedStringFromAttributedStringBox(
-                  AttributedStringBox{attributedString});
+            // different than the one stored in state. The one in state is empty,
+            // while the one in props is passed from JS. If we don't update the
+            // state here, we'll end up with a one-default-line-sized text input
+            if (textInputState.getRevision() == State::initialRevisionValue) {
+                auto plainStringFromState =
+                    std::string([[nsAttributedString string] UTF8String]);
+
+                if (plainStringFromState != textInputProps.text) {
+                // creates new AttributedString from props, adapted from
+                // TextInputShadowNode (ios one, text inputs are
+                // platform-specific)
+                auto attributedString = AttributedString{};
+                attributedString.appendFragment(AttributedString::Fragment{
+                    textInputProps.text, defaultTextAttributes});
+
+                auto attachments = BaseTextShadowNode::Attachments{};
+                BaseTextShadowNode::buildAttributedString(
+                    defaultTextAttributes, *nodes.textInput, attributedString,
+                    attachments);
+
+                // convert the newly created attributed string to
+                // NSAttributedString
+                nsAttributedString = RCTNSAttributedStringFromAttributedStringBox(
+                    AttributedStringBox{attributedString});
+                }
             }
 
             // apply markdown

package/ios/RCTMarkdownUtils.mm

@@ -28,6 +28,9 @@ using namespace facebook;
         }
 
         static std::shared_ptr<jsi::Runtime> runtime;
+        static std::mutex runtimeMutex;
+        auto lock = std::lock_guard<std::mutex>(runtimeMutex);
+
         if (runtime == nullptr) {
             NSString *path = [[NSBundle mainBundle] pathForResource:@"react-native-live-markdown-parser" ofType:@"js"];
             assert(path != nil && "[react-native-live-markdown] Markdown parser bundle not found");

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@expensify/react-native-live-markdown",
-  "version": "0.1.99",
+  "version": "0.1.101",
   "description": "Drop-in replacement for React Native's TextInput component with Markdown formatting.",
   "main": "lib/commonjs/index",
   "module": "lib/module/index",