@expensify/react-native-live-markdown 0.1.73 → 0.1.75

package/ios/MarkdownTextInputDecoratorView.mm

@@ -22,6 +22,7 @@
 #else
   __weak RCTBaseTextInputView *_textInput;
 #endif /* RCT_NEW_ARCH_ENABLED */
+  __weak UIView<RCTBackedTextInputViewProtocol> *_backedTextInputView;
   __weak RCTBackedTextFieldDelegateAdapter *_adapter;
   __weak RCTUITextView *_textView;
 }
@@ -51,11 +52,11 @@
 #ifdef RCT_NEW_ARCH_ENABLED
   react_native_assert([view isKindOfClass:[RCTTextInputComponentView class]] && "Previous sibling component is not an instance of RCTTextInputComponentView.");
   _textInput = (RCTTextInputComponentView *)view;
-  UIView<RCTBackedTextInputViewProtocol> *backedTextInputView = [_textInput valueForKey:@"_backedTextInputView"];
+  _backedTextInputView = [_textInput valueForKey:@"_backedTextInputView"];
 #else
   react_native_assert([view isKindOfClass:[RCTBaseTextInputView class]] && "Previous sibling component is not an instance of RCTBaseTextInputView.");
   _textInput = (RCTBaseTextInputView *)view;
-  UIView<RCTBackedTextInputViewProtocol> *backedTextInputView = _textInput.backedTextInputView;
+  _backedTextInputView = _textInput.backedTextInputView;
 #endif /* RCT_NEW_ARCH_ENABLED */
 
   _markdownUtils = [[RCTMarkdownUtils alloc] init];
@@ -63,12 +64,12 @@
   [_markdownUtils setMarkdownStyle:_markdownStyle];
 
   [_textInput setMarkdownUtils:_markdownUtils];
-  if ([backedTextInputView isKindOfClass:[RCTUITextField class]]) {
-    RCTUITextField *textField = (RCTUITextField *)backedTextInputView;
+  if ([_backedTextInputView isKindOfClass:[RCTUITextField class]]) {
+    RCTUITextField *textField = (RCTUITextField *)_backedTextInputView;
     _adapter = [textField valueForKey:@"textInputDelegateAdapter"];
     [_adapter setMarkdownUtils:_markdownUtils];
-  } else if ([backedTextInputView isKindOfClass:[RCTUITextView class]]) {
-    _textView = (RCTUITextView *)backedTextInputView;
+  } else if ([_backedTextInputView isKindOfClass:[RCTUITextView class]]) {
+    _textView = (RCTUITextView *)_backedTextInputView;
     [_textView setMarkdownUtils:_markdownUtils];
     NSLayoutManager *layoutManager = _textView.layoutManager; // switching to TextKit 1 compatibility mode
     layoutManager.allowsNonContiguousLayout = NO; // workaround for onScroll issue
@@ -100,11 +101,13 @@
 {
   _markdownStyle = markdownStyle;
   [_markdownUtils setMarkdownStyle:markdownStyle];
+
+  // apply new styles
 #ifdef RCT_NEW_ARCH_ENABLED
-  [_textInput textInputDidChange]; // apply new styles
+  [_textInput _setAttributedString:_backedTextInputView.attributedText];
 #else
-  [_textInput setAttributedText:_textInput.attributedText]; // apply new styles
-#endif
+  [_textInput setAttributedText:_textInput.attributedText];
+#endif /* RCT_NEW_ARCH_ENABLED */
 }
 
 @end

package/ios/RCTBaseTextInputView+Markdown.h

@@ -9,6 +9,8 @@ NS_ASSUME_NONNULL_BEGIN
 
 - (void)markdown_setAttributedText:(NSAttributedString *)attributedText;
 
+- (BOOL)markdown_textOf:(NSAttributedString *)newText equals:(NSAttributedString *)oldText;
+
 - (void)markdown_updateLocalData;
 
 @end

package/ios/RCTBaseTextInputView+Markdown.mm

@@ -23,6 +23,16 @@
   [self markdown_setAttributedText:attributedText];
 }
 
+- (BOOL)markdown_textOf:(NSAttributedString *)newText equals:(NSAttributedString *)oldText
+{
+  RCTMarkdownUtils *markdownUtils = [self getMarkdownUtils];
+  if (markdownUtils != nil) {
+    return [newText isEqualToAttributedString:oldText];
+  }
+
+  return [self markdown_textOf:newText equals:oldText];
+}
+
 - (void)markdown_updateLocalData
 {
   RCTMarkdownUtils *markdownUtils = [self getMarkdownUtils];
@@ -69,6 +79,15 @@
       Method swizzledMethod = class_getInstanceMethod(cls, swizzledSelector);
       method_exchangeImplementations(originalMethod, swizzledMethod);
     }
+
+    {
+      // swizzle textOf
+      SEL originalSelector = @selector(textOf:equals:);
+      SEL swizzledSelector = @selector(markdown_textOf:equals:);
+      Method originalMethod = class_getInstanceMethod(cls, originalSelector);
+      Method swizzledMethod = class_getInstanceMethod(cls, swizzledSelector);
+      method_exchangeImplementations(originalMethod, swizzledMethod);
+    }
   });
 }
 

package/ios/RCTLiveMarkdownModule.mm

@@ -14,24 +14,54 @@
 @implementation RCTLiveMarkdownModule {
   BOOL installed_;
   std::shared_ptr<livemarkdown::MarkdownCommitHook> commitHook_;
+  __weak RCTSurfacePresenter *surfacePresenter_;
 }
 
 RCT_EXPORT_MODULE(@"LiveMarkdownModule")
 
 - (NSNumber *)install {
-  if (!installed_) {
-    installed_ = YES;
-
-    RCTBridge *bridge = self.bridge;
-    RCTSurfacePresenter *surfacePresenter = bridge.surfacePresenter;
-    RCTScheduler *scheduler = [surfacePresenter scheduler];
+  if (!installed_ && surfacePresenter_ != nil) {
+    RCTScheduler *scheduler = [surfacePresenter_ scheduler];
 
     commitHook_ =
-        std::make_shared<livemarkdown::MarkdownCommitHook>(scheduler.uiManager);
+      std::make_shared<livemarkdown::MarkdownCommitHook>(scheduler.uiManager);
+    installed_ = YES;
   }
   return @1;
 }
 
+- (void)handleJavaScriptDidLoadNotification:(NSNotification *)notification
+{
+  surfacePresenter_ = self.bridge.surfacePresenter;
+  [self install];
+}
+
+- (void)setBridge:(RCTBridge *)bridge
+{
+  [super setBridge:bridge];
+
+  [[NSNotificationCenter defaultCenter] addObserver:self
+                                           selector:@selector(handleJavaScriptDidLoadNotification:)
+                                               name:RCTJavaScriptDidLoadNotification
+                                             object:nil];
+
+  // only within the first loading `self.bridge.surfacePresenter` exists
+  // during the reload `self.bridge.surfacePresenter` is null
+  if (self.bridge.surfacePresenter) {
+    surfacePresenter_ = self.bridge.surfacePresenter;
+  }
+}
+
+/*
+ * Taken from RCTNativeAnimatedTurboModule:
+ * This selector is invoked via BridgelessTurboModuleSetup.
+ */
+- (void)setSurfacePresenter:(id<RCTSurfacePresenterStub>)surfacePresenter
+{
+  surfacePresenter_ = surfacePresenter;
+}
+
+
 - (std::shared_ptr<facebook::react::TurboModule>)getTurboModule:
     (const facebook::react::ObjCTurboModule::InitParams &)params {
   return std::make_shared<facebook::react::NativeLiveMarkdownModuleSpecJSI>(
@@ -40,6 +70,7 @@ RCT_EXPORT_MODULE(@"LiveMarkdownModule")
 
 - (void)invalidate {
   MarkdownShadowFamilyRegistry::reset();
+  [[NSNotificationCenter defaultCenter] removeObserver:self];
   [super invalidate];
 }
 

package/ios/RCTTextInputComponentView+Markdown.h

@@ -12,7 +12,9 @@ NS_ASSUME_NONNULL_BEGIN
 
 - (void)markdown__setAttributedString:(NSAttributedString *)attributedString;
 
-- (void)textInputDidChange;
+- (BOOL)markdown__textOf:(NSAttributedString *)newText equals:(NSAttributedString *)oldText;
+
+- (void)_setAttributedString:(NSAttributedString *)attributedString;
 
 @end
 

package/ios/RCTTextInputComponentView+Markdown.mm

@@ -47,16 +47,39 @@
   [self markdown__setAttributedString:attributedString];
 }
 
+- (BOOL)markdown__textOf:(NSAttributedString *)newText equals:(NSAttributedString *)oldText
+{
+  RCTMarkdownUtils *markdownUtils = [self getMarkdownUtils];
+  if (markdownUtils != nil) {
+    return [newText isEqualToAttributedString:oldText];
+  }
+
+  return [self markdown__textOf:newText equals:oldText];
+}
+
 + (void)load
 {
   static dispatch_once_t onceToken;
   dispatch_once(&onceToken, ^{
-    Class cls = [self class];
-    SEL originalSelector = @selector(_setAttributedString:);
-    SEL swizzledSelector = @selector(markdown__setAttributedString:);
-    Method originalMethod = class_getInstanceMethod(cls, originalSelector);
-    Method swizzledMethod = class_getInstanceMethod(cls, swizzledSelector);
-    method_exchangeImplementations(originalMethod, swizzledMethod);
+    {
+      // swizzle _setAttributedString
+      Class cls = [self class];
+      SEL originalSelector = @selector(_setAttributedString:);
+      SEL swizzledSelector = @selector(markdown__setAttributedString:);
+      Method originalMethod = class_getInstanceMethod(cls, originalSelector);
+      Method swizzledMethod = class_getInstanceMethod(cls, swizzledSelector);
+      method_exchangeImplementations(originalMethod, swizzledMethod);
+    }
+
+    {
+      // swizzle _textOf
+      Class cls = [self class];
+      SEL originalSelector = @selector(_textOf:equals:);
+      SEL swizzledSelector = @selector(markdown__textOf:equals:);
+      Method originalMethod = class_getInstanceMethod(cls, originalSelector);
+      Method swizzledMethod = class_getInstanceMethod(cls, swizzledSelector);
+      method_exchangeImplementations(originalMethod, swizzledMethod);
+    }
   });
 }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@expensify/react-native-live-markdown",
-  "version": "0.1.73",
+  "version": "0.1.75",
   "description": "Drop-in replacement for React Native's TextInput component with Markdown formatting.",
   "main": "lib/commonjs/index",
   "module": "lib/module/index",