@exodus/sui-api 1.0.3 → 1.1.0

package/CHANGELOG.md

@@ -3,6 +3,16 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [1.1.0](https://github.com/ExodusMovement/assets/compare/@exodus/sui-api@1.0.3...@exodus/sui-api@1.1.0) (2025-10-01)
+
+
+### Features
+
+
+* feat: sui - addressing audit comments  (#6560)
+
+
+
 ## [1.0.3](https://github.com/ExodusMovement/assets/compare/@exodus/sui-api@1.0.2...@exodus/sui-api@1.0.3) (2025-09-10)
 
 **Note:** Version bump only for package @exodus/sui-api

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@exodus/sui-api",
   "packageManager": "yarn@4.3.1",
-  "version": "1.0.3",
+  "version": "1.1.0",
   "description": "Transaction monitors, RPC with the blockchain node, and other networking code for Sui",
   "type": "module",
   "main": "src/index.js",
@@ -29,8 +29,8 @@
     "@exodus/crypto": "^1.0.0-rc.26",
     "@exodus/currency": "^6.0.1",
     "@exodus/models": "^12.0.1",
-    "@exodus/sui-lib": "^1.1.2",
-    "@exodus/sui-meta": "^1.1.0",
+    "@exodus/sui-lib": "^1.3.0",
+    "@exodus/sui-meta": "^1.2.0",
     "bn.js": "^5.2.1",
     "lodash": "^4.17.21",
     "minimalistic-assert": "^1.0.1",
@@ -38,7 +38,7 @@
     "url-join": "^4.0.0"
   },
   "devDependencies": {
-    "@exodus/asset": "^2.1.0",
+    "@exodus/asset": "^2.2.0",
     "@exodus/assets-testing": "^1.0.0"
   },
   "homepage": "https://github.com/ExodusMovement/assets/tree/master/sui/sui-api",
@@ -49,5 +49,5 @@
     "type": "git",
     "url": "git+https://github.com/ExodusMovement/assets.git"
   },
-  "gitHead": "e34e15811edb278cd5dc38c2d52e9cc9c303058f"
+  "gitHead": "b8636ba67e814522b1a744d94501c5eca38ebd68"
 }

package/src/get-fee-async.js

@@ -19,8 +19,7 @@ export const getFeeAsyncFactory = ({ assetClientInterface, serverApi, createUnsi
       asset,
       senderAddress,
       walletAccount,
-      recipientAddress:
-        recipientAddress || '0x7a2ddb6af66beb0d9987c6c9010cb9053454f067e16775a8ecf19961195c3d28',
+      recipientAddress: recipientAddress || senderAddress,
       amount: amount.toBaseString(),
       serverApi,
       gasBudget: MIN_GAS_BUDGET,

package/src/vendors/experimental/mvr.js

@@ -12,6 +12,23 @@ const {
   parseStructTag,
 } = vendorLib.utils
 
+const MOVE_IDENT = /^[A-Z_a-z]\w*$/
+
+// Strict .sui domain (labels a-z0-9 and '-', no leading/trailing '-')
+const SUI_DOMAIN_RE = /^(?=.{1,253}$)(?:[\da-z](?:[\da-z-]{0,61}[\da-z])?\.)+sui$/i
+
+// Sui address helpers
+function isEvenHexDigits(hex) {
+  return /^[\dA-Fa-f]+$/.test(hex) && hex.length > 0 && hex.length % 2 === 0
+}
+
+// Pre-normalization: 1..64 hex digits (<=32 bytes), even length, 0x prefixed
+function isSuiAddressLoose(addr) {
+  if (!/^0x[\dA-Fa-f]+$/.test(addr)) return false
+  const hex = addr.slice(2)
+  return isEvenHexDigits(hex) && hex.length <= 64
+}
+
 var __typeError = (msg) => {
   throw new TypeError(msg)
 }
@@ -303,7 +320,8 @@ function validateOverrides(overrides) {
 
   if (overrides?.types) {
     for (const [type, val] of Object.entries(overrides.types)) {
-      if (parseStructTag(type).typeParams.length > 0) {
+      // NOTE: exodus dev edited on audit
+      if (!isStructTag(type) || parseStructTag(type).typeParams.length > 0) {
         throw new Error(
           'Type overrides must be first-level only. If you want to supply generic types, just pass each type individually.'
         )
@@ -340,9 +358,37 @@ function replaceMvrNames(tag, typeCache) {
 }
 
 function hasMvrName(nameOrType) {
-  return (
-    nameOrType.includes(NAME_SEPARATOR) || nameOrType.includes('@') || nameOrType.includes('.sui')
-  )
+  // NOTE: exodus dev edited on audit
+  if (typeof nameOrType !== 'string') return false
+  const s = nameOrType.trim()
+  if (!s) return false
+
+  // 1) foo(.bar).sui
+  if (SUI_DOMAIN_RE.test(s)) return true
+
+  // 2) name@0x<hex>
+  const at = s.indexOf('@')
+  if (at > 0) {
+    const left = s.slice(0, at)
+    const right = s.slice(at + 1)
+    if (MOVE_IDENT.test(left) && isSuiAddressLoose(right)) return true
+  }
+
+  // 3) namespace/name (exactly one separator, both identifiers)
+  if (s.includes(NAME_SEPARATOR)) {
+    const parts = s.split(NAME_SEPARATOR)
+    if (
+      parts.length === 2 &&
+      parts[0] &&
+      parts[1] &&
+      MOVE_IDENT.test(parts[0]) &&
+      MOVE_IDENT.test(parts[1])
+    ) {
+      return true
+    }
+  }
+
+  return false
 }
 
 function isStructTag(type) {

package/src/vendors/transactions/Commands.js

@@ -6,7 +6,7 @@ import { Argument } from './data/internal.js'
 
 const { toBase64, normalizeSuiObjectId } = vendorLib.utils
 
-const Commands = {
+export const SuiCommands = {
   MoveCall(input) {
     const [pkg, mod = '', fn = ''] =
       'target' in input ? input.target.split('::') : [input.package, input.module, input.function]
@@ -97,6 +97,3 @@ const Commands = {
     }
   },
 }
-
-export { Commands }
-// # sourceMappingURL=Commands.js.map

package/src/vendors/transactions/Transaction.js

@@ -3,7 +3,7 @@
 import { vendorLib } from '@exodus/sui-lib'
 
 import { is, parse } from '../valibot.js'
-import { Commands } from './Commands.js'
+import { SuiCommands } from './Commands.js'
 import { Argument, NormalizedCallArg, ObjectRef, TransactionExpiration } from './data/internal.js'
 import { SerializedTransactionDataV2 } from './data/v2.js'
 import { Inputs } from './Inputs.js'
@@ -430,7 +430,7 @@ const _Transaction = class _Transaction {
 
   // Method shorthands:
   splitCoins(coin, amounts) {
-    const command = Commands.SplitCoins(
+    const command = SuiCommands.SplitCoins(
       typeof coin === 'string'
         ? this.object(coin)
         : __privateMethod(this, _Transaction_instances, resolveArgument_fn).call(this, coin),
@@ -449,7 +449,7 @@ const _Transaction = class _Transaction {
 
   mergeCoins(destination, sources) {
     return this.add(
-      Commands.MergeCoins(
+      SuiCommands.MergeCoins(
         this.object(destination),
         sources.map((src) => this.object(src))
       )
@@ -458,7 +458,7 @@ const _Transaction = class _Transaction {
 
   publish({ modules, dependencies }) {
     return this.add(
-      Commands.Publish({
+      SuiCommands.Publish({
         modules,
         dependencies,
       })
@@ -467,7 +467,7 @@ const _Transaction = class _Transaction {
 
   upgrade({ modules, dependencies, package: packageId, ticket }) {
     return this.add(
-      Commands.Upgrade({
+      SuiCommands.Upgrade({
         modules,
         dependencies,
         package: packageId,
@@ -478,7 +478,7 @@ const _Transaction = class _Transaction {
 
   moveCall({ arguments: args, ...input }) {
     return this.add(
-      Commands.MoveCall({
+      SuiCommands.MoveCall({
         ...input,
         arguments: args?.map((arg) =>
           __privateMethod(this, _Transaction_instances, normalizeTransactionArgument_fn).call(
@@ -492,7 +492,7 @@ const _Transaction = class _Transaction {
 
   transferObjects(objects, address) {
     return this.add(
-      Commands.TransferObjects(
+      SuiCommands.TransferObjects(
         objects.map((obj) => this.object(obj)),
         typeof address === 'string'
           ? this.pure.address(address)
@@ -506,7 +506,7 @@ const _Transaction = class _Transaction {
 
   makeMoveVec({ type, elements }) {
     return this.add(
-      Commands.MakeMoveVec({
+      SuiCommands.MakeMoveVec({
         type,
         elements: elements.map((obj) => this.object(obj)),
       })

package/src/vendors/valibot.js

@@ -2,40 +2,31 @@
 /* eslint-disable sonarjs/no-nested-template-literals */
 /* eslint-disable @exodus/mutable/no-param-reassign-prop-only */
 // src/storages/globalConfig/globalConfig.ts
-var store
 
 // @__NO_SIDE_EFFECTS__
-function getGlobalConfig(config2) {
+function getGlobalConfig(cfg) {
+  // NOTE: exodus dev edited on audit
   return {
-    lang: config2?.lang ?? store?.lang,
-    message: config2?.message,
-    abortEarly: config2?.abortEarly ?? store?.abortEarly,
-    abortPipeEarly: config2?.abortPipeEarly ?? store?.abortPipeEarly,
+    lang: cfg?.lang,
+    message: cfg?.message,
+    abortEarly: !!cfg?.abortEarly,
+    abortPipeEarly: !!cfg?.abortPipeEarly,
   }
 }
 
-// src/storages/globalMessage/globalMessage.ts
-var store2
-
 // @__NO_SIDE_EFFECTS__
 function getGlobalMessage(lang) {
-  return store2?.get(lang)
+  // NOTE: exodus dev edited on audit
 }
 
-// src/storages/schemaMessage/schemaMessage.ts
-var store3
-
 // @__NO_SIDE_EFFECTS__
 function getSchemaMessage(lang) {
-  return store3?.get(lang)
+  // NOTE: exodus dev edited on audit
 }
 
-// src/storages/specificMessage/specificMessage.ts
-var store4
-
 // @__NO_SIDE_EFFECTS__
 function getSpecificMessage(reference, lang) {
-  return store4?.get(reference)?.get(lang)
+  // NOTE: exodus dev edited on audit
 }
 
 // src/utils/_stringify/_stringify.ts