@exodus/solana-api 3.11.7 → 3.11.9

package/CHANGELOG.md

@@ -3,6 +3,36 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [3.11.9](https://github.com/ExodusMovement/assets/compare/@exodus/solana-api@3.11.8...@exodus/solana-api@3.11.9) (2024-12-31)
+
+
+### Bug Fixes
+
+
+* fix: include rentExemptAmount in balance calculation (#4738)
+
+* fix: integration tests (#4720)
+
+
+
+## [3.11.8](https://github.com/ExodusMovement/assets/compare/@exodus/solana-api@3.11.6...@exodus/solana-api@3.11.8) (2024-12-10)
+
+
+### Bug Fixes
+
+
+* fix: prevent invalid account owner (#4485)
+
+* fix: SOL rename deprecated methods (#4512)
+
+
+### License
+
+
+* license: re-license under MIT license (#4515)
+
+
+
 ## [3.11.7](https://github.com/ExodusMovement/assets/compare/@exodus/solana-api@3.11.6...@exodus/solana-api@3.11.7) (2024-11-06)
 
 

package/README.md

@@ -1,4 +1,8 @@
-# Solana Api · [![npm version](https://img.shields.io/badge/npm-private-blue.svg?style=flat)](https://www.npmjs.com/package/@exodus/solana-api)
+# @exodus/solana-api
+
+Transaction monitors, fee monitors, RPC with the blockchain node, and other networking code for Solana. See [Asset Packages](../../docs/asset-packages.md) for more detail on this package's role.
+
+## Known Issues
 
 - To get all transactions data from an address we gotta call 3 rpcs `getSignaturesForAddress` (get txIds) -> `getTransaction` (get tx details) -> `getBlockTime` (get tx timestamp). Pretty annoying and resource-consuming backend-side. (https://github.com/solana-labs/solana/issues/12411)
 - calling `getBlockTime` might results in an error if the slot/block requested is too old (https://github.com/solana-labs/solana/issues/12413), looks like some Solana validators can choose to not keep all the ledger blocks (fix in progress by solana team).

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@exodus/solana-api",
-  "version": "3.11.7",
-  "description": "Exodus internal Solana asset API wrapper",
+  "version": "3.11.9",
+  "description": "Transaction monitors, fee monitors, RPC with the blockchain node, and other networking code for Solana",
   "type": "module",
   "main": "src/index.js",
   "files": [
@@ -14,7 +14,7 @@
   "author": "Exodus Movement, Inc.",
   "license": "ISC",
   "publishConfig": {
-    "access": "restricted"
+    "access": "public"
   },
   "scripts": {
     "test": "run -T exodus-test --jest",
@@ -26,11 +26,11 @@
     "@exodus/asset-lib": "^5.0.0",
     "@exodus/assets": "^11.0.0",
     "@exodus/basic-utils": "^3.0.1",
-    "@exodus/currency": "^5.0.2",
+    "@exodus/currency": "^6.0.1",
     "@exodus/fetch": "^1.2.0",
     "@exodus/models": "^12.0.1",
     "@exodus/simple-retry": "^0.0.6",
-    "@exodus/solana-lib": "^3.6.0",
+    "@exodus/solana-lib": "^3.9.3",
     "@exodus/solana-meta": "^2.0.2",
     "@exodus/timer": "^1.1.1",
     "bn.js": "^4.11.0",
@@ -47,7 +47,7 @@
     "@exodus/assets-testing": "^1.0.0",
     "@exodus/solana-web3.js": "^1.63.1-exodus.9-rc3"
   },
-  "gitHead": "451a0342feffa7ab7dbea8ff7f8e224cbd55c31b",
+  "gitHead": "44b274a6a6f0228014aa0eaac5af850dcaf76fed",
   "bugs": {
     "url": "https://github.com/ExodusMovement/assets/issues?q=is%3Aissue+is%3Aopen+label%3Asolana-api"
   },

package/src/account-state.js

@@ -19,6 +19,7 @@ export const createAccountState = ({ assetList }) => {
       cursor: '',
       balance: asset.currency.ZERO,
       tokenBalances: Object.create(null),
+      rentExemptAmount: asset.currency.ZERO,
       stakingInfo: {
         loaded: false,
         staking: {

package/src/api.js

@@ -17,6 +17,7 @@ import {
 import BN from 'bn.js'
 import lodash from 'lodash'
 import assert from 'minimalistic-assert'
+import ms from 'ms'
 import urljoin from 'url-join'
 import wretch from 'wretch'
 
@@ -46,6 +47,12 @@ export class Api {
       const result = await this.rpcCall('getTokenSupply', [mintAddress])
       return result?.value?.amount
     })
+
+    this.getMinimumBalanceForRentExemption = memoize(
+      (accountSize) => this.rpcCall('getMinimumBalanceForRentExemption', [accountSize]),
+      (accountSize) => accountSize,
+      ms('15m')
+    )
   }
 
   setServer(rpcUrl) {
@@ -137,7 +144,7 @@ export class Api {
   async getRecentBlockHash(commitment) {
     const result = await this.rpcCall(
       'getLatestBlockhash',
-      [{ commitment: commitment || 'finalized', encoding: 'jsonParsed' }],
+      [{ commitment: commitment || 'confirmed', encoding: 'jsonParsed' }],
       { forceHttp: true }
     )
     return lodash.get(result, 'value.blockhash')
@@ -171,7 +178,7 @@ export class Api {
     return this.rpcCall('getBlockTime', [slot])
   }
 
-  async getConfirmedSignaturesForAddress(address, { until, before, limit } = {}) {
+  async getSignaturesForAddress(address, { until, before, limit } = {}) {
     until = until || undefined
     return this.rpcCall('getSignaturesForAddress', [address, { until, before, limit }], { address })
   }
@@ -195,7 +202,7 @@ export class Api {
 
       const txsResultsByAccount = await Promise.all(
         accountsToCheck.map((addr) =>
-          this.getConfirmedSignaturesForAddress(addr, {
+          this.getSignaturesForAddress(addr, {
             until,
             before,
             limit,
@@ -876,10 +883,6 @@ export class Api {
     }, 0)
   }
 
-  async getMinimumBalanceForRentExemption(size) {
-    return this.rpcCall('getMinimumBalanceForRentExemption', [size])
-  }
-
   async getProgramAccounts(programId, config) {
     return this.rpcCall('getProgramAccounts', [programId, config])
   }
@@ -1046,7 +1049,7 @@ export class Api {
     ).toString('base64')
     const { accounts, unitsConsumed, err } = await this.simulateTransaction(encodedTransaction, {
       ...config,
-      replaceRecentBlockhash: true,
+      replaceRecentBlockhash: false,
       sigVerify: false,
     })
     return {

package/src/get-balances.js

@@ -33,7 +33,18 @@ export const getBalancesFactory =
       .clampLowerZero()
 
     const total = stakingFeatureAvailable ? balance : balanceWithoutStaking
-    const spendable = balanceWithoutStaking.sub(asset.accountReserve || zero).clampLowerZero()
+
+    const networkReserve = accountState.rentExemptAmount || zero
+
+    const accountReserve = asset.accountReserve || zero
+
+    // there is no wallet reserve when there are no tokens nor staking actions. Just network reserve for the rent exempt amount.
+    const walletReserve =
+      hasStakedFunds({ locked, withdrawable, pending }) || hasTokensBalance({ accountState })
+        ? accountReserve.sub(networkReserve).clampLowerZero()
+        : zero
+
+    const spendable = balanceWithoutStaking.sub(walletReserve).sub(networkReserve).clampLowerZero()
 
     const staked = locked
     const unstaking = pending
@@ -47,6 +58,8 @@ export const getBalancesFactory =
       spendable,
       staked,
       unstaking,
+      networkReserve,
+      walletReserve,
     }
   }
 
@@ -93,3 +106,9 @@ const getBalanceFromAccountState = ({ asset, accountState }) => {
     asset.currency.ZERO
   )
 }
+
+const hasStakedFunds = ({ locked, withdrawable, pending }) =>
+  [locked, withdrawable, pending].some((amount) => amount.isPositive)
+
+const hasTokensBalance = ({ accountState }) =>
+  Object.values(accountState?.tokenBalances || {}).some((balance) => balance.isPositive)

package/src/tx-log/solana-monitor.js

@@ -294,10 +294,18 @@ export class SolanaMonitor extends BaseMonitor {
 
   async getAccount({ refresh, address, tokenAccounts, accountState, walletAccount }) {
     const tokens = Object.keys(this.assets).filter((name) => name !== this.asset.name)
-    const [solBalance, splBalances] = await Promise.all([
-      this.api.getBalance(address),
-      this.api.getTokensBalance({ address, filterByTokens: tokens, tokenAccounts }),
-    ])
+    const accountInfo = await this.api.getAccountInfo(address).catch(() => {})
+    const accountSize = accountInfo?.space || 0
+    const solBalance = accountInfo?.lamports || 0
+
+    const rentExemptValue = await this.api.getMinimumBalanceForRentExemption(accountSize)
+    const rentExemptAmount = this.asset.currency.baseUnit(rentExemptValue)
+
+    const splBalances = await this.api.getTokensBalance({
+      address,
+      filterByTokens: tokens,
+      tokenAccounts,
+    })
 
     const tokenBalances = _.mapValues(splBalances, (balance, name) =>
       this.assets[name].currency.baseUnit(balance).toDefault()
@@ -334,14 +342,21 @@ export class SolanaMonitor extends BaseMonitor {
       account: {
         balance,
         tokenBalances,
+        rentExemptAmount,
       },
       staking,
     }
   }
 
   async updateState({ account, cursorState, walletAccount, staking }) {
-    const { balance, tokenBalances } = account
-    const newData = { balance, tokenBalances, stakingInfo: staking, ...cursorState }
+    const { balance, tokenBalances, rentExemptAmount } = account
+    const newData = {
+      balance,
+      rentExemptAmount,
+      tokenBalances,
+      stakingInfo: staking,
+      ...cursorState,
+    }
     return this.updateAccountState({ newData, walletAccount })
   }
 

package/src/tx-send.js

@@ -5,7 +5,6 @@ import {
   TOKEN_2022_PROGRAM_ID,
   TOKEN_PROGRAM_ID,
 } from '@exodus/solana-lib'
-import { transactionToBase58 } from '@exodus/solana-lib/src/tx/common.js'
 import assert from 'minimalistic-assert'
 
 export const createAndBroadcastTXFactory =
@@ -34,6 +33,7 @@ export const createAndBroadcastTXFactory =
       expectedMintAddress,
       metadataAddress,
       creators,
+      priorityFee,
       // </MagicEden>
       reference,
       memo,
@@ -129,7 +129,7 @@ export const createAndBroadcastTXFactory =
       from,
       to: address,
       amount,
-      fee: feeAmount,
+      fee: feeData.fee, // feeAmount includes the priortyFee
       recentBlockhash,
       feeData,
       reference,
@@ -139,25 +139,15 @@ export const createAndBroadcastTXFactory =
       ...magicEdenParams,
     })
 
-    let { priorityFee } = feeData
-
     const transactionForFeeEstimation = prepareForSigning(unsignedTransaction)
 
-    if (!priorityFee) {
-      try {
-        priorityFee = await api.getPriorityFee(transactionToBase58(transactionForFeeEstimation))
-      } catch (e) {
-        console.warn(`Failed to fetch priority fee: ${e.message}`)
-        priorityFee = feeData.fallbackPriorityFee
-      }
-    }
-
-    const { unitsConsumed: computeUnits } = await api.simulateUnsignedTransaction({
+    const { unitsConsumed: computeUnits, err } = await api.simulateUnsignedTransaction({
       message: transactionForFeeEstimation.message,
     })
+    if (err) throw new Error(JSON.stringify(err))
 
-    unsignedTransaction.txData.priorityFee = priorityFee
-    unsignedTransaction.txData.computeUnits = computeUnits
+    unsignedTransaction.txData.priorityFee = priorityFee ?? 0
+    unsignedTransaction.txData.computeUnits = computeUnits * feeData.computeUnitsMultiplier
 
     const { txId, rawTx } = await assetClientInterface.signTransaction({
       assetName: baseAsset.name,