@exodus/ethereum-lib 5.20.0 → 5.20.2

package/CHANGELOG.md

@@ -3,6 +3,26 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [5.20.2](https://github.com/ExodusMovement/assets/compare/@exodus/ethereum-lib@5.20.1...@exodus/ethereum-lib@5.20.2) (2025-12-17)
+
+
+### Bug Fixes
+
+
+* fix: prevent acceleration of replaced evm transactions (#6964)
+
+
+
+## [5.20.1](https://github.com/ExodusMovement/assets/compare/@exodus/ethereum-lib@5.20.0...@exodus/ethereum-lib@5.20.1) (2025-12-09)
+
+
+### Bug Fixes
+
+
+* fix: EIP1559 acceleration gas calculation in (#6997). Update getLinearIncentiveBumpForEip1559Transaction() to properly calculate bump tx logic under eip1559
+
+
+
 ## [5.20.0](https://github.com/ExodusMovement/assets/compare/@exodus/ethereum-lib@5.18.5...@exodus/ethereum-lib@5.20.0) (2025-11-19)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@exodus/ethereum-lib",
-  "version": "5.20.0",
+  "version": "5.20.2",
   "description": "Ethereum utils, such as for cryptography, address encoding/decoding, transaction building, etc.",
   "type": "module",
   "main": "src/index.js",
@@ -51,5 +51,5 @@
     "type": "git",
     "url": "git+https://github.com/ExodusMovement/assets.git"
   },
-  "gitHead": "a15d8239871e44fd99d48a2b1a66606e2d428735"
+  "gitHead": "8c3e94c96818b1ce8ce10cb75da29db2c9fe9ab9"
 }

package/src/constants.js

@@ -136,3 +136,6 @@ export const CONFIRMATIONS_NUMBER = mapValues(
 export const ETHEREUM_LIKE_ASSETS = Object.keys(CHAIN_DATA)
 
 export const BUMP_RATE = 1.2
+// Node bump requirement (10% as enforced by Geth/Erigon/Nethermind)
+// Client always bumps by 20% (BUMP_RATE) to exceed this threshold
+export const NODE_BUMP_REQUIREMENT = 1.1

package/src/selectors/get-can-accelerate-tx-factory.js

@@ -12,6 +12,57 @@ const BumpType = {
   RBF: 2,
 }
 
+// NOTE: If a transaction was successfully included,
+//       it is the de-facto highest incentive
+//       transaction - irrespective of other
+//       attempts for that nonce.
+const getHighestIncentiveTxByNonceForTxLog = ({ nonce, txLog }) => {
+  assert(txLog, 'expected txLog')
+
+  if (txLog.size === 0 || !Number.isInteger(nonce)) return
+
+  const txLogSendsByFeeAmountDesc = [...txLog]
+    .filter((tx) => tx.data.nonce === nonce && tx.sent)
+    .sort((a, b) => (a.feeAmount.gt(b.feeAmount) ? -1 : b.feeAmount.gt(a.feeAmount) ? 1 : 0))
+
+  // If any of the transactions competing for this `nonce`
+  // were successful, then we can return this transaction
+  // as it effectively had the highest game-theoretical
+  // incentive regardless of other (potentially higher fee)
+  // transactions that were sent.
+  //
+  // https://github.com/ExodusMovement/exodus-hydra/blob/e59004097f15974a975d14e1823de5d7b1c28308/features/activity-txs/redux/utils/activity-formatters/format-tx-activity.js#L13
+  const maybeConfirmedTx = txLogSendsByFeeAmountDesc.find((tx) => !tx.failed && !tx.pending)
+  if (maybeConfirmedTx) return maybeConfirmedTx
+
+  // https://github.com/ExodusMovement/assets/blob/fbe3702861cba3b21885a65b15f038fcd8541891/shield/asset-lib/src/balances-utils.js#L26
+  const isUnconfirmed = (tx) => !tx.failed && tx.pending
+
+  // NOTE: When trying to find the highest incentive of a
+  //       transaction, consider those which are still
+  //       pending.
+  return txLogSendsByFeeAmountDesc.find(isUnconfirmed)
+}
+
+// Returns the most competitively priced pending
+// transaction from the `TxLog` for a given `nonce`.
+export const getHighestIncentiveTxByNonce = async ({
+  assetClientInterface,
+  asset,
+  nonce,
+  walletAccount,
+}) => {
+  assert(assetClientInterface, 'expected assetClientInterface')
+  assert(asset, 'expected asset')
+  assert(Number.isInteger(nonce), 'expected integer nonce')
+  assert(walletAccount, 'expected walletAccount')
+
+  return getHighestIncentiveTxByNonceForTxLog({
+    txLog: await assetClientInterface.getTxLog({ assetName: asset.name, walletAccount }),
+    nonce,
+  })
+}
+
 // Legacy compatibility with wallets
 export function getPendingNonExchangeTxs(activeWalletAccount, getTxLog, getIsExchangeTx) {
   console.log('Using deprecated function getPendingNonExchangeTxs()')
@@ -103,37 +154,63 @@ const calculateBumpedGasPriceNonEip1559 = ({ currentGasPrice, prevMaxFeePerGas }
   }
 }
 
-const getLinearIncentiveBumpForEip1559Transaction = ({
+/*
+Node Rules:
+GETH:
+The EIP1559 transaction bump logic requires that a replacement transaction must have BOTH:
+1. GasFeeCap >= oldGasFeeCap × (100 + priceBump) / 100
+2. GasTipCap >= oldGasTipCap × (100 + priceBump) / 100
+ERIGON:
+The Erigon EIP1559 transaction bump logic requires that a replacement transaction must have BOTH:
+1. `Tip >= oldTip × (100 + priceBump) / 100`
+2. `FeeCap >= oldFeeCap × (100 + priceBump) / 100`
+NETHERMIND:
+Nethermind's EIP1559 transaction bump logic requires that a replacement transaction must have BOTH:
+### Regular Transactions (10% bump)
+1. `newMaxFeePerGas > oldMaxFeePerGas × 1.1`
+2. `newMaxPriorityFeePerGas > oldMaxPriorityFeePerGas × 1.1`
+
+In short, all these 3 nodes require that the bump is applied to both the tip and the cap.
+This won't work for besu nodes.
+*/
+export const getLinearIncentiveBumpForEip1559Transaction = ({
   currentBaseFeePerGas,
-  prevMaxFeePerGas,
-  prevMaxPriorityFeePerGas,
+  prevMaxFeePerGas, // Previous maxFeePerGas (includes the old tip)
+  prevMaxPriorityFeePerGas, // Previous tip (maxPriorityFeePerGas)
 }) => {
   assert(currentBaseFeePerGas, 'currentBaseFeePerGas is required')
   assert(prevMaxFeePerGas, 'prevMaxFeePerGas is required')
   assert(prevMaxPriorityFeePerGas, 'prevMaxPriorityFeePerGas is required')
 
-  // First, let's determine if there's a bump required just to bring
-  // the transaction up to the `baseFeePerGas`. If the current base
-  // fee is larger, we'll need to see how much to adjust the overall
-  // transaction by.
-  const increaseToBaseFeePerGasTipGasPrice = currentBaseFeePerGas.gt(prevMaxFeePerGas)
-    ? currentBaseFeePerGas.sub(prevMaxFeePerGas)
-    : currentBaseFeePerGas.sub(currentBaseFeePerGas) // TODO: What is a nice way to get ZERO without an `asset`? Is it `currentBaseFeePerGas.ZERO`?
-
-  // The new `bumpedTipGasPrice`.
-  const bumpedTipGasPrice = prevMaxPriorityFeePerGas
-    .mul(BUMP_RATE)
-    .add(increaseToBaseFeePerGasTipGasPrice)
-
-  // We'll make attempt a linear increase of the transaction pricing. By
-  // increasing the `tipGasPrice` and the `gasPrice` by the same amount,
-  // we ensuret he any additional amount we spend (over the basefee) goes
-  // directly to the miner, thereby increasing transaction incentive.
+  //
+  // ---- STEP 1: Geth / Erigon / Nethermind "pricebump" policy ----
+  //
+  // These clients require that BOTH the tip AND the cap are bumped by
+  // the configured percentage (BUMP_RATE), compared to the previous tx:
+  //
+  //   newTip    >= prevTip * BUMP_RATE    AND
+  //   newMaxFee >= prevMaxFee * BUMP_RATE
+  //
+  // Both conditions must be satisfied independently for the replacement
+  // transaction to be accepted by the node's mempool.
+  //
+  const newTip = prevMaxPriorityFeePerGas.mul(BUMP_RATE)
+  let newMaxFee = prevMaxFeePerGas.mul(BUMP_RATE)
+
+  //
+  // ---- STEP 2: EIP-1559 validity "now" ----
+  //
+  // EIP-1559 requires maxFeePerGas >= baseFee + tip for the tx
+  // to be able to actually pay the full priority fee at the current baseFee.
+  //
+  const minCapRequiredNow = currentBaseFeePerGas.add(newTip)
+  if (newMaxFee.lt(minCapRequiredNow)) {
+    newMaxFee = minCapRequiredNow
+  }
+
   return {
-    bumpedGasPrice: prevMaxFeePerGas
-      .sub(prevMaxPriorityFeePerGas) // Removes the previous `tipGasPrice` before adding the next one (`bumpedTipGasPrice` is inclusive).
-      .add(bumpedTipGasPrice),
-    bumpedTipGasPrice,
+    bumpedGasPrice: newMaxFee,
+    bumpedTipGasPrice: newTip,
   }
 }
 
@@ -322,6 +399,20 @@ export const canAccelerateTx = ({
     return wrapResponseToObject({ errorMessage: 'there is a stuck TX with lower nonce' })
   }
 
+  // Check to see if this is the highest incentive transaction for this nonce.
+  const maybeHighestIncentiveTxByNonce = getHighestIncentiveTxByNonceForTxLog({
+    // TODO: is this the correct way to determine a nonce?
+    nonce: tx.data.nonce,
+    txLog: getTxLog(baseAssetName, activeWalletAccount),
+  })
+
+  // NOTE: We should only be able to accelerate the highest
+  //       incentive transaction which is competing for a
+  //       given `nonce`.
+  if (maybeHighestIncentiveTxByNonce && maybeHighestIncentiveTxByNonce.txId !== tx.txId) {
+    return wrapResponseToObject({ errorMessage: 'TX was replaced' })
+  }
+
   const {
     gasPrice: currentGasPrice,
     eip1559Enabled,

package/src/selectors/index.js

@@ -4,6 +4,7 @@ export {
   calculateBumpedGasPriceForFeeData,
   getPendingNonExchangeTxs,
   getAssetPendingNonExchangeTxs,
+  getHighestIncentiveTxByNonce,
 } from './get-can-accelerate-tx-factory.js'
 
 export { default as getIsEnoughBalanceToAccelerateSelectorFactory } from './get-is-enough-balance-to-accelerate-factory.js'