@exodus/ethereum-lib 5.17.2 → 5.18.0

package/CHANGELOG.md

@@ -3,6 +3,26 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [5.18.0](https://github.com/ExodusMovement/assets/compare/@exodus/ethereum-lib@5.17.3...@exodus/ethereum-lib@5.18.0) (2025-09-26)
+
+
+### Features
+
+
+* feat(ethereum): use methodId in new staking txs shape (#6335)
+
+
+
+## [5.17.3](https://github.com/ExodusMovement/assets/compare/@exodus/ethereum-lib@5.17.2...@exodus/ethereum-lib@5.17.3) (2025-09-25)
+
+
+### Bug Fixes
+
+
+* fix: removed contractAddress, keepTxInput and and resolve token amount when sending to a different contract (#6508)
+
+
+
 ## [5.17.2](https://github.com/ExodusMovement/assets/compare/@exodus/ethereum-lib@5.17.1...@exodus/ethereum-lib@5.17.2) (2025-08-29)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@exodus/ethereum-lib",
-  "version": "5.17.2",
+  "version": "5.18.0",
   "description": "Ethereum utils, such as for cryptography, address encoding/decoding, transaction building, etc.",
   "type": "module",
   "main": "src/index.js",
@@ -50,5 +50,5 @@
     "type": "git",
     "url": "git+https://github.com/ExodusMovement/assets.git"
   },
-  "gitHead": "6f48374a175ff7ccea7549806d9f6d574d2f8693"
+  "gitHead": "cf881908a1cff88e98d2f9a7a3f29357474e3d0c"
 }

package/src/unsigned-tx/parse-unsigned-tx.js

@@ -1,3 +1,4 @@
+import { isNumberUnit } from '@exodus/currency'
 import { FeeMarketEIP1559Transaction, Transaction } from '@exodus/ethereumjs/tx'
 import { bufferToInt } from '@exodus/ethereumjs/util'
 import lodash from 'lodash'
@@ -19,6 +20,7 @@ const getCommonTransactionProps = ({ transaction, baseAsset }) => {
 
 const parseBuffer = (asset, unsignedTx) => {
   const { transactionBuffer, chainId, ...legacyTxData } = unsignedTx.txData
+  const feeAsset = asset.feeAsset
   const baseAsset = asset.baseAsset
   assert(
     isEmpty(legacyTxData),
@@ -29,8 +31,8 @@ const parseBuffer = (asset, unsignedTx) => {
     const transaction = FeeMarketEIP1559Transaction.fromSerializedTx(transactionBuffer)
     return {
       ...getCommonTransactionProps({ transaction, baseAsset }),
-      tipGasPrice: baseAsset.currency.baseUnit(transaction.maxPriorityFeePerGas),
-      gasPrice: baseAsset.currency.baseUnit(transaction.maxFeePerGas),
+      tipGasPrice: feeAsset.currency.baseUnit(transaction.maxPriorityFeePerGas),
+      gasPrice: feeAsset.currency.baseUnit(transaction.maxFeePerGas),
       eip1559Enabled: true,
     }
   }
@@ -38,7 +40,7 @@ const parseBuffer = (asset, unsignedTx) => {
   const transaction = Transaction.fromSerializedTx(transactionBuffer)
   return {
     ...getCommonTransactionProps({ transaction, baseAsset }),
-    gasPrice: baseAsset.currency.baseUnit(transaction.gasPrice),
+    gasPrice: feeAsset.currency.baseUnit(transaction.gasPrice),
     eip1559Enabled: false,
   }
 }
@@ -47,15 +49,20 @@ function resolveToAmount({ asset, data, value, to: rawTo }) {
   const _isToken = isToken(asset)
 
   if (_isToken) {
-    const { method, values } = asset.contract.decodeInput(data)
-    if (method === 'transfer' || method === 'approve') {
-      return {
-        to: values[0],
-        amount: asset.currency.baseUnit(values[1]),
+    if (asset.assetId.toLowerCase() === rawTo.toLowerCase()) {
+      const { method, values } = asset.contract.decodeInput(data)
+      if (method === 'transfer' || method === 'approve') {
+        return {
+          to: values[0],
+          amount: asset.currency.baseUnit(values[1]),
+        }
       }
+
+      // it's not possible to resolve the amount when transfering a token to a special contract, e.g lifi
+      return { to: values[0], amount: asset.currency.ZERO }
     }
 
-    return { to: values[0], amount: asset.currency.ZERO }
+    return { to: rawTo, amount: asset.currency.ZERO }
   }
 
   return {
@@ -64,9 +71,22 @@ function resolveToAmount({ asset, data, value, to: rawTo }) {
   }
 }
 
+function toNumberUnit(asset, amount) {
+  if (isNumberUnit(amount)) {
+    return amount
+  }
+
+  if (typeof amount === 'string') {
+    return asset.currency.parse(amount)
+  }
+
+  throw new Error('Cannot parse type ' + typeof amount)
+}
+
 export default function parseUnsignedTx({ asset, unsignedTx }) {
   assert(asset, 'asset is required')
   assert(unsignedTx, 'unsignedTx is required')
+  const feeAsset = asset.feeAsset
   const baseAsset = asset.baseAsset
   const txData = unsignedTx.txData
   const {
@@ -84,17 +104,26 @@ export default function parseUnsignedTx({ asset, unsignedTx }) {
         data: txData.data,
         to: txData.to,
         value: buffer2currency({ asset: baseAsset, value: txData.value }),
-        gasPrice: buffer2currency({ asset: baseAsset, value: txData.gasPrice }),
+        gasPrice: buffer2currency({ asset: feeAsset, value: txData.gasPrice }),
         tipGasPrice: txData.tipGasPrice
-          ? buffer2currency({ asset: baseAsset, value: txData.tipGasPrice })
+          ? buffer2currency({ asset: feeAsset, value: txData.tipGasPrice })
           : undefined,
         eip1559Enabled: Boolean(txData.tipGasPrice),
         gasLimit: bufferToInt(txData.gasLimit),
         nonce: bufferToInt(txData.nonce),
       }
 
-  const fee = gasPrice.mul(gasLimit)
-  const { to, amount } = resolveToAmount({ asset, data, value, to: rawTo })
+  const { to, amount: resolvedAmount } = resolveToAmount({ asset, data, value, to: rawTo })
+
+  // the txMeta.fee may include implicit l1 fees
+  const fee = unsignedTx.txMeta?.fee
+    ? toNumberUnit(feeAsset, unsignedTx.txMeta?.fee)
+    : gasPrice.mul(gasLimit)
+
+  // unsignedTx.txMeta.amount would be more accurate when using non erc20 contracts
+  const amount = unsignedTx.txMeta?.amount
+    ? toNumberUnit(asset, unsignedTx.txMeta.amount)
+    : resolvedAmount ?? asset.currency.ZERO
 
   return {
     to,
@@ -106,5 +135,6 @@ export default function parseUnsignedTx({ asset, unsignedTx }) {
     eip1559Enabled,
     nonce,
     from: null, // TODO: how?
+    data,
   }
 }