@exodus/ethereum-lib 0.0.7 → 0.0.9

package/lib/encode.js

@@ -7,6 +7,8 @@ exports.validate = validate;
 exports.hasChecksum = hasChecksum;
 exports.encodePrivate = encodePrivate;
 exports.encodePublic = encodePublic;
+exports.isValidPrivate = isValidPrivate;
+exports.encodePublicFromPrivate = encodePublicFromPrivate;
 
 var _ethereumjsUtil = _interopRequireDefault(require("ethereumjs-util"));
 
@@ -33,4 +35,16 @@ function encodePublic(compressedPubKey) {
   const hash160bits = _ethereumjsUtil.default.publicToAddress(compressedPubKey, true);
 
   return _ethereumjsUtil.default.toChecksumAddress(hash160bits.toString('hex'));
+}
+
+function isValidPrivate(privateKey) {
+  if (privateKey.length !== 32 || !_ethereumjsUtil.default.isValidPrivate(privateKey)) {
+    return false;
+  }
+
+  return true;
+}
+
+function encodePublicFromPrivate(privateKey) {
+  return _ethereumjsUtil.default.toChecksumAddress(_ethereumjsUtil.default.privateToAddress(privateKey).toString('hex'));
 }

package/lib/unsigned-tx/create-unsigned-tx.js

@@ -27,15 +27,16 @@ function createUnsignedTx({
   chainId
 }) {
   if (txInput) {
-    txInput = _ethereumjsUtil.default.toBuffer(txInput);
+    txInput = _ethereumjsUtil.default.toBuffer(txInput); // If txInput is already a Buffer, then it is passed through
   } else {
     txInput = Buffer.alloc(0);
   }
 
   if (!chainId) chainId = _constants.CHAIN_IDS[baseAsset.name]; // mainnet
 
-  const to = asset.isEthereumToken ? asset.contract.addresses.current : address;
-  let value = (0, _utils.currency2buffer)(asset.isEthereumToken ? baseAsset.currency.ZERO : amount); // TODO: check: present on desktop missing on mobile. This insures we never have a buffer specifying 0.
+  const isEthereumToken = (0, _utils._isEthereumToken)(asset);
+  const to = isEthereumToken ? asset.contract.addresses.current : address;
+  let value = (0, _utils.currency2buffer)(isEthereumToken ? baseAsset.currency.ZERO : amount); // TODO: check: present on desktop missing on mobile. This insures we never have a buffer specifying 0.
   // In ETH, a buffer of zero length and a buffer specifying 0 imply different things
 
   if (value.equals(Buffer.from([0]))) value = Buffer.alloc(0);
@@ -46,7 +47,9 @@ function createUnsignedTx({
 
   const txData = {
     nonce: nonce === 0 ? Buffer.alloc(0) : _ethereumjsUtil.default.intToBuffer(nonce),
+    // mobile: { nonce: ethUtil.intToBuffer(nonce) }
     gasPrice: (0, _utils.currency2buffer)(gasPrice.toBase()),
+    // mobile: { gasPrice: currency2buffer(gasPrice) }
     gasLimit: _ethereumjsUtil.default.intToBuffer(gasLimit),
     to,
     value,
@@ -55,6 +58,7 @@ function createUnsignedTx({
   };
   const txMeta = {
     assetName: asset.name,
+    // TODO: We should move away from putting the PK into txMeta, it is a bad practice. It is a potential PK exposure risk if the wrong PK gets included here.
     privateKey,
     // Used for importing private key
     fee: baseAsset.currency.baseUnit(gasPrice.toBase().toNumber() * gasLimit)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@exodus/ethereum-lib",
-  "version": "0.0.7",
+  "version": "0.0.9",
   "description": "Ethereum Library",
   "main": "lib/index.js",
   "files": [
@@ -14,13 +14,13 @@
   },
   "dependencies": {
     "@exodus/asset-lib": "^3.2.0",
-    "@exodus/models": "^8.0.0",
-    "base-x": "3.0.4",
+    "@exodus/models": "^8.2.0",
+    "base-x": "^3.0.2",
     "ethereumjs-tx": "1.3.7",
     "ethereumjs-util": "5.2.0"
   },
   "devDependencies": {
     "@exodus/assets": "8.0.x"
   },
-  "gitHead": "105c29ed959d9e8fee80d89d9223a3c003a6afb6"
+  "gitHead": "82f045d72b69ea29985e824389401c394f209a1d"
 }