@exodus/ethereum-api 8.78.2 → 8.79.1

package/src/tx-log/monitor-utils/check-pending-transactions.js

@@ -4,13 +4,18 @@ import getSenderNonceKey from './get-sender-nonce-key.js'
 export default function checkPendingTransactions({
   pendingTransactionsGroupedByAddressAndNonce = {},
   pendingTransactionsToCheck = {},
+  recentPendingTransactions = {},
   txlist,
   ourWalletAddress,
   asset,
 }) {
   for (const tx of txlist) {
-    // eslint-disable-next-line @exodus/mutable/no-param-reassign-prop-only
-    delete pendingTransactionsToCheck[tx.txId || tx.hash] // Found this transaction, do not mark it as dropped
+    const txId = tx.txId || tx.hash
+    // Found this transaction on the server, do not mark it as dropped or re-add it
+    // eslint-disable-next-line @exodus/hydra/no-param-reassign-prop-only
+    delete pendingTransactionsToCheck[txId]
+    // eslint-disable-next-line @exodus/hydra/no-param-reassign-prop-only
+    delete recentPendingTransactions[txId]
 
     // check if this TX replaces another pending TX
     const replacedTx =
@@ -29,5 +34,9 @@ export default function checkPendingTransactions({
     }
   }
 
-  return { pendingTransactionsGroupedByAddressAndNonce, pendingTransactionsToCheck }
+  return {
+    pendingTransactionsGroupedByAddressAndNonce,
+    pendingTransactionsToCheck,
+    recentPendingTransactions,
+  }
 }

package/src/tx-log/monitor-utils/get-derive-transactions-to-check.js

@@ -10,6 +10,7 @@ const mapToObject = (map) => Object.fromEntries(map.entries()) // only for strin
 export default function getDeriveTransactionsToCheck({ getTxLog }) {
   return async ({ assetName: _assetName, walletAccount, tokens, ourWalletAddress }) => {
     const pendingTransactionsToCheck = new Map()
+    const recentPendingTransactions = new Map()
     const pendingTransactionsGroupedByAddressAndNonce = new Map()
     const simulatedTransactions = new Map()
     const now = SynchronizedTime.now()
@@ -19,11 +20,13 @@ export default function getDeriveTransactionsToCheck({ getTxLog }) {
       for (const tx of txSet) {
         // ERC20 sends have an entry in ETH and one in the ERC20 log so we just want the ETH one
         if (
-          !pendingTransactionsToCheck.has(tx.txId) &&
           tx.pending &&
-          now - tx.date.getTime() > UNCONFIRMED_TX_LIMIT
+          !pendingTransactionsToCheck.has(tx.txId) &&
+          !recentPendingTransactions.has(tx.txId)
         ) {
-          pendingTransactionsToCheck.set(tx.txId, { tx, assetName })
+          const isRecent = now - tx.date.getTime() <= UNCONFIRMED_TX_LIMIT
+          const map = isRecent ? recentPendingTransactions : pendingTransactionsToCheck
+          map.set(tx.txId, { tx, assetName })
         }
 
         if (tx.meta.simulated) simulatedTransactions.set(tx.txId, tx)
@@ -45,6 +48,7 @@ export default function getDeriveTransactionsToCheck({ getTxLog }) {
 
     return {
       pendingTransactionsToCheck: mapToObject(pendingTransactionsToCheck),
+      recentPendingTransactions: mapToObject(recentPendingTransactions),
       pendingTransactionsGroupedByAddressAndNonce: mapToObject(
         pendingTransactionsGroupedByAddressAndNonce
       ),

package/src/tx-log/monitor-utils/get-transfers-by-token-name.js

@@ -1,4 +1,5 @@
-import lodash from 'lodash'
+import { omit } from '@exodus/basic-utils'
+import lodash from 'lodash' // oxlint-disable-line @exodus/oxlint-plugin-restricted-imports/prefer-basic-utils -- groupBy not in basic-utils
 
 // Sorts an array of token transfer events into an object of transfer event arrays,
 // whose keys are the names of the tokens which are being transferred in the corresponding array.
@@ -12,5 +13,5 @@ export default function getTransfersByTokenName(transfers, tokensByAddress) {
     transfers,
     (transfer) => tokensByAddress.get(transfer.address.toLowerCase())?.name || 'UNKNOWN'
   )
-  return lodash.omit(transfersByTokenName, 'UNKNOWN')
+  return omit(transfersByTokenName, ['UNKNOWN'])
 }

package/src/tx-log/monitor-utils/index.js

@@ -8,5 +8,6 @@ export { default as getDeriveTransactionsToCheck } from './get-derive-transactio
 export { default as getCurrentEIP7702Delegation } from './get-current-eip7702-delegation.js'
 export { default as getCurrentBlackListStatus } from './get-current-blacklist-status.js'
 export { default as verifyRpcPendingTxStatusBatch } from './verify-pending-tx-status-rpc.js'
+export { default as isUnverifiablePendingTxExpired } from './is-unverifiable-pending-tx-expired.js'
 export { extractBalanceFromClarityAccountInfo } from './extract-balance-from-clarity-account-info.js'
 export * from './exclude-unchanged-token-balances.js'

package/src/tx-log/monitor-utils/is-unverifiable-pending-tx-expired.js

@@ -0,0 +1,19 @@
+import { SynchronizedTime } from '@exodus/basic-utils'
+import ms from 'ms'
+
+// Upper bound on how long a pending tx with a per-entry 'unknown' verdict
+// (a hash the node persistently errors on) keeps being preserved across
+// refreshes. Without it, "cannot verify this hash" would mean "keep forever"
+// and a phantom tx would pin nonce derivation indefinitely.
+// Positively verified txs ('pending'/'confirmed') are exempt: their lifetime
+// is bounded by the node itself (mempool eviction yields a 'dropped' verdict).
+// A full batch failure is also exempt: it is evidence about nothing, so the
+// monitors preserve unconditionally until the batch path recovers.
+export const UNVERIFIABLE_PENDING_TX_MAX_AGE = ms('1h')
+
+export default function isUnverifiablePendingTxExpired(tx) {
+  const txTime = tx.date?.getTime()
+  // Fail closed: a tx with a missing or invalid date cannot prove it is young
+  if (!Number.isFinite(txTime)) return true
+  return SynchronizedTime.now() - txTime > UNVERIFIABLE_PENDING_TX_MAX_AGE
+}

package/src/tx-log/monitor-utils/verify-pending-tx-status-rpc.js

@@ -1,10 +1,18 @@
 /**
  * Determines the status of an RPC transaction response.
  *
- * @param {Object|null} rpcTx - The RPC transaction response
- * @returns {{status: 'confirmed' | 'pending' | 'dropped', blockNumber?: number}}
+ * `undefined` means the node returned a JSON-RPC error entry for this hash
+ * (tolerant batch parsing) - no verdict, as opposed to `null` which is a
+ * definitive "not found".
+ *
+ * @param {Object|null|undefined} rpcTx - The RPC transaction response
+ * @returns {{status: 'confirmed' | 'pending' | 'dropped' | 'unknown', blockNumber?: number}}
  */
 function getTxStatus(rpcTx) {
+  if (rpcTx === undefined) {
+    return { status: 'unknown' }
+  }
+
   if (rpcTx?.blockNumber) {
     return { status: 'confirmed', blockNumber: parseInt(rpcTx.blockNumber, 16) }
   }
@@ -29,7 +37,7 @@ function getTxStatus(rpcTx) {
  * @param {Object} params.server - RPC server used to verify pending transactions
  * @param {Object} params.logger - Logger instance for info/debug output
  * @param {string[]} params.txIds - Array of transaction IDs/hashes to verify
- * @returns {Promise<Object<string, {status: 'confirmed' | 'pending' | 'dropped', blockNumber?: number}>>}
+ * @returns {Promise<Object<string, {status: 'confirmed' | 'pending' | 'dropped' | 'unknown', blockNumber?: number}>>}
  */
 export default async function verifyRpcPendingTxStatusBatch({ server, logger, txIds }) {
   if (txIds.length === 0) return {}
@@ -39,27 +47,42 @@ export default async function verifyRpcPendingTxStatusBatch({ server, logger, tx
 
   let responses
   try {
-    responses = await server.sendBatchRequest(requests)
+    // Tolerant parsing: one bad hash must not void the verdicts for every other tx
+    responses = await server.sendBatchRequest(requests, { tolerant: true })
   } catch (error) {
     // If batch request fails, skip all drop checks (safe default)
     logger.warn('Batch RPC request failed, skipping drop checks', error)
     return {}
   }
 
+  if (!Array.isArray(responses) || responses.length !== txIds.length) {
+    // A malformed batch response must not produce 'dropped' verdicts (safe default)
+    logger.warn('Batch RPC response shape mismatch, skipping drop checks')
+    return {}
+  }
+
   // Map responses to statuses
-  const results = {}
+  const results = Object.create(null)
   txIds.forEach((txId, idx) => {
     const rpcTx = responses[idx]
     const txStatus = getTxStatus(rpcTx)
     results[txId] = txStatus
 
     // Log each tx status
-    if (txStatus.status === 'confirmed') {
-      logger.info(`tx ${txId} is confirmed on-chain (block ${txStatus.blockNumber}), skipping drop`)
-    } else if (txStatus.status === 'pending') {
-      logger.info(`tx ${txId} is still in mempool, skipping drop`)
-    } else {
-      logger.info(`tx ${txId} not found on-chain, marking as dropped`)
+    switch (txStatus.status) {
+      case 'confirmed':
+        logger.info(
+          `tx ${txId} is confirmed on-chain (block ${txStatus.blockNumber}), skipping drop`
+        )
+        break
+      case 'pending':
+        logger.info(`tx ${txId} is still in mempool, skipping drop`)
+        break
+      case 'unknown':
+        logger.warn(`tx ${txId} could not be verified (RPC error entry), skipping drop`)
+        break
+      default:
+        logger.info(`tx ${txId} not found on-chain, marking as dropped`)
     }
   })
 

package/src/tx-log-staking-processor/utils.js

@@ -47,7 +47,7 @@ export const calculateRewardsFromStakeTx = ({ tx, currency }) => {
 
   if (stakeTxContainsReward) {
     const txAmount = stakedAmount.sub(tx.coinAmount.abs()).abs()
-    // eslint-disable-next-line @exodus/mutable/no-param-reassign-prop-only -- TODO: Fix this the next time the file is edited.
+    // eslint-disable-next-line @exodus/hydra/no-param-reassign-prop-only -- TODO: Fix this the next time the file is edited.
     return txAmount.toDefaultString()
   }
 }

package/src/tx-send/broadcast-error-handler.js

@@ -29,7 +29,7 @@ export const handleBroadcastError = async (
     isNonceTooLow || errorInfo.reason === EVM_ERROR_REASONS.transactionUnderpriced.reason
 
   if (errorInfo.reason === EVM_ERROR_REASONS.alreadyKnown.reason) {
-    console.info('tx already broadcast')
+    console.debug('tx already broadcast')
     return { shouldRetry: false }
   }
 
@@ -44,7 +44,7 @@ export const handleBroadcastError = async (
   }
 
   if (txAlreadyExists) {
-    console.info('tx already broadcast')
+    console.debug('tx already broadcast')
     return { shouldRetry: false }
   }
 

package/src/tx-send/tx-send.js

@@ -50,7 +50,7 @@ const txSendFactory = ({ assetClientInterface, createTx }) => {
       })
 
       if (shouldRetry) {
-        console.info('trying to send again...') // inject logger factory from platform
+        console.debug('trying to send again...') // inject logger factory from platform
 
         // let's try to fix the nonce issue
         let newNonce = await baseAsset.getNonce({
@@ -73,14 +73,14 @@ const txSendFactory = ({ assetClientInterface, createTx }) => {
         //
         // TODO: should return an unsignedTx -> i.e. completely replicate the transaction
         if (unsignedTx.txData.transactionBuffer) {
-          // eslint-disable-next-line @exodus/mutable/no-param-reassign-prop-only
+          // eslint-disable-next-line @exodus/hydra/no-param-reassign-prop-only
           unsignedTx.txData.transactionBuffer = updateNonce({
             chainId: baseAsset.chainId,
             newNonce,
             unsignedTx,
           })
         } else {
-          // eslint-disable-next-line @exodus/mutable/no-param-reassign-prop-only
+          // eslint-disable-next-line @exodus/hydra/no-param-reassign-prop-only
           unsignedTx.txData.nonce = newNonce
         }