@exodus/ethereum-api 8.59.0 → 8.59.2

package/CHANGELOG.md

@@ -3,6 +3,28 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [8.59.2](https://github.com/ExodusMovement/assets/compare/@exodus/ethereum-api@8.59.1...@exodus/ethereum-api@8.59.2) (2025-11-19)
+
+
+### Bug Fixes
+
+
+* fix: correct absolute balance logic for deeply nested pending transactions (#6966)
+
+* fix: drop pending receive amounts from absolute spendable balances (#6958)
+
+
+
+## [8.59.1](https://github.com/ExodusMovement/assets/compare/@exodus/ethereum-api@8.59.0...@exodus/ethereum-api@8.59.1) (2025-11-10)
+
+
+### Bug Fixes
+
+
+* Fix: add "send all" pathway to ethereum staking (#6667)
+
+
+
 ## [8.59.0](https://github.com/ExodusMovement/assets/compare/@exodus/ethereum-api@8.57.0...@exodus/ethereum-api@8.59.0) (2025-11-10)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@exodus/ethereum-api",
-  "version": "8.59.0",
+  "version": "8.59.2",
   "description": "Transaction monitors, fee monitors, RPC with the blockchain node, and other networking code for Ethereum and EVM-based blockchains",
   "type": "module",
   "main": "src/index.js",
@@ -67,5 +67,5 @@
     "type": "git",
     "url": "git+https://github.com/ExodusMovement/assets.git"
   },
-  "gitHead": "94c7625c1fb029ef261d0ef61e32c7c66d359812"
+  "gitHead": "d1505076f4e06aad8f7962d9fad12354c020a30c"
 }

package/src/get-balances.js

@@ -27,6 +27,15 @@ export const getAbsoluteBalance = ({ asset, txLog }) => {
       break
     }
 
+    // NOTE: Avoids processing any unconfirmed balances, since
+    //       `getAbsoluteBalance` only processes a subset of
+    //       transactions up until the first `balanceChange` event
+    //       is encountered, but `getBalancesFactory` takes all
+    //       all pending amounts into consideration (i.e. those
+    //       at a greater depth than the most recent `balanceChange`
+    //       event).
+    if (!tx.failed && tx.pending) continue
+
     if (!(tx.dropped || tx.data.replacedBy)) {
       if (!tx.error) {
         balance = balance.add(tx.coinAmount)
@@ -128,21 +137,29 @@ export const getBalancesFactory = ({ monitorType, useAbsoluteBalance, rpcBalance
     const unstaking = canClaimUndelegatedBalance ? asset.currency.ZERO : unclaimedUndelegatedBalance
     const unstaked = canClaimUndelegatedBalance ? unclaimedUndelegatedBalance : asset.currency.ZERO
 
-    let total
     let spendable
 
     // Balance from accountState is considered total b/c is fetched from rpc
     if (rpcBalanceAssetNames.includes(asset.name) || monitorType === 'no-history') {
-      total = getBalanceFromAccountState({ asset, accountState }).sub(unconfirmedSent)
-      spendable = total.sub(staked).sub(staking).sub(unstaking).sub(unstaked)
+      // NOTE: Balances from a `no-history` monitor work like calls
+      //       to `balanceOf`/`eth_getBalance` at the latest block tag,
+      //       therefore there's no need to subtract `unconfirmedReceived`.
+      //
+      //       Likewise, they do not compensate for pending sends, so we
+      //       must manually subtract the `unconfirmedSent` to produce a
+      //       pessimistic reading that's safe for consumers.
+      spendable = getBalanceFromAccountState({ asset, accountState }).sub(unconfirmedSent)
     } else {
-      // Balance from txLog does not include staking rewards
-      // spendable and total are calculated differently based on staking txs
       const absoluteBalance = useAbsoluteBalance && getAbsoluteBalance({ asset, txLog })
 
       if (absoluteBalance) {
-        spendable = absoluteBalance
+        // NOTE: The returned `absoluteBalance` returns only confirmed
+        //       values similar to the `'no-history'` case, so we need
+        //       to reduce this amount by the `unconfirmedSent`.
+        spendable = absoluteBalance.sub(unconfirmedSent)
       } else {
+        // Balance from txLog does not include staking rewards
+        // spendable and total are calculated differently based on staking txs
         spendable = getSpendable({
           asset,
           balance: getBalanceFromTxLog({ txLog, asset }),
@@ -150,10 +167,9 @@ export const getBalancesFactory = ({ monitorType, useAbsoluteBalance, rpcBalance
           unconfirmedReceived,
         })
       }
-
-      total = spendable.add(staked).add(staking).add(unstaking).add(unstaked)
     }
 
+    const total = spendable.add(staked).add(staking).add(unstaking).add(unstaked)
     const stakeable = spendable
 
     return {

package/src/staking/ethereum/service.js

@@ -60,7 +60,7 @@ export function createEthereumStakingService({
     return { delegatorAddress, feeData }
   }
 
-  async function delegate({ walletAccount, amount, feeData } = Object.create(null)) {
+  async function delegate({ walletAccount, amount, feeData, isDelegateAll } = Object.create(null)) {
     const asset = await getAsset(assetName)
     const staking = getStakingApi(asset)
     amount = amountToCurrency({ asset, amount })
@@ -76,7 +76,7 @@ export function createEthereumStakingService({
       })}`
     )
 
-    const { gasPrice, gasLimit, tipGasPrice } = await estimateTxFee({
+    const { gasPrice, gasLimit, tipGasPrice, fee } = await estimateTxFee({
       from: delegatorAddress,
       to,
       amount,
@@ -84,6 +84,15 @@ export function createEthereumStakingService({
       feeData,
     })
 
+    // If we are delegating all, we need to subtract the estimated ETH cost from the amount
+    // Better to do it here than from the mobile app where fees can change before the transaction is sent
+    if (isDelegateAll) {
+      const minAmount = getMinAmount(asset)
+      amount = amount.sub(fee)
+      // Re-validate that the amount after fee subtraction is still above the minimum
+      assert(amount.gte(minAmount), `Min Amount ${minAmount}`)
+    }
+
     const txId = await prepareAndSendTx({
       asset,
       walletAccount,