@exodus/ethereum-api 8.22.0 → 8.22.2

package/CHANGELOG.md

@@ -3,6 +3,24 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [8.22.2](https://github.com/ExodusMovement/assets/compare/@exodus/ethereum-api@8.22.1...@exodus/ethereum-api@8.22.2) (2024-12-04)
+
+**Note:** Version bump only for package @exodus/ethereum-api
+
+
+
+
+
+## [8.22.1](https://github.com/ExodusMovement/assets/compare/@exodus/ethereum-api@8.22.0...@exodus/ethereum-api@8.22.1) (2024-12-03)
+
+
+### Bug Fixes
+
+
+* fix: increase gasLimit estimation when from or to address are unknown (#4594)
+
+
+
 ## [8.22.0](https://github.com/ExodusMovement/assets/compare/@exodus/ethereum-api@8.21.3...@exodus/ethereum-api@8.22.0) (2024-12-02)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@exodus/ethereum-api",
-  "version": "8.22.0",
+  "version": "8.22.2",
   "description": "Transaction monitors, fee monitors, RPC with the blockchain node, and other networking code for Ethereum and EVM-based blockchains",
   "type": "module",
   "main": "src/index.js",
@@ -64,5 +64,5 @@
     "type": "git",
     "url": "git+https://github.com/ExodusMovement/assets.git"
   },
-  "gitHead": "9888fd7b7356fd52f0bf92e505071565c8fa19ce"
+  "gitHead": "94b6b798534f6b0587f6940248ab612513bfc34f"
 }

package/src/create-asset.js

@@ -263,6 +263,7 @@ export const createAssetFactory = ({
       getSupportedPurposes: () => [44],
       getTokens,
       hasFeature: (feature) => !!features[feature], // @deprecated use api.features instead
+      privateKeyEncodingDefinition: { encoding: 'hex', prefix: '0x' },
       sendTx,
       signTx: ({ unsignedTx, privateKey, signer }) =>
         signer

package/src/eth-like-util.js

@@ -7,6 +7,9 @@ import * as ErrorWrapper from './error-wrapper.js'
 import { getServer, getServerByName } from './exodus-eth-server/index.js'
 import { fromHexToString } from './number-utils.js'
 
+export const FORWARDER_CONTRACT_CODE =
+  '0x5836818037808036817364b29dc43e817817cf77468c8dda63d98ce08fb25af43d91908282803e602b57fd5bf3'
+
 export async function isContract(baseAssetName, address) {
   return getServerByName(baseAssetName).isContract(address)
 }
@@ -22,11 +25,9 @@ export const isContractAddressCached = memoizeLruCache(
 )
 
 export async function isForwarderContract({ asset, address }) {
-  const contractCode = await getServer(asset).getCode(address)
-  return (
-    contractCode ===
-    '0x5836818037808036817364b29dc43e817817cf77468c8dda63d98ce08fb25af43d91908282803e602b57fd5bf3'
-  )
+  const server = getServer(asset)
+  const contractCode = await server.getCode(address)
+  return contractCode === FORWARDER_CONTRACT_CODE
 }
 
 export const isForwarderContractCached = memoizeLruCache(

package/src/gas-estimation.js

@@ -4,7 +4,7 @@ import BN from 'bn.js'
 
 import { estimateGas, isContractAddressCached } from './eth-like-util.js'
 
-const EXTRA_PERCENTAGE = 20
+export const EXTRA_PERCENTAGE = 20
 
 // 16 gas per non-zero byte (4 gas per zero byte) of "transaction input data"
 const GAS_PER_NON_ZERO_BYTE = 16

package/src/get-fee-async.js

@@ -1,7 +1,7 @@
 import assert from 'minimalistic-assert'
 
 import { isForwarderContractCached } from './eth-like-util.js'
-import { fetchGasLimit, resolveDefaultTxInput } from './gas-estimation.js'
+import { EXTRA_PERCENTAGE, fetchGasLimit, resolveDefaultTxInput } from './gas-estimation.js'
 import { getFeeFactory } from './get-fee.js'
 import { getNftArguments } from './nft-utils.js'
 
@@ -13,19 +13,40 @@ const FIXED_TRANSFER_GAS_LIMIT_ASSETS = new Set([
   'geminidollar',
 ])
 
-async function resolveExtraPercentage({ asset, toAddress }) {
+const UNKNOWN_ADDRESS_EXTRA_PERCENTAGE = {
+  usdt_bsc_ddedf0f8: 80,
+}
+
+export async function resolveExtraPercentage({ asset, fromAddress, toAddress }) {
+  if (asset.baseAsset.estimateL1DataFee) {
+    return 100
+  }
+
   const isToken = asset.name !== asset.baseAsset.name
+
+  const isFixedGasLimitToken = isToken && FIXED_TRANSFER_GAS_LIMIT_ASSETS.has(asset.name)
+
+  if (isFixedGasLimitToken) {
+    return 0
+  }
+
   // calling forwarder contracts with a bumped gas limit causes 'Out Of Gas' error on chain
   const hasForwarderContract =
     !isToken && toAddress ? await isForwarderContractCached({ asset, address: toAddress }) : false
 
-  return asset.baseAsset.estimateL1DataFee
-    ? 100
-    : (isToken && FIXED_TRANSFER_GAS_LIMIT_ASSETS.has(asset.name)) || hasForwarderContract
-      ? 0
-      : undefined
+  if (hasForwarderContract) {
+    return 0
+  }
+
+  if (!fromAddress || !toAddress) {
+    return UNKNOWN_ADDRESS_EXTRA_PERCENTAGE[asset.name] ?? EXTRA_PERCENTAGE
+  }
+
+  return EXTRA_PERCENTAGE
 }
 
+const ARBITRARY_ADDRESS = '0xffffffffffffffffffffffffffffffffffffffff'
+
 const getFeeAsyncFactory = ({
   assetClientInterface,
   gasLimit: defaultGasLimit,
@@ -37,8 +58,8 @@ const getFeeAsyncFactory = ({
   return async ({
     nft,
     asset,
-    fromAddress = '0xffffffffffffffffffffffffffffffffffffffff', // sending from a random address
-    toAddress = '0xffffffffffffffffffffffffffffffffffffffff', // sending to a random address,
+    fromAddress: providedFromAddress,
+    toAddress: providedToAddress,
     amount,
     bip70,
     txInput: txInputPram,
@@ -49,16 +70,24 @@ const getFeeAsyncFactory = ({
     gasLimit: providedGasLimit,
     isRbfAllowed = true, // Destkop, isRbfAllowed=true when advanced panel is on
   }) => {
+    const fromAddress = providedFromAddress || ARBITRARY_ADDRESS // sending from a random address
+    const toAddress = providedToAddress || ARBITRARY_ADDRESS // sending to a random address,
+
     const resolveGasLimit = async () => {
       if (nft) {
         return getNftArguments({ asset, nft, fromAddress, toAddress })
       }
 
       if (!amount) amount = asset.currency.ZERO
-      const extraPercentage = await resolveExtraPercentage({ asset, toAddress })
       const txInput = txInputPram || resolveDefaultTxInput({ asset, toAddress, amount })
       if (providedGasLimit) return { gasLimit: providedGasLimit, txInput }
 
+      const extraPercentage = await resolveExtraPercentage({
+        asset,
+        fromAddress: providedFromAddress,
+        toAddress: providedToAddress,
+      })
+
       const gasLimit = await fetchGasLimit({
         asset,
         fromAddress,