@exodus/ethereum-api 8.21.3 → 8.22.1

package/CHANGELOG.md

@@ -3,6 +3,26 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [8.22.1](https://github.com/ExodusMovement/assets/compare/@exodus/ethereum-api@8.22.0...@exodus/ethereum-api@8.22.1) (2024-12-03)
+
+
+### Bug Fixes
+
+
+* fix: increase gasLimit estimation when from or to address are unknown (#4594)
+
+
+
+## [8.22.0](https://github.com/ExodusMovement/assets/compare/@exodus/ethereum-api@8.21.3...@exodus/ethereum-api@8.22.0) (2024-12-02)
+
+
+### Features
+
+
+* feat: gasPriceMaximumRate in evm fee data (#4578)
+
+
+
 ## [8.21.3](https://github.com/ExodusMovement/assets/compare/@exodus/ethereum-api@8.21.2...@exodus/ethereum-api@8.21.3) (2024-11-27)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@exodus/ethereum-api",
-  "version": "8.21.3",
+  "version": "8.22.1",
   "description": "Transaction monitors, fee monitors, RPC with the blockchain node, and other networking code for Ethereum and EVM-based blockchains",
   "type": "module",
   "main": "src/index.js",
@@ -64,5 +64,5 @@
     "type": "git",
     "url": "git+https://github.com/ExodusMovement/assets.git"
   },
-  "gitHead": "391020017026fc2d06ff3d7f164a5c91a6922c3f"
+  "gitHead": "3388dd56aaa85965b27bc8a13e92f098a43cba58"
 }

package/src/create-asset-plugin-factory.js

@@ -1,6 +1,4 @@
 import { createMetaDef } from '@exodus/asset'
-import { FeeData } from '@exodus/asset-lib'
-import { UnitType } from '@exodus/currency'
 import assert from 'minimalistic-assert'
 
 import { createAssetFactory } from './create-asset.js'
@@ -27,8 +25,6 @@ export const createAssetPluginFactory = (config) => {
     [ticker]: decimals || 18,
   }
 
-  const currency = UnitType.create(units)
-
   // adds lots of validation in config
   const tokenOverrides = (token) => ({
     ...token,
@@ -43,7 +39,7 @@ export const createAssetPluginFactory = (config) => {
   }
 
   const assetType = 'ETHEREUM_LIKE'
-  const { asset, assetsList } = createMetaDef({
+  const { assetsList } = createMetaDef({
     assetParams: {
       ...meta,
       name,
@@ -56,61 +52,17 @@ export const createAssetPluginFactory = (config) => {
     tokensParams: meta.tokens || [],
     tokenOverrides,
   })
-
-  const resolveFeeDataConfigDefaults = () => {
-    const shared = {
-      tipGasPrice: '0 Gwei',
-      fuelThreshold: '0 Gwei',
-      gasPriceEconomicalRate: 0.8,
-      gasPriceMinimumRate: 0.6,
-    }
-
-    if (config.eip1559Enabled === true) {
-      assert(config.baseFeePerGas, 'baseFeePerGas is required')
-      const baseFeePerGas = currency.parse(config.baseFeePerGas)
-      const gasPrice = config.gasPrice ? currency.parse(config.gasPrice) : baseFeePerGas.mul(1.5)
-      return {
-        gasPrice: gasPrice.toBaseString({ unit: true }),
-        baseFeePerGas: baseFeePerGas.toBaseString({ unit: true }),
-        max: gasPrice.mul(5).toBaseString({ unit: true }),
-        min: gasPrice.div(5).toBaseString({ unit: true }),
-        eip1559Enabled: config.eip1559Enabled,
-        ...shared,
-        ...config.feeData,
-      }
-    }
-
-    if (config.eip1559Enabled === false) {
-      assert(config.gasPrice, 'gasPrice is required')
-      const gasPrice = currency.parse(config.gasPrice)
-      return {
-        gasPrice: gasPrice.toBaseString({ unit: true }),
-        max: gasPrice.mul(5).toBaseString({ unit: true }),
-        min: gasPrice.div(5).toBaseString({ unit: true }),
-        eip1559Enabled: config.eip1559Enabled,
-        ...shared,
-        ...config.feeData,
-      }
-    }
-
-    return {
-      gasPrice: '0.02 Gwei',
-      baseFeePerGas: '0.02 Gwei',
-      eip1559Enabled: true,
-      ...shared,
+  const feeDataConfig = Object.fromEntries(
+    Object.entries({
+      gasPrice: config.gasPrice,
+      baseFeePerGas: config.baseFeePerGas,
+      eip1559Enabled: config.eip1559Enabled,
       ...config.feeData,
-    }
-  }
-
-  const feeData = new FeeData({
-    config: resolveFeeDataConfigDefaults(),
-    mainKey: 'gasPrice',
-    currency: asset.currency,
-  })
-
+    }).filter(([_, value]) => value !== undefined)
+  )
   const createAsset = createAssetFactory({
     assetsList,
-    feeData,
+    feeDataConfig,
     ...config.plugin,
   })
 

package/src/create-asset.js

@@ -23,6 +23,7 @@ import ms from 'ms'
 import { addressHasHistoryFactory } from './address-has-history.js'
 import { createTokenFactory } from './create-token-factory.js'
 import { createEvmServer } from './exodus-eth-server/index.js'
+import { createFeeData } from './fee-data-factory.js'
 import { createGetBalanceForAddress } from './get-balance-for-address.js'
 import { getBalancesFactory } from './get-balances.js'
 import { getEffectiveGasPrice, getFeeFactory } from './get-fee.js'
@@ -47,7 +48,8 @@ export const createAssetFactory = ({
   customCreateGetKeyIdentifier,
   customTokens: defaultCustomTokens = true,
   erc20FuelBuffer,
-  feeData,
+  feeData: providedFeeData,
+  feeDataConfig,
   feeMonitorInterval,
   fuelThreshold,
   isMaxFeeAsset = false,
@@ -62,11 +64,13 @@ export const createAssetFactory = ({
   forceGasLimitEstimation = false,
 }) => {
   assert(assetsList, 'assetsList is required')
-  assert(feeData, 'feeData is required')
+  assert(providedFeeData || feeDataConfig, 'feeData or feeDataConfig is required')
   assert(serverUrl, 'serverUrl is required')
   assert(confirmationsNumber, 'confirmationsNumber is required')
 
   const base = assetsList.find((asset) => asset.name === asset.baseAssetName)
+
+  const feeData = providedFeeData || createFeeData({ currency: base.currency, feeDataConfig })
   assert(base, 'base is required')
 
   const chainId = base.chainId

package/src/eth-like-util.js

@@ -7,6 +7,9 @@ import * as ErrorWrapper from './error-wrapper.js'
 import { getServer, getServerByName } from './exodus-eth-server/index.js'
 import { fromHexToString } from './number-utils.js'
 
+export const FORWARDER_CONTRACT_CODE =
+  '0x5836818037808036817364b29dc43e817817cf77468c8dda63d98ce08fb25af43d91908282803e602b57fd5bf3'
+
 export async function isContract(baseAssetName, address) {
   return getServerByName(baseAssetName).isContract(address)
 }
@@ -22,11 +25,9 @@ export const isContractAddressCached = memoizeLruCache(
 )
 
 export async function isForwarderContract({ asset, address }) {
-  const contractCode = await getServer(asset).getCode(address)
-  return (
-    contractCode ===
-    '0x5836818037808036817364b29dc43e817817cf77468c8dda63d98ce08fb25af43d91908282803e602b57fd5bf3'
-  )
+  const server = getServer(asset)
+  const contractCode = await server.getCode(address)
+  return contractCode === FORWARDER_CONTRACT_CODE
 }
 
 export const isForwarderContractCached = memoizeLruCache(

package/src/fee-data-factory.js

@@ -0,0 +1,56 @@
+import { FeeData } from '@exodus/asset-lib'
+import assert from 'minimalistic-assert'
+
+const createFeeDataConfigDefaults = ({ currency, feeDataConfig }) => {
+  const shared = {
+    tipGasPrice: '0 Gwei',
+    fuelThreshold: '0 Gwei',
+    gasPriceEconomicalRate: 0.8,
+    gasPriceMinimumRate: 0.6,
+    gasPriceMaximumRate: 1.3,
+  }
+
+  if (feeDataConfig.eip1559Enabled === true) {
+    assert(feeDataConfig.baseFeePerGas, 'baseFeePerGas is required')
+    const baseFeePerGas = currency.parse(feeDataConfig.baseFeePerGas)
+    const gasPrice = feeDataConfig.gasPrice
+      ? currency.parse(feeDataConfig.gasPrice)
+      : baseFeePerGas.mul(1.5)
+    return {
+      gasPrice: gasPrice.toBaseString({ unit: true }),
+      baseFeePerGas: baseFeePerGas.toBaseString({ unit: true }),
+      eip1559Enabled: feeDataConfig.eip1559Enabled,
+      ...shared,
+      ...feeDataConfig,
+    }
+  }
+
+  if (feeDataConfig.eip1559Enabled === false) {
+    assert(feeDataConfig.gasPrice, 'gasPrice is required')
+    const gasPrice = currency.parse(feeDataConfig.gasPrice)
+    return {
+      gasPrice: gasPrice.toBaseString({ unit: true }),
+      max: gasPrice.mul(5).toBaseString({ unit: true }),
+      min: gasPrice.div(5).toBaseString({ unit: true }),
+      eip1559Enabled: feeDataConfig.eip1559Enabled,
+      ...shared,
+      ...feeDataConfig,
+    }
+  }
+
+  return {
+    gasPrice: '0.02 Gwei',
+    baseFeePerGas: '0.02 Gwei',
+    eip1559Enabled: true,
+    ...shared,
+    ...feeDataConfig,
+  }
+}
+
+export const createFeeData = ({ currency, feeDataConfig }) => {
+  return new FeeData({
+    config: createFeeDataConfigDefaults({ currency, feeDataConfig }),
+    mainKey: 'gasPrice',
+    currency,
+  })
+}

package/src/gas-estimation.js

@@ -4,7 +4,7 @@ import BN from 'bn.js'
 
 import { estimateGas, isContractAddressCached } from './eth-like-util.js'
 
-const EXTRA_PERCENTAGE = 20
+export const EXTRA_PERCENTAGE = 20
 
 // 16 gas per non-zero byte (4 gas per zero byte) of "transaction input data"
 const GAS_PER_NON_ZERO_BYTE = 16

package/src/get-fee-async.js

@@ -1,7 +1,7 @@
 import assert from 'minimalistic-assert'
 
 import { isForwarderContractCached } from './eth-like-util.js'
-import { fetchGasLimit, resolveDefaultTxInput } from './gas-estimation.js'
+import { EXTRA_PERCENTAGE, fetchGasLimit, resolveDefaultTxInput } from './gas-estimation.js'
 import { getFeeFactory } from './get-fee.js'
 import { getNftArguments } from './nft-utils.js'
 
@@ -13,19 +13,40 @@ const FIXED_TRANSFER_GAS_LIMIT_ASSETS = new Set([
   'geminidollar',
 ])
 
-async function resolveExtraPercentage({ asset, toAddress }) {
+const UNKNOWN_ADDRESS_EXTRA_PERCENTAGE = {
+  usdt_bsc_ddedf0f8: 80,
+}
+
+export async function resolveExtraPercentage({ asset, fromAddress, toAddress }) {
+  if (asset.baseAsset.estimateL1DataFee) {
+    return 100
+  }
+
   const isToken = asset.name !== asset.baseAsset.name
+
+  const isFixedGasLimitToken = isToken && FIXED_TRANSFER_GAS_LIMIT_ASSETS.has(asset.name)
+
+  if (isFixedGasLimitToken) {
+    return 0
+  }
+
   // calling forwarder contracts with a bumped gas limit causes 'Out Of Gas' error on chain
   const hasForwarderContract =
     !isToken && toAddress ? await isForwarderContractCached({ asset, address: toAddress }) : false
 
-  return asset.baseAsset.estimateL1DataFee
-    ? 100
-    : (isToken && FIXED_TRANSFER_GAS_LIMIT_ASSETS.has(asset.name)) || hasForwarderContract
-      ? 0
-      : undefined
+  if (hasForwarderContract) {
+    return 0
+  }
+
+  if (!fromAddress || !toAddress) {
+    return UNKNOWN_ADDRESS_EXTRA_PERCENTAGE[asset.name] ?? EXTRA_PERCENTAGE
+  }
+
+  return EXTRA_PERCENTAGE
 }
 
+const ARBITRARY_ADDRESS = '0xffffffffffffffffffffffffffffffffffffffff'
+
 const getFeeAsyncFactory = ({
   assetClientInterface,
   gasLimit: defaultGasLimit,
@@ -37,8 +58,8 @@ const getFeeAsyncFactory = ({
   return async ({
     nft,
     asset,
-    fromAddress = '0xffffffffffffffffffffffffffffffffffffffff', // sending from a random address
-    toAddress = '0xffffffffffffffffffffffffffffffffffffffff', // sending to a random address,
+    fromAddress: providedFromAddress,
+    toAddress: providedToAddress,
     amount,
     bip70,
     txInput: txInputPram,
@@ -49,16 +70,24 @@ const getFeeAsyncFactory = ({
     gasLimit: providedGasLimit,
     isRbfAllowed = true, // Destkop, isRbfAllowed=true when advanced panel is on
   }) => {
+    const fromAddress = providedFromAddress || ARBITRARY_ADDRESS // sending from a random address
+    const toAddress = providedToAddress || ARBITRARY_ADDRESS // sending to a random address,
+
     const resolveGasLimit = async () => {
       if (nft) {
         return getNftArguments({ asset, nft, fromAddress, toAddress })
       }
 
       if (!amount) amount = asset.currency.ZERO
-      const extraPercentage = await resolveExtraPercentage({ asset, toAddress })
       const txInput = txInputPram || resolveDefaultTxInput({ asset, toAddress, amount })
       if (providedGasLimit) return { gasLimit: providedGasLimit, txInput }
 
+      const extraPercentage = await resolveExtraPercentage({
+        asset,
+        fromAddress: providedFromAddress,
+        toAddress: providedToAddress,
+      })
+
       const gasLimit = await fetchGasLimit({
         asset,
         fromAddress,