@exodus/ethereum-api 7.0.17 → 7.1.0

package/src/tx-log/monitor-utils/exclude-unchanged-token-balances.js

@@ -1,13 +1,12 @@
 export function excludeUnchangedTokenBalances(currentTokenBalances, newTokenBalancePairs) {
   const newTokenBalances = Object.fromEntries(newTokenBalancePairs)
 
-  const tokenBalances = newTokenBalancePairs.reduce((tokenBalancesAcc, [token, balance]) => {
+  return newTokenBalancePairs.reduce((tokenBalancesAcc, [token, balance]) => {
     const currentBalance = currentTokenBalances[token]
     if (!newTokenBalances[token].isZero || (currentBalance && !currentBalance.isZero)) {
       tokenBalancesAcc[token] = balance
     }
+
     return tokenBalancesAcc
   }, {})
-
-  return tokenBalances
 }

package/src/tx-log/monitor-utils/get-derive-data-needed-for-tick.js

@@ -1,7 +1,7 @@
 // A super-selector that returns all the current data needed for a tick of the ETH monitor.
 
 export default function getDeriveDataNeededForTick(aci) {
-  return async function({ assetName, walletAccount }) {
+  return async function ({ assetName, walletAccount }) {
     const receiveAddress = await aci.getReceiveAddress({ assetName, walletAccount, useCache: true })
     const currentAccountState = await aci.getAccountState({ assetName, walletAccount })
     const minimumConfirmations = await aci.getConfirmationsNumber({ assetName })

package/src/tx-log/monitor-utils/get-derive-transactions-to-check.js

@@ -3,7 +3,7 @@ import getSenderNonceKey from './get-sender-nonce-key'
 
 export const UNCONFIRMED_TX_LIMIT = ms('5m')
 
-const mapToObject = (map) => Object.fromEntries([...map.entries()]) // only for string keys
+const mapToObject = (map) => Object.fromEntries(map.entries()) // only for string keys
 
 export default function getDeriveTransactionsToCheck({ getTxLog }) {
   return async ({ assetName: _assetName, walletAccount, tokens, ourWalletAddress }) => {
@@ -23,6 +23,7 @@ export default function getDeriveTransactionsToCheck({ getTxLog }) {
         ) {
           pendingTransactionsToCheck.set(tx.txId, { tx, assetName })
         }
+
         if (tx.meta.simulated) simulatedTransactions.set(tx.txId, tx)
 
         const senderNonceKey = getSenderNonceKey(tx, ourWalletAddress)

package/src/tx-log/monitor-utils/get-log-items-from-server-tx.js

@@ -28,7 +28,9 @@ export default function getLogItemsFromServerTx({
   const toAddress = tryFindExternalRecipient(ethereumTransfers, ourWalletAddress)
   const ourWalletWasSender = serverTx.from === ourWalletAddress
   const METHOD_ID_LENGTH = 10
-  const methodId = serverTx.data && { methodId: serverTx.data.substring(0, METHOD_ID_LENGTH) }
+  const methodId = serverTx.data && {
+    methodId: serverTx.data.slice(0, Math.max(0, METHOD_ID_LENGTH)),
+  }
   const data = serverTx.data || '0x'
   const logItemCommonProperties = {
     confirmations,
@@ -83,6 +85,7 @@ export default function getLogItemsFromServerTx({
       ])
     }
   }
+
   // handle erc20
   Object.entries(tokenTransfersByTokenName).forEach(([tokenName, tokenTransfers]) => {
     const sendingTransferPresent = tokenTransfers.some(({ from }) => from === ourWalletAddress)
@@ -154,7 +157,7 @@ function isSelfSendTx({
 }
 
 function isNftTransfer({ serverTx, ourWalletAddress }) {
-  if (!Array.isArray(serverTx.erc721) || serverTx.erc721.length < 1) return false
+  if (!Array.isArray(serverTx.erc721) || serverTx.erc721.length === 0) return false
 
   return serverTx.erc721.some(
     (transfer) => transfer.to === ourWalletAddress || transfer.from === ourWalletAddress

package/src/tx-log/ws-updates.js

@@ -11,7 +11,7 @@ export function subscribeToWSNotifications({
   beforeStart = false,
 }) {
   Object.entries(addressesByWalletAccount).forEach(([walletAccount, addresses]) => {
-    const address = String(Array.from(addresses)[0]).toLowerCase() // Only check m/0/0
+    const address = String([...addresses][0]).toLowerCase() // Only check m/0/0
     const mapKey = `${server.getURL()}:${address}` // different chains might have the same addresses
     if (subscribedToAddressNotificationsMap.has(mapKey)) return
 

package/src/websocket/index.js

@@ -11,10 +11,11 @@ if (typeof process !== 'undefined' && (process.type === 'renderer' || process.ty
   } else {
     module.exports = require('ws')
   }
-} else if (typeof WebSocket !== 'undefined') {
-  // THIS IS FOR BE
-  module.exports = globalThis.WebSocket
-} else {
+  // eslint-disable-next-line no-undef
+} else if (typeof WebSocket === 'undefined') {
   // THIS IS FOR UNIT TESTING.
   module.exports = require('ws')
+} else {
+  // THIS IS FOR BE
+  module.exports = globalThis.WebSocket
 }