@exodus/ethereum-api 5.0.9 → 5.0.11

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@exodus/ethereum-api",
-  "version": "5.0.9",
+  "version": "5.0.11",
   "description": "Ethereum Api",
   "main": "src/index.js",
   "files": [
@@ -36,5 +36,5 @@
   "devDependencies": {
     "@exodus/models": "^8.10.4"
   },
-  "gitHead": "894830a79d49d9673b40143b4893234bc01a7cbc"
+  "gitHead": "b34adcc696b2e7f67c8e556f3d0ed31cc481ed4d"
 }

package/src/gas-estimation.js

@@ -63,7 +63,9 @@ export async function fetchGasLimit({
   if (_isToken) {
     // only create tx-input only if not pass tx-input to a token asset
     if (txInput === '0x') {
-      txInput = ethUtil.bufferToHex(asset.contract.transfer.build(toAddress, amount.toBaseString()))
+      txInput = ethUtil.bufferToHex(
+        asset.contract.transfer.build(toAddress.toLowerCase(), amount.toBaseString())
+      )
     }
     amount = asset.baseAsset.currency.ZERO
     toAddress = asset.contract.address

package/src/simulate-tx/simulate-eth-tx.js

@@ -23,6 +23,32 @@ async function getAssetSymbolFromContract(contractAddress) {
   return assetSymbol
 }
 
+// Sometimes ERC20 transfers happen with a proxy contract and Blocknative Preview API duplicates them.
+// We consider transfers having the same type (ERC20), symbol, decimals number and the delta number (transfer amount)
+// as duplicates and remove them.
+export function maybeRemoveDuplicates(balanceChanges) {
+  // We didn't encounter duplicates in other cases so doing this check to limit the function impact.
+  if (balanceChanges.length !== 2) return balanceChanges
+
+  const uniqueBalanceChanges = []
+  const existingBalanceChangesSet = new Set()
+  for (const balanceChange of balanceChanges) {
+    const { asset: assetData, delta } = balanceChange
+    if (assetData.type !== 'erc20') {
+      uniqueBalanceChanges.push(balanceChange)
+      continue
+    }
+
+    const key = `${assetData.type}:${assetData.symbol}:${assetData.decimal}:${delta}`
+    if (existingBalanceChangesSet.has(key)) continue
+
+    existingBalanceChangesSet.add(key)
+    uniqueBalanceChanges.push(balanceChange)
+  }
+
+  return uniqueBalanceChanges
+}
+
 async function prepareBalanceChanges(
   internalTransactions,
   balanceChanges,
@@ -102,7 +128,7 @@ async function prepareBalanceChanges(
     }
   }
 
-  return preparedBalanceChanges
+  return maybeRemoveDuplicates(preparedBalanceChanges)
 }
 
 async function tryToDecodeApprovalTransaction(transaction) {