@exodus/bytes 1.5.0 → 1.6.0

package/README.md

@@ -33,16 +33,30 @@ See [Performance](./Performance.md) for more info
 import { TextDecoder, TextEncoder } from '@exodus/bytes/encoding.js'
 ```
 
-Less than half the bundle size of [text-encoding](https://npmjs.com/text-encoding), [whatwg-encoding](https://npmjs.com/whatwg-encoding) or [iconv-lite](https://npmjs.com/iconv-lite) (gzipped or not), and [is much faster](#fast).
-See also [lite version](#lite-version).
+Less than half the bundle size of [text-encoding](https://npmjs.com/text-encoding), [whatwg-encoding](https://npmjs.com/whatwg-encoding) or [iconv-lite](https://npmjs.com/iconv-lite) (gzipped or not).\
+Also [much faster](#fast) than all of those.
 
-Spec compliant, passing WPT and covered with extra tests.
+> [!TIP]
+> See also the [lite version](#lite-version) to get this down to 9 KiB gzipped.
 
-Moreover, tests for this library uncovered [bugs in all major implementations](https://docs.google.com/spreadsheets/d/1pdEefRG6r9fZy61WHGz0TKSt8cO4ISWqlpBN5KntIvQ/edit).
+Spec compliant, passing WPT and covered with extra tests.\
+Moreover, tests for this library uncovered [bugs in all major implementations](https://docs.google.com/spreadsheets/d/1pdEefRG6r9fZy61WHGz0TKSt8cO4ISWqlpBN5KntIvQ/edit).\
+Including all three major browser engines being wrong at UTF-8.\
+See [WPT pull request](https://github.com/web-platform-tests/wpt/pull/56892).
 
-[Faster than Node.js native implementation on Node.js](https://github.com/nodejs/node/issues/61041#issuecomment-3649242024).
+It works correctly even in environments that have native implementations broken (that's all of them currently).\
 Runs (and passes WPT) on Node.js built without ICU.
 
+> [!NOTE]
+> [Faster than Node.js native implementation on Node.js](https://github.com/nodejs/node/issues/61041#issuecomment-3649242024).
+>
+> The JS multi-byte version is as fast as native impl in Node.js and browsers, but (unlike them) returns correct results.
+>
+> For encodings where native version is known to be fast and correct, it is automatically used.\
+> Some single-byte encodings are faster than native in all three major browser engines.
+
+See [analysis table](https://docs.google.com/spreadsheets/d/1pdEefRG6r9fZy61WHGz0TKSt8cO4ISWqlpBN5KntIvQ/edit) for more info.
+
 ### Caveat: `TextDecoder` / `TextEncoder` APIs are lossy by default per spec
 
 _These are only provided as a compatibility layer, prefer hardened APIs instead in new code._

package/fallback/_utils.js

@@ -128,3 +128,9 @@ export function decode2string(arr, start, end, m) {
 export function assert(condition, msg) {
   if (!condition) throw new Error(msg)
 }
+
+// On arrays in heap (<= 64) it's cheaper to copy into a pooled buffer than lazy-create the ArrayBuffer storage
+export const toBuf = (x) =>
+  x.byteLength <= 64 && x.BYTES_PER_ELEMENT === 1
+    ? Buffer.from(x)
+    : Buffer.from(x.buffer, x.byteOffset, x.byteLength)

package/fallback/latin1.js

@@ -5,6 +5,7 @@ import {
   nativeBuffer,
   isHermes,
   isDeno,
+  isLE,
 } from './_utils.js'
 
 // See http://stackoverflow.com/a/22747272/680742, which says that lowest limit is in Chrome, with 0xffff args
@@ -60,6 +61,16 @@ export function decodeLatin1(arr, start = 0, stop = arr.length) {
   return String.fromCharCode.apply(String, sliced)
 }
 
+// Unchecked for well-formedness, raw. Expects Uint16Array input
+export const decodeUCS2 =
+  nativeBuffer && isLE && !isDeno
+    ? (u16, stop = u16.length) => {
+        // TODO: fast path for BE, perhaps faster path for Deno. Note that decoder replaces, this function doesn't
+        if (stop > 32) return nativeBuffer.from(u16.buffer, u16.byteOffset, stop * 2).ucs2Slice() // from 64 bytes, below are in heap
+        return decodeLatin1(u16, 0, stop)
+      }
+    : (u16, stop = u16.length) => decodeLatin1(u16, 0, stop)
+
 // Does not check input, uses best available method
 // Building an array for this is only faster than proper string concatenation when TextDecoder or native Buffer are available
 export const decodeAscii = nativeBuffer
@@ -70,7 +81,10 @@ export const decodeAscii = nativeBuffer
         : nativeDecoder.decode(a) // On Node.js, utf8 decoder is faster than latin1
   : nativeDecoderLatin1
     ? (a) => nativeDecoderLatin1.decode(a) // On browsers (specifically WebKit), latin1 decoder is faster than utf8
-    : (a) => decodeLatin1(new Uint8Array(a.buffer, a.byteOffset, a.byteLength)) // Fallback. We shouldn't get here, constructing with strings directly is faster
+    : (a) =>
+        decodeLatin1(
+          a instanceof Uint8Array ? a : new Uint8Array(a.buffer, a.byteOffset, a.byteLength)
+        )
 
 /* eslint-disable @exodus/mutable/no-param-reassign-prop-only */
 

package/fallback/multi-byte.js

@@ -1,4 +1,4 @@
-import { asciiPrefix, decodeLatin1 } from './latin1.js'
+import { asciiPrefix, decodeAscii, decodeLatin1, decodeUCS2 } from './latin1.js'
 import { getTable } from './multi-byte.table.js'
 
 export const E_STRICT = 'Input is not well-formed for this encoding'
@@ -11,36 +11,48 @@ export const E_STRICT = 'Input is not well-formed for this encoding'
 // Common between euc-kr and big5
 function bigDecoder(err, pair) {
   let lead = 0
+  let oi = 0
+  let o16
 
   const decodeLead = (b) => {
-    const str = pair(lead, b)
+    const p = pair(lead, b)
     lead = 0
-    if (str) return str
-    return b < 128 ? String.fromCharCode(err(), b) : String.fromCharCode(err())
+    if (typeof p === 'number') {
+      o16[oi++] = p
+    } else if (p) {
+      // This is still faster than string concatenation. Can we optimize strings though?
+      for (let i = 0; i < p.length; i++) o16[oi++] = p.charCodeAt(i)
+    } else {
+      o16[oi++] = err()
+      if (b < 128) o16[oi++] = b
+    }
   }
 
   const decode = (arr, start, end, stream) => {
-    let res = ''
     let i = start
+    o16 = new Uint16Array(end - start + (lead ? 1 : 0)) // there are pairs but they consume more than one byte
+    oi = 0
 
-    if (lead && i < end) res += decodeLead(arr[i++])
+    if (lead && i < end) decodeLead(arr[i++])
     while (i < end) {
       const b = arr[i++]
       if (b < 128) {
-        res += String.fromCharCode(b)
+        o16[oi++] = b
       } else if (b === 0x80 || b === 0xff) {
-        res += String.fromCharCode(err())
+        o16[oi++] = err()
       } else {
         lead = b
-        if (i < end) res += decodeLead(arr[i++])
+        if (i < end) decodeLead(arr[i++])
       }
     }
 
     if (lead && !stream) {
       lead = 0
-      res += String.fromCharCode(err())
+      o16[oi++] = err()
     }
 
+    const res = decodeUCS2(o16, oi)
+    o16 = null
     return res
   }
 
@@ -57,7 +69,7 @@ const mappers = {
     return bigDecoder(err, (l, b) => {
       if (b < 0x41 || b > 0xfe) return
       const cp = euc[(l - 0x81) * 190 + b - 0x41]
-      return cp !== undefined && cp !== REP ? String.fromCharCode(cp) : undefined
+      return cp !== undefined && cp !== REP ? cp : undefined
     })
   },
   // https://encoding.spec.whatwg.org/#euc-jp-decoder
@@ -66,55 +78,61 @@ const mappers = {
     const jis0212 = getTable('jis0212')
     let j12 = false
     let lead = 0
+    let oi = 0
+    let o16
 
     const decodeLead = (b) => {
       if (lead === 0x8e && b >= 0xa1 && b <= 0xdf) {
         lead = 0
-        return String.fromCharCode(0xfe_c0 + b)
-      }
-
-      if (lead === 0x8f && b >= 0xa1 && b <= 0xfe) {
+        o16[oi++] = 0xfe_c0 + b
+      } else if (lead === 0x8f && b >= 0xa1 && b <= 0xfe) {
         j12 = true
         lead = b
-        return ''
-      }
+      } else {
+        let cp
+        if (lead >= 0xa1 && lead <= 0xfe && b >= 0xa1 && b <= 0xfe) {
+          cp = (j12 ? jis0212 : jis0208)[(lead - 0xa1) * 94 + b - 0xa1]
+        }
 
-      let cp
-      if (lead >= 0xa1 && lead <= 0xfe && b >= 0xa1 && b <= 0xfe) {
-        cp = (j12 ? jis0212 : jis0208)[(lead - 0xa1) * 94 + b - 0xa1]
+        lead = 0
+        j12 = false
+        if (cp !== undefined && cp !== REP) {
+          o16[oi++] = cp
+        } else {
+          o16[oi++] = err()
+          if (b < 128) o16[oi++] = b
+        }
       }
-
-      lead = 0
-      j12 = false
-      if (cp !== undefined && cp !== REP) return String.fromCharCode(cp)
-      return b < 128 ? String.fromCharCode(err(), b) : String.fromCharCode(err())
     }
 
     const decode = (arr, start, end, stream) => {
-      let res = ''
       let i = start
+      o16 = new Uint16Array(end - start + (lead ? 1 : 0))
+      oi = 0
 
-      if (lead && i < end) res += decodeLead(arr[i++])
-      if (lead && i < end) res += decodeLead(arr[i++]) // could be two leads, but no more
+      if (lead && i < end) decodeLead(arr[i++])
+      if (lead && i < end) decodeLead(arr[i++]) // could be two leads, but no more
       while (i < end) {
         const b = arr[i++]
         if (b < 128) {
-          res += String.fromCharCode(b)
+          o16[oi++] = b
         } else if ((b < 0xa1 && b !== 0x8e && b !== 0x8f) || b === 0xff) {
-          res += String.fromCharCode(err())
+          o16[oi++] = err()
         } else {
           lead = b
-          if (i < end) res += decodeLead(arr[i++])
-          if (lead && i < end) res += decodeLead(arr[i++]) // could be two leads
+          if (i < end) decodeLead(arr[i++])
+          if (lead && i < end) decodeLead(arr[i++]) // could be two leads
         }
       }
 
       if (lead && !stream) {
         lead = 0
         j12 = false // can be true only when lead is non-zero
-        res += String.fromCharCode(err())
+        o16[oi++] = err()
       }
 
+      const res = decodeUCS2(o16, oi)
+      o16 = null
       return res
     }
 
@@ -238,7 +256,8 @@ const mappers = {
     }
 
     const decode = (arr, start, end, stream) => {
-      let res = ''
+      const o16 = new Uint16Array(end - start + 2) // err in eof + lead from state
+      let oi = 0
       let i = start
       const pushback = [] // local and auto-cleared
 
@@ -246,7 +265,7 @@ const mappers = {
       // Same as the full loop, but without EOF handling
       while (i < end || pushback.length > 0) {
         const c = bytes(pushback, pushback.length > 0 ? pushback.pop() : arr[i++])
-        if (c !== undefined) res += String.fromCodePoint(c)
+        if (c !== undefined) o16[oi++] = c // 16-bit
       }
 
       // Then, dump EOF. This needs the same loop as the characters can be pushed back
@@ -254,11 +273,11 @@ const mappers = {
         while (i <= end || pushback.length > 0) {
           if (i < end || pushback.length > 0) {
             const c = bytes(pushback, pushback.length > 0 ? pushback.pop() : arr[i++])
-            if (c !== undefined) res += String.fromCodePoint(c)
+            if (c !== undefined) o16[oi++] = c // 16-bit
           } else {
             const c = eof(pushback)
             if (c === null) break // clean exit
-            res += String.fromCodePoint(c)
+            o16[oi++] = c
           }
         }
       }
@@ -272,7 +291,7 @@ const mappers = {
         out = false
       }
 
-      return res
+      return decodeUCS2(o16, oi)
     }
 
     return { decode, isAscii: () => false }
@@ -281,44 +300,57 @@ const mappers = {
   shift_jis: (err) => {
     const jis0208 = getTable('jis0208')
     let lead = 0
+    let oi = 0
+    let o16
 
     const decodeLead = (b) => {
       const l = lead
       lead = 0
       if (b >= 0x40 && b <= 0xfc && b !== 0x7f) {
         const p = (l - (l < 0xa0 ? 0x81 : 0xc1)) * 188 + b - (b < 0x7f ? 0x40 : 0x41)
-        if (p >= 8836 && p <= 10_715) return String.fromCharCode(0xe0_00 - 8836 + p)
+        if (p >= 8836 && p <= 10_715) {
+          o16[oi++] = 0xe0_00 - 8836 + p
+          return
+        }
+
         const cp = jis0208[p]
-        if (cp !== undefined && cp !== REP) return String.fromCharCode(cp)
+        if (cp !== undefined && cp !== REP) {
+          o16[oi++] = cp
+          return
+        }
       }
 
-      return b < 128 ? String.fromCharCode(err(), b) : String.fromCharCode(err())
+      o16[oi++] = err()
+      if (b < 128) o16[oi++] = b
     }
 
     const decode = (arr, start, end, stream) => {
-      let res = ''
+      o16 = new Uint16Array(end - start + (lead ? 1 : 0))
+      oi = 0
       let i = start
 
-      if (lead && i < end) res += decodeLead(arr[i++])
+      if (lead && i < end) decodeLead(arr[i++])
       while (i < end) {
         const b = arr[i++]
         if (b <= 0x80) {
-          res += String.fromCharCode(b) // 0x80 is allowed
+          o16[oi++] = b // 0x80 is allowed
         } else if (b >= 0xa1 && b <= 0xdf) {
-          res += String.fromCharCode(0xfe_c0 + b)
+          o16[oi++] = 0xfe_c0 + b
         } else if (b === 0xa0 || b > 0xfc) {
-          res += String.fromCharCode(err())
+          o16[oi++] = err()
         } else {
           lead = b
-          if (i < end) res += decodeLead(arr[i++])
+          if (i < end) decodeLead(arr[i++])
         }
       }
 
       if (lead && !stream) {
         lead = 0
-        res += String.fromCharCode(err())
+        o16[oi++] = err()
       }
 
+      const res = decodeUCS2(o16, oi)
+      o16 = null
       return res
     }
 
@@ -349,7 +381,8 @@ const mappers = {
     // g3 is 0 or 0x81-0xfe
 
     const decode = (arr, start, end, stream) => {
-      let res = ''
+      const o16 = new Uint16Array(end - start + (g1 ? 3 : 0)) // even with pushback it's at most 1 char per byte
+      let oi = 0
       let i = start
       const pushback = [] // local and auto-cleared
 
@@ -357,30 +390,38 @@ const mappers = {
       // Same as the full loop, but without EOF handling
       while (i < end || pushback.length > 0) {
         const b = pushback.length > 0 ? pushback.pop() : arr[i++]
-        if (g3) {
-          if (b < 0x30 || b > 0x39) {
-            pushback.push(b, g3, g2)
-            g1 = g2 = g3 = 0
-            res += String.fromCharCode(err())
-          } else {
-            const p = index((g1 - 0x81) * 12_600 + (g2 - 0x30) * 1260 + (g3 - 0x81) * 10 + b - 0x30)
-            g1 = g2 = g3 = 0
-            if (p === undefined) {
-              res += String.fromCharCode(err())
+        if (g1) {
+          // g2 can be set only when g1 is set, g3 can be set only when g2 is set
+          // hence, 3 checks for g3 is faster than 3 checks for g1
+          if (g2) {
+            if (g3) {
+              if (b < 0x30 || b > 0x39) {
+                pushback.push(b, g3, g2)
+                g1 = g2 = g3 = 0
+                o16[oi++] = err()
+              } else {
+                const p = index(
+                  (g1 - 0x81) * 12_600 + (g2 - 0x30) * 1260 + (g3 - 0x81) * 10 + b - 0x30
+                )
+                g1 = g2 = g3 = 0
+                if (p === undefined) {
+                  o16[oi++] = err()
+                } else if (p <= 0xff_ff) {
+                  o16[oi++] = p // Can validly return replacement
+                } else {
+                  const d = p - 0x1_00_00
+                  o16[oi++] = 0xd8_00 | (d >> 10)
+                  o16[oi++] = 0xdc_00 | (d & 0x3_ff)
+                }
+              }
+            } else if (b >= 0x81 && b <= 0xfe) {
+              g3 = b
             } else {
-              res += String.fromCodePoint(p) // Can validly return replacement
+              pushback.push(b, g2)
+              g1 = g2 = 0
+              o16[oi++] = err()
             }
-          }
-        } else if (g2) {
-          if (b >= 0x81 && b <= 0xfe) {
-            g3 = b
-          } else {
-            pushback.push(b, g2)
-            g1 = g2 = 0
-            res += String.fromCharCode(err())
-          }
-        } else if (g1) {
-          if (b >= 0x30 && b <= 0x39) {
+          } else if (b >= 0x30 && b <= 0x39) {
             g2 = b
           } else {
             let cp
@@ -390,18 +431,18 @@ const mappers = {
 
             g1 = 0
             if (cp !== undefined && cp !== REP) {
-              res += String.fromCodePoint(cp)
+              o16[oi++] = cp // 16-bit
             } else {
-              res += String.fromCharCode(err())
-              if (b < 128) res += String.fromCharCode(b) // can be processed immediately
+              o16[oi++] = err()
+              if (b < 128) o16[oi++] = b // can be processed immediately
             }
           }
         } else if (b < 128) {
-          res += String.fromCharCode(b)
+          o16[oi++] = b
         } else if (b === 0x80) {
-          res += '\u20AC'
+          o16[oi++] = 0x20_ac
         } else if (b === 0xff) {
-          res += String.fromCharCode(err())
+          o16[oi++] = err()
         } else {
           g1 = b
         }
@@ -410,10 +451,10 @@ const mappers = {
       // if g1 = 0 then g2 = g3 = 0
       if (g1 && !stream) {
         g1 = g2 = g3 = 0
-        res += String.fromCharCode(err())
+        o16[oi++] = err()
       }
 
-      return res
+      return decodeUCS2(o16, oi)
     }
 
     return { decode, isAscii: () => g1 === 0 } // if g1 = 0 then g2 = g3 = 0
@@ -452,8 +493,9 @@ export function multibyteDecoder(enc, loose = false) {
   return (arr, stream = false) => {
     let res = ''
     if (asciiSuperset && (!mapper || mapper.isAscii?.())) {
-      res = decodeLatin1(arr, 0, asciiPrefix(arr))
-      if (res.length === arr.length) return res // ascii
+      const prefixLen = asciiPrefix(arr)
+      if (prefixLen === arr.length) return decodeAscii(arr) // ascii
+      res = decodeLatin1(arr, 0, prefixLen) // TODO: check if decodeAscii with subarray is faster for small prefixes too
     }
 
     streaming = stream // affects onErr

package/fallback/multi-byte.table.js

@@ -56,7 +56,9 @@ function unwrap(res, t, pos, stringMode = false) {
         }
 
         if (stringMode) {
-          for (let k = 0; k < x; k++, pos++, code++) res[pos] = String.fromCodePoint(code)
+          for (let k = 0; k < x; k++, pos++, code++) {
+            res[pos] = code <= 0xff_ff ? code : String.fromCodePoint(code)
+          }
         } else {
           for (let k = 0; k < x; k++, pos++, code++) res[pos] = code
         }
@@ -65,8 +67,13 @@ function unwrap(res, t, pos, stringMode = false) {
       pos = unwrap(res, indices[x], pos, stringMode) // self-reference using shared chunks
     } else if (stringMode) {
       const s = [...utf16toString(loadBase64(x), 'uint8-le')] // splits by codepoints
-      for (let i = 0; i < s.length; ) res[pos++] = s[i++] // TODO: splice?
-      code = s[s.length - 1].codePointAt(0) + 1
+      let char
+      for (let i = 0; i < s.length; ) {
+        char = s[i++]
+        res[pos++] = char.length === 1 ? char.charCodeAt(0) : char // strings only for high codepoints
+      }
+
+      code = char.codePointAt(0) + 1
     } else {
       const u16 = to16input(loadBase64(x), true) // data is little-endian
       res.set(u16, pos)

package/fallback/single-byte.js

@@ -1,4 +1,4 @@
-import { asciiPrefix, decodeLatin1 } from './latin1.js'
+import { asciiPrefix, decodeAscii, decodeLatin1 } from './latin1.js'
 import encodings from './single-byte.encodings.js'
 import { decode2string } from './_utils.js'
 
@@ -74,8 +74,9 @@ export function encodingDecoder(encoding) {
       strings = allCodes.map((c) => String.fromCharCode(c))
     }
 
-    const prefix = decodeLatin1(arr, 0, asciiPrefix(arr))
-    if (prefix.length === arr.length) return prefix
+    const prefixLen = asciiPrefix(arr)
+    if (prefixLen === arr.length) return decodeAscii(arr)
+    const prefix = decodeLatin1(arr, 0, prefixLen) // TODO: check if decodeAscii with subarray is faster for small prefixes too
     const suffix = decode2string(arr, prefix.length, arr.length, strings)
     if (!loose && incomplete && suffix.includes('\uFFFD')) throw new TypeError(E_STRICT)
     return prefix + suffix

package/fallback/utf16.js

@@ -1,4 +1,4 @@
-import { decodeLatin1, encodeCharcodes } from './latin1.js'
+import { decodeUCS2, encodeCharcodes } from './latin1.js'
 import { isLE } from './_utils.js'
 
 export const E_STRICT = 'Input is not well-formed utf16'
@@ -38,9 +38,9 @@ export function to16input(u8, le) {
 }
 
 export const decode = (u16, loose = false, checked = false) => {
-  if (checked || isWellFormed(u16)) return decodeLatin1(u16, 0, u16.length) // it's capable of decoding Uint16Array to UTF-16 as well
+  if (checked || isWellFormed(u16)) return decodeUCS2(u16)
   if (!loose) throw new TypeError(E_STRICT)
-  return decodeLatin1(toWellFormed(Uint16Array.from(u16)), 0, u16.length) // cloned for replacement
+  return decodeUCS2(toWellFormed(Uint16Array.from(u16))) // cloned for replacement
 }
 
 export function encode(str, loose = false, checked = false, swapped = false) {

package/multi-byte.node.js

@@ -1,10 +1,8 @@
 import { assertUint8 } from './assert.js'
-import { isDeno } from './fallback/_utils.js'
+import { isDeno, toBuf } from './fallback/_utils.js'
 import { isAsciiSuperset, multibyteDecoder } from './fallback/multi-byte.js'
 import { isAscii } from 'node:buffer'
 
-const toBuf = (x) => Buffer.from(x.buffer, x.byteOffset, x.byteLength)
-
 export function createMultibyteDecoder(encoding, loose = false) {
   const jsDecoder = multibyteDecoder(encoding, loose) // asserts
   let streaming = false

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@exodus/bytes",
-  "version": "1.5.0",
+  "version": "1.6.0",
   "description": "Various operations on Uint8Array data",
   "scripts": {
     "lint": "eslint .",

package/single-byte.js

@@ -6,6 +6,12 @@ const { TextDecoder } = globalThis
 
 let windows1252works
 
+// prettier-ignore
+const skipNative = new Set([
+  'iso-8859-16', // iso-8859-16 is somehow broken in WebKit, at least on CI
+  'iso-8859-6', 'iso-8859-8', 'iso-8859-8-i', // slow in all 3 engines
+])
+
 function shouldUseNative(enc) {
   // https://issues.chromium.org/issues/468458388
   // Also might be incorrectly imlemented on platforms as Latin1 (e.g. in Node.js) or regress
@@ -24,8 +30,7 @@ function shouldUseNative(enc) {
     return windows1252works
   }
 
-  // iso-8859-16 is somehow broken in WebKit, at least on CI
-  return enc !== 'iso-8859-16'
+  return !skipNative.has(enc)
 }
 
 export function createSinglebyteDecoder(encoding, loose = false) {

package/single-byte.node.js

@@ -1,11 +1,9 @@
 import { assertUint8 } from './assert.js'
 import { isAscii } from 'node:buffer'
-import { isDeno, isLE } from './fallback/_utils.js'
+import { isDeno, isLE, toBuf } from './fallback/_utils.js'
 import { asciiPrefix } from './fallback/latin1.js'
 import { encodingMapper, encodingDecoder, E_STRICT } from './fallback/single-byte.js'
 
-const toBuf = (x) => Buffer.from(x.buffer, x.byteOffset, x.byteLength)
-
 function latin1Prefix(arr, start) {
   let p = start | 0
   const length = arr.length

package/utf8.js

@@ -57,7 +57,7 @@ function decode(arr, loose = false) {
   if (nativeDecoder) return loose ? decoderLoose.decode(arr) : decoderFatal.decode(arr) // Node.js and browsers
 
   // Fast path for ASCII prefix, this is faster than all alternatives below
-  const prefix = decodeLatin1(arr, 0, asciiPrefix(arr))
+  const prefix = decodeLatin1(arr, 0, asciiPrefix(arr)) // No native decoder to use, so decodeAscii is useless here
   if (prefix.length === arr.length) return prefix
 
   // This codepath gives a ~3x perf boost on Hermes