@exodus/bitcoin-api 4.9.0 → 4.9.1

package/CHANGELOG.md

@@ -3,6 +3,16 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [4.9.1](https://github.com/ExodusMovement/assets/compare/@exodus/bitcoin-api@4.9.0...@exodus/bitcoin-api@4.9.1) (2026-01-26)
+
+
+### Bug Fixes
+
+
+* fix(bitcoin-api): add safe-string errors for Insight failures (#7320)
+
+
+
 ## [4.9.0](https://github.com/ExodusMovement/assets/compare/@exodus/bitcoin-api@4.8.3...@exodus/bitcoin-api@4.9.0) (2025-12-23)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@exodus/bitcoin-api",
-  "version": "4.9.0",
+  "version": "4.9.1",
   "description": "Bitcoin transaction and fee monitors, RPC with the blockchain node, other networking code.",
   "type": "module",
   "main": "src/index.js",
@@ -33,6 +33,7 @@
     "@exodus/i18n-dummy": "^1.0.0",
     "@exodus/key-identifier": "^1.3.0",
     "@exodus/models": "^12.0.1",
+    "@exodus/safe-string": "^1.4.0",
     "@exodus/send-validation-model": "^1.0.0",
     "@exodus/simple-retry": "^0.0.6",
     "bech32": "^1.1.3",
@@ -60,5 +61,5 @@
     "type": "git",
     "url": "git+https://github.com/ExodusMovement/assets.git"
   },
-  "gitHead": "39b743562bc1171bf3d145b47382db9023c660dd"
+  "gitHead": "481b327c2b57d6272c47807615be9f967ebb3d13"
 }

package/src/fee/utxo-selector.js

@@ -1,4 +1,3 @@
-import NumberUnit from '@exodus/currency'
 import { UtxoCollection } from '@exodus/models'
 import lodash from 'lodash'
 import assert from 'minimalistic-assert'
@@ -68,12 +67,10 @@ export const selectUtxos = ({
       const changeUtxos = usableUtxos.getTxIdUtxos(tx.txId)
       // Don't replace a tx that has already been spent
       if (tx.data.changeAddress && changeUtxos.size === 0) continue
-      let feePerKB
-      if (tx.data.feePerKB + MIN_RELAY_FEE > feeRate.toBaseNumber()) {
-        feePerKB = new NumberUnit(tx.data.feePerKB + MIN_RELAY_FEE, asset.currency.baseUnit)
-      } else {
-        feePerKB = feeRate
-      }
+      const feePerKB =
+        tx.data.feePerKB + MIN_RELAY_FEE > feeRate.toBaseNumber()
+          ? currency.baseUnit(tx.data.feePerKB + MIN_RELAY_FEE)
+          : feeRate
 
       const replaceFeeEstimator = getFeeEstimator(asset, { feePerKB, unconfirmedTxAncestor })
       const inputs = UtxoCollection.fromJSON(tx.data.inputs, { currency })

package/src/insight-api-client/index.js

@@ -1,3 +1,4 @@
+import { safeString } from '@exodus/safe-string'
 import { retry } from '@exodus/simple-retry'
 import delay from 'delay'
 import lodash from 'lodash'
@@ -5,16 +6,29 @@ import urlJoin from 'url-join'
 
 const { isEmpty } = lodash
 
-const getTextFromResponse = async (response) => {
-  try {
-    const responseBody = await response.text()
-    return responseBody.slice(0, 100)
-  } catch {
-    return ''
-  }
-}
-
-const fetchJson = async (url, fetchOptions, nullWhen404) => {
+const INSIGHT_HTTP_ERROR_MESSAGE = safeString`insight-api-http-error`
+const INSIGHT_JSON_ERROR_MESSAGE = safeString`insight-api-invalid-json`
+const INSIGHT_MISSING_TXID_MESSAGE = safeString`insight-api-missing-txid`
+const INSIGHT_HTTP_ERROR_BALANCE_MESSAGE = safeString`insight-api-http-error:balance`
+const INSIGHT_HTTP_ERROR_STATUS_MESSAGE = safeString`insight-api-http-error:status`
+const INSIGHT_HTTP_ERROR_ADDR_MESSAGE = safeString`insight-api-http-error:addr`
+const INSIGHT_HTTP_ERROR_UTXO_MESSAGE = safeString`insight-api-http-error:utxo`
+const INSIGHT_HTTP_ERROR_TX_MESSAGE = safeString`insight-api-http-error:tx`
+const INSIGHT_HTTP_ERROR_FULLTX_MESSAGE = safeString`insight-api-http-error:fulltx`
+const INSIGHT_HTTP_ERROR_RAWTX_MESSAGE = safeString`insight-api-http-error:rawtx`
+const INSIGHT_HTTP_ERROR_ADDRS_TXS_MESSAGE = safeString`insight-api-http-error:addrs-txs`
+const INSIGHT_HTTP_ERROR_UNCONFIRMED_ANCESTOR_MESSAGE = safeString`insight-api-http-error:unconfirmed-ancestor`
+const INSIGHT_HTTP_ERROR_FEES_MESSAGE = safeString`insight-api-http-error:fees`
+const INSIGHT_HTTP_ERROR_BROADCAST_MESSAGE = safeString`insight-api-http-error:broadcast`
+const INSIGHT_HTTP_ERROR_CLAIMABLE_MESSAGE = safeString`insight-api-http-error:claimable`
+const INSIGHT_HTTP_ERROR_UNCLAIMED_MESSAGE = safeString`insight-api-http-error:unclaimed`
+
+const fetchJson = async (
+  url,
+  fetchOptions,
+  nullWhen404,
+  httpErrorMessage = INSIGHT_HTTP_ERROR_MESSAGE
+) => {
   const response = await fetch(url, fetchOptions)
 
   if (nullWhen404 && response.status === 404) {
@@ -22,20 +36,22 @@ const fetchJson = async (url, fetchOptions, nullWhen404) => {
   }
 
   if (!response.ok) {
-    throw new Error(
-      `${url} returned ${response.status}: ${
-        response.statusText || 'Unknown Status Text'
-      }. Body: ${await getTextFromResponse(response)}`
-    )
+    const error = new Error(httpErrorMessage)
+    error.code = `${response.status}`
+    throw error
   }
 
-  return response.json()
+  try {
+    return await response.json()
+  } catch (err) {
+    throw new Error(INSIGHT_JSON_ERROR_MESSAGE, { cause: err })
+  }
 }
 
-async function fetchJsonRetry(url, fetchOptions) {
+async function fetchJsonRetry(url, fetchOptions, httpErrorMessage) {
   const waitTimes = ['5s', '10s', '20s', '30s']
   const fetchWithRetry = retry(fetchJson, { delayTimesMs: waitTimes })
-  return fetchWithRetry(url, fetchOptions)
+  return fetchWithRetry(url, fetchOptions, false, httpErrorMessage)
 }
 
 export default class InsightAPIClient {
@@ -56,12 +72,17 @@ export default class InsightAPIClient {
   async fetchBalance(address) {
     const encodedAddress = encodeURIComponent(address)
     const url = urlJoin(this._baseURL, `/balance/${encodedAddress}`)
-    return fetchJson(url)
+    return fetchJson(url, undefined, false, INSIGHT_HTTP_ERROR_BALANCE_MESSAGE)
   }
 
   async fetchBlockHeight() {
     const url = urlJoin(this._baseURL, '/status')
-    const status = await fetchJson(url, { timeout: 10_000 })
+    const status = await fetchJson(
+      url,
+      { timeout: 10_000 },
+      false,
+      INSIGHT_HTTP_ERROR_STATUS_MESSAGE
+    )
     return status.info.blocks
   }
 
@@ -71,7 +92,7 @@ export default class InsightAPIClient {
       this._baseURL,
       opts?.includeTxs ? `/addr/${encodedAddress}` : `/addr/${encodedAddress}?noTxList=1`
     )
-    return fetchJson(url)
+    return fetchJson(url, undefined, false, INSIGHT_HTTP_ERROR_ADDR_MESSAGE)
   }
 
   async fetchUTXOs(addresses, { assetNames = [] } = {}) {
@@ -83,7 +104,7 @@ export default class InsightAPIClient {
 
     const encodedAddresses = encodeURIComponent(addresses)
     const url = urlJoin(this._baseURL, `/addrs/${encodedAddresses}/utxo?${query}`)
-    const utxos = await fetchJson(url)
+    const utxos = await fetchJson(url, undefined, false, INSIGHT_HTTP_ERROR_UTXO_MESSAGE)
 
     return utxos.map((utxo) => ({
       address: utxo.address,
@@ -100,12 +121,12 @@ export default class InsightAPIClient {
   async fetchTx(txId) {
     const encodedTxId = encodeURIComponent(txId)
     const url = urlJoin(this._baseURL, `/tx/${encodedTxId}`)
-    return fetchJson(url, undefined, true)
+    return fetchJson(url, undefined, true, INSIGHT_HTTP_ERROR_TX_MESSAGE)
   }
 
   async fetchTxObject(txId) {
     const url = urlJoin(this._baseURL, `/fulltx?${new URLSearchParams({ hash: txId })}`)
-    const object = await fetchJson(url, undefined, true)
+    const object = await fetchJson(url, undefined, true, INSIGHT_HTTP_ERROR_FULLTX_MESSAGE)
     if (!object || isEmpty(object)) {
       return null
     }
@@ -116,7 +137,7 @@ export default class InsightAPIClient {
   async fetchRawTx(txId) {
     const encodedTxId = encodeURIComponent(txId)
     const url = urlJoin(this._baseURL, `/rawtx/${encodedTxId}`)
-    const { rawtx } = await fetchJson(url)
+    const { rawtx } = await fetchJson(url, undefined, false, INSIGHT_HTTP_ERROR_RAWTX_MESSAGE)
     return rawtx
   }
 
@@ -136,7 +157,7 @@ export default class InsightAPIClient {
       timeout: 10_000,
     }
 
-    return fetchJsonRetry(url, fetchOptions)
+    return fetchJsonRetry(url, fetchOptions, INSIGHT_HTTP_ERROR_ADDRS_TXS_MESSAGE)
   }
 
   async fetchAllTxData(addrs = [], chunk = 25, httpDelay = 2000, shouldStopFetching = () => {}) {
@@ -159,12 +180,12 @@ export default class InsightAPIClient {
   async fetchUnconfirmedAncestorData(txId) {
     const encodedTxId = encodeURIComponent(txId)
     const url = urlJoin(this._baseURL, `/unconfirmed_ancestor/${encodedTxId}`)
-    return fetchJson(url)
+    return fetchJson(url, undefined, false, INSIGHT_HTTP_ERROR_UNCONFIRMED_ANCESTOR_MESSAGE)
   }
 
   async fetchFeeRate() {
     const url = urlJoin(this._baseURL, '/v2/fees')
-    return fetchJson(url)
+    return fetchJson(url, undefined, false, INSIGHT_HTTP_ERROR_FEES_MESSAGE)
   }
 
   async broadcastTx(rawTx) {
@@ -187,28 +208,32 @@ export default class InsightAPIClient {
       console.warn('Insight Broadcast HTTP Error:')
       console.warn(response.statusText)
       console.warn(data)
-      throw new Error(`Insight Broadcast HTTP Error: ${data}`)
+      const error = new Error(INSIGHT_HTTP_ERROR_BROADCAST_MESSAGE)
+      error.code = `${response.status}`
+      throw error
     }
 
     try {
       data = JSON.parse(data)
     } catch (err) {
       console.warn('Insight Broadcast JSON Parse Error:', err.message, data)
-      throw new Error(`data: ${data}`, { cause: err })
+      throw new Error(INSIGHT_JSON_ERROR_MESSAGE, { cause: err })
     }
 
-    if (!data.txid) throw new Error('transaction id was not returned')
+    if (!data.txid) {
+      throw new Error(INSIGHT_MISSING_TXID_MESSAGE)
+    }
   }
 
   async getClaimable(address) {
     const encodedAddress = encodeURIComponent(address)
     const url = urlJoin(this._baseURL, `/addr/${encodedAddress}/claimable`)
-    return fetchJson(url)
+    return fetchJson(url, undefined, false, INSIGHT_HTTP_ERROR_CLAIMABLE_MESSAGE)
   }
 
   async getUnclaimed(address) {
     const encodedAddress = encodeURIComponent(address)
     const url = urlJoin(this._baseURL, `/addr/${encodedAddress}/unclaimed`)
-    return fetchJson(url)
+    return fetchJson(url, undefined, false, INSIGHT_HTTP_ERROR_UNCLAIMED_MESSAGE)
   }
 }