@exodus/bitcoin-api 2.9.2 → 2.9.3-hotfix

package/src/tx-sign/common.js

@@ -6,16 +6,16 @@ export function extractTransaction({ psbt, skipFinalize }) {
     const rawPSBT = psbt.toBuffer()
 
     return { plainTx: { rawPSBT } }
-  } else {
-    // Serialize tx
-    psbt.finalizeAllInputs()
-    const tx = psbt.extractTransaction()
-    const rawTx = tx.toBuffer()
-    const txId = tx.getId()
-
-    // tx needs to be serializable for desktop RPC send => sign communication
-    return { rawTx, txId, tx: serializeTx({ tx }) }
   }
+
+  // Serialize tx
+  psbt.finalizeAllInputs()
+  const tx = psbt.extractTransaction()
+  const rawTx = tx.toBuffer()
+  const txId = tx.getId()
+
+  // tx needs to be serializable for desktop RPC send => sign communication
+  return { rawTx, txId, tx: serializeTx({ tx }) }
 }
 
 export const serializeTx = ({ tx }) => {

package/src/tx-sign/create-get-key-and-purpose.js

@@ -20,9 +20,9 @@ export const createGetKeyAndPurpose = ({
     const networkInfo = coinInfo.toBitcoinJS()
     if (privateKeysAddressMap) {
       return getPrivateKeyFromMap(privateKeysAddressMap, networkInfo, purpose, address)
-    } else {
-      return getPrivateKeyFromHDKeys(hdkeys, addressPathsMap, keys, networkInfo, purpose, address)
     }
+
+    return getPrivateKeyFromHDKeys(hdkeys, addressPathsMap, keys, networkInfo, purpose, address)
   })
 
 function getPrivateKeyFromMap(privateKeysAddressMap, networkInfo, purpose, address) {

package/src/tx-sign/create-sign-with-wallet.js

@@ -36,9 +36,9 @@ export function createSignWithWallet({
       // The sighash value from the PSBT input itself will be used.
       // This list just represents possible sighash values the inputs can have.
       const allowedSigHashTypes =
-        sigHash !== undefined
-          ? [sigHash, Transaction.SIGHASH_ALL] // `SIGHASH_DEFAULT` is a default safe sig hash, always allow it.
-          : undefined
+        sigHash === undefined
+          ? undefined // `SIGHASH_DEFAULT` is a default safe sig hash, always allow it.
+          : [sigHash, Transaction.SIGHASH_ALL]
       const { key, purpose, publicKey } = getKeyAndPurpose(address)
 
       const isP2SH = purpose === 49

package/src/tx-sign/default-entropy.js

@@ -1,4 +1,2 @@
 // extension point so tests can assert signatures deterministically
-export function getSchnorrEntropy() {
-  return undefined
-}
+export function getSchnorrEntropy() {}

package/src/tx-sign/default-prepare-for-signing.js

@@ -2,8 +2,8 @@ import assert from 'minimalistic-assert'
 import { Psbt, Transaction } from '@exodus/bitcoinjs-lib'
 
 const _MAXIMUM_FEE_RATES = {
-  qtumignition: 25000,
-  ravencoin: 1000000,
+  qtumignition: 25_000,
+  ravencoin: 1_000_000,
 }
 
 /**
@@ -24,27 +24,25 @@ export function createPrepareForSigning({ assetName, resolvePurpose, coinInfo })
     if (isPsbtBufferPassed) {
       // PSBT created externally (Web3, etc..)
       return createPsbtFromBuffer({ psbtBuffer: unsignedTx.txData.psbtBuffer })
-    } else {
-      // Create PSBT based on internal Exodus data structure
-      const networkInfo = coinInfo.toBitcoinJS()
-      const psbt = createPsbtFromTxData({
-        ...unsignedTx.txData,
-        ...unsignedTx.txMeta,
-        resolvePurpose,
-        networkInfo,
-      })
-      if (!['bitcoin', 'bitcoinregtest', 'bitcointestnet'].includes(assetName)) psbt.setVersion(1)
-
-      return psbt
     }
+
+    // Create PSBT based on internal Exodus data structure
+    const networkInfo = coinInfo.toBitcoinJS()
+    const psbt = createPsbtFromTxData({
+      ...unsignedTx.txData,
+      ...unsignedTx.txMeta,
+      resolvePurpose,
+      networkInfo,
+    })
+    if (!['bitcoin', 'bitcoinregtest', 'bitcointestnet'].includes(assetName)) psbt.setVersion(1)
+
+    return psbt
   }
 }
 
 // Creates a PSBT instance from the passed transaction buffer provided by 3rd parties (e.g. dApps).
 function createPsbtFromBuffer({ psbtBuffer, ecc }) {
-  const psbt = Psbt.fromBuffer(psbtBuffer, { eccLib: ecc })
-
-  return psbt
+  return Psbt.fromBuffer(psbtBuffer, { eccLib: ecc })
 }
 
 // Creates a PSBT instance from the passed inputs, outputs etc. The wallet itself provides this data.
@@ -97,7 +95,7 @@ const canParseTx = (rawTxBuffer) => {
   try {
     Transaction.fromBuffer(rawTxBuffer)
     return true
-  } catch (e) {
+  } catch {
     return false
   }
 }

package/src/tx-sign/default-sign-hardware.js

@@ -58,12 +58,13 @@ function createSignWithHardwareWallet({ assetName, resolvePurpose }) {
 }
 
 function getDerivationPaths({ resolvePurpose, accountIndex, addressPathsMap }) {
-  let derivationPaths = []
+  const derivationPaths = []
   for (const [address, path] of Object.entries(addressPathsMap)) {
     const purpose = resolvePurpose(address)
     const derivationPath = `m/${purpose}'/0'/${accountIndex}'/${path.slice(2)}` // TODO: coinindex
     derivationPaths.push(derivationPath)
   }
+
   return derivationPaths
 }
 

package/src/tx-sign/taproot.js

@@ -15,6 +15,7 @@ export function tweakSigner({ signer, tweakHash, network }) {
   if (!privateKey) {
     throw new Error('Private key is required for tweaking signer!')
   }
+
   if (signer.publicKey[0] === 3) {
     privateKey = ecc.privateNegate(privateKey)
   }
@@ -41,14 +42,17 @@ function tapTweakHash(pubKey, h) {
  */
 export function toAsyncSigner({ keyPair }) {
   assert(keyPair, 'keyPair is required')
+  // eslint-disable-next-line @exodus/mutable/no-param-reassign-prop-only
   keyPair.sign = async (h) => {
     const sig = await ecc.signAsync(h, keyPair.privateKey)
     return Buffer.from(sig)
   }
 
+  // eslint-disable-next-line @exodus/mutable/no-param-reassign-prop-only
   keyPair.signSchnorr = async (h) => {
     const sig = await ecc.signSchnorrAsync(h, keyPair.privateKey, getSchnorrEntropy())
     return Buffer.from(sig)
   }
+
   return keyPair
 }

package/src/tx-utils.js

@@ -1,7 +1,7 @@
 import { resolveExtraFeeOfTx } from './unconfirmed-ancestor-data'
 
 export const findUnconfirmedSentRbfTxs = (txSet) =>
-  Array.from(txSet).filter(
+  [...txSet].filter(
     (tx) =>
       tx.sent &&
       tx.pending &&
@@ -12,10 +12,9 @@ export const findUnconfirmedSentRbfTxs = (txSet) =>
   )
 
 export const findLargeUnconfirmedTxs = ({ txSet, feeRate, maxFee, unconfirmedTxAncestor }) =>
-  !txSet
-    ? new Set()
-    : new Set(
-        Array.from(txSet)
+  txSet
+    ? new Set(
+        [...txSet]
           .filter((tx) => {
             if (!tx.pending) return false
             const extraFee = resolveExtraFeeOfTx({
@@ -27,3 +26,4 @@ export const findLargeUnconfirmedTxs = ({ txSet, feeRate, maxFee, unconfirmedTxA
           })
           .map((tx) => tx.txId)
       )
+    : new Set()

package/src/unconfirmed-ancestor-data.js

@@ -18,6 +18,7 @@ export async function resolveUnconfirmedAncestorData({ utxos, insightClient }) {
       console.warn(e)
     }
   }
+
   return dataMap
 }
 

package/src/utxos-utils.js

@@ -3,7 +3,7 @@ import { UtxoCollection } from '@exodus/models'
 import { findLargeUnconfirmedTxs } from './tx-utils'
 import assert from 'minimalistic-assert'
 
-const MAX_ORDINAL_VALUE_POSTAGE = 10000
+const MAX_ORDINAL_VALUE_POSTAGE = 10_000
 
 export const getInscriptionTxId = (inscriptionId) => {
   return inscriptionId.split('i')[0]
@@ -15,7 +15,7 @@ export function getTransferOrdinalsUtxos({ inscriptionIds, ordinalsUtxos }) {
   )
 
   // this is for the micky mouse case. It has 2 inscriptions from the same tx but different output
-  const inscriptionTxs = inscriptionIds.map(getInscriptionTxId)
+  const inscriptionTxs = new Set(inscriptionIds.map(getInscriptionTxId))
 
   // https://ordinals.hiro.so/inscription/862ecd0fe343da32d19ff9277639ff71e10d894f55b6dee82dbfb9c158d5d30ci0
   // https://ordinals.hiro.so/inscription/862ecd0fe343da32d19ff9277639ff71e10d894f55b6dee82dbfb9c158d5d30ci1
@@ -28,13 +28,12 @@ export function getTransferOrdinalsUtxos({ inscriptionIds, ordinalsUtxos }) {
           offset: inscription.offset,
         })
         return (
-          validInscription &&
-          !inscriptionTxs.includes(getInscriptionTxId(inscription.inscriptionId))
+          validInscription && !inscriptionTxs.has(getInscriptionTxId(inscription.inscriptionId))
         )
       }) || []
   )
   assert(
-    !unsafeInscriptions.length,
+    unsafeInscriptions.length === 0,
     `The following inscriptions are unsafe ${unsafeInscriptions.map(
       (i) => i.inscriptionId
     )} when ${inscriptionIds} should be spent`
@@ -117,8 +116,10 @@ function isOrdinalUtxo({
     if (!hasOrdinals) {
       console.log('Excluding utxo from btc spending:', utxo.address.toString(), utxo)
     }
+
     return true // assume is ordinal just in case
   }
+
   return hasOrdinals
 }
 
@@ -136,15 +137,18 @@ export function mergeAdditionalInscriptions({ allUtxos, additionalInscriptions }
                 existingInscription.inscriptionId === additionalInscription.inscriptionId
             )
           }
+
           return forUtxo
         })
         .map((additionalInscription) => ({
           inscriptionId: additionalInscription.inscriptionId,
           offset: additionalInscription.offset || 0,
         }))
-      if (inscriptions.length) {
+      if (inscriptions.length > 0) {
+        // eslint-disable-next-line @exodus/mutable/no-param-reassign-prop-only
         utxo.inscriptions = [...(utxo.inscriptions || []), ...inscriptions]
       }
+
       return utxo
     }),
     {
@@ -205,6 +209,7 @@ export function getConfirmedOrRfbDisabledUtxos({ utxos, allowUnconfirmedRbfEnabl
   if (allowUnconfirmedRbfEnabledUtxos) {
     return utxos
   }
+
   return utxos.filter((utxo) => utxo.confirmations > 0 || !utxo.rbfEnabled)
 }
 
@@ -212,6 +217,7 @@ function filterDustUtxos({ utxos, feeData }) {
   if (feeData.utxoDustValue) {
     return utxos.filter((utxo) => utxo.value.toBaseNumber() > feeData.utxoDustValue)
   }
+
   return utxos
 }