@exodus/bitcoin-api 2.28.0 → 2.29.1

package/CHANGELOG.md

@@ -3,6 +3,25 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [2.29.1](https://github.com/ExodusMovement/assets/compare/@exodus/bitcoin-api@2.29.0...@exodus/bitcoin-api@2.29.1) (2024-11-13)
+
+**Note:** Update exports in fee module of package @exodus/bitcoin-api
+
+
+## [2.29.0](https://github.com/ExodusMovement/assets/compare/@exodus/bitcoin-api@2.28.0...@exodus/bitcoin-api@2.29.0) (2024-11-10)
+
+
+### Features
+
+* filter immature coinbase utxos in getUsableUtxos ([#4507](https://github.com/ExodusMovement/assets/issues/4507)) ([3774f66](https://github.com/ExodusMovement/assets/commit/3774f66ee733ca5a3f07a7556c349d08c2d217e9))
+
+
+### Bug Fixes
+
+* fetch and require raw txs for segwit inputs ([#4399](https://github.com/ExodusMovement/assets/issues/4399)) ([f5822cc](https://github.com/ExodusMovement/assets/commit/f5822cc60d6e542f9aea88c051e1a2dbe56da13d))
+
+
+
 ## [2.28.0](https://github.com/ExodusMovement/assets/compare/@exodus/bitcoin-api@2.27.0...@exodus/bitcoin-api@2.28.0) (2024-10-31)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@exodus/bitcoin-api",
-  "version": "2.28.0",
+  "version": "2.29.1",
   "description": "Exodus bitcoin-api",
   "type": "module",
   "main": "src/index.js",
@@ -56,5 +56,5 @@
     "type": "git",
     "url": "git+https://github.com/ExodusMovement/assets.git"
   },
-  "gitHead": "65c334463a6fd913d73d2873ac455c5ec675705a"
+  "gitHead": "5faabb2475dbf47e9877276b1ef22ad237628c40"
 }

package/src/fee/fee-estimator.js

@@ -79,49 +79,17 @@ export const getSizeFactory = ({ defaultOutputType, addressApi }) => {
       4 + // n_locktime
       varuint.encodingLength(inputs.length) + // inputs_len
       // input[]
-      inputs.reduce((t, script) => {
-        if (script === null) script = '76a914000000000000000000000000000000000000000088ac' // P2PKH
-        assert(isHex(script), 'script must be hex string')
-
-        const scriptType = scriptClassifier.classifyScriptHex({ assetName, script })
-
-        const supportedTypes = supportedInputTypes[assetName] || supportedInputTypes.default
-        assert(
-          supportedTypes.includes(scriptType),
-          `Only ${supportedTypes.join(', ')} inputs supported right now`
-        )
-
-        const scriptSigLengths = compressed
-          ? scriptSigCompressedLengths
-          : scriptSigUncompressedLengths
-        const scriptSigLength = scriptSigLengths[scriptType]
-        return t + 32 + 4 + varuint.encodingLength(scriptSigLength) + scriptSigLength + 4
-      }, 0) +
+      inputs.reduce(
+        (t, script) => t + getInputSize({ script, scriptClassifier, assetName, compressed }),
+        0
+      ) +
       varuint.encodingLength(outputs.length) + // outputs_len
       // output[]
-      outputs.reduce((t, output) => {
-        // if (output === null) output = get(asset, 'address.versions.bech32') ? 'P2WSH' : 'P2PKH'
-
-        if (output === null) output = defaultOutputType
-
-        let scriptType = scriptClassify.types[output]
-        const supportedTypes = supportedOutputTypes[assetName] || supportedOutputTypes.default
-
-        if (!supportedTypes.includes(scriptType)) {
-          scriptType = scriptClassifier.classifyAddress({
-            assetName,
-            address: output,
-          })
-        }
-
-        assert(
-          supportedTypes.includes(scriptType),
-          `Only ${supportedTypes.join(', ')} outputs supported right now`
-        )
-
-        const scriptPubKeyLength = scriptPubKeyLengths[scriptType]
-        return t + 8 + varuint.encodingLength(scriptPubKeyLength) + scriptPubKeyLength
-      }, 0)
+      outputs.reduce(
+        (t, output) =>
+          t + getOutputSize({ output, scriptClassifier, assetName, defaultOutputType }),
+        0
+      )
 
     const witnessSize =
       1 + // marker
@@ -169,4 +137,45 @@ const getFeeEstimatorFactory = ({ defaultOutputType, addressApi }) => {
   return createDefaultFeeEstimator(getSize)
 }
 
+export const getInputSize = ({ script, scriptClassifier, assetName, compressed }) => {
+  if (script === null) script = '76a914000000000000000000000000000000000000000088ac' // P2PKH
+  assert(isHex(script), 'script must be hex string')
+
+  const scriptType = scriptClassifier.classifyScriptHex({ assetName, script })
+
+  const supportedTypes = supportedInputTypes[assetName] || supportedInputTypes.default
+  assert(
+    supportedTypes.includes(scriptType),
+    `Only ${supportedTypes.join(', ')} inputs supported right now`
+  )
+
+  const scriptSigLengths = compressed ? scriptSigCompressedLengths : scriptSigUncompressedLengths
+  const scriptSigLength = scriptSigLengths[scriptType]
+  return 32 + 4 + varuint.encodingLength(scriptSigLength) + scriptSigLength + 4
+}
+
+export const getOutputSize = ({ output, scriptClassifier, assetName, defaultOutputType }) => {
+  // if (output === null) output = get(asset, 'address.versions.bech32') ? 'P2WSH' : 'P2PKH'
+
+  if (output === null) output = defaultOutputType
+
+  let scriptType = scriptClassify.types[output]
+  const supportedTypes = supportedOutputTypes[assetName] || supportedOutputTypes.default
+
+  if (!supportedTypes.includes(scriptType)) {
+    scriptType = scriptClassifier.classifyAddress({
+      assetName,
+      address: output,
+    })
+  }
+
+  assert(
+    supportedTypes.includes(scriptType),
+    `Only ${supportedTypes.join(', ')} outputs supported right now`
+  )
+
+  const scriptPubKeyLength = scriptPubKeyLengths[scriptType]
+  return 8 + varuint.encodingLength(scriptPubKeyLength) + scriptPubKeyLength
+}
+
 export default getFeeEstimatorFactory

package/src/fee/index.js

@@ -1,2 +1,9 @@
 export * from './get-fee-resolver.js'
-export { default as getFeeEstimatorFactory } from './fee-estimator.js'
+export {
+  default as getFeeEstimatorFactory,
+  getInputSize,
+  getOutputSize,
+  getSizeFactory,
+} from './fee-estimator.js'
+export { default as createDefaultFeeEstimator } from './fee-utils.js'
+export { scriptClassifierFactory } from './script-classifier.js'

package/src/tx-log/bitcoin-monitor-scanner.js

@@ -418,6 +418,7 @@ export class BitcoinMonitorScanner {
           feePerKB: txItem.fees ? (txItem.fees / txItem.vsize) * 1000 * 1e8 : null,
           rbfEnabled: txItem.rbf,
           blocksSeen: 0,
+          ...(txItem.vin.length === 0 ? { isCoinbase: true } : undefined),
         },
         currencies: { [assetName]: currency },
       }
@@ -544,6 +545,7 @@ export class BitcoinMonitorScanner {
           script: vout.scriptPubKey.hex,
           value: val,
           rbfEnabled: txItem.rbf,
+          ...(txItem.vin.length === 0 ? { isCoinbase: true } : undefined),
         }
 
         if (this.#ordinalsEnabled) {

package/src/tx-send/index.js

@@ -71,7 +71,14 @@ export async function getNonWitnessTxs(asset, utxos, insightClient) {
       utxos
         .getAddressesForTxId(txId)
         .toAddressStrings()
-        .some((a) => asset.address.isP2PKH(a) || asset.address.isP2SH(a))
+        .some(
+          (a) =>
+            asset.address.isP2PKH(a) ||
+            asset.address.isP2SH(a) ||
+            asset.address.isP2SH2?.(a) ||
+            asset.address.isP2WPKH?.(a) ||
+            asset.address.isP2WSH?.(a)
+        )
     )
 
     if (nonWitnessTxIds.length > 0) {

package/src/tx-sign/default-prepare-for-signing.js

@@ -85,17 +85,24 @@ function createPsbtFromTxData({
     const isTaprootAddress = purpose === 86
 
     const txIn = { hash: txId, index: vout, sequence }
-    if (isSegwitAddress || isTaprootAddress) {
-      if (isTaprootAddress && tapLeafScript) {
-        txIn.tapLeafScript = tapLeafScript
-      }
 
-      // witness outputs only require the value and the script, not the full transaction
+    if (isTaprootAddress && tapLeafScript) {
+      txIn.tapLeafScript = tapLeafScript
+    }
+
+    if (isSegwitAddress || isTaprootAddress) {
+      // taproot outputs only require the value and the script, not the full transaction
       txIn.witnessUtxo = { value, script: Buffer.from(script, 'hex') }
-    } else {
-      const rawTx = (rawTxs || []).find((t) => t.txId === txId)
-      // non-witness outptus require the full transaction
-      assert(!!rawTx, 'Non-witness outputs require the full previous transaction.')
+    }
+
+    const rawTx = (rawTxs || []).find((t) => t.txId === txId)
+
+    // Non-taproot outputs require the full transaction
+    assert(
+      isTaprootAddress || !!rawTx?.rawData,
+      `Non-taproot outputs require the full previous transaction.`
+    )
+    if (!isTaprootAddress) {
       const rawTxBuffer = Buffer.from(rawTx.rawData, 'hex')
       if (canParseTx(Transaction, rawTxBuffer)) {
         txIn.nonWitnessUtxo = rawTxBuffer

package/src/utxos-utils.js

@@ -233,11 +233,25 @@ function filterDustUtxos({ utxos, feeData }) {
   return utxos
 }
 
-export function getUsableUtxos({ asset, utxos, feeData, txSet, unconfirmedTxAncestor }) {
+const COINBASE_MATURITY_HEIGHT = 100
+
+export function getUsableUtxos({
+  asset,
+  utxos: someCoinbaseUtxos,
+  feeData,
+  txSet,
+  unconfirmedTxAncestor,
+}) {
   assert(asset, 'asset is required')
-  assert(utxos, 'utxos is required')
+  assert(someCoinbaseUtxos, 'utxos is required')
   assert(feeData, 'feeData is required')
   assert(txSet, 'txSet is required')
+
+  // Filter out immature coinbase outputs. They are not spendable.
+  const utxos = someCoinbaseUtxos.filter(
+    (utxo) => !utxo.isCoinbase || utxo.confirmations >= COINBASE_MATURITY_HEIGHT
+  )
+
   if (!['bitcoin', 'bitcointestnet', 'bitcoinregtest'].includes(asset.name))
     return filterDustUtxos({ utxos, feeData })